Re: [Qemu-devel] [PATCH v2 27/45] scsi-disk: Preserve tray state on migration

[Markus Armbruster]

Kevin Wolf <address@hidden> writes:

> Am 02.09.2011 17:35, schrieb Markus Armbruster:
>> Kevin Wolf <address@hidden> writes:
>> 
>>> Am 03.08.2011 15:08, schrieb Markus Armbruster:
>>>> Breaks migration of qdevs "scsi-cd" and legacy "scsi-disk" to older
>>>> versions.  We normally use subsections to avoid that.  Not possible
>>>> here, because we don't have a section to begin with.  Too bad.
>>>>
>>>> Signed-off-by: Markus Armbruster <address@hidden>
>>>
>>> A more logical approach would be to add migration support to SCSI first.
>> 
>> Isn't that what I do?
>> 
>>> I guess adding .unmigratable = 1 makes more sense at the moment.
>> 
>> Why?
>
> Hm, you mean that we can successfully migrate SCSI today?
>
> SCSIDiskState doesn't seem to directly have anything variable that must
> be migrated. I think SCSIDevice does have fields that need to be
> migrated (unit_attention, sense and the request list). I'm not sure what
> other state scsi-bus involves, but unless the SCSI controllers can
> restore all of it, it should have a VMState, too.

Easiest solution is to just drop my patch then.