[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 26/45] ide/atapi: Preserve tray state on migr
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v2 26/45] ide/atapi: Preserve tray state on migration |
Date: |
Fri, 02 Sep 2011 17:59:07 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:6.0) Gecko/20110816 Thunderbird/6.0 |
Am 02.09.2011 17:20, schrieb Markus Armbruster:
> Kevin Wolf <address@hidden> writes:
>
>> Am 03.08.2011 15:08, schrieb Markus Armbruster:
>>> Use a subsection, so that migration to older version still works,
>>> provided the tray is closed and unlocked.
>>>
>>> Signed-off-by: Markus Armbruster <address@hidden>
>>
>> Ah, here is the migration part. The state wasn't migrated before, so not
>> doing it in patch 10 doesn't break anything. I would still prefer to add
>> migration in the same patch that adds the fields.
>>
>> You could just move the subsection itself and keep the post_load part
>> here if it doesn't fit naturally in one of the other patches of the series.
>
> I don't get this part, I'm afraid.
I was afraid that you can't merge all of this patch into patch 10
because the post_load functions depends on later patches. So I suggested
that you just add the subsection definition itself to patch 10 and keep
the addition of post_load as patch 26.
Kevin