[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 37/45] block: Show whether the guest ejected
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 37/45] block: Show whether the guest ejected the medium in info block |
|
Date: |
Fri, 02 Sep 2011 17:29:23 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) |
Kevin Wolf <address@hidden> writes:
> Am 03.08.2011 15:08, schrieb Markus Armbruster:
>> Need to ask the device, so this requires new BlockDevOps member
>> is_medium_ejected().
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>
> I find the name confusing. "medium is ejected" seems to mean "tray is
> open". It isn't obvious that "tray is closed, but no medium is inserted"
> is not "medium is ejected".
>
> Why not call it tray_open like in the devices?
Not all all devices with removable media have trays. I'll rename it
anyway. We'll figure out how to handle devices without trays when we
add one.