Re: [Qemu-devel] [PATCH] Add support for r6040 NIC

[Gerd Hoffmann]

On 08/31/11 18:06, Anthony Liguori wrote:
> On 08/31/2011 09:35 AM, malc wrote:
> > On Wed, 31 Aug 2011, Anthony Liguori wrote:
> >
> > > Upper case field names are not okay. If you think coding style isn't
> > > clear,
> > > that's a bug in coding style.

> There's no benefit to going through and changing existing code but new
> code needs to be consistent with the vast majority of code in the rest
> of the tree. It's about overall code base consistency and maintainability.

I don't see the point in being too picky about this.  Especially 
consistency is a tricky thing.

As USB has been raised in this thread already:  The struct field names 
in the USBDesc* structs are actually consistent.  They are consistent 
with the naming convention in the USB world, i.e. you'll find those 
funky names like "wMaxPacketSize" in the USB specs, in the "lsusb -v" 
output and probably other places too.  Which makes alot of sense IMHO 
and is quite convenient when hacking the USB code.

The USB naming convention and the qemu naming convention don't match, so 
it is impossible to please everybody here ...

cheers,
  Gerd