[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFT 1/2] coreaudio: Fix OSStatus format specifie
From: |
malc |
Subject: |
Re: [Qemu-devel] [PATCH RFT 1/2] coreaudio: Fix OSStatus format specifier |
Date: |
Thu, 23 Jun 2011 16:54:09 +0400 (MSD) |
User-agent: |
Alpine 2.00 (LNX 1167 2008-08-23) |
On Thu, 23 Jun 2011, Andreas F?rber wrote:
> OSStatus type is defined as SInt32.
> Use %d format instead of %ld to avoid a warning on ppc64.
Which itself is defined as
typedef signed long SInt32;
(here on ppc32 inside:
/Developer/SDKs/MacOSX10.4u.sdk/usr/include/libkern/OSTypes.h)
So i'd suggest to just cast the thing to appropriate long type
and be done with it.
>
> Cc: Alexandre Raymond <address@hidden>
> Cc: malc <address@hidden>
> Signed-off-by: Andreas Faerber <address@hidden>
> ---
> Alexandre, Could you please test this on v10.6? Thanks!
>
> audio/coreaudio.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/audio/coreaudio.c b/audio/coreaudio.c
> index 3bd75cd..d2b9248 100644
> --- a/audio/coreaudio.c
> +++ b/audio/coreaudio.c
> @@ -104,7 +104,7 @@ static void coreaudio_logstatus (OSStatus status)
> break;
>
> default:
> - AUD_log (AUDIO_CAP, "Reason: status code %ld\n", status);
> + AUD_log (AUDIO_CAP, "Reason: status code %d\n", status);
> return;
> }
>
>
--
mailto:address@hidden
Re: [Qemu-devel] [PATCH 0/2] Darwin CoreAudio warning fixes, Andreas Färber, 2011/06/23