[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC][PATCH] Register Linux dyntick timer as per-thread
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [RFC][PATCH] Register Linux dyntick timer as per-thread signal |
|
Date: |
Thu, 16 Jun 2011 07:39:52 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc15 Thunderbird/3.1.10 |
On 06/16/2011 02:31 AM, Jan Kiszka wrote:
> ev.sigev_value.sival_int = 0;
> - ev.sigev_notify = SIGEV_SIGNAL;
> ev.sigev_signo = SIGALRM;
> +#ifdef SIGEV_THREAD_ID
> + if (qemu_signalfd_available()) {
> + ev.sigev_notify = SIGEV_THREAD_ID;
> + ev._sigev_un._tid = qemu_get_thread_id();
> + } else
> +#endif /* SIGEV_THREAD_ID */
> + {
> + ev.sigev_notify = SIGEV_SIGNAL;
> + }
>
Rather than do the else-inside-ifdef thing, why not
leave the original setting of sigev_notify where it
was, and let the ifdef overwrite it?
r~