Re: [Qemu-devel] Re: [PATCH 00/10] pci: pci_register_bar_simple

[Avi Kivity]

On 04/04/2011 07:22 PM, Anthony Liguori wrote:
> On 04/04/2011 10:59 AM, Michael S. Tsirkin wrote:
> > On Mon, Apr 04, 2011 at 06:27:57PM +0300, Avi Kivity wrote:
> > > Many PCI BARs that use the memory address space map a single MMIO 
> > > region into
> > > the entire BAR range.  Introduce an API pci_register_bar_simple() 
> > > for that use
> > > case, and convert all users where this can be done trivially.
> > >
> > > This will reduce the work required to introduce a PCI memory API; 
> > > it's also
> > > a nice code reduction in its own right.
> > This will save some code, so
> > Acked-by: Michael S. Tsirkin<address@hidden>
> >
> > I really hope the rest of devices will follow.
>
> How complete is this?

I converted all devices which were easy to convert.  There may be one or 
two more that can be converted with additional work (and perhaps with an 
additional pic_bar_get_current_address() API, and a 
pci_bar_set_coalescing() API).  The rest likely need to stick with the 
callback-based API.

--
error compiling committee.c: too many arguments to function