[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] arm: basic support for ARMv4/ARMv4T emulati
From: |
Dmitry Eremin-Solenikov |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] arm: basic support for ARMv4/ARMv4T emulation |
Date: |
Sat, 2 Apr 2011 19:25:32 +0400 |
On 3/31/11, Dmitry Eremin-Solenikov <address@hidden> wrote:
> On 3/30/11, Peter Maydell <address@hidden> wrote:
>> On 30 March 2011 12:41, Dmitry Eremin-Solenikov <address@hidden>
>> wrote:
>>> @@ -7172,10 +7210,7 @@ static void disas_arm_insn(CPUState * env,
>>> DisasContext *s)
>>> }
>>> if (insn & (1 << 20)) {
>>> /* Complete the load. */
>>> - if (rd == 15)
>>> - gen_bx(s, tmp);
>>> - else
>>> - store_reg(s, rd, tmp);
>>> + store_reg_from_load(env, s, rn, tmp);
>>> }
>>> break;
>>> case 0x08:
>>
>> Shouldn't the argument to store_reg_from_load() be 'rd', not 'rn'?
>
> Yeah, it seems so :)
> Please commit the fixed patch.
Do I need to send the fixed patchset?
--
With best wishes
Dmitry
- Re: [Qemu-devel] [PATCH 1/3] arm: basic support for ARMv4/ARMv4T emulation,
Dmitry Eremin-Solenikov <=