[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots
From: |
Marcelo Tosatti |
Subject: |
[Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots |
Date: |
Mon, 26 Apr 2010 10:47:17 -0300 |
User-agent: |
Mutt/1.5.20 (2009-08-17) |
On Sun, Apr 25, 2010 at 05:17:55PM +0300, Avi Kivity wrote:
> On 04/25/2010 04:57 PM, Jan Kiszka wrote:
> >
> >>It's still a good idea. The current API assumes that there will be only
> >>one slot-based client (or that multiple clients will keep the refcount
> >>themselves).
> >>
> >>After the bytemap -> multiple bitmaps conversion this can be extended to
> >>each client getting its own bitmap (and therefore, s/refcount/list of
> >>bitmaps/ and s/!refcount/list_empty()/).
> >>
> >No concerns if
> > - there is an existing use case for multiple clients, at least in
> > qemu-kvm
>
> There isn't. But I don't like hidden breakage.
>
> > - the logging API is consistently converted, not just extended
> > (IOW, migration_log is converted to logging_count)
>
> migration_log needs to remain global, since we want hotplug memory
> to autostart logging.
>
> > - someone signs he checked that current use of start/stop in qemu is
> > completely symmetrical (I think to remember this used to be not the
> > case, but I might be wrong)
>
> I remember this too. Marcelo?
Don't see any guarantee that it is symmetrical. Anyway, will drop
the patch from the series.
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, (continued)
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Jan Kiszka, 2010/04/25
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Avi Kivity, 2010/04/25
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Jan Kiszka, 2010/04/25
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Avi Kivity, 2010/04/25
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Jan Kiszka, 2010/04/25
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Avi Kivity, 2010/04/25
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Jan Kiszka, 2010/04/25
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Avi Kivity, 2010/04/25
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Jan Kiszka, 2010/04/25
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Avi Kivity, 2010/04/26
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots,
Marcelo Tosatti <=
- [Qemu-devel] [uq/master patch 4/5] kvm: port qemu-kvm's bitmap scanning, Marcelo Tosatti, 2010/04/23
- [Qemu-devel] [uq/master patch 1/5] vga: fix typo in length passed to kvm_log_stop, Marcelo Tosatti, 2010/04/23
- [Qemu-devel] [uq/master patch 3/5] introduce leul_to_cpu, Marcelo Tosatti, 2010/04/23
- [Qemu-devel] [uq/master patch 5/5] introduce qemu_ram_map, Marcelo Tosatti, 2010/04/23
- [Qemu-devel] Re: [uq/master patch 0/5] prepare for qemu-kvm's usage of upstream memslot code, Avi Kivity, 2010/04/25