Re: [Qemu-devel] [PATCH 01/20] eepro100: Fix compiler errors from debug messages

[Stefan Weil]

Anthony Liguori schrieb:
> On 02/14/2010 10:16 AM, Stefan Weil wrote:
>> When debug output was enabled (by defining DEBUG_EEPRO100),
>> some debug messages resulted in a compiler error.
>>
>> This is fixed here.
>>
>> Signed-off-by: Stefan Weil<address@hidden>
>>    
>
> Michael,
>
> Can you take these through your tree?
>
> Regards,
>
> Anthony Liguori

Up to now, I got feedback for 2 of these 20 patches:

[PATCH 05/20] eepro100: Add all supported devices to pci.c
    Michael asked whether it would be cleaner to have a single
    eepro100 device with specific model as qdev option.
    As long as there are no more opinions on this topic,
    I suggest to omit this single patch.

[PATCH 11/20] eepro100: Use symbolic names for bits in EEPROM id
    Michael had two points: an unused type name and enum members
    which were written in lower_case instead of UPPER_CASE.

If there are no other open topics, I suggest to commit the patch
series as it is (optionally without 05/20). Upper / lower case can be
fixed later when this new rule is added to the style guide.

Regards,

Stefan Weil