[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 08/18] block/vvfat.c: fix warnings with _FORTIFY
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH 08/18] block/vvfat.c: fix warnings with _FORTIFY_SOURCE |
Date: |
Sun, 20 Dec 2009 11:48:15 +0100 |
User-agent: |
KMail/1.9.5 |
Am Sonntag, 20. Dezember 2009 02:39 schrieb Kirill A. Shutemov:
> CC block/vvfat.o
> cc1: warnings being treated as errors
> block/vvfat.c: In function 'commit_one_file':
> block/vvfat.c:2259: error: ignoring return value of 'ftruncate', declared
with attribute warn_unused_result
> make: *** [block/vvfat.o] Error 1
> CC block/vvfat.o
> In file included from /usr/include/stdio.h:912,
> from ./qemu-common.h:19,
> from block/vvfat.c:27:
> In function 'snprintf',
> inlined from 'init_directories' at block/vvfat.c:871,
> inlined from 'vvfat_open' at block/vvfat.c:1068:
> /usr/include/bits/stdio2.h:65: error: call to __builtin___snprintf_chk will
always overflow destination buffer
> make: *** [block/vvfat.o] Error 1
>
> Signed-off-by: Kirill A. Shutemov <address@hidden>
> ---
> block/vvfat.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/block/vvfat.c b/block/vvfat.c
> index 063f731..7b6a405 100644
> --- a/block/vvfat.c
> +++ b/block/vvfat.c
> @@ -868,7 +868,8 @@ static int init_directories(BDRVVVFATState* s,
> {
> direntry_t* entry=array_get_next(&(s->directory));
> entry->attributes=0x28; /* archive | volume label */
> - snprintf((char*)entry->name,11,"QEMU VVFAT");
> + snprintf((char*)entry->name,8,"QEMU VV");
> + snprintf((char*)entry->extension,3,"FAT");
> }
>
> /* Now build FAT, and write back information into directory */
> @@ -2256,7 +2257,7 @@ static int commit_one_file(BDRVVVFATState* s,
> c = c1;
> }
>
> - ftruncate(fd, size);
> + assert(!ftruncate(fd, size));
Don't use expressions with side effects for assertions. If anyone compiles
with NDEBUG defined, the ftruncate will be missing.
Kevin
- [Qemu-devel] [PATCH 16/18] hw/pc.c: fix warnings with _FORTIFY_SOURCE, (continued)
- Re: [Qemu-devel] [PATCH 16/18] hw/pc.c: fix warnings with _FORTIFY_SOURCE, Blue Swirl, 2009/12/22
- Re: [Qemu-devel] [PATCH 14/18] vl.c: fix warning with _FORTIFY_SOURCE, Blue Swirl, 2009/12/22
- Re: [Qemu-devel] [PATCH 12/18] savevm.c: fix warning with _FORTIFY_SOURCE, Blue Swirl, 2009/12/22
- Re: [Qemu-devel] [PATCH 11/18] usb-linux.c: fix warning with _FORTIFY_SOURCE, Blue Swirl, 2009/12/22
- Re: [Qemu-devel] [PATCH 10/18] net/slirp.c: fix warning with _FORTIFY_SOURCE, Blue Swirl, 2009/12/22
- [Qemu-devel] Re: [PATCH 09/18] block/qcow2.c: fix warnings with _FORTIFY_SOURCE, Andreas Schwab, 2009/12/20
- Re: [Qemu-devel] [PATCH 08/18] block/vvfat.c: fix warnings with _FORTIFY_SOURCE,
Kevin Wolf <=
- Re: [Qemu-devel] [PATCH 07/18] block/bochs.c: fix warning with _FORTIFY_SOURCE, Blue Swirl, 2009/12/22
- Re: [Qemu-devel] [PATCH 03/18] posix-aio-compat.c: fix warning with _FORTIFY_SOURCE, Paul Brook, 2009/12/20
Re: [Qemu-devel] [PATCH 02/18] block.c: fix warning with _FORTIFY_SOURCE, Blue Swirl, 2009/12/22
Re: [Qemu-devel] [PATCH 01/18] Do not disable _FORTIFY_SOURCE, Blue Swirl, 2009/12/20