[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] A different way to ask for readonly drive
From: |
Stefan Weil |
Subject: |
Re: [Qemu-devel] [PATCH] A different way to ask for readonly drive |
Date: |
Mon, 14 Dec 2009 16:53:33 +0100 |
User-agent: |
Mozilla-Thunderbird 2.0.0.22 (X11/20090707) |
Naphtali Sprei schrieb:
> Hi,
> After feedback from Red Hat guys, I've decided to slightly modify the
> approach to drive's readonly.
> The new approach also addresses the silent fall-back to open the drives' file
> as read-only when read-write fails
> (permission denied) that causes unexpected behavior.
> Instead of the 'readonly' boolean flag, another flag introduced (a
> replacement), 'read_write' with three values [on|off|try]:
> read_write=on : open with read and write permission, no fall-back to read-only
> read_write=off: open with read-only permission
> read_write=try: open with read and write permission and if fails, fall-back
> to read-only (the default if nothing specified)
>
> Suggestions for better naming for flag/values welcomed.
>
> I've tried to explicitly pass the required flags for the bdrv_open function
> in callers, but probably missed some.
>
> Naphtali
>
> ...
>
Instead of on/off, I'd prefer the common shortcuts rw/ro.
"try" is ok, but maybe "rw-ro" is better.
So here are my suggestions:
read_write=rw
read_write=ro
read_write=rw-ro
or
access=rw
access=ro
access=rw-ro
Regards,
Stefan
- [Qemu-devel] [PATCH] A different way to ask for readonly drive, Naphtali Sprei, 2009/12/14
- Re: [Qemu-devel] [PATCH] A different way to ask for readonly drive,
Stefan Weil <=
- Re: [Qemu-devel] [PATCH] A different way to ask for readonly drive, Jamie Lokier, 2009/12/15
- Re: [Qemu-devel] [PATCH] A different way to ask for readonly drive, Stefan Weil, 2009/12/15
- Re: [Qemu-devel] [PATCH] A different way to ask for readonly drive, Christoph Hellwig, 2009/12/17
- Re: [Qemu-devel] [PATCH] A different way to ask for readonly drive, Jamie Lokier, 2009/12/17
- Re: [Qemu-devel] [PATCH] A different way to ask for readonly drive, Kevin Wolf, 2009/12/17
- Re: [Qemu-devel] [PATCH] A different way to ask for readonly drive, Jamie Lokier, 2009/12/17
- Re: [Qemu-devel] [PATCH] A different way to ask for readonly drive, Markus Armbruster, 2009/12/17
Re: [Qemu-devel] [PATCH] A different way to ask for readonly drive, Kevin Wolf, 2009/12/15
Re: [Qemu-devel] [PATCH] A different way to ask for readonly drive, Richard W.M. Jones, 2009/12/17