[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 3/3] Cocoa: Silence warnings
From: |
Andreas Faerber |
Subject: |
[Qemu-devel] [PATCH 3/3] Cocoa: Silence warnings |
Date: |
Sun, 6 Dec 2009 05:57:57 +0100 |
Missing static for cocoa_keycode_to_qemu.
Missing const for character constant.
__LITTLE_ENDIAN__ is undefined on Big Endian host.
Signed-off-by: Andreas Faerber <address@hidden>
Cc: John Arbuckle <address@hidden>
---
cocoa.m | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/cocoa.m b/cocoa.m
index 7062571..05f507d 100644
--- a/cocoa.m
+++ b/cocoa.m
@@ -229,7 +229,7 @@ int keymap[] =
*/
};
-int cocoa_keycode_to_qemu(int keycode)
+static int cocoa_keycode_to_qemu(int keycode)
{
if((sizeof(keymap)/sizeof(int)) <= keycode)
{
@@ -315,7 +315,7 @@ int cocoa_keycode_to_qemu(int keycode)
screen.bitsPerComponent, //bitsPerComponent
screen.bitsPerPixel, //bitsPerPixel
(screen.width * (screen.bitsPerComponent/2)), //bytesPerRow
-#if __LITTLE_ENDIAN__
+#ifdef __LITTLE_ENDIAN__
CGColorSpaceCreateWithName(kCGColorSpaceGenericRGB), //colorspace
for OS X >= 10.4
kCGBitmapByteOrder32Little | kCGImageAlphaNoneSkipFirst,
#else
@@ -783,7 +783,7 @@ int cocoa_keycode_to_qemu(int keycode)
if(returnCode == NSCancelButton) {
exit(0);
} else if(returnCode == NSOKButton) {
- char *bin = "qemu";
+ const char *bin = "qemu";
char *img = (char*)[ [ sheet filename ]
cStringUsingEncoding:NSASCIIStringEncoding];
char **argv = (char**)malloc( sizeof(char*)*3 );
--
1.6.5.3
- [Qemu-devel] Adding support for Mac OS X ppc64 host, Andreas Faerber, 2009/12/05
- [Qemu-devel] [PATCH 1/3] TCG: Mac OS X support for ppc64 target, Andreas Faerber, 2009/12/05
- [Qemu-devel] [PATCH 2/3] Cocoa: ppc64 host support, Andreas Faerber, 2009/12/05
- [Qemu-devel] [PATCH 3/3] Cocoa: Silence warnings,
Andreas Faerber <=
- [Qemu-devel] Re: [PATCH 1/3] TCG: Mac OS X support for ppc64 target, malc, 2009/12/06
- [Qemu-devel] Re: [PATCH 1/3] TCG: Mac OS X support for ppc64 target, Andreas Färber, 2009/12/06
- [Qemu-devel] Re: [PATCH 1/3] TCG: Mac OS X support for ppc64 target, malc, 2009/12/06
- [Qemu-devel] [PATCH v2 1/3] TCG: Mac OS X support for ppc64 target, Andreas Faerber, 2009/12/06
- [Qemu-devel] [PATCH v2 2/3] Cocoa: ppc64 host support, Andreas Faerber, 2009/12/06
- [Qemu-devel] [PATCH v2 3/3] Cocoa: Silence warnings, Andreas Faerber, 2009/12/06
- [Qemu-devel] Re: [PATCH v2 2/3] Cocoa: ppc64 host support, Alexander Graf, 2009/12/06
- [Qemu-devel] Re: [PATCH v2 2/3] Cocoa: ppc64 host support, Andreas Färber, 2009/12/06
- [Qemu-devel] Re: [PATCH v2 2/3] Cocoa: ppc64 host support, Alexander Graf, 2009/12/06
- [Qemu-devel] Re: [PATCH v2 2/3] Cocoa: ppc64 host support, Mike Kronenberg, 2009/12/06