[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Get coding style closer to the real world
From: |
Alexander Graf |
Subject: |
Re: [Qemu-devel] [PATCH] Get coding style closer to the real world |
Date: |
Sat, 5 Dec 2009 00:47:18 +0100 |
On 04.12.2009, at 18:47, Paul Brook wrote:
> On Monday 30 November 2009, Alexander Graf wrote:
>> Currently we have this stupid role of disallowing:
>>
>> if (r)
>> break;
>
> This has been discussed to death several times, in several different paces,
> and with no clear resolution or consensus, so I'm going to make an executive
> decision:
>
> The coding style stays as-is. Braces are required. Please ensure that all
> patches follow the coding style. There may be exceptions, but there should be
> a *good* reason for deviation.
>
>
> If there are real problems or ambiguities in the coding style then I am
> willing to consider fixing it. This particular change meets neither criteria.
>
> By picking a single coding style we've pretty much guaranteed that most
> people
> will disagree with some of it. IMO consistency is more important.
Could we please convert all the code base to the new style then? For exactly
the consistency reason.
Alex