[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 15/41] virtio: remove save/load_queue for virtio
From: |
Juan Quintela |
Subject: |
[Qemu-devel] Re: [PATCH 15/41] virtio: remove save/load_queue for virtio |
Date: |
Wed, 02 Dec 2009 19:22:11 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
"Michael S. Tsirkin" <address@hidden> wrote:
> On Wed, Dec 02, 2009 at 01:04:13PM +0100, Juan Quintela wrote:
>> diff --git a/hw/virtio.c b/hw/virtio.c
>> index c136005..b565bf9 100644
>> --- a/hw/virtio.c
>> +++ b/hw/virtio.c
>> @@ -643,8 +643,10 @@ void virtio_save(VirtIODevice *vdev, QEMUFile *f)
>> qemu_put_be32(f, vdev->vq[i].vring.num);
>> qemu_put_be64(f, vdev->vq[i].pa);
>> qemu_put_be16s(f, &vdev->vq[i].last_avail_idx);
>> - if (vdev->binding->save_queue)
>> - vdev->binding->save_queue(vdev->binding_opaque, i, f);
>> + if (vdev->type == VIRTIO_PCI &&
>> + virtio_pci_msix_present(vdev->binding_opaque)) {
>> + qemu_put_be16s(f, &vdev->vq[i].vector);
>> + }
>> }
>> }
>>
>
> I think this will break build on systems without PCI
> because virtio_pci.c is not linked in there.
> Correct?
It compiles for syborg (it has pci). There are no other users.
> Making generic virtio.c depend on virtio_pci.c looks
> wrong in any case. We have bindings to
> resolve exactly this dependency problem.
There is no way that you throw "this" blob to vmstate and it will know
what to do there. if it is needed, we can create an empty
virtio_pci_msix_present() function for !CONFIG_PCI.
Later, Juan.
- [Qemu-devel] [PATCH 09/41] msix: port to vmstate, (continued)
- [Qemu-devel] [PATCH 09/41] msix: port to vmstate, Juan Quintela, 2009/12/02
- [Qemu-devel] [PATCH 10/41] qemu/pci: document msix_entries_nr field, Juan Quintela, 2009/12/02
- [Qemu-devel] [PATCH 11/41] virtio: Introduce type field to distingish between PCI and Syborg, Juan Quintela, 2009/12/02
- [Qemu-devel] [PATCH 12/41] virtio-pci: port pci config to vmstate, Juan Quintela, 2009/12/02
- [Qemu-devel] [PATCH 13/41] msix: msix_load/save are not needed anymore, Juan Quintela, 2009/12/02
- [Qemu-devel] [PATCH 14/41] virtio: remove save/load_config for virtio, Juan Quintela, 2009/12/02
- [Qemu-devel] [PATCH 15/41] virtio: remove save/load_queue for virtio, Juan Quintela, 2009/12/02
[Qemu-devel] [PATCH 16/41] virtio: Add num_pci_queues field, Juan Quintela, 2009/12/02
[Qemu-devel] [PATCH 17/41] virtio: split virtio_post_load() from virtio_load(), Juan Quintela, 2009/12/02
[Qemu-devel] [PATCH 18/41] virtio: change config_len type to int32_t, Juan Quintela, 2009/12/02
[Qemu-devel] [PATCH 21/41] virtio: port to vmstate, Juan Quintela, 2009/12/02
[Qemu-devel] [PATCH 19/41] virtio: use the right types for VirtQueue elements, Juan Quintela, 2009/12/02