Re: [Qemu-devel] [PATCH 2/4] rom loader: make vga+rom loading target specific

[Blue Swirl]

On Tue, Oct 13, 2009 at 2:06 PM, Gerd Hoffmann <address@hidden> wrote:
> This patch adds a loader-target.c file for target-specific
> rom loading functions.  The rom_add_vga() and rom_add_option()
> macros are transformed into functions and sticked in there.  They
> load the bios on TARGET_I386 and no nothing on other targets.

IIRC the VGA cards on non-x86 machines contain ROMs too, some (PPC?
Alpha?) machine had a simple x86 emulator just to run the ROM code.
Then you could enable the VGA ROM loading unconditionally. So maybe
the patch isn't necessary?

Otherwise you could add two files without macros, then the files can
be compiled just once.