[Qemu-devel] Re: [PATCH] IDE: Return zero when reading error register with slave selected

[Justin Chevrier]

--- On Sat, 12/13/08, Justin Chevrier <address@hidden> wrote:

> From: Justin Chevrier <address@hidden>
> Subject: [PATCH] IDE: Return zero when reading error register with slave 
> selected
> To: address@hidden
> Date: Saturday, December 13, 2008, 7:46 PM
> During hardware detection Openserver issues commands to
> slaves on both primary and secondary ports. We already
> return a zero for the status register in this situation but
> after reading the status register the Openserver installer
> proceeds to check the value of the error register. Currently
> we return the existing value in the register. This confuses
> the installer and it tries to access the slave units later
> on. When the command that gets issued later gets ignored the
> installer freezes. The patch below returns zero when reading
> the error register if a slave unit is selected. Openserver
> can now successfully be installed using the emulated IDE
> hard drive.
> 
> Changelog:
> 
> Return zero when reading error register with slave selected
> 
> Signed-off-by: Justin Chevrier <address@hidden>
> 
> --- hw/ide.c    (revision 5976)
> +++ hw/ide.c    (working copy)
> @@ -2472,7 +2472,8 @@
>          ret = 0xff;
>          break;
>      case 1:
> -        if (!ide_if[0].bs && !ide_if[1].bs)
> +        if ((!ide_if[0].bs && !ide_if[1].bs) ||
> +            (s != ide_if && !s->bs))
>              ret = 0;
>          else if (!hob)
>              ret = s->error;

Hey Guys,

Anything wrong with this patch?

I've since tested Win98, WinXP SP2, Gentoo Linux x86 (2.6.27.7) and Debian 
Linux SPARC (2.6.18-5-sparc32) all without issue.

Thanks,

Justin