Re: [Qemu-devel] [6023] Use a hex value instead of possibly ambiguous 8 bit character

[Johannes Schindelin]

Hi,


Please Cc: me, I only did not miss your message because it is a slow 
Sunday morning (_and_ I am not in a deep hacking session).



On Sun, 14 Dec 2008, Andreas Schwab wrote:

> Johannes Schindelin <address@hidden> writes:
> 
> > +#define ADD_CHAR(c) buffer[j++] = (c) ? '.' : (c)

Oops.  This is obviously wrong, and should read

#define ADD_CHAR(c) buffer[j++] = (c) < ' ' ? '.' : (c)

> isprint(c) perhaps?

I vote against using isprint(c).  The code is simple as it is, otherwise 
you'd have to look up what isprint() does, _and_ rely on isprint() being 
present.

I know, there are many people on this list who are all too happy to rely 
on new-fangled C99 stuff or lock themselves (and others) in with GCCisms. 
Peronally, though, I find it utterly stupid to do that unless you really 
have to.

Ciao,
Dscho