Re: [Qemu-devel] (no subject)

[Aurelien Jarno]

On Thu, Dec 11, 2008 at 04:12:33PM -0600, Hollis Blanchard wrote:
> I'm not familiar with this device, but I'm fairly certain the writel handler 
> is
> not supposed to recurse.
>
> Signed-off-by: Hollis Blanchard <address@hidden>

Thanks, applied.

> diff --git a/hw/ppc405_boards.c b/hw/ppc405_boards.c
> index 4144dae..1d8b6ab 100644
> --- a/hw/ppc405_boards.c
> +++ b/hw/ppc405_boards.c
> @@ -129,9 +129,9 @@ static uint32_t ref405ep_fpga_readl (void *opaque, 
> target_phys_addr_t addr)
>  static void ref405ep_fpga_writel (void *opaque,
>                                    target_phys_addr_t addr, uint32_t value)
>  {
> -    ref405ep_fpga_writel(opaque, addr, (value >> 24) & 0xFF);
> -    ref405ep_fpga_writel(opaque, addr + 1, (value >> 16) & 0xFF);
> -    ref405ep_fpga_writel(opaque, addr + 2, (value >> 8) & 0xFF);
> +    ref405ep_fpga_writeb(opaque, addr, (value >> 24) & 0xFF);
> +    ref405ep_fpga_writeb(opaque, addr + 1, (value >> 16) & 0xFF);
> +    ref405ep_fpga_writeb(opaque, addr + 2, (value >> 8) & 0xFF);
>      ref405ep_fpga_writeb(opaque, addr + 3, value & 0xFF);
>  }
>  
> 
> 
> 

-- 
  .''`.  Aurelien Jarno             | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   address@hidden         | address@hidden
   `-    people.debian.org/~aurel32 | www.aurel32.net