Re: [Qemu-devel] [5889] Make struct iovec universally available

[Andreas Färber]

Am 05.12.2008 um 21:05 schrieb Anthony Liguori:

> Revision: 5889
>          http://svn.sv.gnu.org/viewvc/? 
> view=rev&root=qemu&revision=5889
> Author:   aliguori
> Date:     2008-12-05 20:05:26 +0000 (Fri, 05 Dec 2008)
>
> Log Message:
> -----------
> Make struct iovec universally available
>
> Vectored IO APIs will require some sort of vector argument.  It  
> makes sense to
> use struct iovec and just define it globally for Windows.
>
> Signed-off-by: Anthony Liguori <address@hidden>

> Modified: trunk/configure
> ===================================================================
> --- trunk/configure     2008-12-05 17:56:40 UTC (rev 5888)
> +++ trunk/configure     2008-12-05 20:05:26 UTC (rev 5889)
> @@ -1017,6 +1017,17 @@
>   fi
> fi
>
> +##########################################
> +# iovec probe
> +cat > $TMPC <<EOF
> +#include <sys/uio.h>
> +int main(void) { struct iovec iov; return 0; }
> +EOF
> +iovec=no
> +if $cc $ARCH_CFLAGS -o $TMPE $TMPC 2> /dev/null ; then
> +  iovec=yes
> +fi
> +
> # Check if tools are available to build documentation.
> if [ -x "`which texi2html 2>/dev/null`" ] && \
>    [ -x "`which pod2man 2>/dev/null`" ]; then
> @@ -1376,6 +1387,9 @@
> if test "$blobs" = "yes" ; then
>   echo "INSTALL_BLOBS=yes" >> $config_mak
> fi
> +if test "$iovec" = "yes" ; then
> +  echo "#define HAVE_IOVEC 1" >> $config_h
> +fi
>
> # XXX: suppress that
> if [ "$bsd" = "yes" ] ; then

On Mac OS X v10.5 this test results in HAVE_IOVEC 1, but I get the  
following compilation failure:

gcc -I. -I.. -I/Users/andreas/Q/qemu/target-i386 -I/Users/andreas/Q/ 
qemu -MMD -MT pc.o -MP -DNEED_CPU_H -D__powerpc__ -D_GNU_SOURCE - 
D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -I/Users/andreas/Q/qemu/tcg - 
I/Users/andreas/Q/qemu/tcg/ppc -I/Users/andreas/Q/qemu/fpu -DHAS_AUDIO  
-DHAS_AUDIO_CHOICE -I/Users/andreas/Q/qemu/slirp -O2 -g -fno-strict- 
aliasing -Wall -Wundef -Wendif-labels -Wwrite-strings -mdynamic-no- 
pic  -c -o pc.o /Users/andreas/Q/qemu/hw/pc.c
In file included from /Users/andreas/Q/qemu/hw/virtio-blk.h:17,
                 from /Users/andreas/Q/qemu/hw/pc.c:36:
/Users/andreas/Q/qemu/hw/virtio.h:67: error: array type has incomplete  
element type
/Users/andreas/Q/qemu/hw/virtio.h:68: error: array type has incomplete  
element type
/Users/andreas/Q/qemu/hw/pc.c: In function ‘pc_init1’:
/Users/andreas/Q/qemu/hw/pc.c:830: warning: large integer implicitly  
truncated to unsigned type
make[1]: *** [pc.o] Error 1
make: *** [subdir-i386-softmmu] Error 2

It does not go away even if I #define HAVE_IOVEC 0 in config-host.h.

Any ideas?

Andreas