[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] ide.c make write cacheing controllable by guest
From: |
Ian Jackson |
Subject: |
Re: [Qemu-devel] [PATCH] ide.c make write cacheing controllable by guest |
Date: |
Tue, 26 Feb 2008 18:11:50 +0000 |
Jamie Lokier writes ("Re: [Qemu-devel] [PATCH] ide.c make write cacheing
controllable by guest"):
> I agree it's a bit ambiguous. My understanding is that _increases_ in
> size are included, by convention as much as anything, since the larger
> size is necessary to retrieve the data later.
Yes. Well, if you're sufficiently convinced then I think the right
thing for you to do is to submit a patch to change the calls to fsync
to calls to fdatasync.
Sadly my patches don't seem to have been applied in CVS yet. I'll
arrange to publish my git tree and then you can make a diff that will
sit properly on top of my tree (which is what you want because I have
added error checking, so otherwise we get a conflict).
Ian.