[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] mips-user socket-related syscall support
From: |
Raphaël Rigo |
Subject: |
Re: [Qemu-devel] [PATCH] mips-user socket-related syscall support |
Date: |
Thu, 22 Jun 2006 19:14:30 +0200 |
User-agent: |
Thunderbird 1.5.0.4 (X11/20060614) |
Raphaël Rigo wrote:
> Fabrice Bellard wrote:
>> Another point is that doing:
>>
>> + target_long args[6];
>> +
>> + tputl(args, arg1);
>> + tputl(args+1, arg2);
>> + tputl(args+2, arg3);
>> + tputl(args+3, arg4);
>> + tputl(args+4, arg5);
>> + tputl(args+5, arg6);
>>
>> at the start of every syscall is not acceptable. You should add a
>> specific socket call wrapper which takes arg1... arg6 as arguments.
>>
>> Regards,
>>
>> Fabrice.
> Thanks for reviewing it, the new attached version should be much cleaner.
>
> Regards,
> Raphaël
Sorry to insist, but can you please include it in the CVS? I really think it's
useful.
Thanks,
Raphaël