[Qemu-commits] [qemu/qemu] 024d04: virtio-rng: block max-bytes=0

qemu-commits
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] 024d04: virtio-rng: block max-bytes=0

From:	Richard Henderson
Subject:	[Qemu-commits] [qemu/qemu] 024d04: virtio-rng: block max-bytes=0
Date:	Thu, 01 Aug 2024 03:53:57 -0700
  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: 024d046bf41b5256adec671085bcee767a6da125
      
https://github.com/qemu/qemu/commit/024d046bf41b5256adec671085bcee767a6da125
  Author: Michael S. Tsirkin <mst@redhat.com>
  Date:   2024-08-01 (Thu, 01 Aug 2024)

  Changed paths:
    M hw/virtio/virtio-rng.c

  Log Message:
  -----------
  virtio-rng: block max-bytes=0

with max-bytes set to 0, quota is 0 and so device does not work.
block this to avoid user confusion

Message-Id: 
<73a89a42d82ec8b47358f25119b87063e4a6ea57.1721818306.git.mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>


  Commit: e57030e8dc071424b0fc35c0e0cf2898e53d5e81
      
https://github.com/qemu/qemu/commit/e57030e8dc071424b0fc35c0e0cf2898e53d5e81
  Author: Michael S. Tsirkin <mst@redhat.com>
  Date:   2024-08-01 (Thu, 01 Aug 2024)

  Changed paths:
    M MAINTAINERS
    M docs/system/index.rst
    R docs/system/sriov.rst

  Log Message:
  -----------
  Revert "docs: Document composable SR-IOV device"

This reverts commit d6f40c95b35bd380340b698e4306704fe22a5d68.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: cc91ac0a7240dea713acc802d0c304163a1c15c6
      
https://github.com/qemu/qemu/commit/cc91ac0a7240dea713acc802d0c304163a1c15c6
  Author: Michael S. Tsirkin <mst@redhat.com>
  Date:   2024-08-01 (Thu, 01 Aug 2024)

  Changed paths:
    M hw/virtio/virtio-net-pci.c

  Log Message:
  -----------
  Revert "virtio-net: Implement SR-IOV VF"

This reverts commit c2d6db6a1f39780b24538440091893f9fbe060a7.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: 67f5b279fc72e43ccdee20a1a1e54cb51e24f06a
      
https://github.com/qemu/qemu/commit/67f5b279fc72e43ccdee20a1a1e54cb51e24f06a
  Author: Michael S. Tsirkin <mst@redhat.com>
  Date:   2024-08-01 (Thu, 01 Aug 2024)

  Changed paths:
    M hw/virtio/virtio-pci.c
    M include/hw/virtio/virtio-pci.h

  Log Message:
  -----------
  Revert "virtio-pci: Implement SR-IOV PF"

This reverts commit 3f868ffb0bae0c4feafabe34a371cded57fe3806.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: aa01c4914ed6f6c087ee172483e22a515c4cc66a
      
https://github.com/qemu/qemu/commit/aa01c4914ed6f6c087ee172483e22a515c4cc66a
  Author: Michael S. Tsirkin <mst@redhat.com>
  Date:   2024-08-01 (Thu, 01 Aug 2024)

  Changed paths:
    M hw/pci/pci.c
    M hw/pci/pcie_sriov.c
    M include/hw/pci/pci_device.h
    M include/hw/pci/pcie_sriov.h

  Log Message:
  -----------
  Revert "pcie_sriov: Allow user to create SR-IOV device"

This reverts commit 122173a5830f7757f8a94a3b1559582f312e140b.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: c8597d3e1c79a27cbf8ec3bed1a58a426f29ae21
      
https://github.com/qemu/qemu/commit/c8597d3e1c79a27cbf8ec3bed1a58a426f29ae21
  Author: Michael S. Tsirkin <mst@redhat.com>
  Date:   2024-08-01 (Thu, 01 Aug 2024)

  Changed paths:
    M hw/pci/pcie_sriov.c

  Log Message:
  -----------
  Revert "pcie_sriov: Check PCI Express for SR-IOV PF"

This reverts commit 47cc753e50076c25334091783738be9f716253b1.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: da44479b1d79dd31eabaa865260ad3e679cdf2e1
      
https://github.com/qemu/qemu/commit/da44479b1d79dd31eabaa865260ad3e679cdf2e1
  Author: Michael S. Tsirkin <mst@redhat.com>
  Date:   2024-08-01 (Thu, 01 Aug 2024)

  Changed paths:
    M hw/pci/pcie_sriov.c

  Log Message:
  -----------
  Revert "pcie_sriov: Ensure PF and VF are mutually exclusive"

This reverts commit 78f9d7fd1989311040beff54979bcb2a1ba0aff2.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: 558452512f068bfb3584a5a8b15530b0c53074c7
      
https://github.com/qemu/qemu/commit/558452512f068bfb3584a5a8b15530b0c53074c7
  Author: Michael S. Tsirkin <mst@redhat.com>
  Date:   2024-08-01 (Thu, 01 Aug 2024)

  Changed paths:
    M hw/pci/pci.c

  Log Message:
  -----------
  Revert "hw/pci: Fix SR-IOV VF number calculation"

This reverts commit ca6dd3aef8a103138c99788bcba8195d4905ddc5.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: b9ba81769499533488540b6d5ed7c7569476a427
      
https://github.com/qemu/qemu/commit/b9ba81769499533488540b6d5ed7c7569476a427
  Author: Michael S. Tsirkin <mst@redhat.com>
  Date:   2024-08-01 (Thu, 01 Aug 2024)

  Changed paths:
    M hw/pci/pci.c
    M hw/pci/pcie_sriov.c
    M include/hw/pci/pcie_sriov.h

  Log Message:
  -----------
  Revert "pcie_sriov: Register VFs after migration"

This reverts commit 107a64b9a360cf5ca046852bc03334f7a9f22aef.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: ae9c192de7ab0f56f32d8b60b6568917e0138919
      
https://github.com/qemu/qemu/commit/ae9c192de7ab0f56f32d8b60b6568917e0138919
  Author: Michael S. Tsirkin <mst@redhat.com>
  Date:   2024-08-01 (Thu, 01 Aug 2024)

  Changed paths:
    M hw/pci/pcie_sriov.c
    M hw/pci/trace-events
    M include/hw/pci/pcie_sriov.h

  Log Message:
  -----------
  Revert "pcie_sriov: Remove num_vfs from PCIESriovPF"

This reverts commit cbd9e5120bac3e292eee77b7a2e3692f235a1a26.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: 9bab08da4e932e9c95919951792ae09d0a59f726
      
https://github.com/qemu/qemu/commit/9bab08da4e932e9c95919951792ae09d0a59f726
  Author: Michael S. Tsirkin <mst@redhat.com>
  Date:   2024-08-01 (Thu, 01 Aug 2024)

  Changed paths:
    M hw/pci/pcie_sriov.c

  Log Message:
  -----------
  Revert "pcie_sriov: Release VFs failed to realize"

This reverts commit 1a9bf009012e590cb166a4a9bae4bc18fb084d76.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: b1282f1e352db9947267a6524c6ded9678e82629
      
https://github.com/qemu/qemu/commit/b1282f1e352db9947267a6524c6ded9678e82629
  Author: Michael S. Tsirkin <mst@redhat.com>
  Date:   2024-08-01 (Thu, 01 Aug 2024)

  Changed paths:
    M hw/pci/pci.c
    M hw/pci/pcie_sriov.c
    M include/hw/pci/pci.h
    M include/hw/pci/pci_device.h
    M include/hw/pci/pcie_sriov.h

  Log Message:
  -----------
  Revert "pcie_sriov: Reuse SR-IOV VF device instances"

This reverts commit 139610ae67f6ecf92127bb7bf53ac6265b459ec8.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: 19c45c00dc6a52f80f27dabbd28de1b770c16a89
      
https://github.com/qemu/qemu/commit/19c45c00dc6a52f80f27dabbd28de1b770c16a89
  Author: Michael S. Tsirkin <mst@redhat.com>
  Date:   2024-08-01 (Thu, 01 Aug 2024)

  Changed paths:
    M docs/pcie_sriov.txt
    M hw/net/igb.c
    M hw/nvme/ctrl.c
    M hw/pci/pcie_sriov.c
    M include/hw/pci/pcie_sriov.h

  Log Message:
  -----------
  Revert "pcie_sriov: Ensure VF function number does not overflow"

This reverts commit 77718701157f6ca77ea7a57b536fa0a22f676082.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: b0fdaee5d1ed52f650ca0c3bebfce3dd4dc8ddb5
      
https://github.com/qemu/qemu/commit/b0fdaee5d1ed52f650ca0c3bebfce3dd4dc8ddb5
  Author: Michael S. Tsirkin <mst@redhat.com>
  Date:   2024-08-01 (Thu, 01 Aug 2024)

  Changed paths:
    M hw/pci/pcie_sriov.c

  Log Message:
  -----------
  Revert "pcie_sriov: Do not manually unrealize"

This reverts commit c613ad25125bf3016aa8f81ce170f5ac91d2379f.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: 47279e8afa84cb28e84e3ac4392487b94a494fa9
      
https://github.com/qemu/qemu/commit/47279e8afa84cb28e84e3ac4392487b94a494fa9
  Author: Michael S. Tsirkin <mst@redhat.com>
  Date:   2024-08-01 (Thu, 01 Aug 2024)

  Changed paths:
    M hw/ppc/spapr_pci.c

  Log Message:
  -----------
  Revert "hw/ppc/spapr_pci: Do not reject VFs created after a PF"

This reverts commit 26f86093ec989cb73ad03e8a234f5dc321e1e267.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: f1feffc4ef4b1c02daa5ce23fa8ad728c8ef7ce9
      
https://github.com/qemu/qemu/commit/f1feffc4ef4b1c02daa5ce23fa8ad728c8ef7ce9
  Author: Michael S. Tsirkin <mst@redhat.com>
  Date:   2024-08-01 (Thu, 01 Aug 2024)

  Changed paths:
    M hw/ppc/spapr_pci.c

  Log Message:
  -----------
  Revert "hw/ppc/spapr_pci: Do not create DT for disabled PCI device"

This reverts commit 723c5b4628d047e43825a046c6ee517b82b88117.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: 93829009a685687e2fb48158cb5df18c4eb49d07
      
https://github.com/qemu/qemu/commit/93829009a685687e2fb48158cb5df18c4eb49d07
  Author: Michael S. Tsirkin <mst@redhat.com>
  Date:   2024-08-01 (Thu, 01 Aug 2024)

  Changed paths:
    M hw/pci/pci.c
    M hw/pci/pci_host.c
    M include/hw/pci/pci.h
    M include/hw/pci/pci_device.h

  Log Message:
  -----------
  Revert "hw/pci: Rename has_power to enabled"

This reverts commit 6a31b219a5338564f3978251c79f96f689e037da.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: 9a45b0761628cc59267b3283a85d15294464ac31
      
https://github.com/qemu/qemu/commit/9a45b0761628cc59267b3283a85d15294464ac31
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2024-08-01 (Thu, 01 Aug 2024)

  Changed paths:
    M hw/i386/amd_iommu.c

  Log Message:
  -----------
  hw/i386/amd_iommu: Don't leak memory in amdvi_update_iotlb()

In amdvi_update_iotlb() we will only put a new entry in the hash
table if to_cache.perm is not IOMMU_NONE.  However we allocate the
memory for the new AMDVIIOTLBEntry and for the hash table key
regardless.  This means that in the IOMMU_NONE case we will leak the
memory we alloacted.

Move the allocations into the if() to the point where we know we're
going to add the item to the hash table.

Cc: qemu-stable@nongnu.org
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2452
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20240731170019.3590563-1-peter.maydell@linaro.org>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: 515457757ff8540c524ff39ea1d9564b251c6532
      
https://github.com/qemu/qemu/commit/515457757ff8540c524ff39ea1d9564b251c6532
  Author: yeeli <seven.yi.lee@gmail.com>
  Date:   2024-08-01 (Thu, 01 Aug 2024)

  Changed paths:
    M hw/i386/intel_iommu.c

  Log Message:
  -----------
  intel_iommu: Fix for IQA reg read dropped DW field

If VT-D hardware supports scalable mode, Linux will set the IQA DW field
(bit11). In qemu, the vtd_mem_write and vtd_update_iq_dw set DW field well.
However, vtd_mem_read the DW field wrong because "& VTD_IQA_QS" dropped the
value of DW.
Replace "&VTD_IQA_QS" with "& (VTD_IQA_QS | VTD_IQA_DW_MASK)" could save
the DW field.

Test patch as below:

config the "x-scalable-mode" option:
"-device intel-iommu,caching-mode=on,x-scalable-mode=on,aw-bits=48"

After Linux OS boot, check the IQA_REG DW Field by usage 1 or 2:

1. IOMMU_DEBUGFS:
Before fix:
cat /sys/kernel/debug/iommu/intel/iommu_regset |grep IQA
IQA                     0x90            0x00000001001da001

After fix:
cat /sys/kernel/debug/iommu/intel/iommu_regset |grep IQA
IQA                     0x90            0x00000001001da801

Check DW field(bit11) is 1.

2. devmem2 read the IQA_REG (offset 0x90):
Before fix:
devmem2 0xfed90090
/dev/mem opened.
Memory mapped at address 0x7f72c795b000.
Value at address 0xFED90090 (0x7f72c795b090): 0x1DA001

After fix:
devmem2 0xfed90090
/dev/mem opened.
Memory mapped at address 0x7fc95281c000.
Value at address 0xFED90090 (0x7fc95281c090): 0x1DA801

Check DW field(bit11) is 1.

Signed-off-by: yeeli <seven.yi.lee@gmail.com>
Message-Id: <20240725031858.1529902-1-seven.yi.lee@gmail.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: 5e25c93ccb8ddc8dda6845d6c09334ca44cbef17
      
https://github.com/qemu/qemu/commit/5e25c93ccb8ddc8dda6845d6c09334ca44cbef17
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2024-08-01 (Thu, 01 Aug 2024)

  Changed paths:
    M MAINTAINERS
    M docs/pcie_sriov.txt
    M docs/system/index.rst
    R docs/system/sriov.rst
    M hw/i386/amd_iommu.c
    M hw/i386/intel_iommu.c
    M hw/net/igb.c
    M hw/nvme/ctrl.c
    M hw/pci/pci.c
    M hw/pci/pci_host.c
    M hw/pci/pcie_sriov.c
    M hw/pci/trace-events
    M hw/ppc/spapr_pci.c
    M hw/virtio/virtio-net-pci.c
    M hw/virtio/virtio-pci.c
    M hw/virtio/virtio-rng.c
    M include/hw/pci/pci.h
    M include/hw/pci/pci_device.h
    M include/hw/pci/pcie_sriov.h
    M include/hw/virtio/virtio-pci.h

  Log Message:
  -----------
  Merge tag 'for_upstream' of https://git.kernel.org/pub/scm/virt/kvm/mst/qemu 
into staging

virtio,pci,pc: fixes

revert virtio pci/SR-IOV emulation at author's request
a couple of fixes in virtio,vtd

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

# -----BEGIN PGP SIGNATURE-----
#
# iQFDBAABCAAtFiEEXQn9CHHI+FuUyooNKB8NuNKNVGkFAmarSFUPHG1zdEByZWRo
# YXQuY29tAAoJECgfDbjSjVRp7fwH/3wNCGhgHhF5dhKRKRn8hqhxYl2rXnv0LKYI
# Rgsoxh3kw6oKBXxLG/B4V2GkqDSU8q8NuHnvGmmAUQ/uHmwTWbBbrZ+HwMMmaRhT
# Ox8kIXiVYAtw24yLKDvyoKbMLjLKb9/QqTT4rbsQ9yl5PLxwoGGJEu/ifM1MbZZY
# f5CDtj3hRArIZEjMt0Q3h+G7///BRVZxQ/0de57whGXcr349qgMpiIThvlCOj7Yf
# rQ68AGS4yk1Jk0oxiYyWjo43o8JbB5bMnCrkzDy4ZdY5Sw9zGb48CmcrBUl4J9lv
# NVDYK63dsvRS0ew7PxaEwu32MIQLJcn5s521m81/ZAhbdyzLnlI=
# =/2+K
# -----END PGP SIGNATURE-----
# gpg: Signature made Thu 01 Aug 2024 06:33:25 PM AEST
# gpg:                using RSA key 5D09FD0871C8F85B94CA8A0D281F0DB8D28D5469
# gpg:                issuer "mst@redhat.com"
# gpg: Good signature from "Michael S. Tsirkin <mst@kernel.org>" [undefined]
# gpg:                 aka "Michael S. Tsirkin <mst@redhat.com>" [undefined]
# gpg: WARNING: The key's User ID is not certified with a trusted signature!
# gpg:          There is no indication that the signature belongs to the owner.
# Primary key fingerprint: 0270 606B 6F3C DF3D 0B17  0970 C350 3912 AFBE 8E67
#      Subkey fingerprint: 5D09 FD08 71C8 F85B 94CA  8A0D 281F 0DB8 D28D 5469

* tag 'for_upstream' of https://git.kernel.org/pub/scm/virt/kvm/mst/qemu:
  intel_iommu: Fix for IQA reg read dropped DW field
  hw/i386/amd_iommu: Don't leak memory in amdvi_update_iotlb()
  Revert "hw/pci: Rename has_power to enabled"
  Revert "hw/ppc/spapr_pci: Do not create DT for disabled PCI device"
  Revert "hw/ppc/spapr_pci: Do not reject VFs created after a PF"
  Revert "pcie_sriov: Do not manually unrealize"
  Revert "pcie_sriov: Ensure VF function number does not overflow"
  Revert "pcie_sriov: Reuse SR-IOV VF device instances"
  Revert "pcie_sriov: Release VFs failed to realize"
  Revert "pcie_sriov: Remove num_vfs from PCIESriovPF"
  Revert "pcie_sriov: Register VFs after migration"
  Revert "hw/pci: Fix SR-IOV VF number calculation"
  Revert "pcie_sriov: Ensure PF and VF are mutually exclusive"
  Revert "pcie_sriov: Check PCI Express for SR-IOV PF"
  Revert "pcie_sriov: Allow user to create SR-IOV device"
  Revert "virtio-pci: Implement SR-IOV PF"
  Revert "virtio-net: Implement SR-IOV VF"
  Revert "docs: Document composable SR-IOV device"
  virtio-rng: block max-bytes=0

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


Compare: https://github.com/qemu/qemu/compare/e9d2db818ff9...5e25c93ccb8d

To unsubscribe from these emails, change your notification settings at 
https://github.com/qemu/qemu/settings/notifications
[Prev in Thread]
Current Thread
[Next in Thread]
[Qemu-commits] [qemu/qemu] 024d04: virtio-rng: block max-bytes=0, Richard Henderson <=
- [Qemu-commits] [qemu/qemu] 024d04: virtio-rng: block max-bytes=0, Richard Henderson, 2024/08/01
Next by Date: [Qemu-commits] [qemu/qemu] 024d04: virtio-rng: block max-bytes=0
Next by thread: [Qemu-commits] [qemu/qemu] 024d04: virtio-rng: block max-bytes=0
Index(es):
- Date
- Thread