qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 515632: tests/lcitool: fix debian-i686-cross


From: Richard Henderson
Subject: [Qemu-commits] [qemu/qemu] 515632: tests/lcitool: fix debian-i686-cross toolchain prefix
Date: Fri, 05 Jul 2024 11:08:43 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 515632d5205a2abc9beb80cc70f51235fe2b47f2
      
https://github.com/qemu/qemu/commit/515632d5205a2abc9beb80cc70f51235fe2b47f2
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2024-07-05 (Fri, 05 Jul 2024)

  Changed paths:
    M tests/docker/dockerfiles/debian-i686-cross.docker
    M tests/lcitool/refresh

  Log Message:
  -----------
  tests/lcitool: fix debian-i686-cross toolchain prefix

I guess we never noticed and tried to build with this cross image. Fix
the toolchain prefix so we actually build 32 bit images.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240705084047.857176-2-alex.bennee@linaro.org>


  Commit: 4d17cc5a7811316d5c6ff09a33af0f1dd6a16d10
      
https://github.com/qemu/qemu/commit/4d17cc5a7811316d5c6ff09a33af0f1dd6a16d10
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2024-07-05 (Fri, 05 Jul 2024)

  Changed paths:
    M .gitlab-ci.d/crossbuilds.yml

  Log Message:
  -----------
  testing: restore some testing for i686

The commit 4f9a8315e6 (gitlab-ci.d/crossbuilds: Drop the i386 system
emulation job) was a little too aggressive dropping testing for 32 bit
system builds. Partially revert but using the debian-i686 cross build
images this time as fedora has deprecated the 32 bit stuff.

As the SEV breakage gets in the way and its TCG issues we want to
catch I've added --disable-kvm to the build.

Reported-by: Richard Henderson <richard.henderson@linaro.org>
Suggested-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240705084047.857176-3-alex.bennee@linaro.org>


  Commit: d44fe13b2b8631956b4e4ea72c5b39d8c9f194e2
      
https://github.com/qemu/qemu/commit/d44fe13b2b8631956b4e4ea72c5b39d8c9f194e2
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2024-07-05 (Fri, 05 Jul 2024)

  Changed paths:
    M system/physmem.c
    M system/trace-events
    M trace-events

  Log Message:
  -----------
  tracepoints: move physmem trace points

They don't need to be in the global trace-events file and can have a
local trace header. Also add address_space_map tracepoint for tracking
mapping behaviour.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240705084047.857176-4-alex.bennee@linaro.org>


  Commit: f5fcc648083e71cfb9394894903f8ea108ff8831
      
https://github.com/qemu/qemu/commit/f5fcc648083e71cfb9394894903f8ea108ff8831
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2024-07-05 (Fri, 05 Jul 2024)

  Changed paths:
    M hw/core/loader-fit.c

  Log Message:
  -----------
  hw/core: ensure kernel_end never gets used undefined

Really the problem here is the return values of fit_load_[kernel|fdt]() are a
little all over the place. However we don't want to somehow get
through not having set kernel_end and having it just be random unused
data.

The compiler complained on an --enable-gcov build:

  In file included from ../../hw/core/loader-fit.c:20:
  /home/alex/lsrc/qemu.git/include/qemu/osdep.h: In function ‘load_fit’:
  /home/alex/lsrc/qemu.git/include/qemu/osdep.h:486:45: error: ‘kernel_end’ may 
be used uninitialized [-Werror=maybe-uninitialized]
    486 | #define ROUND_UP(n, d) ROUND_DOWN((n) + (d) - 1, (d))
        |                                             ^
  ../../hw/core/loader-fit.c:270:12: note: ‘kernel_end’ was declared here
    270 |     hwaddr kernel_end;
        |            ^~~~~~~~~~

Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Aleksandar Rikalo <arikalo@gmail.com>
Message-Id: <20240705084047.857176-5-alex.bennee@linaro.org>


  Commit: aa8246d8b4f81d5a552837c825fa4c72c55e1de9
      
https://github.com/qemu/qemu/commit/aa8246d8b4f81d5a552837c825fa4c72c55e1de9
  Author: Akihiko Odaki <akihiko.odaki@daynix.com>
  Date:   2024-07-05 (Fri, 05 Jul 2024)

  Changed paths:
    M tests/docker/Makefile.include

  Log Message:
  -----------
  tests/docker: Specify --userns keep-id for Podman

Previously we are always specifying -u $(UID) to match the UID in the
container with one outside. This causes a problem with rootless Podman.

Rootless Podman remaps user IDs in the container to ones controllable
for the current user outside. The -u option instructs Podman to use
a specified UID in the container but does not affect the UID remapping.
Therefore, the UID in the container can be remapped to some other UID
outside the container. This can make the access to bind-mounted volumes
fail because the remapped UID mismatches with the owner of the
directories.

Replace -u $(UID) with --userns keep-id, which fixes the UID remapping.
This change is limited to Podman because Docker does not support
--userns keep-id.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Message-Id: <20240626-podman-v1-1-f8c8daf2bb0a@daynix.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240705084047.857176-6-alex.bennee@linaro.org>


  Commit: 7e3798eddde9bcbf3e83ddcd236eeca4c413f34f
      
https://github.com/qemu/qemu/commit/7e3798eddde9bcbf3e83ddcd236eeca4c413f34f
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2024-07-05 (Fri, 05 Jul 2024)

  Changed paths:
    M tests/tcg/minilib/printf.c

  Log Message:
  -----------
  tests/tcg/minilib: Constify digits in print_num

This avoids a memcpy to the stack when compiled with clang.
Since we don't enable optimization, nor provide memcpy,
this results in an undefined symbol error at link time.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Message-Id: <20240630190050.160642-2-richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240705084047.857176-7-alex.bennee@linaro.org>


  Commit: 546215d38aea068d4761dc41715161fcc2d127d0
      
https://github.com/qemu/qemu/commit/546215d38aea068d4761dc41715161fcc2d127d0
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2024-07-05 (Fri, 05 Jul 2024)

  Changed paths:
    M tests/tcg/Makefile.target
    M tests/tcg/aarch64/Makefile.softmmu-target
    M tests/tcg/aarch64/Makefile.target

  Log Message:
  -----------
  tests/tcg: Adjust variable defintion from cc-option

Define the variable to the compiler flag used, not "y".
This avoids replication of the compiler flag itself.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Message-Id: <20240630190050.160642-3-richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240705084047.857176-8-alex.bennee@linaro.org>


  Commit: e35562b3a506437a084c58fbddab8a56b0c7c90e
      
https://github.com/qemu/qemu/commit/e35562b3a506437a084c58fbddab8a56b0c7c90e
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2024-07-05 (Fri, 05 Jul 2024)

  Changed paths:
    M tests/tcg/aarch64/Makefile.softmmu-target

  Log Message:
  -----------
  tests/tcg/aarch64: Drop -fno-tree-loop-distribute-patterns

This option is not supported by clang, and is not required
in order to get sve code generation with gcc 12.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Message-Id: <20240630190050.160642-4-richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240705084047.857176-9-alex.bennee@linaro.org>


  Commit: 79e73b5df0a7b94efe7875a80ffb55b34eeb7ecc
      
https://github.com/qemu/qemu/commit/79e73b5df0a7b94efe7875a80ffb55b34eeb7ecc
  Author: Akihiko Odaki <akihiko.odaki@daynix.com>
  Date:   2024-07-05 (Fri, 05 Jul 2024)

  Changed paths:
    M tests/tcg/aarch64/bti-1.c
    M tests/tcg/aarch64/bti-3.c

  Log Message:
  -----------
  tests/tcg/aarch64: Explicitly specify register width

clang version 18.1.6 assumes a register is 64-bit by default and
complains if a 32-bit value is given. Explicitly specify register width
when passing a 32-bit value.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20240627-tcg-v2-3-1690a813348e@daynix.com>
Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Message-Id: <20240630190050.160642-5-richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240705084047.857176-10-alex.bennee@linaro.org>


  Commit: 69375de17bd345f85defc54dae53bc0440e3fc18
      
https://github.com/qemu/qemu/commit/69375de17bd345f85defc54dae53bc0440e3fc18
  Author: Akihiko Odaki <akihiko.odaki@daynix.com>
  Date:   2024-07-05 (Fri, 05 Jul 2024)

  Changed paths:
    M tests/tcg/aarch64/mte-1.c

  Log Message:
  -----------
  tests/tcg/aarch64: Fix irg operand type

irg expects 64-bit integers. Passing a 32-bit integer results in
compilation failure with clang version 18.1.6.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Message-Id: <20240627-tcg-v2-4-1690a813348e@daynix.com>
Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Message-Id: <20240630190050.160642-6-richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240705084047.857176-11-alex.bennee@linaro.org>


  Commit: 98b323fa656fe3ae4304d4803705fe4e6f3abc72
      
https://github.com/qemu/qemu/commit/98b323fa656fe3ae4304d4803705fe4e6f3abc72
  Author: Akihiko Odaki <akihiko.odaki@daynix.com>
  Date:   2024-07-05 (Fri, 05 Jul 2024)

  Changed paths:
    M tests/tcg/arm/fcvt.c

  Log Message:
  -----------
  tests/tcg/aarch64: Do not use x constraint

clang version 18.1.6 does not support x constraint for AArch64.
Use w instead.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Message-Id: <20240627-tcg-v2-5-1690a813348e@daynix.com>
Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Message-Id: <20240630190050.160642-7-richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240705084047.857176-12-alex.bennee@linaro.org>


  Commit: b04bed529ec2bcd8f17fb127e700639bf2da9ac7
      
https://github.com/qemu/qemu/commit/b04bed529ec2bcd8f17fb127e700639bf2da9ac7
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2024-07-05 (Fri, 05 Jul 2024)

  Changed paths:
    M tests/tcg/aarch64/Makefile.target

  Log Message:
  -----------
  tests/tcg/aarch64: Add -fno-integrated-as for sme

The only use of SME is inline assembly.  Both gcc and clang only
support SME with very recent releases; by deferring detection to
the assembler we get better test coverage.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Message-Id: <20240630190050.160642-8-richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240705084047.857176-13-alex.bennee@linaro.org>


  Commit: 3693408c5ebc21008ce0ba7bc03c8a80fbb432ad
      
https://github.com/qemu/qemu/commit/3693408c5ebc21008ce0ba7bc03c8a80fbb432ad
  Author: Akihiko Odaki <akihiko.odaki@daynix.com>
  Date:   2024-07-05 (Fri, 05 Jul 2024)

  Changed paths:
    M tests/tcg/aarch64/fcvt.ref
    M tests/tcg/arm/fcvt.c
    M tests/tcg/arm/fcvt.ref

  Log Message:
  -----------
  tests/tcg/arm: Fix fcvt result messages

The test cases for "converting double-precision to single-precision"
emits float but the result variable was typed as uint32_t and corrupted
the printed values. Propertly type it as float.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Fixes: 8ec8a55e3fc9 ("tests/tcg/arm: add fcvt test cases for AArch32/64")
Message-Id: <20240627-tcg-v2-1-1690a813348e@daynix.com>
[rth: Update arm ref file as well]
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Message-Id: <20240630190050.160642-9-richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240705084047.857176-14-alex.bennee@linaro.org>


  Commit: 8807477c36bc304259b370d3d62c014ee9a0e5ad
      
https://github.com/qemu/qemu/commit/8807477c36bc304259b370d3d62c014ee9a0e5ad
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2024-07-05 (Fri, 05 Jul 2024)

  Changed paths:
    M tests/tcg/arm/Makefile.softmmu-target

  Log Message:
  -----------
  tests/tcg/arm: Drop -N from LDFLAGS

This is redudant with a linker script, and is not
supported by clang.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Message-Id: <20240630190050.160642-10-richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240705084047.857176-15-alex.bennee@linaro.org>


  Commit: 40126a16bddb85fb2f6300be5a919789ccf4d66f
      
https://github.com/qemu/qemu/commit/40126a16bddb85fb2f6300be5a919789ccf4d66f
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2024-07-05 (Fri, 05 Jul 2024)

  Changed paths:
    M tests/tcg/arm/Makefile.target

  Log Message:
  -----------
  tests/tcg/arm: Use -fno-integrated-as for test-arm-iwmmxt

Clang does not support IWMXT instructions.
Fall back to the external assembler.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Message-Id: <20240630190050.160642-11-richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240705084047.857176-16-alex.bennee@linaro.org>


  Commit: 1e7c9ba4a24d97dfeb59de2c0ac158c749945abc
      
https://github.com/qemu/qemu/commit/1e7c9ba4a24d97dfeb59de2c0ac158c749945abc
  Author: Akihiko Odaki <akihiko.odaki@daynix.com>
  Date:   2024-07-05 (Fri, 05 Jul 2024)

  Changed paths:
    M tests/tcg/arm/fcvt.c

  Log Message:
  -----------
  tests/tcg/arm: Manually register allocate half-precision numbers

Clang does not allow specifying an integer as the value of a single
precision register.  Explicitly move value from a general register.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
[rth: Use one single inline asm block.]
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Message-Id: <20240630190050.160642-12-richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240705084047.857176-17-alex.bennee@linaro.org>


  Commit: e3693cd3c9fe868e6b87d0677ad9740b56937d34
      
https://github.com/qemu/qemu/commit/e3693cd3c9fe868e6b87d0677ad9740b56937d34
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2024-07-05 (Fri, 05 Jul 2024)

  Changed paths:
    M tests/tcg/arm/Makefile.target

  Log Message:
  -----------
  tests/tcg/arm: Use -march and -mfpu for fcvt

Clang requires the architecture to be set properly
in order to assemble the half-precision instructions.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Message-Id: <20240630190050.160642-13-richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240705084047.857176-18-alex.bennee@linaro.org>


  Commit: 2f93ff3113d60635328fdeaec5d1fece6ceade5a
      
https://github.com/qemu/qemu/commit/2f93ff3113d60635328fdeaec5d1fece6ceade5a
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2024-07-05 (Fri, 05 Jul 2024)

  Changed paths:
    M tests/tcg/arm/fcvt.c

  Log Message:
  -----------
  tests/tcg/arm: Use vmrs/vmsr instead of mcr/mrc

Clang 14 generates

/home/rth/qemu/src/tests/tcg/arm/fcvt.c:431:9: error: invalid operand for 
instruction
    asm("mrc p10, 7, r1, cr1, cr0, 0\n\t"
        ^
<inline asm>:1:6: note: instantiated into assembly here
        mrc p10, 7, r1, cr1, cr0, 0
            ^
/home/rth/qemu/src/tests/tcg/arm/fcvt.c:432:32: error: invalid operand for 
instruction
        "orr r1, r1, %[flags]\n\t"
                               ^
<inline asm>:3:6: note: instantiated into assembly here
        mcr p10, 7, r1, cr1, cr0, 0
            ^

This is perhaps a clang bug, but using the neon mnemonic is clearer.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Message-Id: <20240630190050.160642-14-richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240705084047.857176-19-alex.bennee@linaro.org>


  Commit: f324a03ee23177e41509786bf09c9e7263989ff8
      
https://github.com/qemu/qemu/commit/f324a03ee23177e41509786bf09c9e7263989ff8
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2024-07-05 (Fri, 05 Jul 2024)

  Changed paths:
    M linux-user/main.c

  Log Message:
  -----------
  linux-user/main: Suppress out-of-range comparison warning for clang

For arm32 host and arm64 guest we get

.../main.c:851:32: error: result of comparison of constant 70368744177664 with 
expression of type 'unsigned long' is always false 
[-Werror,-Wtautological-constant-out-of-range-compare]
        if (TASK_UNMAPPED_BASE < reserved_va) {
            ~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~

We already disable -Wtype-limits here, for this exact comparison, but
that is not enough for clang.  Disable -Wtautological-compare as well,
which is a superset.  GCC ignores the unknown warning flag.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Message-Id: <20240630190050.160642-15-richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240705084047.857176-20-alex.bennee@linaro.org>


  Commit: a4ad4db484c15ac3ed21d6700a3aa9bdc7eed719
      
https://github.com/qemu/qemu/commit/a4ad4db484c15ac3ed21d6700a3aa9bdc7eed719
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2024-07-05 (Fri, 05 Jul 2024)

  Changed paths:
    M .gitlab-ci.d/buildtest.yml
    M .gitlab-ci.d/crossbuilds.yml

  Log Message:
  -----------
  gitlab: don't bother with KVM for TCI builds

In fact any other accelerator would be pointless as the point is to
exercise the TCI accelerator anyway.

Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240705084047.857176-21-alex.bennee@linaro.org>


  Commit: 03295660c854119646baa2e429aac9f2d1fb8a0f
      
https://github.com/qemu/qemu/commit/03295660c854119646baa2e429aac9f2d1fb8a0f
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2024-07-05 (Fri, 05 Jul 2024)

  Changed paths:
    M tests/plugin/insn.c

  Log Message:
  -----------
  test/plugin: make insn plugin less noisy by default

While the match functionality is useful lets make the verbosity
optional while we are actually running.

Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240705084047.857176-22-alex.bennee@linaro.org>


  Commit: ee3878bda1057e3e693ddbc5de657ccc6bcca2bd
      
https://github.com/qemu/qemu/commit/ee3878bda1057e3e693ddbc5de657ccc6bcca2bd
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2024-07-05 (Fri, 05 Jul 2024)

  Changed paths:
    M tests/plugin/insn.c

  Log Message:
  -----------
  test/plugins: preserve the instruction record over translations

We are interested in the particular instruction so we should use a
stable record for it. We could bring this down to physical address but
for now vaddr + disas seems to do the trick.

Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240705084047.857176-23-alex.bennee@linaro.org>


  Commit: bb3dd92d32e1ea805a1eecbb23b35f7675d8a83e
      
https://github.com/qemu/qemu/commit/bb3dd92d32e1ea805a1eecbb23b35f7675d8a83e
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2024-07-05 (Fri, 05 Jul 2024)

  Changed paths:
    M contrib/plugins/lockstep.c

  Log Message:
  -----------
  plugins/lockstep: preserve sock_path

We can't assign sock_path directly from the autofree'd GStrv, take a
copy.

Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240705084047.857176-24-alex.bennee@linaro.org>


  Commit: 5e77f22ac95d18fdbe7e5c542002786f2126a780
      
https://github.com/qemu/qemu/commit/5e77f22ac95d18fdbe7e5c542002786f2126a780
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2024-07-05 (Fri, 05 Jul 2024)

  Changed paths:
    M contrib/plugins/lockstep.c

  Log Message:
  -----------
  plugins/lockstep: make mixed-mode safe

The ExecState is shared across the socket and if we want to compare
say 64 bit and 32 bit binaries we need the two to use the same sizes
for things.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240705084047.857176-25-alex.bennee@linaro.org>


  Commit: 13167b5fe93c2faa91aa08f91353b066423b5ec3
      
https://github.com/qemu/qemu/commit/13167b5fe93c2faa91aa08f91353b066423b5ec3
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2024-07-05 (Fri, 05 Jul 2024)

  Changed paths:
    M contrib/plugins/lockstep.c

  Log Message:
  -----------
  plugins/lockstep: mention the one-insn-per-tb option

This really helps with lockstep although its super slow on big jobs.

Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240705084047.857176-26-alex.bennee@linaro.org>


  Commit: 3b8550c955ccd0a31667414d69a469bfdb7a56ff
      
https://github.com/qemu/qemu/commit/3b8550c955ccd0a31667414d69a469bfdb7a56ff
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2024-07-05 (Fri, 05 Jul 2024)

  Changed paths:
    M contrib/plugins/lockstep.c

  Log Message:
  -----------
  plugins/lockstep: clean-up output

We were repeating information which wasn't super clear. As we already
will have dumped the last failing PC just note the divergence and dump
the previous instruction log.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240705084047.857176-27-alex.bennee@linaro.org>


  Commit: 2089a2e5bb81a258b7d30bf51a2ab7447ecc4e7f
      
https://github.com/qemu/qemu/commit/2089a2e5bb81a258b7d30bf51a2ab7447ecc4e7f
  Author: Philippe Mathieu-Daudé <philmd@linaro.org>
  Date:   2024-07-05 (Fri, 05 Jul 2024)

  Changed paths:
    M plugins/core.c

  Log Message:
  -----------
  plugins: Ensure vCPU index is assigned in init/exit hooks

Since vCPUs are hashed by their index, this index can't
be uninitialized (UNASSIGNED_CPU_INDEX).

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Message-Id: <20240606124010.2460-2-philmd@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240705084047.857176-28-alex.bennee@linaro.org>


  Commit: 853c685e8cb4a53d29c3c61145638b22fd1b9659
      
https://github.com/qemu/qemu/commit/853c685e8cb4a53d29c3c61145638b22fd1b9659
  Author: Philippe Mathieu-Daudé <philmd@linaro.org>
  Date:   2024-07-05 (Fri, 05 Jul 2024)

  Changed paths:
    M hw/core/cpu-common.c
    M include/qemu/plugin.h

  Log Message:
  -----------
  plugins: Free CPUPluginState before destroying vCPU state

cpu::plugin_state is allocated in cpu_common_initfn() when
the vCPU state is created. Release it in cpu_common_finalize()
when we are done.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Message-Id: <20240606124010.2460-3-philmd@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240705084047.857176-29-alex.bennee@linaro.org>


  Commit: 0f3974b64c7dd56e98ebcb98575932eadde421c6
      
https://github.com/qemu/qemu/commit/0f3974b64c7dd56e98ebcb98575932eadde421c6
  Author: Philippe Mathieu-Daudé <philmd@linaro.org>
  Date:   2024-07-05 (Fri, 05 Jul 2024)

  Changed paths:
    M hw/core/cpu-common.c
    M plugins/core.c

  Log Message:
  -----------
  accel/tcg: Move qemu_plugin_vcpu_init__async() to plugins/

Calling qemu_plugin_vcpu_init__async() on the vCPU thread
is a detail of plugins, not relevant to TCG vCPU management.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Message-Id: <20240606124010.2460-4-philmd@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240705084047.857176-30-alex.bennee@linaro.org>


  Commit: 0ef6b12e5839667fa0cec4f463a95fef77b18fda
      
https://github.com/qemu/qemu/commit/0ef6b12e5839667fa0cec4f463a95fef77b18fda
  Author: Gustavo Romero <gustavo.romero@linaro.org>
  Date:   2024-07-05 (Fri, 05 Jul 2024)

  Changed paths:
    M gdbstub/gdbstub.c

  Log Message:
  -----------
  gdbstub: Clean up process_string_cmd

Change 'process_string_cmd' to return true on success and false on
failure, instead of 0 and -1.

Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20240628050850.536447-2-gustavo.romero@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240705084047.857176-31-alex.bennee@linaro.org>


  Commit: 133f202b19d8332de8d433c627fe6354e2ecf889
      
https://github.com/qemu/qemu/commit/133f202b19d8332de8d433c627fe6354e2ecf889
  Author: Gustavo Romero <gustavo.romero@linaro.org>
  Date:   2024-07-05 (Fri, 05 Jul 2024)

  Changed paths:
    M gdbstub/gdbstub.c
    M gdbstub/internals.h
    M gdbstub/syscalls.c
    M gdbstub/system.c
    M gdbstub/user-target.c
    M gdbstub/user.c
    A include/gdbstub/commands.h

  Log Message:
  -----------
  gdbstub: Move GdbCmdParseEntry into a new header file

Move GdbCmdParseEntry and its associated types into a separate header
file to allow the use of GdbCmdParseEntry and other gdbstub command
functions outside of gdbstub.c.

Since GdbCmdParseEntry and get_param are now public, kdoc
GdbCmdParseEntry and rename get_param to gdb_get_cmd_param.

This commit also makes gdb_put_packet public since is used in gdbstub
command handling.

Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240628050850.536447-3-gustavo.romero@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240705084047.857176-32-alex.bennee@linaro.org>


  Commit: 60f4ce8e2cb9afebc7f3e40062087b91b7243c36
      
https://github.com/qemu/qemu/commit/60f4ce8e2cb9afebc7f3e40062087b91b7243c36
  Author: Gustavo Romero <gustavo.romero@linaro.org>
  Date:   2024-07-05 (Fri, 05 Jul 2024)

  Changed paths:
    M gdbstub/gdbstub.c
    M include/gdbstub/commands.h

  Log Message:
  -----------
  gdbstub: Add support for target-specific stubs

Currently, it's not possible to have stubs specific to a given target,
even though there are GDB features which are target-specific, like, for
instance, memory tagging.

This commit introduces gdb_extend_qsupported_features,
gdb_extend_query_table, and gdb_extend_set_table functions as interfaces
to extend the qSupported string, the query handler table, and the set
handler table, allowing target-specific stub implementations.

Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240628050850.536447-4-gustavo.romero@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240705084047.857176-33-alex.bennee@linaro.org>


  Commit: 41bfb6704eed12015ddead4e507b97b39b1ff5f6
      
https://github.com/qemu/qemu/commit/41bfb6704eed12015ddead4e507b97b39b1ff5f6
  Author: Gustavo Romero <gustavo.romero@linaro.org>
  Date:   2024-07-05 (Fri, 05 Jul 2024)

  Changed paths:
    M target/arm/tcg/mte_helper.c

  Log Message:
  -----------
  target/arm: Fix exception case in allocation_tag_mem_probe

If page in 'ptr_access' is inaccessible and probe is 'true'
allocation_tag_mem_probe should not throw an exception, but currently it
does, so fix it.

Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20240628050850.536447-5-gustavo.romero@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240705084047.857176-34-alex.bennee@linaro.org>


  Commit: 0c9b437c90b127bb99fc2e0d3cd41136b2148078
      
https://github.com/qemu/qemu/commit/0c9b437c90b127bb99fc2e0d3cd41136b2148078
  Author: Gustavo Romero <gustavo.romero@linaro.org>
  Date:   2024-07-05 (Fri, 05 Jul 2024)

  Changed paths:
    M target/arm/tcg/mte_helper.c
    A target/arm/tcg/mte_helper.h

  Log Message:
  -----------
  target/arm: Make some MTE helpers widely available

Make the MTE helpers allocation_tag_mem_probe, load_tag1, and store_tag1
available to other subsystems.

Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20240628050850.536447-6-gustavo.romero@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240705084047.857176-35-alex.bennee@linaro.org>


  Commit: bef6a77f6da8bdba7dca36aec4976b434d0d8f1c
      
https://github.com/qemu/qemu/commit/bef6a77f6da8bdba7dca36aec4976b434d0d8f1c
  Author: Gustavo Romero <gustavo.romero@linaro.org>
  Date:   2024-07-05 (Fri, 05 Jul 2024)

  Changed paths:
    M linux-user/aarch64/meson.build
    A linux-user/aarch64/mte_user_helper.c
    A linux-user/aarch64/mte_user_helper.h
    M linux-user/aarch64/target_prctl.h
    M linux-user/syscall.c

  Log Message:
  -----------
  target/arm: Factor out code for setting MTE TCF0 field

Factor out the code used for setting the MTE TCF0 field from the prctl
code into a convenient function. Other subsystems, like gdbstub, need to
set this field as well, so keep it as a separate function to avoid
duplication and ensure consistency in how this field is set across the
board.

Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
Message-Id: <20240628050850.536447-7-gustavo.romero@linaro.org>
[AJB: clean-up includes, move MTE defines]
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240705084047.857176-36-alex.bennee@linaro.org>


  Commit: 3ce0fc57a0e7d528ce0435c93205f9f6558c38ff
      
https://github.com/qemu/qemu/commit/3ce0fc57a0e7d528ce0435c93205f9f6558c38ff
  Author: Gustavo Romero <gustavo.romero@linaro.org>
  Date:   2024-07-05 (Fri, 05 Jul 2024)

  Changed paths:
    M gdbstub/internals.h
    M include/gdbstub/commands.h

  Log Message:
  -----------
  gdbstub: Make hex conversion function non-internal

Make gdb_hextomem non-internal so it's not confined to use only in
gdbstub.c.

Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20240628050850.536447-8-gustavo.romero@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240705084047.857176-37-alex.bennee@linaro.org>


  Commit: 2be4d5db1e50f5aabdeea6d1e63ef75cccd0bbdb
      
https://github.com/qemu/qemu/commit/2be4d5db1e50f5aabdeea6d1e63ef75cccd0bbdb
  Author: Gustavo Romero <gustavo.romero@linaro.org>
  Date:   2024-07-05 (Fri, 05 Jul 2024)

  Changed paths:
    M gdbstub/gdbstub.c
    M include/gdbstub/commands.h

  Log Message:
  -----------
  gdbstub: Pass CPU context to command handler

Allow passing the current CPU context to command handlers via user_ctx
when the handler requires it.

Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
Message-Id: <20240628050850.536447-9-gustavo.romero@linaro.org>
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240705084047.857176-38-alex.bennee@linaro.org>


  Commit: 3b6c27d8f23bfc298cae3a7e404421107705b211
      
https://github.com/qemu/qemu/commit/3b6c27d8f23bfc298cae3a7e404421107705b211
  Author: Gustavo Romero <gustavo.romero@linaro.org>
  Date:   2024-07-05 (Fri, 05 Jul 2024)

  Changed paths:
    M gdbstub/gdbstub.c

  Log Message:
  -----------
  gdbstub: Use true to set cmd_startswith

cmd_startswith is a boolean so use 'true' to set it instead of 1.

Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
Message-Id: <20240628050850.536447-10-gustavo.romero@linaro.org>
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240705084047.857176-39-alex.bennee@linaro.org>


  Commit: f81198cefad223afc8e1ae60e9830b60e5f2d6ff
      
https://github.com/qemu/qemu/commit/f81198cefad223afc8e1ae60e9830b60e5f2d6ff
  Author: Gustavo Romero <gustavo.romero@linaro.org>
  Date:   2024-07-05 (Fri, 05 Jul 2024)

  Changed paths:
    M configs/targets/aarch64-linux-user.mak
    A gdb-xml/aarch64-mte.xml
    M target/arm/cpu.c
    M target/arm/gdbstub.c
    M target/arm/gdbstub64.c
    M target/arm/internals.h

  Log Message:
  -----------
  gdbstub: Add support for MTE in user mode

This commit implements the stubs to handle the qIsAddressTagged,
qMemTag, and QMemTag GDB packets, allowing all GDB 'memory-tag'
subcommands to work with QEMU gdbstub on aarch64 user mode. It also
implements the get/set functions for the special GDB MTE register
'tag_ctl', used to control the MTE fault type at runtime.

Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
Message-Id: <20240628050850.536447-11-gustavo.romero@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240705084047.857176-40-alex.bennee@linaro.org>


  Commit: 340ca46b681b1e9cac1643a7fd964947aeb68a56
      
https://github.com/qemu/qemu/commit/340ca46b681b1e9cac1643a7fd964947aeb68a56
  Author: Gustavo Romero <gustavo.romero@linaro.org>
  Date:   2024-07-05 (Fri, 05 Jul 2024)

  Changed paths:
    M configure
    M tests/tcg/aarch64/Makefile.target
    A tests/tcg/aarch64/gdbstub/test-mte.py
    A tests/tcg/aarch64/mte-8.c

  Log Message:
  -----------
  tests/tcg/aarch64: Add MTE gdbstub tests

Add tests to exercise the MTE stubs. The tests will only run if a
version of GDB that supports MTE is available in the test environment.

Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
[AJB: re-base and checkpatch fixes]
Message-Id: <20240628050850.536447-12-gustavo.romero@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240705084047.857176-41-alex.bennee@linaro.org>


  Commit: f2cb4026fccfe073f84a4b440e41d3ed0c3134f6
      
https://github.com/qemu/qemu/commit/f2cb4026fccfe073f84a4b440e41d3ed0c3134f6
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2024-07-05 (Fri, 05 Jul 2024)

  Changed paths:
    M .gitlab-ci.d/buildtest.yml
    M .gitlab-ci.d/crossbuilds.yml
    M configs/targets/aarch64-linux-user.mak
    M configure
    M contrib/plugins/lockstep.c
    A gdb-xml/aarch64-mte.xml
    M gdbstub/gdbstub.c
    M gdbstub/internals.h
    M gdbstub/syscalls.c
    M gdbstub/system.c
    M gdbstub/user-target.c
    M gdbstub/user.c
    M hw/core/cpu-common.c
    M hw/core/loader-fit.c
    A include/gdbstub/commands.h
    M include/qemu/plugin.h
    M linux-user/aarch64/meson.build
    A linux-user/aarch64/mte_user_helper.c
    A linux-user/aarch64/mte_user_helper.h
    M linux-user/aarch64/target_prctl.h
    M linux-user/main.c
    M linux-user/syscall.c
    M plugins/core.c
    M system/physmem.c
    M system/trace-events
    M target/arm/cpu.c
    M target/arm/gdbstub.c
    M target/arm/gdbstub64.c
    M target/arm/internals.h
    M target/arm/tcg/mte_helper.c
    A target/arm/tcg/mte_helper.h
    M tests/docker/Makefile.include
    M tests/docker/dockerfiles/debian-i686-cross.docker
    M tests/lcitool/refresh
    M tests/plugin/insn.c
    M tests/tcg/Makefile.target
    M tests/tcg/aarch64/Makefile.softmmu-target
    M tests/tcg/aarch64/Makefile.target
    M tests/tcg/aarch64/bti-1.c
    M tests/tcg/aarch64/bti-3.c
    M tests/tcg/aarch64/fcvt.ref
    A tests/tcg/aarch64/gdbstub/test-mte.py
    M tests/tcg/aarch64/mte-1.c
    A tests/tcg/aarch64/mte-8.c
    M tests/tcg/arm/Makefile.softmmu-target
    M tests/tcg/arm/Makefile.target
    M tests/tcg/arm/fcvt.c
    M tests/tcg/arm/fcvt.ref
    M tests/tcg/minilib/printf.c
    M trace-events

  Log Message:
  -----------
  Merge tag 'pull-maintainer-july24-050724-1' of 
https://gitlab.com/stsquad/qemu into staging

Updates for testing, plugins, gdbstub

  - restore some 32 bit host builds and testing
  - move some physmem tracepoint definitions
  - use --userns keep-id for podman builds
  - cleanup check-tcg compiler flag checking for Arm
  - fix some casting in fcvt test
  - tweak check-tcg inline asm for clang
  - suppress some invalid clang warnings
  - disable KVM for the TCI builds
  - improve the insn tracking plugin
  - cleanups to the lockstep plugin
  - free plugin data on cpu finalise
  - assert cpu->index assigned
  - move qemu_plugin_vcpu_init__async into plugin code
  - add support for dynamic gdb command tables
  - allow targets to extend gdb capabilities
  - enable user-mode MTE support

# -----BEGIN PGP SIGNATURE-----
#
# iQEzBAABCgAdFiEEZoWumedRZ7yvyN81+9DbCVqeKkQFAmaH3bEACgkQ+9DbCVqe
# KkTnvwf9HS68sTICEJqBfY663hjcfdFGsSV/h3q7SN3fhKm/3JHGNK+kumgqdnaC
# ykd7tx0AtBGgKm83B7G6MPywsVMIosMeV3mFeJTVHhKsFwGNjSiGkr3j4R2qxjFt
# nYQ977FqBKyhvhSplR2wwhwi+JpuGWFGlnQTvdF2Z7ni4YCDFcbl4eiMyGwsjbWm
# 0VBP+wCSSMIIbS9Qb7DrhZlfu0+wKZK/q0FLzVVofcLSXGou+Mse/qhtG+yAU/FI
# qqqV+7J4PU9E4BqFaklxyRtBrpXNDgpo77pu6ZR7oDXD7HNMuIAuEIlkxMJjarNM
# xN64WOOzw15R2RMVyXdYx6ccxWft2Q==
# =9Gmk
# -----END PGP SIGNATURE-----
# gpg: Signature made Fri 05 Jul 2024 04:49:05 AM PDT
# gpg:                using RSA key 6685AE99E75167BCAFC8DF35FBD0DB095A9E2A44
# gpg: Good signature from "Alex Bennée (Master Work Key) 
<alex.bennee@linaro.org>" [full]

* tag 'pull-maintainer-july24-050724-1' of https://gitlab.com/stsquad/qemu: (40 
commits)
  tests/tcg/aarch64: Add MTE gdbstub tests
  gdbstub: Add support for MTE in user mode
  gdbstub: Use true to set cmd_startswith
  gdbstub: Pass CPU context to command handler
  gdbstub: Make hex conversion function non-internal
  target/arm: Factor out code for setting MTE TCF0 field
  target/arm: Make some MTE helpers widely available
  target/arm: Fix exception case in allocation_tag_mem_probe
  gdbstub: Add support for target-specific stubs
  gdbstub: Move GdbCmdParseEntry into a new header file
  gdbstub: Clean up process_string_cmd
  accel/tcg: Move qemu_plugin_vcpu_init__async() to plugins/
  plugins: Free CPUPluginState before destroying vCPU state
  plugins: Ensure vCPU index is assigned in init/exit hooks
  plugins/lockstep: clean-up output
  plugins/lockstep: mention the one-insn-per-tb option
  plugins/lockstep: make mixed-mode safe
  plugins/lockstep: preserve sock_path
  test/plugins: preserve the instruction record over translations
  test/plugin: make insn plugin less noisy by default
  ...

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


Compare: https://github.com/qemu/qemu/compare/5915139aba16...f2cb4026fccf

To unsubscribe from these emails, change your notification settings at 
https://github.com/qemu/qemu/settings/notifications



reply via email to

[Prev in Thread] Current Thread [Next in Thread]