qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] c1991c: hw/intc/s390_flic: Fix interrupt cont


From: Richard Henderson
Subject: [Qemu-commits] [qemu/qemu] c1991c: hw/intc/s390_flic: Fix interrupt controller migrat...
Date: Tue, 02 Jul 2024 21:46:44 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: c1991c0984243850faa267735db6f624f2aea06a
      
https://github.com/qemu/qemu/commit/c1991c0984243850faa267735db6f624f2aea06a
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2024-07-02 (Tue, 02 Jul 2024)

  Changed paths:
    M hw/intc/s390_flic.c
    M hw/s390x/s390-virtio-ccw.c
    M include/hw/s390x/s390_flic.h

  Log Message:
  -----------
  hw/intc/s390_flic: Fix interrupt controller migration on s390x with TCG

Migration of a s390x guest with TCG was long known to be very unstable,
so the tests in tests/qtest/migration-test.c are disabled if running
with TCG instead of KVM.

Nicholas Piggin did a great analysis of the problem:

"The flic pending state is not migrated, so if the machine is migrated
 while an interrupt is pending, it can be lost. This shows up in
 qtest migration test, an extint is pending (due to console writes?)
 and the CPU waits via s390_cpu_set_psw and expects the interrupt to
 wake it. However when the flic pending state is lost, s390_cpu_has_int
 returns false, so s390_cpu_exec_interrupt falls through to halting
 again."

Thus let's finally migrate the pending state, and to be on the safe
side, also the other state variables of the QEMUS390FLICState structure.

Message-ID: <20240619144421.261342-1-thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: ada9311de31720c1b347e42582c0540914f2ffa6
      
https://github.com/qemu/qemu/commit/ada9311de31720c1b347e42582c0540914f2ffa6
  Author: Nicholas Piggin <npiggin@gmail.com>
  Date:   2024-07-02 (Tue, 02 Jul 2024)

  Changed paths:
    M tests/qtest/migration-test.c

  Log Message:
  -----------
  tests/qtest/migration-test: enable on s390x with TCG

s390x with TCG is more stable now. Enable it.

Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
Message-Id: <20240525131241.378473-3-npiggin@gmail.com>
Reviewed-by: Prasad Pandit <pjp@fedoraproject.org>
[thuth: Added "with TCG" to the commit message]
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: eefd26b8766d1db527946070510970af07ca033f
      
https://github.com/qemu/qemu/commit/eefd26b8766d1db527946070510970af07ca033f
  Author: Akihiko Odaki <akihiko.odaki@daynix.com>
  Date:   2024-07-02 (Tue, 02 Jul 2024)

  Changed paths:
    M tests/qtest/device-introspect-test.c

  Log Message:
  -----------
  tests/qtest: Use qtest_add_data_func_full()

A test function may not be executed depending on the test command line
so it is wrong to free data with a test function. Use
qtest_add_data_func_full() to register a function to free data.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Message-ID: <20240627-san-v2-10-750bb0946dbd@daynix.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: f48b7a4b69b55ed0c9e74013822ee3b16d8d7055
      
https://github.com/qemu/qemu/commit/f48b7a4b69b55ed0c9e74013822ee3b16d8d7055
  Author: Akihiko Odaki <akihiko.odaki@daynix.com>
  Date:   2024-07-02 (Tue, 02 Jul 2024)

  Changed paths:
    M tests/qtest/libqtest.c

  Log Message:
  -----------
  tests/qtest: Free unused QMP response

This fixes LeakSanitizer warnings.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Message-ID: <20240627-san-v2-11-750bb0946dbd@daynix.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 0d626d12eb3e550a1ac0dd2e505042ed1fb4d50b
      
https://github.com/qemu/qemu/commit/0d626d12eb3e550a1ac0dd2e505042ed1fb4d50b
  Author: Akihiko Odaki <akihiko.odaki@daynix.com>
  Date:   2024-07-02 (Tue, 02 Jul 2024)

  Changed paths:
    M tests/qtest/libqtest.c

  Log Message:
  -----------
  tests/qtest: Free old machine variable name

This fixes LeakSanitizer warnings.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Message-ID: <20240627-san-v2-12-750bb0946dbd@daynix.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: dcc3e1218d463484e703a87cd754f4930402d30d
      
https://github.com/qemu/qemu/commit/dcc3e1218d463484e703a87cd754f4930402d30d
  Author: Akihiko Odaki <akihiko.odaki@daynix.com>
  Date:   2024-07-02 (Tue, 02 Jul 2024)

  Changed paths:
    M tests/qtest/qos-test.c

  Log Message:
  -----------
  tests/qtest: Free paths

This fixes LeakSanitizer warnings.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Message-ID: <20240627-san-v2-14-750bb0946dbd@daynix.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 4ab2546265c2133395c163bbdf2bea2ea30e3989
      
https://github.com/qemu/qemu/commit/4ab2546265c2133395c163bbdf2bea2ea30e3989
  Author: Akihiko Odaki <akihiko.odaki@daynix.com>
  Date:   2024-07-02 (Tue, 02 Jul 2024)

  Changed paths:
    M tests/qtest/vhost-user-test.c

  Log Message:
  -----------
  tests/qtest: Free GThread

These GThreads are never referenced.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Message-ID: <20240627-san-v2-15-750bb0946dbd@daynix.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 5f79abcf74d32d7b9cef3481df2c354fc0cad540
      
https://github.com/qemu/qemu/commit/5f79abcf74d32d7b9cef3481df2c354fc0cad540
  Author: Alexandre Iooss <erdnaxe@crans.org>
  Date:   2024-07-02 (Tue, 02 Jul 2024)

  Changed paths:
    M docs/devel/tcg-plugins.rst

  Log Message:
  -----------
  docs: add precision about capstone for execlog plugin

Some people are wondering why they get an empty string as disassembly.
Most of the time, they configured QEMU without Capstone support.
Let's document this behaviour to help users.

Signed-off-by: Alexandre Iooss <erdnaxe@crans.org>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Message-ID: <20240620135731.977377-1-erdnaxe@crans.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 999c870e9ebc9a0b742d58b884a3bab756ffd777
      
https://github.com/qemu/qemu/commit/999c870e9ebc9a0b742d58b884a3bab756ffd777
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2024-07-02 (Tue, 02 Jul 2024)

  Changed paths:
    M hw/s390x/s390-virtio-ccw.c

  Log Message:
  -----------
  hw/s390x: Attach default virtio-net devices to the /machine/virtual-css-bridge

The initial virtio-net-ccw devices currently do not have a proper parent
in the QOM tree, so they show up under /machine/unattached - which is
somewhat ugly. Let's attach them to /machine/virtual-css-bridge/virtual-css
instead.

Message-ID: <20240701200108.154271-1-thuth@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 99a28bd50fff03ef0bc2570ed3082c1e7e1be0bf
      
https://github.com/qemu/qemu/commit/99a28bd50fff03ef0bc2570ed3082c1e7e1be0bf
  Author: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
  Date:   2024-07-02 (Tue, 02 Jul 2024)

  Changed paths:
    A tests/avocado/hotplug_blk.py

  Log Message:
  -----------
  tests/avocado: add hotplug_blk test

Introduce a test, that checks that plug/unplug of virtio-blk device
works.

(the test is developed by copying hotplug_cpu.py, so keep original
copyright)

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20240409065854.366856-1-vsementsov@yandex-team.ru>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 5e8881c2d27db8a1e3924d604f0507b1186fb3a8
      
https://github.com/qemu/qemu/commit/5e8881c2d27db8a1e3924d604f0507b1186fb3a8
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2024-07-02 (Tue, 02 Jul 2024)

  Changed paths:
    M .travis.yml

  Log Message:
  -----------
  .travis.yml: Install python3-tomli in all build jobs

Since commit 1f97715c83 ('Revert "python: use vendored tomli"')
this package is a hard requirement for compiling QEMU, so install
it now in all Travis jobs, too.

Message-ID: <20240624094807.182313-1-thuth@redhat.com>
Acked-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: e3e2708fee10e6df413c36a71b100c59710e727e
      
https://github.com/qemu/qemu/commit/e3e2708fee10e6df413c36a71b100c59710e727e
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2024-07-02 (Tue, 02 Jul 2024)

  Changed paths:
    M pc-bios/s390-ccw/Makefile

  Log Message:
  -----------
  pc-bios/s390-ccw: Remove duplicated LDFLAGS

The -Wl,-pie and -nostdlib flags are added to LDFLAGS twice. Merge
the two lines to get rid of the duplicates.

Message-ID: <20240621082422.136217-2-thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 1a2d52c7fcaeaaf4f2fe8d4d5183dccaeab67768
      
https://github.com/qemu/qemu/commit/1a2d52c7fcaeaaf4f2fe8d4d5183dccaeab67768
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2024-07-02 (Tue, 02 Jul 2024)

  Changed paths:
    M .travis.yml
    M docs/devel/tcg-plugins.rst
    M hw/intc/s390_flic.c
    M hw/s390x/s390-virtio-ccw.c
    M include/hw/s390x/s390_flic.h
    M pc-bios/s390-ccw/Makefile
    A tests/avocado/hotplug_blk.py
    M tests/qtest/device-introspect-test.c
    M tests/qtest/libqtest.c
    M tests/qtest/migration-test.c
    M tests/qtest/qos-test.c
    M tests/qtest/vhost-user-test.c

  Log Message:
  -----------
  Merge tag 'pull-request-2024-07-02' of https://gitlab.com/thuth/qemu into 
staging

* Fix interrupt controller migration on s390x with TCG and enable qtest
* Fix memory leaks in qtests
* Use a proper qom-tree parent for s390x virtio-net devices
* Add hotplug avocado test for virtio-blk
* Fix Travis jobs (need python3-tomli now)

# -----BEGIN PGP SIGNATURE-----
#
# iQJFBAABCAAvFiEEJ7iIR+7gJQEY8+q5LtnXdP5wLbUFAmaD1qsRHHRodXRoQHJl
# ZGhhdC5jb20ACgkQLtnXdP5wLbWOtg//a+6nRcV8crCGzMaxhH32NxcjvV7TPiAI
# FioqOsomKfKKTMIDlbjsgQiQWqGrN/mdnxSzasypxZrC3eoDYJCIUyQfR2iGe4t2
# JJ4gQhQGuXkSstGErj8yw83UnG1drG+XuZ/psSij4/R2ft6Me8miFSh3cCgIm541
# 0DtffV6rAXIEqA+bswKsPq+7bq6ZCxZjaWgKhzfP5RNnpjPvHYMDDPZt9a2Fk9xC
# d3TILh/0djuVr8nZNUkQJBT5EU6dxVDb1JMqn4G6e6kWtiDBh/XwvMtC0KHVCJH1
# tHDz7n+FpwBfpo1cz0Y/Bn9pTW4K9KZ+GVlLOihfbh7Eaix0+RPzLKCigLVg1v8I
# HaNFr70FxF5Xzmvie36arEKf0CwQCinxvfM9USBD0uP3tOzSZwX2XxM0+FBIjUf3
# fYIY8qV1hQZM5tXFxtU5LW4A64pVGwEHlEIcodxo8mY/DnZUdIvB5L5C4rxATnVr
# t2eWc23sGdMZgKxUtlG0PIr80ImkYBWFOLztUmDPOff6igiyw2ZxaLQHyERPEc0O
# 1CL4K4K5FKNtJgjSwJyU1NquGKk85vUSjiUW1JOvInUFjRECIQ7+R41p6FU+eTHO
# l50cKaf2TCWqDOwMOjFYOHj6TWZGXnTmkSN60g0OLioy3UY+Kghd2Zq+aTK5ptyh
# 1BhcvTin9Zg=
# =lLG3
# -----END PGP SIGNATURE-----
# gpg: Signature made Tue 02 Jul 2024 03:30:03 AM PDT
# gpg:                using RSA key 27B88847EEE0250118F3EAB92ED9D774FE702DB5
# gpg:                issuer "thuth@redhat.com"
# gpg: Good signature from "Thomas Huth <th.huth@gmx.de>" [full]
# gpg:                 aka "Thomas Huth <thuth@redhat.com>" [full]
# gpg:                 aka "Thomas Huth <th.huth@posteo.de>" [unknown]
# gpg:                 aka "Thomas Huth <huth@tuxfamily.org>" [full]

* tag 'pull-request-2024-07-02' of https://gitlab.com/thuth/qemu:
  pc-bios/s390-ccw: Remove duplicated LDFLAGS
  .travis.yml: Install python3-tomli in all build jobs
  tests/avocado: add hotplug_blk test
  hw/s390x: Attach default virtio-net devices to the /machine/virtual-css-bridge
  docs: add precision about capstone for execlog plugin
  tests/qtest: Free GThread
  tests/qtest: Free paths
  tests/qtest: Free old machine variable name
  tests/qtest: Free unused QMP response
  tests/qtest: Use qtest_add_data_func_full()
  tests/qtest/migration-test: enable on s390x with TCG
  hw/intc/s390_flic: Fix interrupt controller migration on s390x with TCG

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


Compare: https://github.com/qemu/qemu/compare/6746482d12da...1a2d52c7fcae

To unsubscribe from these emails, change your notification settings at 
https://github.com/qemu/qemu/settings/notifications



reply via email to

[Prev in Thread] Current Thread [Next in Thread]