[Qemu-commits] [qemu/qemu] 588c5b: input/adb: Only include header where

qemu-commits

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 588c5b: input/adb: Only include header where

From:	Peter Maydell
Subject:	[Qemu-commits] [qemu/qemu] 588c5b: input/adb: Only include header where needed
Date:	Tue, 07 Feb 2023 07:16:43 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 588c5b0b9fe7c27c61cd4bd57b21ebc0fd06b45f
      
https://github.com/qemu/qemu/commit/588c5b0b9fe7c27c61cd4bd57b21ebc0fd06b45f
  Author: BALATON Zoltan <balaton@eik.bme.hu>
  Date:   2023-02-06 (Mon, 06 Feb 2023)

  Changed paths:
    M hw/misc/macio/cuda.c
    M hw/misc/macio/pmu.c
    M hw/misc/mos6522.c
    M include/hw/misc/mac_via.h
    M include/hw/misc/macio/cuda.h
    M include/hw/misc/macio/pmu.h
    M include/hw/misc/mos6522.h

  Log Message:
  -----------
  input/adb: Only include header where needed

The header hw/input/adb.h is included by some files that don't need
it. Clean it up and include only where necessary.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Message-Id: 
<f46bc751e8426f9d937c9540f2e67d2f0b2cc582.1672868854.git.balaton@eik.bme.hu>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>


  Commit: 4db4847d83f11a33f08b75836d1116a1188121ca
      
https://github.com/qemu/qemu/commit/4db4847d83f11a33f08b75836d1116a1188121ca
  Author: BALATON Zoltan <balaton@eik.bme.hu>
  Date:   2023-02-06 (Mon, 06 Feb 2023)

  Changed paths:
    M hw/ppc/mac_newworld.c
    M hw/ppc/mac_oldworld.c

  Log Message:
  -----------
  mac_{old,new}world: Use local variable instead of qdev_get_machine()

We already have machine in a local variable so no need to use
qdev_get_machine(), also remove now unneeded line break.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Message-Id: 
<719299533b89aa4516966065eae05c75744f50d3.1672868854.git.balaton@eik.bme.hu>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Bernhard Beschow <shentey@gmail.com>
Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>


  Commit: ea361fc348a43f5e751351191d8fc09fadd310bf
      
https://github.com/qemu/qemu/commit/ea361fc348a43f5e751351191d8fc09fadd310bf
  Author: BALATON Zoltan <balaton@eik.bme.hu>
  Date:   2023-02-06 (Mon, 06 Feb 2023)

  Changed paths:
    M hw/misc/macio/macio.c

  Log Message:
  -----------
  hw/misc/macio: Avoid some QOM casts

At several places we already have the object pointer with the right
type so we don't need to cast it back and forth. Avoiding these casts
improves readability.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Message-Id: 
<67b2d4700879c3b4cd574f1faa1a0d1950b3d0ee.1674001242.git.balaton@eik.bme.hu>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>


  Commit: 740ce28c464110d67e05cb1f99ade58329f74add
      
https://github.com/qemu/qemu/commit/740ce28c464110d67e05cb1f99ade58329f74add
  Author: BALATON Zoltan <balaton@eik.bme.hu>
  Date:   2023-02-06 (Mon, 06 Feb 2023)

  Changed paths:
    M hw/misc/macio/macio.c

  Log Message:
  -----------
  hw/misc/macio: Rename sysbus_dev to sbd for consistency and brevity

Some functions use sysbus_dev while others sbd name for local variable
storing a sysbus device pointer. Standardise on the shorter name to be
consistent and make the code easier to read as short name is less
distracting and needs less line breaks.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Message-Id: 
<6c79d6903fc11e153f8050a374904c2b5d5db585.1674001242.git.balaton@eik.bme.hu>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>


  Commit: af36fca459e8f3c8fadf887048a9d1bce1101f4e
      
https://github.com/qemu/qemu/commit/af36fca459e8f3c8fadf887048a9d1bce1101f4e
  Author: BALATON Zoltan <balaton@eik.bme.hu>
  Date:   2023-02-06 (Mon, 06 Feb 2023)

  Changed paths:
    M hw/misc/macio/macio.c

  Log Message:
  -----------
  hw/misc/macio: Remove some single use local variables

Drop some local variables that could just be substituted at the single
place they were used. This makes the code shorter and simpler.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Message-Id: 
<165a4ea190af7c09832f50f02004fad82f704898.1674001242.git.balaton@eik.bme.hu>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>


  Commit: 1d0c537985abf5c497498f985b746ebe3e0cca54
      
https://github.com/qemu/qemu/commit/1d0c537985abf5c497498f985b746ebe3e0cca54
  Author: BALATON Zoltan <balaton@eik.bme.hu>
  Date:   2023-02-06 (Mon, 06 Feb 2023)

  Changed paths:
    M hw/misc/macio/macio.c

  Log Message:
  -----------
  hw/misc/macio: Return bool from functions taking errp

Use the convention to return bool from functions which take an error
pointer which allows for callers to pass through their error pointer
without needing a local.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Message-Id: 
<bfce0751e82b031f5e6fb3c32cfbce6325434400.1674001242.git.balaton@eik.bme.hu>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>


  Commit: 1f7888e2250adf3f4cffc24f7be29f062e095480
      
https://github.com/qemu/qemu/commit/1f7888e2250adf3f4cffc24f7be29f062e095480
  Author: BALATON Zoltan <balaton@eik.bme.hu>
  Date:   2023-02-06 (Mon, 06 Feb 2023)

  Changed paths:
    M hw/nvram/mac_nvram.c
    M include/hw/nvram/mac_nvram.h

  Log Message:
  -----------
  mac_nvram: Add block backend to persist NVRAM contents

Add a way to set a backing store for the mac_nvram similar to what
spapr_nvram or mac_via PRAM already does to allow to save its contents
between runs.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: 
<4b1605a9e484cc95f6e141f297487a070fd418ac.1675297286.git.balaton@eik.bme.hu>
Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>


  Commit: 5df3eb4d361fd609632281969b101f4f84f1c4d8
      
https://github.com/qemu/qemu/commit/5df3eb4d361fd609632281969b101f4f84f1c4d8
  Author: BALATON Zoltan <balaton@eik.bme.hu>
  Date:   2023-02-06 (Mon, 06 Feb 2023)

  Changed paths:
    M hw/ppc/mac_oldworld.c

  Log Message:
  -----------
  mac_oldworld: Allow specifying nvram backing store

Add a way to set a backing store for the mac_nvram. Use -drive
file=nvram.img,format=raw,if=mtd to specify backing file where
nvram.img must be MACIO_NVRAM_SIZE which is 8192 bytes.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: 
<1aadee8f0ca0f56cf1b7c45c3944676a07d91de9.1675297286.git.balaton@eik.bme.hu>
Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>


  Commit: 285ee77f5b58237c972bbe82aa0e1dc489c147d6
      
https://github.com/qemu/qemu/commit/285ee77f5b58237c972bbe82aa0e1dc489c147d6
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2023-02-07 (Tue, 07 Feb 2023)

  Changed paths:
    M hw/misc/macio/cuda.c
    M hw/misc/macio/macio.c
    M hw/misc/macio/pmu.c
    M hw/misc/mos6522.c
    M hw/nvram/mac_nvram.c
    M hw/ppc/mac_newworld.c
    M hw/ppc/mac_oldworld.c
    M include/hw/misc/mac_via.h
    M include/hw/misc/macio/cuda.h
    M include/hw/misc/macio/pmu.h
    M include/hw/misc/mos6522.h
    M include/hw/nvram/mac_nvram.h

  Log Message:
  -----------
  Merge tag 'qemu-macppc-20230206' of https://github.com/mcayland/qemu into 
staging

qemu-macppc patches for 8.0

# -----BEGIN PGP SIGNATURE-----
#
# iQFSBAABCgA8FiEEzGIauY6CIA2RXMnEW8LFb64PMh8FAmPheL4eHG1hcmsuY2F2
# ZS1heWxhbmRAaWxhbmRlLmNvLnVrAAoJEFvCxW+uDzIflMUIAKeDljnot7I3cF3y
# XnkPtPOUrzurii348hgQAULbDcnffkwstoML8vVpjt6tK9fZDduWB2bcXm00BFPr
# tFXmW/IZaQ1Z9yEXEpFRUU1L68gGYyXCFEmBjE4fE2WoSRRQObkx7IGgFLBk7L3t
# hyLx1kSBziSxgnkoX8ZQqMTweLjcllWA8s9+EtfpyTOu0mewKtbcAEyUwaJQTPPT
# tfgMxjXdNquK89KXGelDiGHAKzMgCAnX2jVEkrw1PKKgLsf1FrQVDPJkWMhWv82x
# FaCjyzL7YEn+h9Gd1j5JmhqYYKPF8akIs4bfrwcl9blyNRbb/NWF/odYgM1WIy8x
# fQDJcwc=
# =RB4n
# -----END PGP SIGNATURE-----
# gpg: Signature made Mon 06 Feb 2023 22:01:34 GMT
# gpg:                using RSA key CC621AB98E82200D915CC9C45BC2C56FAE0F321F
# gpg:                issuer "mark.cave-ayland@ilande.co.uk"
# gpg: Good signature from "Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>" 
[full]
# Primary key fingerprint: CC62 1AB9 8E82 200D 915C  C9C4 5BC2 C56F AE0F 321F

* tag 'qemu-macppc-20230206' of https://github.com/mcayland/qemu:
  mac_oldworld: Allow specifying nvram backing store
  mac_nvram: Add block backend to persist NVRAM contents
  hw/misc/macio: Return bool from functions taking errp
  hw/misc/macio: Remove some single use local variables
  hw/misc/macio: Rename sysbus_dev to sbd for consistency and brevity
  hw/misc/macio: Avoid some QOM casts
  mac_{old,new}world: Use local variable instead of qdev_get_machine()
  input/adb: Only include header where needed

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/6661b8c7fe3f...285ee77f5b58

[Prev in Thread]

Current Thread

[Next in Thread]

[Qemu-commits] [qemu/qemu] 588c5b: input/adb: Only include header where needed, Peter Maydell, 2023/02/07
- [Qemu-commits] [qemu/qemu] 588c5b: input/adb: Only include header where needed, Peter Maydell <=

Prev by Date: [Qemu-commits] [qemu/qemu] 588c5b: input/adb: Only include header where needed
Next by Date: [Qemu-commits] [qemu/qemu] 301d7f: migration: Fix migration crash when target psize l...
Previous by thread: [Qemu-commits] [qemu/qemu] 588c5b: input/adb: Only include header where needed
Next by thread: [Qemu-commits] [qemu/qemu] 301d7f: migration: Fix migration crash when target psize l...
Index(es):
- Date
- Thread