[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] 3d5583: Drop more useless casts from void * t
|
From: |
Peter Maydell |
|
Subject: |
[Qemu-commits] [qemu/qemu] 3d5583: Drop more useless casts from void * to pointer |
|
Date: |
Thu, 15 Dec 2022 05:05:33 -0800 |
Branch: refs/heads/master
Home: https://github.com/qemu/qemu
Commit: 3d558330adec7233da6c48c5e8584eb176fb77d7
https://github.com/qemu/qemu/commit/3d558330adec7233da6c48c5e8584eb176fb77d7
Author: Markus Armbruster <armbru@redhat.com>
Date: 2022-12-14 (Wed, 14 Dec 2022)
Changed paths:
M bsd-user/elfload.c
M contrib/plugins/cache.c
M contrib/vhost-user-blk/vhost-user-blk.c
M hw/core/qdev-clock.c
M hw/hyperv/vmbus.c
M hw/net/cadence_gem.c
M hw/net/virtio-net.c
M hw/nvme/ctrl.c
M hw/rdma/vmw/pvrdma_cmd.c
M hw/rdma/vmw/pvrdma_qp_ops.c
M hw/virtio/virtio-iommu.c
M linux-user/syscall.c
M target/i386/hax/hax-all.c
M tests/tcg/aarch64/system/semiheap.c
M util/vfio-helpers.c
Log Message:
-----------
Drop more useless casts from void * to pointer
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20221123133811.1398562-1-armbru@redhat.com>
Commit: 6c37ebf3301ca449ebe449138b86e55762503250
https://github.com/qemu/qemu/commit/6c37ebf3301ca449ebe449138b86e55762503250
Author: Markus Armbruster <armbru@redhat.com>
Date: 2022-12-14 (Wed, 14 Dec 2022)
Changed paths:
M hw/arm/virt.c
M hw/hyperv/vmbus.c
M qga/commands-win32.c
Log Message:
-----------
error: Drop some obviously superfluous error_propagate()
When error_propagate(errp, local_err) is the only reader of
@local_err, we can just as well change its writers to write @errp
directly, and drop the error_propagate() along with @local_err.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20221121085054.683122-2-armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Commit: 740d6c4eba8bb44ea00550ccc97a4c49945ecc3c
https://github.com/qemu/qemu/commit/740d6c4eba8bb44ea00550ccc97a4c49945ecc3c
Author: Markus Armbruster <armbru@redhat.com>
Date: 2022-12-14 (Wed, 14 Dec 2022)
Changed paths:
M block/copy-before-write.c
M dump/dump.c
M hw/core/qdev.c
M hw/pci/msi.c
M hw/remote/vfio-user-obj.c
M ui/util.c
Log Message:
-----------
error: Drop a few superfluous ERRP_GUARD()
include/qapi/error.h on ERRP_GUARD():
* It must be used when the function dereferences @errp or passes
* @errp to error_prepend(), error_vprepend(), or error_append_hint().
* It is safe to use even when it's not needed, but please avoid
* cluttering the source with useless code.
Clean up some of this clutter.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20221121085054.683122-3-armbru@redhat.com>
Commit: 05e385d2a96325c1f26b874f1b832237229b8c1f
https://github.com/qemu/qemu/commit/05e385d2a96325c1f26b874f1b832237229b8c1f
Author: Markus Armbruster <armbru@redhat.com>
Date: 2022-12-14 (Wed, 14 Dec 2022)
Changed paths:
M hw/arm/armsse.c
M hw/core/machine.c
M hw/virtio/vhost-vdpa.c
M iothread.c
M monitor/qmp-cmds.c
Log Message:
-----------
error: Move ERRP_GUARD() to the beginning of the function
include/qapi/error.h advises to put ERRP_GUARD() right at the
beginning of the function, because only then can it guard the whole
function. Clean up the few spots disregarding the advice.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20221121085054.683122-4-armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Commit: 457552fc7d7ff2042e23884ab189ccc216778963
https://github.com/qemu/qemu/commit/457552fc7d7ff2042e23884ab189ccc216778963
Author: Markus Armbruster <armbru@redhat.com>
Date: 2022-12-14 (Wed, 14 Dec 2022)
Changed paths:
M monitor/misc.c
Log Message:
-----------
monitor: Simplify monitor_fd_param()'s error handling
Cc: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20221121085054.683122-5-armbru@redhat.com>
Commit: 50707b391ecb35dfdd8c92615bca92b601dc3cf1
https://github.com/qemu/qemu/commit/50707b391ecb35dfdd8c92615bca92b601dc3cf1
Author: Markus Armbruster <armbru@redhat.com>
Date: 2022-12-14 (Wed, 14 Dec 2022)
Changed paths:
M monitor/monitor.c
Log Message:
-----------
monitor: Use ERRP_GUARD() in monitor_init()
Cc: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20221121085054.683122-6-armbru@redhat.com>
Commit: f766e6dc6acfcfc7e2885518954b1e88111b5527
https://github.com/qemu/qemu/commit/f766e6dc6acfcfc7e2885518954b1e88111b5527
Author: Markus Armbruster <armbru@redhat.com>
Date: 2022-12-14 (Wed, 14 Dec 2022)
Changed paths:
M block/blkdebug.c
M include/qemu/config-file.h
M util/qemu-config.c
Log Message:
-----------
qemu-config: Make config_parse_qdict() return bool
This simplifies error checking.
Cc: Hanna Reitz <hreitz@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20221121085054.683122-7-armbru@redhat.com>
Commit: 0a3090b1d2e3f62578b2f982b11fc5f0185b1de2
https://github.com/qemu/qemu/commit/0a3090b1d2e3f62578b2f982b11fc5f0185b1de2
Author: Markus Armbruster <armbru@redhat.com>
Date: 2022-12-14 (Wed, 14 Dec 2022)
Changed paths:
M util/qemu-config.c
Log Message:
-----------
qemu-config: Use ERRP_GUARD() where obviously appropriate
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20221121085054.683122-8-armbru@redhat.com>
Commit: f560eb1f0a73b786a9c306d453d9e2e846ecb3e7
https://github.com/qemu/qemu/commit/f560eb1f0a73b786a9c306d453d9e2e846ecb3e7
Author: Markus Armbruster <armbru@redhat.com>
Date: 2022-12-14 (Wed, 14 Dec 2022)
Changed paths:
M util/qemu-sockets.c
Log Message:
-----------
sockets: Use ERRP_GUARD() where obviously appropriate
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20221121085054.683122-9-armbru@redhat.com>
Commit: d1c81c34964193bc62167ee60bf70b203e763699
https://github.com/qemu/qemu/commit/d1c81c34964193bc62167ee60bf70b203e763699
Author: Markus Armbruster <armbru@redhat.com>
Date: 2022-12-14 (Wed, 14 Dec 2022)
Changed paths:
M accel/kvm/kvm-all.c
M hw/core/qdev-properties-system.c
M hw/i386/pc.c
M hw/virtio/virtio-balloon.c
M hw/virtio/virtio-mem.c
M net/colo-compare.c
M target/i386/kvm/kvm.c
M util/thread-context.c
Log Message:
-----------
qapi: Use returned bool to check for failure (again)
Commit 012d4c96e2 changed the visitor functions taking Error ** to
return bool instead of void, and the commits following it used the new
return value to simplify error checking. Since then a few more uses
in need of the same treatment crept in. Do that. All pretty
mechanical except for
* balloon_stats_get_all()
This is basically the same transformation commit 012d4c96e2 applied
to the virtual walk example in include/qapi/visitor.h.
* set_max_queue_size()
Additionally replace "goto end of function" by return.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20221121085054.683122-10-armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Commit: 10220d2f96406463fc283a3de6b13fc38f8befff
https://github.com/qemu/qemu/commit/10220d2f96406463fc283a3de6b13fc38f8befff
Author: Markus Armbruster <armbru@redhat.com>
Date: 2022-12-14 (Wed, 14 Dec 2022)
Changed paths:
M include/io/channel.h
Log Message:
-----------
io: Tidy up fat-fingered parameter name
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20221121085054.683122-11-armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Commit: 66997c42e02c84481fc162a5b7bd6ad6c643bae2
https://github.com/qemu/qemu/commit/66997c42e02c84481fc162a5b7bd6ad6c643bae2
Author: Markus Armbruster <armbru@redhat.com>
Date: 2022-12-14 (Wed, 14 Dec 2022)
Changed paths:
M hw/9pfs/9p-synth.c
M hw/char/sifive_uart.c
M hw/ppc/ppc4xx_sdram.c
M hw/rdma/vmw/pvrdma_cmd.c
M hw/virtio/vhost-user.c
M include/hw/pci/pci.h
M migration/dirtyrate.c
M migration/tls.c
M replay/replay-time.c
M scripts/coccinelle/return_directly.cocci
M semihosting/console.c
M softmmu/memory.c
M softmmu/physmem.c
M target/avr/cpu.h
M target/loongarch/cpu.c
M target/mips/tcg/dsp_helper.c
M target/riscv/debug.c
M target/riscv/vector_helper.c
M tests/bench/benchmark-crypto-akcipher.c
M tests/qtest/erst-test.c
M tests/qtest/hexloader-test.c
M tests/qtest/pvpanic-pci-test.c
M tests/qtest/pvpanic-test.c
M tests/qtest/test-filter-mirror.c
M tests/qtest/virtio-ccw-test.c
M tests/tcg/multiarch/sha512.c
M tools/virtiofsd/fuse_lowlevel.c
Log Message:
-----------
cleanup: Tweak and re-run return_directly.cocci
Tweak the semantic patch to drop redundant parenthesis around the
return expression.
Coccinelle drops a comment in hw/rdma/vmw/pvrdma_cmd.c; restored
manually.
Coccinelle messes up vmdk_co_create(), not sure why. Change dropped,
will be done manually in the next commit.
Line breaks in target/avr/cpu.h and hw/rdma/vmw/pvrdma_cmd.c tidied up
manually.
Whitespace in tools/virtiofsd/fuse_lowlevel.c tidied up manually.
checkpatch.pl complains "return of an errno should typically be -ve"
two times for hw/9pfs/9p-synth.c. Preexisting, the patch merely makes
it visible to checkpatch.pl.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20221122134917.1217307-2-armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Acked-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Commit: 851fd4a01dcf579f96f18d41b3e4bf369b64ef3a
https://github.com/qemu/qemu/commit/851fd4a01dcf579f96f18d41b3e4bf369b64ef3a
Author: Markus Armbruster <armbru@redhat.com>
Date: 2022-12-14 (Wed, 14 Dec 2022)
Changed paths:
M block/vmdk.c
Log Message:
-----------
block/vmdk: Simplify vmdk_co_create() to return directly
Cc: Fam Zheng <fam@euphon.net>
Cc: Kevin Wolf <kwolf@redhat.com>
Cc: Hanna Reitz <hreitz@redhat.com>
Cc: qemu-block@nongnu.org
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20221122134917.1217307-3-armbru@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Commit: 6c5aaee4b61eb8bf60c7c30365432710b4346421
https://github.com/qemu/qemu/commit/6c5aaee4b61eb8bf60c7c30365432710b4346421
Author: Markus Armbruster <armbru@redhat.com>
Date: 2022-12-14 (Wed, 14 Dec 2022)
Changed paths:
M hw/ppc/ppc4xx_sdram.c
Log Message:
-----------
ppc4xx_sdram: Simplify sdram_ddr_size() to return
Suggested-by: BALATON Zoltan <balaton@eik.bme.hu>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <87a64i87zp.fsf@pond.sub.org>
Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Commit: 48804eebd4a327e4b11f902ba80a00876ee53a43
https://github.com/qemu/qemu/commit/48804eebd4a327e4b11f902ba80a00876ee53a43
Author: Peter Maydell <peter.maydell@linaro.org>
Date: 2022-12-15 (Thu, 15 Dec 2022)
Changed paths:
M accel/kvm/kvm-all.c
M block/blkdebug.c
M block/copy-before-write.c
M block/vmdk.c
M bsd-user/elfload.c
M contrib/plugins/cache.c
M contrib/vhost-user-blk/vhost-user-blk.c
M dump/dump.c
M hw/9pfs/9p-synth.c
M hw/arm/armsse.c
M hw/arm/virt.c
M hw/char/sifive_uart.c
M hw/core/machine.c
M hw/core/qdev-clock.c
M hw/core/qdev-properties-system.c
M hw/core/qdev.c
M hw/hyperv/vmbus.c
M hw/i386/pc.c
M hw/net/cadence_gem.c
M hw/net/virtio-net.c
M hw/nvme/ctrl.c
M hw/pci/msi.c
M hw/ppc/ppc4xx_sdram.c
M hw/rdma/vmw/pvrdma_cmd.c
M hw/rdma/vmw/pvrdma_qp_ops.c
M hw/remote/vfio-user-obj.c
M hw/virtio/vhost-user.c
M hw/virtio/vhost-vdpa.c
M hw/virtio/virtio-balloon.c
M hw/virtio/virtio-iommu.c
M hw/virtio/virtio-mem.c
M include/hw/pci/pci.h
M include/io/channel.h
M include/qemu/config-file.h
M iothread.c
M linux-user/syscall.c
M migration/dirtyrate.c
M migration/tls.c
M monitor/misc.c
M monitor/monitor.c
M monitor/qmp-cmds.c
M net/colo-compare.c
M qga/commands-win32.c
M replay/replay-time.c
M scripts/coccinelle/return_directly.cocci
M semihosting/console.c
M softmmu/memory.c
M softmmu/physmem.c
M target/avr/cpu.h
M target/i386/hax/hax-all.c
M target/i386/kvm/kvm.c
M target/loongarch/cpu.c
M target/mips/tcg/dsp_helper.c
M target/riscv/debug.c
M target/riscv/vector_helper.c
M tests/bench/benchmark-crypto-akcipher.c
M tests/qtest/erst-test.c
M tests/qtest/hexloader-test.c
M tests/qtest/pvpanic-pci-test.c
M tests/qtest/pvpanic-test.c
M tests/qtest/test-filter-mirror.c
M tests/qtest/virtio-ccw-test.c
M tests/tcg/aarch64/system/semiheap.c
M tests/tcg/multiarch/sha512.c
M tools/virtiofsd/fuse_lowlevel.c
M ui/util.c
M util/qemu-config.c
M util/qemu-sockets.c
M util/thread-context.c
M util/vfio-helpers.c
Log Message:
-----------
Merge tag 'pull-misc-2022-12-14' of https://repo.or.cz/qemu/armbru into
staging
Miscellaneous patches for 2022-12-14
# gpg: Signature made Wed 14 Dec 2022 15:23:02 GMT
# gpg: using RSA key 354BC8B3D7EB2A6B68674E5F3870B400EB918653
# gpg: issuer "armbru@redhat.com"
# gpg: Good signature from "Markus Armbruster <armbru@redhat.com>" [full]
# gpg: aka "Markus Armbruster <armbru@pond.sub.org>" [full]
# Primary key fingerprint: 354B C8B3 D7EB 2A6B 6867 4E5F 3870 B400 EB91 8653
* tag 'pull-misc-2022-12-14' of https://repo.or.cz/qemu/armbru:
ppc4xx_sdram: Simplify sdram_ddr_size() to return
block/vmdk: Simplify vmdk_co_create() to return directly
cleanup: Tweak and re-run return_directly.cocci
io: Tidy up fat-fingered parameter name
qapi: Use returned bool to check for failure (again)
sockets: Use ERRP_GUARD() where obviously appropriate
qemu-config: Use ERRP_GUARD() where obviously appropriate
qemu-config: Make config_parse_qdict() return bool
monitor: Use ERRP_GUARD() in monitor_init()
monitor: Simplify monitor_fd_param()'s error handling
error: Move ERRP_GUARD() to the beginning of the function
error: Drop a few superfluous ERRP_GUARD()
error: Drop some obviously superfluous error_propagate()
Drop more useless casts from void * to pointer
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Compare: https://github.com/qemu/qemu/compare/ae2b87341b5d...48804eebd4a3