[Qemu-commits] [qemu/qemu] 266aae: libvhost-user: Fix wrong type of argument to forma...

[Paolo Bonzini]

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: 266aaedc37d1e18af6c62f7f67c7e29887e32061
      
https://github.com/qemu/qemu/commit/266aaedc37d1e18af6c62f7f67c7e29887e32061
  Author: Stefan Weil via <qemu-devel@nongnu.org>
  Date:   2022-11-27 (Sun, 27 Nov 2022)

  Changed paths:
    M subprojects/libvhost-user/libvhost-user.c

  Log Message:
  -----------
  libvhost-user: Fix wrong type of argument to formatting function (reported by 
LGTM)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Message-Id: <20220422070144.1043697-2-sw@weilnetz.de>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20221126152507.283271-2-sw@weilnetz.de>


  Commit: 8541bf452d8b083beb79cd496b73f2ebd852c369
      
https://github.com/qemu/qemu/commit/8541bf452d8b083beb79cd496b73f2ebd852c369
  Author: Stefan Weil via <qemu-devel@nongnu.org>
  Date:   2022-11-27 (Sun, 27 Nov 2022)

  Changed paths:
    M subprojects/libvhost-user/libvhost-user.c

  Log Message:
  -----------
  libvhost-user: Fix format strings

Signed-off-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20220422070144.1043697-3-sw@weilnetz.de>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20221126152507.283271-3-sw@weilnetz.de>


  Commit: 7d4774e681d2cea5569ee42a8a485647acf3cf7d
      
https://github.com/qemu/qemu/commit/7d4774e681d2cea5569ee42a8a485647acf3cf7d
  Author: Stefan Weil via <qemu-devel@nongnu.org>
  Date:   2022-11-27 (Sun, 27 Nov 2022)

  Changed paths:
    M subprojects/libvhost-user/libvhost-user.c

  Log Message:
  -----------
  libvhost-user: Fix two more format strings

This fix is required for 32 bit hosts. The bug was detected by CI
for arm-linux, but is also relevant for i386-linux.

Reported-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20221126152507.283271-4-sw@weilnetz.de>


  Commit: 52a57d8d1fbaf1942cce94e41521b7b564dd37ee
      
https://github.com/qemu/qemu/commit/52a57d8d1fbaf1942cce94e41521b7b564dd37ee
  Author: Stefan Weil via <qemu-devel@nongnu.org>
  Date:   2022-11-27 (Sun, 27 Nov 2022)

  Changed paths:
    M subprojects/libvhost-user/libvhost-user.c

  Log Message:
  -----------
  libvhost-user: Add format attribute to local function vu_panic

Signed-off-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20220422070144.1043697-4-sw@weilnetz.de>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20221126152507.283271-5-sw@weilnetz.de>


  Commit: ec09f22d01d1e59a42f0a5d4f02c325e03df3bc6
      
https://github.com/qemu/qemu/commit/ec09f22d01d1e59a42f0a5d4f02c325e03df3bc6
  Author: Stefan Weil via <qemu-devel@nongnu.org>
  Date:   2022-11-27 (Sun, 27 Nov 2022)

  Changed paths:
    M MAINTAINERS

  Log Message:
  -----------
  MAINTAINERS: Add subprojects/libvhost-user to section "vhost"

Signed-off-by: Stefan Weil <sw@weilnetz.de>
[Michael agreed to act as maintainer for libvhost-user via email in
https://lore.kernel.org/qemu-devel/20221123015218-mutt-send-email-mst@kernel.org/.
--Stefan]
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20221126152507.283271-6-sw@weilnetz.de>


  Commit: ac149498215809bfb5c0ddce1953519fbfda5004
      
https://github.com/qemu/qemu/commit/ac149498215809bfb5c0ddce1953519fbfda5004
  Author: Stefan Weil via <qemu-devel@nongnu.org>
  Date:   2022-11-27 (Sun, 27 Nov 2022)

  Changed paths:
    M include/net/net.h
    M net/socket.c
    M net/stream.c

  Log Message:
  -----------
  Add G_GNUC_PRINTF to function qemu_set_info_str and fix related issues

With the G_GNUC_PRINTF function attribute the compiler detects
two potential insecure format strings:

../../../net/stream.c:248:31: warning: format string is not a string literal 
(potentially insecure) [-Wformat-security]
    qemu_set_info_str(&s->nc, uri);
                              ^~~
../../../net/stream.c:322:31: warning: format string is not a string literal 
(potentially insecure) [-Wformat-security]
    qemu_set_info_str(&s->nc, uri);
                              ^~~

There are also two other warnings:

../../../net/socket.c:182:35: warning: zero-length gnu_printf format string 
[-Wformat-zero-length]
  182 |         qemu_set_info_str(&s->nc, "");
      |                                   ^~
../../../net/stream.c:170:35: warning: zero-length gnu_printf format string 
[-Wformat-zero-length]
  170 |         qemu_set_info_str(&s->nc, "");

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20221126152507.283271-7-sw@weilnetz.de>


Compare: https://github.com/qemu/qemu/compare/c23a95636622...ac1494982158