qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] c8885b: target/loongarch: Separate the hardwa


From: Greg Kurz
Subject: [Qemu-commits] [qemu/qemu] c8885b: target/loongarch: Separate the hardware flags into...
Date: Mon, 07 Nov 2022 13:01:04 -0800

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: c8885b8839dfe39ee7b02dedcbf79af9087c9079
      
https://github.com/qemu/qemu/commit/c8885b8839dfe39ee7b02dedcbf79af9087c9079
  Author: Rui Wang <wangrui@loongson.cn>
  Date:   2022-11-07 (Mon, 07 Nov 2022)

  Changed paths:
    M target/loongarch/cpu.h
    M target/loongarch/insn_trans/trans_privileged.c.inc
    M target/loongarch/tlb_helper.c
    M target/loongarch/translate.c
    M target/loongarch/translate.h

  Log Message:
  -----------
  target/loongarch: Separate the hardware flags into MMU index and PLV

Regarding the patchset v3 has been merged into main line, and not
approved, this patch updates to patchset v4.

Fixes: b4bda200 ("target/loongarch: Adjust the layout of hardware flags bit 
fields")
Link: https://lists.nongnu.org/archive/html/qemu-devel/2022-11/msg00808.html
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Rui Wang <wangrui@loongson.cn>
Message-Id: <20221107024526.702297-2-wangrui@loongson.cn>
Signed-off-by: Song Gao <gaosong@loongson.cn>


  Commit: e913bace61c539a88feb489b424554ebb2d5d3a3
      
https://github.com/qemu/qemu/commit/e913bace61c539a88feb489b424554ebb2d5d3a3
  Author: Rui Wang <wangrui@loongson.cn>
  Date:   2022-11-07 (Mon, 07 Nov 2022)

  Changed paths:
    M target/loongarch/insn_trans/trans_farith.c.inc

  Log Message:
  -----------
  target/loongarch: Fix return value of CHECK_FPE

Regarding the patchset v3 has been merged into main line, and not
approved, this patch updates to patchset v4.

Fixes: 2419978c ("target/loongarch: Fix emulation of float-point disable 
exception")
Link: https://lists.nongnu.org/archive/html/qemu-devel/2022-11/msg00808.html
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Rui Wang <wangrui@loongson.cn>
Message-Id: <20221107024526.702297-3-wangrui@loongson.cn>
Signed-off-by: Song Gao <gaosong@loongson.cn>


  Commit: 622a84ef76e4fb91327651cc3294a589c341acb5
      
https://github.com/qemu/qemu/commit/622a84ef76e4fb91327651cc3294a589c341acb5
  Author: Stefan Hajnoczi <stefanha@redhat.com>
  Date:   2022-11-07 (Mon, 07 Nov 2022)

  Changed paths:
    M target/loongarch/cpu.h
    M target/loongarch/insn_trans/trans_farith.c.inc
    M target/loongarch/insn_trans/trans_privileged.c.inc
    M target/loongarch/tlb_helper.c
    M target/loongarch/translate.c
    M target/loongarch/translate.h

  Log Message:
  -----------
  Merge tag 'pull-loongarch-20221107' of https://gitlab.com/gaosong/qemu into 
staging

pull-loongarch-20221107

# -----BEGIN PGP SIGNATURE-----
#
# iLMEAAEIAB0WIQS4/x2g0v3LLaCcbCxAov/yOSY+3wUCY2hz5gAKCRBAov/yOSY+
# 31ESA/9ppQVu70y8AnA/aYCzC6koQxxAsaD/lvwc7M1xzeZnjwOsVnsFLpZITTJj
# 2+2O/BlEO3uRvAtV6E7Vtu9D/+Cc+HQ7yOFnwbY0jZmePThp3YYtTg6o+2T7/9ya
# RMicgny1SYjsOjG8/Uam9+dRbH5QheNFwid0BWFhMts9MDB3Mg==
# =zZ8m
# -----END PGP SIGNATURE-----
# gpg: Signature made Sun 06 Nov 2022 21:56:38 EST
# gpg:                using RSA key B8FF1DA0D2FDCB2DA09C6C2C40A2FFF239263EDF
# gpg: Good signature from "Song Gao <m17746591750@163.com>" [unknown]
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg:          There is no indication that the signature belongs to the owner.
# Primary key fingerprint: B8FF 1DA0 D2FD CB2D A09C  6C2C 40A2 FFF2 3926 3EDF

* tag 'pull-loongarch-20221107' of https://gitlab.com/gaosong/qemu:
  target/loongarch: Fix return value of CHECK_FPE
  target/loongarch: Separate the hardware flags into MMU index and PLV

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>


  Commit: 479b350ebf08248eb7729a02a07ddfe7a7c65e44
      
https://github.com/qemu/qemu/commit/479b350ebf08248eb7729a02a07ddfe7a7c65e44
  Author: Greg Kurz <groug@kaod.org>
  Date:   2022-11-07 (Mon, 07 Nov 2022)

  Changed paths:
    M util/log.c

  Log Message:
  -----------
  util/log: Make the per-thread flag immutable

Per-thread logging was implemented under the assumption that once
enabled, it is not possible to switch back to single file logging.
This isn't enforced though and it is possible to go through the
global file opening sequence in per-thread mode. The code isn't
ready for this and produces unexpected results as detailed below.

Start QEMU in system emulation mode with `-D ./qemu.log.%d -d tid`
and then change the log level from the monitor to something that
doesn't have tid, e.g. `log cpu_reset`. The value of log_flags
is zero and per_thread is set to false : the rest of the code
then assumes it is running in the global log case and opens a
file named `qemu.log.%d`, which is obviously not an expected
behavior.

Enforce the immutability of the flag early in qemu_set_log_internal()
so that its value is correct for all subsequent users.

Fixes: 4e51069d6793 ("util/log: Support per-thread log files")
Cc: richard.henderson@linaro.org
Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20221104120059.678470-2-groug@kaod.org
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>


  Commit: 524fc737431d240f9d9f10aaf381003092868bac
      
https://github.com/qemu/qemu/commit/524fc737431d240f9d9f10aaf381003092868bac
  Author: Greg Kurz <groug@kaod.org>
  Date:   2022-11-07 (Mon, 07 Nov 2022)

  Changed paths:
    M util/log.c

  Log Message:
  -----------
  util/log: Ignore per-thread flag if global file already there

If QEMU is started with `-D qemu.log.%d` without any `-d` option,
doing `log all` in the monitor fails with:

Filename template with '%d' required for 'tid'

It is confusing since '%d' was actually passed.

This happens because QEMU caches the log file name with %d converted
to getpid() since `tid` wasn't required. This name isn't suitable
for a subsequent enablement of per-thread logs. There's little cause
to change the behavior as `-d tid` is mostly used at user-only startup.

Drop the per-thread from the requested flags in this case : `log all`
will thus enable everything except `tid` instead of failing. This is
preferable over forcing the user to enable each log item individually.

With this patch, `tid` is now truely immutable : it can only be set
or unset from the command line and never changed afterwards.

Fixes: 4e51069d6793 ("util/log: Support per-thread log files")
Cc: richard.henderson@linaro.org
Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20221104120059.678470-3-groug@kaod.org
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>


Compare: https://github.com/qemu/qemu/compare/cd706454c6cd...524fc737431d



reply via email to

[Prev in Thread] Current Thread [Next in Thread]