[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] e935b7: x86: return modified setup_data only
|
From: |
Paolo Bonzini |
|
Subject: |
[Qemu-commits] [qemu/qemu] e935b7: x86: return modified setup_data only if read as me... |
|
Date: |
Tue, 04 Oct 2022 11:10:18 -0700 |
Branch: refs/heads/staging
Home: https://github.com/qemu/qemu
Commit: e935b735085dfa61d8e6d276b6f9e7687796a3c7
https://github.com/qemu/qemu/commit/e935b735085dfa61d8e6d276b6f9e7687796a3c7
Author: Jason A. Donenfeld <Jason@zx2c4.com>
Date: 2022-09-27 (Tue, 27 Sep 2022)
Changed paths:
M hw/i386/x86.c
M hw/nvram/fw_cfg.c
M include/hw/nvram/fw_cfg.h
Log Message:
-----------
x86: return modified setup_data only if read as memory, not as file
If setup_data is being read into a specific memory location, then
generally the setup_data address parameter is read first, so that the
caller knows where to read it into. In that case, we should return
setup_data containing the absolute addresses that are hard coded and
determined a priori. This is the case when kernels are loaded by BIOS,
for example. In contrast, when setup_data is read as a file, then we
shouldn't modify setup_data, since the absolute address will be wrong by
definition. This is the case when OVMF loads the image.
This allows setup_data to be used like normal, without crashing when EFI
tries to use it.
(As a small development note, strangely, fw_cfg_add_file_callback() was
exported but fw_cfg_add_bytes_callback() wasn't, so this makes that
consistent.)
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Laurent Vivier <laurent@vivier.eu>
Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>
Cc: Philippe Mathieu-Daudé <f4bug@amsat.org>
Cc: Richard Henderson <richard.henderson@linaro.org>
Suggested-by: Ard Biesheuvel <ardb@kernel.org>
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Message-Id: <20220921093134.2936487-1-Jason@zx2c4.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Commit: eebb38a5633a77f5fa79d6486d5b2fcf8fbe3c07
https://github.com/qemu/qemu/commit/eebb38a5633a77f5fa79d6486d5b2fcf8fbe3c07
Author: Jason A. Donenfeld <Jason@zx2c4.com>
Date: 2022-09-27 (Tue, 27 Sep 2022)
Changed paths:
M hw/i386/x86.c
Log Message:
-----------
x86: use typedef for SetupData struct
The preferred style is SetupData as a typedef, not setup_data as a plain
struct.
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Ard Biesheuvel <ardb@kernel.org>
Suggested-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Message-Id: <20220921093134.2936487-2-Jason@zx2c4.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Commit: 763a2828bf313ed55878b09759dc435355035f2e
https://github.com/qemu/qemu/commit/763a2828bf313ed55878b09759dc435355035f2e
Author: Jason A. Donenfeld <Jason@zx2c4.com>
Date: 2022-09-27 (Tue, 27 Sep 2022)
Changed paths:
M hw/i386/x86.c
Log Message:
-----------
x86: reinitialize RNG seed on system reboot
Since this is read from fw_cfg on each boot, the kernel zeroing it out
alone is insufficient to prevent it from being used twice. And indeed on
reboot we always want a new seed, not the old one. So re-fill it in this
circumstance.
Cc: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Message-Id: <20220921093134.2936487-3-Jason@zx2c4.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Commit: ffe2d2382e5f1aae1abc4081af407905ef380311
https://github.com/qemu/qemu/commit/ffe2d2382e5f1aae1abc4081af407905ef380311
Author: Jason A. Donenfeld <Jason@zx2c4.com>
Date: 2022-09-27 (Tue, 27 Sep 2022)
Changed paths:
M hw/i386/microvm.c
M hw/i386/pc_piix.c
M hw/i386/pc_q35.c
Log Message:
-----------
x86: re-enable rng seeding via SetupData
This reverts 3824e25db1 ("x86: disable rng seeding via setup_data"), but
for 7.2 rather than 7.1, now that modifying setup_data is safe to do.
Cc: Laurent Vivier <laurent@vivier.eu>
Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>
Cc: Philippe Mathieu-Daudé <f4bug@amsat.org>
Cc: Richard Henderson <richard.henderson@linaro.org>
Cc: Ard Biesheuvel <ardb@kernel.org>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Message-Id: <20220921093134.2936487-4-Jason@zx2c4.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Commit: 2fc7eb689704687f890688507e15bbbe71275f63
https://github.com/qemu/qemu/commit/2fc7eb689704687f890688507e15bbbe71275f63
Author: Paolo Bonzini <pbonzini@redhat.com>
Date: 2022-09-27 (Tue, 27 Sep 2022)
Changed paths:
M pc-bios/qboot.rom
Log Message:
-----------
qboot: rebuild based on latest commit
df22fbb751 ("qboot: update to latest submodule") updated the qboot
submodule from a5300c49 to 8ca302e8. However, qboot isn't built during
the QEMU's build process but rather is included in binary form. So
rebuild it here.
Cc: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
[Rebuilt it myself for paranoia. - Paolo]
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Commit: 7089977a24133b3b1dd0864f4138efe3b906af4b
https://github.com/qemu/qemu/commit/7089977a24133b3b1dd0864f4138efe3b906af4b
Author: Paolo Bonzini <pbonzini@redhat.com>
Date: 2022-09-27 (Tue, 27 Sep 2022)
Changed paths:
M configure
M pc-bios/optionrom/Makefile
Log Message:
-----------
configure: do not invoke as/ld directly for pc-bios/optionrom
Just use using the compiler binary, with -nostdlib in the case of the
linker; the compiler driver (whether i686-*-gcc, or x86_64-*-gcc with
the -m32 option) will then pick the right magic option to as and ld.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Commit: 5433af7697ba97531d97e16e721cfe8a90722198
https://github.com/qemu/qemu/commit/5433af7697ba97531d97e16e721cfe8a90722198
Author: Paolo Bonzini <pbonzini@redhat.com>
Date: 2022-09-29 (Thu, 29 Sep 2022)
Changed paths:
M docs/about/deprecated.rst
M docs/about/removed-features.rst
M hw/watchdog/sbsa_gwdt.c
M hw/watchdog/watchdog.c
M hw/watchdog/wdt_aspeed.c
M hw/watchdog/wdt_diag288.c
M hw/watchdog/wdt_i6300esb.c
M hw/watchdog/wdt_ib700.c
M hw/watchdog/wdt_imx2.c
M include/sysemu/watchdog.h
M qemu-options.hx
M softmmu/vl.c
Log Message:
-----------
watchdog: remove -watchdog option
This was deprecated in 6.2 and is ready to go. It removes quite a bit
of code that handled the registration of watchdog models.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Commit: 0e902f59c1f24f5779850d4ff6001c88bed2527c
https://github.com/qemu/qemu/commit/0e902f59c1f24f5779850d4ff6001c88bed2527c
Author: Paolo Bonzini <pbonzini@redhat.com>
Date: 2022-09-29 (Thu, 29 Sep 2022)
Changed paths:
M tests/qtest/dbus-display-test.c
M ui/dbus.h
Log Message:
-----------
ui: fix path to dbus-display1.h
While the source directory is always included in the include path,
the corresponding directory in the build tree is not. Therefore,
custom_targets (e.g. ui/dbus-display1.h) must be referred to using
the full path.
This avoids a build failure when ui/dbus-chardev.c is not built as
a module:
In file included from ../ui/dbus-chardev.c:32:
../ui/dbus.h:34:10: fatal error: dbus-display1.h: No such file or directory
34 | #include "dbus-display1.h"
| ^~~~~~~~~~~~~~~~~
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Commit: ad9f958db5c48b9501905002a19e80b221dc7186
https://github.com/qemu/qemu/commit/ad9f958db5c48b9501905002a19e80b221dc7186
Author: Bernhard Beschow <shentey@gmail.com>
Date: 2022-09-29 (Thu, 29 Sep 2022)
Changed paths:
M hw/virtio/vhost-shadow-virtqueue.c
Log Message:
-----------
hw/virtio/vhost-shadow-virtqueue: Silence GCC error "maybe-uninitialized"
GCC issues a false positive warning, resulting in build failure with -Werror:
In file included from /usr/include/glib-2.0/glib.h:114,
from src/include/glib-compat.h:32,
from src/include/qemu/osdep.h:144,
from ../src/hw/virtio/vhost-shadow-virtqueue.c:10:
In function ‘g_autoptr_cleanup_generic_gfree’,
inlined from ‘vhost_handle_guest_kick’ at
../src/hw/virtio/vhost-shadow-virtqueue.c:292:42:
/usr/include/glib-2.0/glib/glib-autocleanups.h:28:3: error: ‘elem’ may be
used uninitialized [-Werror=maybe-uninitialized]
28 | g_free (*pp);
| ^~~~~~~~~~~~
../src/hw/virtio/vhost-shadow-virtqueue.c: In function
‘vhost_handle_guest_kick’:
../src/hw/virtio/vhost-shadow-virtqueue.c:292:42: note: ‘elem’ was declared
here
292 | g_autofree VirtQueueElement *elem;
| ^~~~
cc1: all warnings being treated as errors
There is actually no problem since "elem" is initialized in both branches.
Silence the warning by initializig it with "NULL".
$ gcc --version
gcc (GCC) 12.2.0
Fixes: 9c2ab2f1ec333be8614cc12272d4b91960704dbe ("vhost: stop transfer elem
ownership in vhost_handle_guest_kick")
Signed-off-by: Bernhard Beschow <shentey@gmail.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20220910151117.6665-1-shentey@gmail.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Commit: fcf5813cba7079d94eccc8804fb80c4b05e48a86
https://github.com/qemu/qemu/commit/fcf5813cba7079d94eccc8804fb80c4b05e48a86
Author: Wang, Lei <lei4.wang@intel.com>
Date: 2022-09-29 (Thu, 29 Sep 2022)
Changed paths:
M .gitignore
Log Message:
-----------
.gitignore: add .cache/ to .gitignore
$PROJECT/.cache/clangd/index is the intended location for project index
data when using clangd as the language server. Ignore this directory to
keep the git status clean.
Signed-off-by: Wang, Lei <lei4.wang@intel.com>
Message-Id: <20220907150010.2047037-1-lei4.wang@intel.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Commit: c6cc866c0eaab1deddea21bf0b386730ed71bb97
https://github.com/qemu/qemu/commit/c6cc866c0eaab1deddea21bf0b386730ed71bb97
Author: Tong Zhang <t.zhang2@samsung.com>
Date: 2022-09-29 (Thu, 29 Sep 2022)
Changed paths:
M hw/mem/cxl_type3.c
Log Message:
-----------
mem/cxl_type3: fix GPF DVSEC
The structure is for device dvsec not port dvsec. Change type to fix
this issue.
Signed-off-by: Tong Zhang <t.zhang2@samsung.com>
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Message-Id: <20220915175853.2902-1-t.zhang2@samsung.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Commit: 321b0ca353a2cb568ed7807ff6b64ad97101ee1e
https://github.com/qemu/qemu/commit/321b0ca353a2cb568ed7807ff6b64ad97101ee1e
Author: Matheus Tavares Bernardino <quic_mathbern@quicinc.com>
Date: 2022-09-29 (Thu, 29 Sep 2022)
Changed paths:
M scripts/checkpatch.pl
Log Message:
-----------
checkpatch: ignore target/hexagon/imported/* files
These files come from an external project (the hexagon archlib), so they
deliberately do not follow QEMU's coding style. To avoid false positives
from checkpatch.pl, let's disable the checking for those.
Signed-off-by: Matheus Tavares Bernardino <quic_mathbern@quicinc.com>
Message-Id:
<e3b6a345a88807a1c4daa45f638b2a90af538fd5.1663681339.git.quic_mathbern@quicinc.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Commit: bb2dc4b73a30613216c048fe2a6551e011d1c963
https://github.com/qemu/qemu/commit/bb2dc4b73a30613216c048fe2a6551e011d1c963
Author: Paolo Bonzini <pbonzini@redhat.com>
Date: 2022-10-01 (Sat, 01 Oct 2022)
Changed paths:
M meson.build
Log Message:
-----------
meson: -display dbus and CFI are incompatible
The generated skeletons for DBus call the finalize method of the parent
type using code like
G_OBJECT_CLASS (qemu_dbus_display1_chardev_skeleton_parent_class)->finalize
(object);
However, the finalize method is defined in a shared library that is not
compiled with CFI. Do not enable anything that uses gdbus-codegen if
--enable-cfi was specified.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Commit: 8a29c20597f98e20c7390300b63fa6ac7d3ad6dd
https://github.com/qemu/qemu/commit/8a29c20597f98e20c7390300b63fa6ac7d3ad6dd
Author: Paolo Bonzini <pbonzini@redhat.com>
Date: 2022-10-01 (Sat, 01 Oct 2022)
Changed paths:
M configure
M meson
M meson.build
M qga/meson.build
Log Message:
-----------
meson: require 0.61.3
This removes the dependency of dbus-display on --enable-modules. It also allows
cleanups in modinfo collection and allows moving C++ compiler detection to
meson.build.
Because it is now deprecated to use install_subdir to create an empty directory,
replace it with install_emptydir.
Updating the Meson submodule to 0.61.5 also removes the message
WARNING: Broken python installation detected. Python files installed
by Meson might not be found by python interpreter.
unless using system meson is forced with --meson.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/873
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/848
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Commit: 6d3226357fb848499aacf609bf628932bca781ea
https://github.com/qemu/qemu/commit/6d3226357fb848499aacf609bf628932bca781ea
Author: Paolo Bonzini <pbonzini@redhat.com>
Date: 2022-10-01 (Sat, 01 Oct 2022)
Changed paths:
M meson.build
Log Message:
-----------
meson: multiple names can be passed to dependency()
This is new in Meson 0.60.0.
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Commit: b485458e00dae4af5e2b7b1c17521e2885180544
https://github.com/qemu/qemu/commit/b485458e00dae4af5e2b7b1c17521e2885180544
Author: Paolo Bonzini <pbonzini@redhat.com>
Date: 2022-10-01 (Sat, 01 Oct 2022)
Changed paths:
M configure
M meson.build
A scripts/main.c
Log Message:
-----------
configure, meson: move C++ compiler detection to meson.build
The test is slightly weaker than before, because it does not
call an extern "C" function from a C source file. However,
in practice what we seek to detect is ABI compatibility of the
various sanitizer flags, and for that it is enough to compile
anything with CC and link it with CXX.
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Commit: e4333d14c574631029e2d9d00bcb94b81a8df800
https://github.com/qemu/qemu/commit/e4333d14c574631029e2d9d00bcb94b81a8df800
Author: Paolo Bonzini <pbonzini@redhat.com>
Date: 2022-10-01 (Sat, 01 Oct 2022)
Changed paths:
M configure
M meson.build
Log Message:
-----------
configure, meson: move linker flag detection to meson
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Commit: c4ef867f2949bf2a2ae18a4e27cf1a34bbc8aecb
https://github.com/qemu/qemu/commit/c4ef867f2949bf2a2ae18a4e27cf1a34bbc8aecb
Author: Ray Zhang <zhanglei002@gmail.com>
Date: 2022-10-01 (Sat, 01 Oct 2022)
Changed paths:
M target/i386/kvm/kvm.c
Log Message:
-----------
target/i386/kvm: fix kvmclock_current_nsec: Assertion `time.tsc_timestamp <=
migration_tsc' failed
New KVM_CLOCK flags were added in the
kernel.(c68dc1b577eabd5605c6c7c08f3e07ae18d30d5d)
```
+ #define KVM_CLOCK_VALID_FLAGS \
+ (KVM_CLOCK_TSC_STABLE | KVM_CLOCK_REALTIME | KVM_CLOCK_HOST_TSC)
case KVM_CAP_ADJUST_CLOCK:
- r = KVM_CLOCK_TSC_STABLE;
+ r = KVM_CLOCK_VALID_FLAGS;
```
kvm_has_adjust_clock_stable needs to handle additional flags,
so that s->clock_is_reliable can be true and kvmclock_current_nsec doesn't need
to be called.
Signed-off-by: Ray Zhang <zhanglei002@gmail.com>
Message-Id: <20220922100523.2362205-1-zhanglei002@gmail.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Commit: cc63374a5a7c240b7d3be734ef589dabbefc7527
https://github.com/qemu/qemu/commit/cc63374a5a7c240b7d3be734ef589dabbefc7527
Author: Jason A. Donenfeld <Jason@zx2c4.com>
Date: 2022-10-01 (Sat, 01 Oct 2022)
Changed paths:
M hw/i386/x86.c
Log Message:
-----------
x86: re-initialize RNG seed when selecting kernel
We don't want it to be possible to re-read the RNG seed after ingesting
it, because this ruins forward secrecy. Currently, however, the setup
data section can just be re-read. Since the kernel is always read after
the setup data, use the selection of the kernel as a trigger to
re-initialize the RNG seed, just like we do on reboot, to preserve
forward secrecy.
Cc: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Message-Id: <20220922152847.3670513-1-Jason@zx2c4.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Commit: 90dc46d31495ec5825dc35e6984c38149261538f
https://github.com/qemu/qemu/commit/90dc46d31495ec5825dc35e6984c38149261538f
Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
Date: 2022-10-04 (Tue, 04 Oct 2022)
Changed paths:
M block/qcow2-bitmap.c
Log Message:
-----------
block/qcow2-bitmap: Add missing cast to silent GCC error
Commit d1258dd0c8 ("qcow2: autoloading dirty bitmaps") added the
set_readonly_helper() GFunc handler, correctly casting the gpointer
user_data in both the g_slist_foreach() caller and the handler.
Few commits later (commit 1b6b0562db), the handler is reused in
qcow2_reopen_bitmaps_rw() but missing the gpointer cast, resulting
in the following error when using Homebrew GCC 12.2.0:
[2/658] Compiling C object libblock.fa.p/block_qcow2-bitmap.c.o
../../block/qcow2-bitmap.c: In function 'qcow2_reopen_bitmaps_rw':
../../block/qcow2-bitmap.c:1211:60: error: incompatible type for argument 3
of 'g_slist_foreach'
1211 | g_slist_foreach(ro_dirty_bitmaps, set_readonly_helper, false);
| ^~~~~
| |
| _Bool
In file included from
/opt/homebrew/Cellar/glib/2.72.3_1/include/glib-2.0/glib/gmain.h:26,
from
/opt/homebrew/Cellar/glib/2.72.3_1/include/glib-2.0/glib/giochannel.h:33,
from
/opt/homebrew/Cellar/glib/2.72.3_1/include/glib-2.0/glib.h:54,
from /Users/philmd/source/qemu/include/glib-compat.h:32,
from /Users/philmd/source/qemu/include/qemu/osdep.h:144,
from ../../block/qcow2-bitmap.c:28:
/opt/homebrew/Cellar/glib/2.72.3_1/include/glib-2.0/glib/gslist.h:127:61:
note: expected 'gpointer' {aka 'void *'} but argument is of type '_Bool'
127 | gpointer
user_data);
| ~~~~~~~~~~~~~~~~~~^~~~~~~~~
At top level:
FAILED: libblock.fa.p/block_qcow2-bitmap.c.o
Fix by adding the missing gpointer cast.
Fixes: 1b6b0562db ("qcow2: support .bdrv_reopen_bitmaps_rw")
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Message-Id: <20220919182755.51967-1-f4bug@amsat.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Commit: 76eb88b12baf2bd9a1729ded33bd58b7da5d7ec3
https://github.com/qemu/qemu/commit/76eb88b12baf2bd9a1729ded33bd58b7da5d7ec3
Author: Markus Armbruster <armbru@redhat.com>
Date: 2022-10-04 (Tue, 04 Oct 2022)
Changed paths:
M replay/replay.c
M target/i386/kvm/kvm.c
M target/i386/whpx/whpx-all.c
Log Message:
-----------
Drop superfluous conditionals around g_free()
There is no need to guard g_free(P) with if (P): g_free(NULL) is safe.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20220923090428.93529-1-armbru@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Commit: c5e8d51824fe725d0693cd9f50171d34297c5cc0
https://github.com/qemu/qemu/commit/c5e8d51824fe725d0693cd9f50171d34297c5cc0
Author: Markus Armbruster <armbru@redhat.com>
Date: 2022-10-04 (Tue, 04 Oct 2022)
Changed paths:
M hw/remote/iommu.c
M hw/virtio/virtio-crypto.c
M migration/dirtyrate.c
M softmmu/dirtylimit.c
Log Message:
-----------
Use g_new() & friends where that makes obvious sense
g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer,
for two reasons. One, it catches multiplication overflowing size_t.
Two, it returns T * rather than void *, which lets the compiler catch
more type errors.
This commit only touches allocations with size arguments of the form
sizeof(T).
Patch created mechanically with:
$ spatch --in-place --sp-file scripts/coccinelle/use-g_new-etc.cocci \
--macro-file scripts/cocci-macro-file.h FILES...
The previous iteration was commit a95942b50c.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Message-Id: <20220923084254.4173111-1-armbru@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Commit: 4a4a74bf439910e957db42405a3abefdf867516a
https://github.com/qemu/qemu/commit/4a4a74bf439910e957db42405a3abefdf867516a
Author: Stefan Berger <stefanb@linux.ibm.com>
Date: 2022-10-04 (Tue, 04 Oct 2022)
Changed paths:
M docs/specs/tpm.rst
Log Message:
-----------
docs: Update TPM documentation for usage of a TPM 2
Update the TPM documentation for usage of a TPM 2 rather than a TPM 1.2.
Adjust the command lines and expected outputs inside the VM accordingly.
Update the command line to start a TPM 2 with swtpm.
Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20220927122146.2787854-1-stefanb@linux.ibm.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Commit: f8ec554cb87503806ca341b69d3474c8cfdf6c28
https://github.com/qemu/qemu/commit/f8ec554cb87503806ca341b69d3474c8cfdf6c28
Author: Stefan Hajnoczi <stefanha@redhat.com>
Date: 2022-10-04 (Tue, 04 Oct 2022)
Changed paths:
M configure
M docs/about/deprecated.rst
M docs/about/removed-features.rst
M hw/i386/microvm.c
M hw/i386/pc_piix.c
M hw/i386/pc_q35.c
M hw/i386/x86.c
M hw/nvram/fw_cfg.c
M hw/watchdog/sbsa_gwdt.c
M hw/watchdog/watchdog.c
M hw/watchdog/wdt_aspeed.c
M hw/watchdog/wdt_diag288.c
M hw/watchdog/wdt_i6300esb.c
M hw/watchdog/wdt_ib700.c
M hw/watchdog/wdt_imx2.c
M include/hw/nvram/fw_cfg.h
M include/sysemu/watchdog.h
M meson
M meson.build
M pc-bios/optionrom/Makefile
M pc-bios/qboot.rom
M qemu-options.hx
M qga/meson.build
A scripts/main.c
M softmmu/vl.c
M target/i386/kvm/kvm.c
M tests/qtest/dbus-display-test.c
M ui/dbus.h
Log Message:
-----------
Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging
* x86: re-enable rng seeding via SetupData
* x86: reinitialize RNG seed on system reboot and after kernel load
* qboot: rebuild based on latest commit
* watchdog: remove -watchdog option
* update Meson to 0.61.5, move more configure tests
# -----BEGIN PGP SIGNATURE-----
#
# iQFIBAABCAAyFiEE8TM4V0tmI4mGbHaCv/vSX3jHroMFAmM4kiAUHHBib256aW5p
# QHJlZGhhdC5jb20ACgkQv/vSX3jHroNfbgf+IHhIHVxtBVWqayVRkwpQC+oAFV/V
# 4bvJI90rHmTNPA36n1ocUmQmXyNVTQFW/t7mlln5BhOwNzxnQycVe2idfMa6ntkb
# hHpe2NbICF9Crzb9BkK4wnaBLwEWA/X3WlnCqPYtxlxEhjmxu+HPtF7vm12OTkOV
# JevH3EN1gMiAfMo+gcRBlrwb5kntLm3nGZTCd218Ope22PoU6MVvxb9ivieJG8kD
# xDUGPQNU0mB9pypwLYZAqmu34xJ8Stly9UuJ1M2iQoawIs7W2Qy7svpOrsKZ3W/7
# D7J18QLAjI7Hq6rUWPgK5ugnUvVMdaTXM7MZSuIDIxRJuj5YryIsHRPybQ==
# =HEmX
# -----END PGP SIGNATURE-----
# gpg: Signature made Sat 01 Oct 2022 15:16:48 EDT
# gpg: using RSA key F13338574B662389866C7682BFFBD25F78C7AE83
# gpg: issuer "pbonzini@redhat.com"
# gpg: Good signature from "Paolo Bonzini <bonzini@gnu.org>" [full]
# gpg: aka "Paolo Bonzini <pbonzini@redhat.com>" [full]
# Primary key fingerprint: 46F5 9FBD 57D6 12E7 BFD4 E2F7 7E15 100C CD36 69B1
# Subkey fingerprint: F133 3857 4B66 2389 866C 7682 BFFB D25F 78C7 AE83
* tag 'for-upstream' of https://gitlab.com/bonzini/qemu:
x86: re-initialize RNG seed when selecting kernel
target/i386/kvm: fix kvmclock_current_nsec: Assertion `time.tsc_timestamp <=
migration_tsc' failed
configure, meson: move linker flag detection to meson
configure, meson: move C++ compiler detection to meson.build
meson: multiple names can be passed to dependency()
meson: require 0.61.3
meson: -display dbus and CFI are incompatible
ui: fix path to dbus-display1.h
watchdog: remove -watchdog option
configure: do not invoke as/ld directly for pc-bios/optionrom
qboot: rebuild based on latest commit
x86: re-enable rng seeding via SetupData
x86: reinitialize RNG seed on system reboot
x86: use typedef for SetupData struct
x86: return modified setup_data only if read as memory, not as file
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Commit: fafd35a6dab8e70a7c395aaa8e1273267cf9f3c8
https://github.com/qemu/qemu/commit/fafd35a6dab8e70a7c395aaa8e1273267cf9f3c8
Author: Stefan Hajnoczi <stefanha@redhat.com>
Date: 2022-10-04 (Tue, 04 Oct 2022)
Changed paths:
M .gitignore
M docs/specs/tpm.rst
M hw/mem/cxl_type3.c
M hw/remote/iommu.c
M hw/virtio/vhost-shadow-virtqueue.c
M hw/virtio/virtio-crypto.c
M migration/dirtyrate.c
M replay/replay.c
M scripts/checkpatch.pl
M softmmu/dirtylimit.c
M target/i386/kvm/kvm.c
M target/i386/whpx/whpx-all.c
Log Message:
-----------
Merge tag 'trivial-branch-for-7.2-pull-request' of
https://gitlab.com/laurent_vivier/qemu into staging
Pull request trivial patches branch 20220930-v2
# -----BEGIN PGP SIGNATURE-----
#
# iQJGBAABCAAwFiEEzS913cjjpNwuT1Fz8ww4vT8vvjwFAmM7XoISHGxhdXJlbnRA
# dml2aWVyLmV1AAoJEPMMOL0/L748D/0QAKbYtTWjhFPeapjZVoTv13YrTvczWrcF
# omL6IZivVq0t7hun4iem0DwmvXJELMGexEOTvEJOzM19IIlvvwvOsI8xnxpcMnEY
# 6GKVbs53Ba0bg2yh7Dll2W9jkou9eX27DwUHMVF8KX7qqsbU+WyD/vdGZitgGt+T
# 8yna7kzVvNVsdB3+DbIatI5RzzHeu4OqeuH/WCtAyzCaLB64UYTcHprskxIp4+wp
# dR+EUSoDEr9Qx4PC+uVEsTFK1zZjyAYNoNIkh6fhlkRvDJ1uA75m3EJ57P8xPPqe
# VbVkPMKi0d4c52m6XvLsQhyYryLx/qLLUAkJWVpY66aHcapYbZAEAfZmNGTQLrOJ
# qIOJzIkOdU6l3pRgXVdVCgkHRc2HETwET2LyVbNkUz/vBlW2wOZQbZFbezComael
# bQ/gNBYqP+eOGnZzeWbKBGHr/9QDBClNufidIMC+sOiUw0iSifzjkFwvH7IElx6K
# EQCOSV6pOhKVlinTpmBbk1XD3xDkQ7ZidiLT9g+P1c8dExrXBhWOnfUHueISb8+s
# KKMozuxQ/6/3c/DP5hwI9cKPEWEbqJfq1kMuxIvEivKGwUIqX2yq4VJ+hSlYJ+CW
# nGjXZldtf4KwH+cTsxyPmdZRR5Q7+ODr5Xo7GNvEKBuDsHs7uUl1c3vvOykQgje9
# +dyJR6TfbQWn
# =aK29
# -----END PGP SIGNATURE-----
# gpg: Signature made Mon 03 Oct 2022 18:13:22 EDT
# gpg: using RSA key CD2F75DDC8E3A4DC2E4F5173F30C38BD3F2FBE3C
# gpg: issuer "laurent@vivier.eu"
# gpg: Good signature from "Laurent Vivier <lvivier@redhat.com>" [full]
# gpg: aka "Laurent Vivier <laurent@vivier.eu>" [full]
# gpg: aka "Laurent Vivier (Red Hat) <lvivier@redhat.com>"
[full]
# Primary key fingerprint: CD2F 75DD C8E3 A4DC 2E4F 5173 F30C 38BD 3F2F BE3C
* tag 'trivial-branch-for-7.2-pull-request' of
https://gitlab.com/laurent_vivier/qemu:
docs: Update TPM documentation for usage of a TPM 2
Use g_new() & friends where that makes obvious sense
Drop superfluous conditionals around g_free()
block/qcow2-bitmap: Add missing cast to silent GCC error
checkpatch: ignore target/hexagon/imported/* files
mem/cxl_type3: fix GPF DVSEC
.gitignore: add .cache/ to .gitignore
hw/virtio/vhost-shadow-virtqueue: Silence GCC error "maybe-uninitialized"
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Compare: https://github.com/qemu/qemu/compare/efbf38d73e5d...fafd35a6dab8
- [Qemu-commits] [qemu/qemu] e935b7: x86: return modified setup_data only if read as me...,
Paolo Bonzini <=