[Qemu-commits] [qemu/qemu] d82b11: ui: dbus-display requires CONFIG_GBM

[Richard Henderson]

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: d82b11f69953cf15cee819bcf02dfd87325980a9
      
https://github.com/qemu/qemu/commit/d82b11f69953cf15cee819bcf02dfd87325980a9
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2022-07-28 (Thu, 28 Jul 2022)

  Changed paths:
    M meson.build
    M ui/meson.build

  Log Message:
  -----------
  ui: dbus-display requires CONFIG_GBM

Without CONFIG_GBM, compiling dbus-display fails with

../ui/dbus.c: In function ‘dbus_create_context’:
../ui/dbus.c:47:20: error: ‘qemu_egl_rn_ctx’ undeclared (first use in this 
function); did you mean ‘qemu_egl_init_ctx’?
   47 |                    qemu_egl_rn_ctx);
      |                    ^~~~~~~~~~~~~~~
      |                    qemu_egl_init_ctx
../ui/dbus.c:47:20: note: each undeclared identifier is reported only once for 
each function it appears in

and many other similar errors, because include/ui/egl-helpers.h only has
these declaration if gbm is found on the system.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1108
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 37e7b86766244b62a406747bb78e049390d0b528
      
https://github.com/qemu/qemu/commit/37e7b86766244b62a406747bb78e049390d0b528
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2022-07-28 (Thu, 28 Jul 2022)

  Changed paths:
    M hw/display/vga.c

  Log Message:
  -----------
  vga: fix incorrect line height in 640x200x2 mode

When in CGA modes, QEMU wants to ignore the maximum scan field (bits 0..4) of
the maximum scan length register in the CRTC.  It is not clear why this is
needed---for example, Bochs ignores bit 7 instead.  The issue is that the
CGA modes are not detected correctly, and in particular mode 6 results in
multi_scan==3 according to how SeaBIOS programs it.  The right way to check
for CGA graphics modes is to check whether bit 13 of the address is special
cased by the CRT controller to achieve line interleaving, i.e. whether bit 0
of the CRTC mode control register is clear.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1020
Reported-by: Korneliusz Osmenda <korneliuszo@gmail.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: bb7e03cb5677b570c5966c7dd946f9ed7acd11bc
      
https://github.com/qemu/qemu/commit/bb7e03cb5677b570c5966c7dd946f9ed7acd11bc
  Author: Claudio Fontana <cfontana@suse.de>
  Date:   2022-07-28 (Thu, 28 Jul 2022)

  Changed paths:
    M stubs/replay-tools.c

  Log Message:
  -----------
  stubs: update replay-tools to match replay.h types

detected with GCC 13 [-Werror=enum-int-mismatch]

Solves Issue #1096.

Signed-off-by: Claudio Fontana <cfontana@suse.de>
Cc: Pavel Dovgalyuk <pavel.dovgalyuk@ispras.ru>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20220704075832.31537-1-cfontana@suse.de>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 705c881f7d8573d7520de2566396feb6a1223d57
      
https://github.com/qemu/qemu/commit/705c881f7d8573d7520de2566396feb6a1223d57
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2022-07-29 (Fri, 29 Jul 2022)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: Fix ppc container_cross_cc substitution

When moving this code out of probe_target_compiler(), we failed to adjust
the variable in which the target is located, resulting in e.g.
powerpc64-linux-user-linux-gnu-gcc-10

Fixes: cd362defbbd ("tests/tcg: merge configure.sh back into main configure 
script")
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220728183901.1290113-1-richard.henderson@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 47c182fe8b03c0c40059fb95840923e65c9bdb4f
      
https://github.com/qemu/qemu/commit/47c182fe8b03c0c40059fb95840923e65c9bdb4f
  Author: Cornelia Huck <cohuck@redhat.com>
  Date:   2022-07-29 (Fri, 29 Jul 2022)

  Changed paths:
    M accel/kvm/kvm-all.c
    M target/arm/kvm.c

  Log Message:
  -----------
  kvm: don't use perror() without useful errno

perror() is designed to append the decoded errno value to a
string. This, however, only makes sense if we called something that
actually sets errno prior to that.

For the callers that check for split irqchip support that is not the
case, and we end up with confusing error messages that end in
"success". Use error_report() instead.

Signed-off-by: Cornelia Huck <cohuck@redhat.com>
Message-Id: <20220728142446.438177-1-cohuck@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: ebc55f523c2f406e30ec8fad77bd3b9aad5d4579
      
https://github.com/qemu/qemu/commit/ebc55f523c2f406e30ec8fad77bd3b9aad5d4579
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2022-07-29 (Fri, 29 Jul 2022)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: pass correct cflags to container-based cross compilers

probe_target_compiler returns nonempty $target_cc for installed toolchains
and $container_cross_cc for container-based toolchains.  In both cases
however the flags (coming from $cross_cc_cflags_${target_arch}) must be
in $target_cflags.

Therefore, do not clear them prior to returning from probe_target_compiler.

Reported-by: Taylor Simpson <tsimpson@quicinc.com>
Fixes: 92e288fcfb ("build: try both native and cross compilers", 2022-07-08)
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 9fac07bea86d4c0f2e4fec8aab1bed89435d8bce
      
https://github.com/qemu/qemu/commit/9fac07bea86d4c0f2e4fec8aab1bed89435d8bce
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2022-07-29 (Fri, 29 Jul 2022)

  Changed paths:
    M accel/kvm/kvm-all.c
    M configure
    M hw/display/vga.c
    M meson.build
    M stubs/replay-tools.c
    M target/arm/kvm.c
    M ui/meson.build

  Log Message:
  -----------
  Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging

* Misc build system bugfixes
* Fix CGA 2-color graphics

# -----BEGIN PGP SIGNATURE-----
#
# iQFIBAABCAAyFiEE8TM4V0tmI4mGbHaCv/vSX3jHroMFAmLj1BYUHHBib256aW5p
# QHJlZGhhdC5jb20ACgkQv/vSX3jHroO1nQgAoKoT4oiRrHGRPRav5FVHedeVoLgn
# QXqdiB90xB4uoxeCqqEWWdQ/yuGkCrhrBYqlJynM7BLj0ujqsxw5MHsmcN4MKwVH
# 9hQQDegpzRcN8yY9/t4vBqxS66Z6Pj8zVTq58FkyTsE5yusayoT2gXINb/Y6iEnm
# sff46kgnXmx0+QiEVkzfuQk4Q4orih554GquOiUUrT0QfVgkTmZr3EIjU0x6urU9
# 9Pnr20GB4iK4IdqcDT1y/7viHhRLwzONO/6+7dmod82cxWVwIR3WZlonqOsWBS/F
# Vw6iVWquC7vMm7eS9mh2bZZSkXkczcdegKVE5O4WgpdqXmad4sJtWBgT5g==
# =q27Q
# -----END PGP SIGNATURE-----
# gpg: Signature made Fri 29 Jul 2022 05:35:34 AM PDT
# gpg:                using RSA key F13338574B662389866C7682BFFBD25F78C7AE83
# gpg:                issuer "pbonzini@redhat.com"
# gpg: Good signature from "Paolo Bonzini <bonzini@gnu.org>" [undefined]
# gpg:                 aka "Paolo Bonzini <pbonzini@redhat.com>" [undefined]
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg:          There is no indication that the signature belongs to the owner.
# Primary key fingerprint: 46F5 9FBD 57D6 12E7 BFD4  E2F7 7E15 100C CD36 69B1
#      Subkey fingerprint: F133 3857 4B66 2389 866C  7682 BFFB D25F 78C7 AE83

* tag 'for-upstream' of https://gitlab.com/bonzini/qemu:
  configure: pass correct cflags to container-based cross compilers
  kvm: don't use perror() without useful errno
  configure: Fix ppc container_cross_cc substitution
  stubs: update replay-tools to match replay.h types
  vga: fix incorrect line height in 640x200x2 mode
  ui: dbus-display requires CONFIG_GBM

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


Compare: https://github.com/qemu/qemu/compare/0279d0e6b528...9fac07bea86d