qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] feb6cb: tests: refresh to latest libvirt-ci m


From: Richard Henderson
Subject: [Qemu-commits] [qemu/qemu] feb6cb: tests: refresh to latest libvirt-ci module
Date: Fri, 29 Jul 2022 05:23:56 -0700

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: feb6cb936906ad049bdc77ef176b1d402e341c29
      
https://github.com/qemu/qemu/commit/feb6cb936906ad049bdc77ef176b1d402e341c29
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2022-07-29 (Fri, 29 Jul 2022)

  Changed paths:
    M .gitlab-ci.d/cirrus/freebsd-12.vars
    M .gitlab-ci.d/cirrus/freebsd-13.vars
    M .gitlab-ci.d/cirrus/macos-11.vars
    M tests/docker/dockerfiles/alpine.docker
    M tests/docker/dockerfiles/centos8.docker
    M tests/docker/dockerfiles/debian-amd64.docker
    M tests/docker/dockerfiles/debian-arm64-cross.docker
    M tests/docker/dockerfiles/debian-armel-cross.docker
    M tests/docker/dockerfiles/debian-armhf-cross.docker
    M tests/docker/dockerfiles/debian-mips64el-cross.docker
    M tests/docker/dockerfiles/debian-mipsel-cross.docker
    M tests/docker/dockerfiles/debian-ppc64el-cross.docker
    M tests/docker/dockerfiles/debian-s390x-cross.docker
    M tests/docker/dockerfiles/fedora.docker
    M tests/docker/dockerfiles/opensuse-leap.docker
    M tests/docker/dockerfiles/ubuntu2004.docker
    M tests/lcitool/libvirt-ci
    M tests/lcitool/projects/qemu.yml
    M tests/lcitool/refresh

  Log Message:
  -----------
  tests: refresh to latest libvirt-ci module

Notable changes:

  - libvirt-ci source tree was re-arranged, so the script we
    run now lives in a bin/ sub-dir

  - opensuse 15.2 is replaced by opensuse 15.3

  - libslirp is temporarily dropped on opensuse as the
    libslirp-version.h is broken

     https://bugzilla.opensuse.org/show_bug.cgi?id=1201551

  - The incorrectly named python3-virtualenv module was
    changed to python3-venv, but most distros don't need
    any package as 'venv' is a standard part of python

  - glibc-static was renamed to libc-static, to reflect
    fact that it isn't going to be glibc on all distros

  - The cmocka/json-c deps that were manually added to
    the centos dockerfile and are now consistently added
    to all targets

Acked-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220722130431.2319019-2-berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Acked-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220725140520.515340-2-alex.bennee@linaro.org>


  Commit: 998f3347223234eeb2f47235eaa222cf0ee7f8ca
      
https://github.com/qemu/qemu/commit/998f3347223234eeb2f47235eaa222cf0ee7f8ca
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2022-07-29 (Fri, 29 Jul 2022)

  Changed paths:
    M .gitlab-ci.d/cirrus/build.yml
    M .gitlab-ci.d/custom-runners/centos-stream-8-x86_64.yml
    M .gitlab-ci.d/custom-runners/ubuntu-20.04-aarch32.yml
    M .gitlab-ci.d/custom-runners/ubuntu-20.04-aarch64.yml
    M .gitlab-ci.d/custom-runners/ubuntu-20.04-s390x.yml

  Log Message:
  -----------
  gitlab: show testlog.txt contents when cirrus/custom-runner jobs fail

When tests fail meson just displays a summary and tells you to look at
the testlog.txt file for details. The native jobs on shared runners
publish testlog.txt as an artifact. For the Cirrus jobs and custom
runner jobs this is not currently possible. The best we can do is cat
the log contents on failure, to give maintainers a fighting chance
of diagnosing the problem.

Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220722130431.2319019-3-berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20220725140520.515340-3-alex.bennee@linaro.org>


  Commit: ca58b4931ec2599eb8a2564bef231b32247348bf
      
https://github.com/qemu/qemu/commit/ca58b4931ec2599eb8a2564bef231b32247348bf
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2022-07-29 (Fri, 29 Jul 2022)

  Changed paths:
    M .gitlab-ci.d/container-cross.yml
    M .gitlab-ci.d/stages.yml

  Log Message:
  -----------
  gitlab: drop 'containers-layer2' stage

Since we express dependencies via a 'needs' clause, we don't need to
split container builds into separate stages. GitLab happily lets jobs
depend on other jobs in the same stage and will run them when possible.

Acked-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220722130431.2319019-4-berrange@redhat.com>
[AJB: fix typo]
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20220725140520.515340-4-alex.bennee@linaro.org>


  Commit: 6ad5208661643aad31328433aaaa2045805b12b8
      
https://github.com/qemu/qemu/commit/6ad5208661643aad31328433aaaa2045805b12b8
  Author: Bin Meng <bin.meng@windriver.com>
  Date:   2022-07-29 (Fri, 29 Jul 2022)

  Changed paths:
    M .cirrus.yml

  Log Message:
  -----------
  .cirrus.yml: Change winsymlinks to 'native'

At present winsymlinks is set to 'nativestrict', and its behavior is:

  a) if native symlinks are enabled and <target> exists, creates
     <destination> as a native Windows symlink;
  b) else if native symlinks are not enabled or if <target> does
     not exist, 'ln -s' fails.

This causes the following error message was seen during the configure:

  "ln: failed to create symbolic link
  'x86_64-softmmu/qemu-system-x86_64.exe': No such file or directory"

Change winsymlinks to 'native' whose behavior is most similar to the
behavior of 'ln -s' on *nix, that is:

  a) if native symlinks are enabled, and whether <target> exists
     or not, creates <destination> as a native Windows symlink;
  b) else if native symlinks are not enabled, and whether <target>
     exists or not, 'ln -s' creates as a Windows shortcut file.

Signed-off-by: Bin Meng <bin.meng@windriver.com>
Acked-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Yonggang Luo <luoyonggang@gmail.com>
Message-Id: <20220719161230.766063-1-bmeng.cn@gmail.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20220725140520.515340-5-alex.bennee@linaro.org>


  Commit: 93a02e822fc65d8f16eb98f64af88d69ba3c9fd6
      
https://github.com/qemu/qemu/commit/93a02e822fc65d8f16eb98f64af88d69ba3c9fd6
  Author: Bin Meng <bin.meng@windriver.com>
  Date:   2022-07-29 (Fri, 29 Jul 2022)

  Changed paths:
    M .gitlab-ci.d/windows.yml

  Log Message:
  -----------
  .gitlab-ci.d/windows.yml: Enable native Windows symlink

The following error message was seen during the configure:

  "ln: failed to create symbolic link
  'x86_64-softmmu/qemu-system-x86_64.exe': No such file or directory"

By default the MSYS environment variable is not defined, so the runtime
behavior of winsymlinks is: if <target> does not exist, 'ln -s' fails.
At the configure phase, the qemu-system-x86_64.exe has not been built
so creation of the symbolic link fails hence the error message.

Set winsymlinks to 'native' whose behavior is most similar to the
behavior of 'ln -s' on *nix, that is:

  a) if native symlinks are enabled, and whether <target> exists
     or not, creates <destination> as a native Windows symlink;
  b) else if native symlinks are not enabled, and whether <target>
     exists or not, 'ln -s' creates as a Windows shortcut file.

Signed-off-by: Bin Meng <bin.meng@windriver.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20220725123000.807608-1-bmeng.cn@gmail.com>
Message-Id: <20220725140520.515340-6-alex.bennee@linaro.org>


  Commit: aed04e6357fa10735c43574ea67a9551580d6e82
      
https://github.com/qemu/qemu/commit/aed04e6357fa10735c43574ea67a9551580d6e82
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2022-07-29 (Fri, 29 Jul 2022)

  Changed paths:
    M semihosting/console.c

  Log Message:
  -----------
  semihosting: Don't return negative values on qemu_semihosting_console_write() 
failure

The documentation comment for qemu_semihosting_console_write() says
 * Returns: number of bytes written -- this should only ever be short
 * on some sort of i/o error.

and the callsites rely on this.  However, the implementation code
path which sends console output to a chardev doesn't honour this,
and will return negative values on error.  Bring it into line with
the other implementation codepaths and the documentation, so that
it returns 0 on error.

Spotted by Coverity, because console_write() passes the return value
to unlock_user(), which doesn't accept a negative length.

Resolves: Coverity CID 1490288
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220719121110.225657-2-peter.maydell@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20220725140520.515340-7-alex.bennee@linaro.org>


  Commit: 45704e89047fc0a151c5909f006d8757140f23d6
      
https://github.com/qemu/qemu/commit/45704e89047fc0a151c5909f006d8757140f23d6
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2022-07-29 (Fri, 29 Jul 2022)

  Changed paths:
    M semihosting/syscalls.c

  Log Message:
  -----------
  semihosting: Don't copy buffer after console_write()

The console_write() semihosting function outputs guest data from a
buffer; it doesn't update that buffer.  It therefore doesn't need to
pass a length value to unlock_user(), but can pass 0, meaning "do not
copy any data back to the guest memory".

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220719121110.225657-3-peter.maydell@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20220725140520.515340-8-alex.bennee@linaro.org>


  Commit: fed49cdf6a721d76f9ac1cf76fd05b3fbd8b4892
      
https://github.com/qemu/qemu/commit/fed49cdf6a721d76f9ac1cf76fd05b3fbd8b4892
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2022-07-29 (Fri, 29 Jul 2022)

  Changed paths:
    M semihosting/arm-compat-semi.c

  Log Message:
  -----------
  semihosting: Check for errors on SET_ARG()

The SET_ARG() macro returns an error indication; we check this in the
TARGET_SYS_GET_CMDLINE case but not when we use it in implementing
TARGET_SYS_ELAPSED.  Check for and handle the errors via the do_fault
codepath, and update the comment documenting the SET_ARG() and
GET_ARG() macros to note how they handle memory access errors.

Resolves: Coverity CID 1490287
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220719121110.225657-4-peter.maydell@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20220725140520.515340-9-alex.bennee@linaro.org>


  Commit: 9b1268f55ceb0d9390a051cad299b3021dfa9896
      
https://github.com/qemu/qemu/commit/9b1268f55ceb0d9390a051cad299b3021dfa9896
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2022-07-29 (Fri, 29 Jul 2022)

  Changed paths:
    M semihosting/arm-compat-semi.c

  Log Message:
  -----------
  semihosting: Fix handling of buffer in TARGET_SYS_TMPNAM

The TARGET_SYS_TMPNAM implementation has two bugs spotted by
Coverity:
 * confusion about whether 'len' has the length of the string
   including or excluding the terminating NUL means we
   lock_user() len bytes of memory but memcpy() len + 1 bytes
 * In the error-exit cases we forget to free() the buffer
   that asprintf() returned to us

Resolves: Coverity CID 1490285, 1490289
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220719121110.225657-5-peter.maydell@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20220725140520.515340-10-alex.bennee@linaro.org>


  Commit: 0882caf4d607bcfb1efa99034f5f045f30eb43d7
      
https://github.com/qemu/qemu/commit/0882caf4d607bcfb1efa99034f5f045f30eb43d7
  Author: Ilya Leoshkevich <iii@linux.ibm.com>
  Date:   2022-07-29 (Fri, 29 Jul 2022)

  Changed paths:
    M include/sysemu/sysemu.h
    M qapi/run-state.json
    M qemu-options.hx
    M softmmu/main.c
    M softmmu/runstate.c

  Log Message:
  -----------
  qapi: Add exit-failure PanicAction

Currently QEMU exits with code 0 on both panic an shutdown. For tests
it is useful to return 1 on panic, so that it counts as a test
failure.

Introduce a new exit-failure PanicAction that makes main() return
EXIT_FAILURE. Tests can use -action panic=exit-failure option to
activate this behavior.

Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: David Hildenbrand <david@redhat.com>
Message-Id: <20220725223746.227063-2-iii@linux.ibm.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>


  Commit: 503e549e441e6f28eaf8a5ffd0edd3e1eba9cfec
      
https://github.com/qemu/qemu/commit/503e549e441e6f28eaf8a5ffd0edd3e1eba9cfec
  Author: Ilya Leoshkevich <iii@linux.ibm.com>
  Date:   2022-07-29 (Fri, 29 Jul 2022)

  Changed paths:
    A tests/tcg/s390x/Makefile.softmmu-target
    A tests/tcg/s390x/unaligned-lowcore.S

  Log Message:
  -----------
  tests/tcg/s390x: Test unaligned accesses to lowcore

Add a small test to avoid regressions.

Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Acked-by: Richard Henderson <richard.henderson@linaro.org>
Acked-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20220725223746.227063-3-iii@linux.ibm.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>


  Commit: 28053143ab865d5a5fae7d486cf68181d37dde72
      
https://github.com/qemu/qemu/commit/28053143ab865d5a5fae7d486cf68181d37dde72
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2022-07-29 (Fri, 29 Jul 2022)

  Changed paths:
    M docs/devel/qom.rst

  Log Message:
  -----------
  docs/devel: fix description of OBJECT_DECLARE_SIMPLE_TYPE

Since 30b5707c26 (qom: Remove module_obj_name parameter from
OBJECT_DECLARE* macros) we don't need the additional two parameters.
Fix the documentation.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20220725140520.515340-13-alex.bennee@linaro.org>


  Commit: 1235cf7d315b415fc2e4aa81815fda6ce96518c4
      
https://github.com/qemu/qemu/commit/1235cf7d315b415fc2e4aa81815fda6ce96518c4
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2022-07-29 (Fri, 29 Jul 2022)

  Changed paths:
    M qemu-options.hx

  Log Message:
  -----------
  qemu-options: bring the kernel and image options together

How to control the booting of QEMU is often a source of confusion for
users. Bring the options that control this together in the manual
pages and add some verbiage to describe when each option is
appropriate. This attempts to codify some of the knowledge expressed
in:

  
https://stackoverflow.com/questions/58420670/qemu-bios-vs-kernel-vs-device-loader-file/58434837#58434837

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Message-Id: <20220725140520.515340-14-alex.bennee@linaro.org>


  Commit: 0279d0e6b528ee9ab7f8f80b9dc2501708fb97a5
      
https://github.com/qemu/qemu/commit/0279d0e6b528ee9ab7f8f80b9dc2501708fb97a5
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2022-07-29 (Fri, 29 Jul 2022)

  Changed paths:
    M .cirrus.yml
    M .gitlab-ci.d/cirrus/build.yml
    M .gitlab-ci.d/cirrus/freebsd-12.vars
    M .gitlab-ci.d/cirrus/freebsd-13.vars
    M .gitlab-ci.d/cirrus/macos-11.vars
    M .gitlab-ci.d/container-cross.yml
    M .gitlab-ci.d/custom-runners/centos-stream-8-x86_64.yml
    M .gitlab-ci.d/custom-runners/ubuntu-20.04-aarch32.yml
    M .gitlab-ci.d/custom-runners/ubuntu-20.04-aarch64.yml
    M .gitlab-ci.d/custom-runners/ubuntu-20.04-s390x.yml
    M .gitlab-ci.d/stages.yml
    M .gitlab-ci.d/windows.yml
    M docs/devel/qom.rst
    M include/sysemu/sysemu.h
    M qapi/run-state.json
    M qemu-options.hx
    M semihosting/arm-compat-semi.c
    M semihosting/console.c
    M semihosting/syscalls.c
    M softmmu/main.c
    M softmmu/runstate.c
    M tests/docker/dockerfiles/alpine.docker
    M tests/docker/dockerfiles/centos8.docker
    M tests/docker/dockerfiles/debian-amd64.docker
    M tests/docker/dockerfiles/debian-arm64-cross.docker
    M tests/docker/dockerfiles/debian-armel-cross.docker
    M tests/docker/dockerfiles/debian-armhf-cross.docker
    M tests/docker/dockerfiles/debian-mips64el-cross.docker
    M tests/docker/dockerfiles/debian-mipsel-cross.docker
    M tests/docker/dockerfiles/debian-ppc64el-cross.docker
    M tests/docker/dockerfiles/debian-s390x-cross.docker
    M tests/docker/dockerfiles/fedora.docker
    M tests/docker/dockerfiles/opensuse-leap.docker
    M tests/docker/dockerfiles/ubuntu2004.docker
    M tests/lcitool/libvirt-ci
    M tests/lcitool/projects/qemu.yml
    M tests/lcitool/refresh
    A tests/tcg/s390x/Makefile.softmmu-target
    A tests/tcg/s390x/unaligned-lowcore.S

  Log Message:
  -----------
  Merge tag 'pull-testing-next-290722-1' of https://github.com/stsquad/qemu 
into staging

Testing, semihosting and doc fixes:

  - update to latest libvirt-ci
  - echo testlog.txt on failed cirrus runs
  - drop containers-layer2 stage
  - update handling of symlinks on windows builds
  - return 0 for failure of semihosting console write
  - don't copy unused buffer after semihost operation
  - check for errors in semihosting args
  - fix buffer handling for semihosting TMPNAM
  - add qapi exit-failure PanicAction
  - add lowcore unaligned access test to s390x
  - fix documentation of OBJECT_DECLARE_SIMPLE_TYPE
  - expand documentation on booting code

# -----BEGIN PGP SIGNATURE-----
#
# iQEzBAABCgAdFiEEZoWumedRZ7yvyN81+9DbCVqeKkQFAmLjoIQACgkQ+9DbCVqe
# KkSLyAf7Byt1jeIHCYYYqOPj8+Zx+kJXgWr59wMRSDFLwd0wWeFkgQhxriSlSUAl
# oVOTP8fkczeaMKPhp7CJnqpcQuZzD6iaK9hg/hNzKy0gTQbJgFRtTSP7c0E0iak5
# ZfDX5h+BRSAoeDo3I+ulj/bLKlj+KbxRWGf+y4K9rRGHKcTJUbcpkZ7aQlK5J6UD
# nqjkrvgnNWslxhdRSI6+2KPzkYaOmbiyPIVGOiBvmyv0N+NuazPvFMp2mFGH25kB
# XGsU5zxmm8IskxLGHHFvlwIM19SwB/2vArLtyaTVEPbLDhvdENePrPSL1Lr2BA/A
# yStVAvAnyy7Cdr8YmRCAGm3qnY61dg==
# =57ZK
# -----END PGP SIGNATURE-----
# gpg: Signature made Fri 29 Jul 2022 01:55:32 AM PDT
# gpg:                using RSA key 6685AE99E75167BCAFC8DF35FBD0DB095A9E2A44
# gpg: Good signature from "Alex Bennée (Master Work Key) 
<alex.bennee@linaro.org>" [undefined]
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg:          There is no indication that the signature belongs to the owner.
# Primary key fingerprint: 6685 AE99 E751 67BC AFC8  DF35 FBD0 DB09 5A9E 2A44

* tag 'pull-testing-next-290722-1' of https://github.com/stsquad/qemu:
  qemu-options: bring the kernel and image options together
  docs/devel: fix description of OBJECT_DECLARE_SIMPLE_TYPE
  tests/tcg/s390x: Test unaligned accesses to lowcore
  qapi: Add exit-failure PanicAction
  semihosting: Fix handling of buffer in TARGET_SYS_TMPNAM
  semihosting: Check for errors on SET_ARG()
  semihosting: Don't copy buffer after console_write()
  semihosting: Don't return negative values on qemu_semihosting_console_write() 
failure
  .gitlab-ci.d/windows.yml: Enable native Windows symlink
  .cirrus.yml: Change winsymlinks to 'native'
  gitlab: drop 'containers-layer2' stage
  gitlab: show testlog.txt contents when cirrus/custom-runner jobs fail
  tests: refresh to latest libvirt-ci module

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


Compare: https://github.com/qemu/qemu/compare/cc42559ab129...0279d0e6b528



reply via email to

[Prev in Thread] Current Thread [Next in Thread]