qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] bbb015: qga: treat get-guest-fsinfo as "best


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] bbb015: qga: treat get-guest-fsinfo as "best effort"
Date: Tue, 19 Jul 2022 09:14:46 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: bbb0151cf2e82489120a15df5e2eb9653312b0ec
      
https://github.com/qemu/qemu/commit/bbb0151cf2e82489120a15df5e2eb9653312b0ec
  Author: John Snow <jsnow@redhat.com>
  Date:   2022-07-18 (Mon, 18 Jul 2022)

  Changed paths:
    M qga/commands-posix.c

  Log Message:
  -----------
  qga: treat get-guest-fsinfo as "best effort"

In some container environments, there may be references to block devices
witnessable from a container through /proc/self/mountinfo that reference
devices we simply don't have access to in the container, and cannot
provide information about.

Instead of failing the entire fsinfo command, return stub information
for these failed lookups.

This allows test-qga to pass under docker tests, which are in turn used
by the CentOS VM tests.

Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20220708153503.18864-2-jsnow@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 1ab330eae5bc191ed165adc6937fba20ee767b56
      
https://github.com/qemu/qemu/commit/1ab330eae5bc191ed165adc6937fba20ee767b56
  Author: John Snow <jsnow@redhat.com>
  Date:   2022-07-18 (Mon, 18 Jul 2022)

  Changed paths:
    M tests/vm/centos

  Log Message:
  -----------
  tests/vm: use 'cp' instead of 'ln' for temporary vm images

If the initial setup fails, you've permanently altered the state of the
downloaded image in an unknowable way. Use 'cp' like our other test
setup scripts do.

Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220708153503.18864-3-jsnow@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 70457c60fea43f34ad10adc6bb60c73feff049f3
      
https://github.com/qemu/qemu/commit/70457c60fea43f34ad10adc6bb60c73feff049f3
  Author: John Snow <jsnow@redhat.com>
  Date:   2022-07-18 (Mon, 18 Jul 2022)

  Changed paths:
    M tests/vm/centos

  Log Message:
  -----------
  tests/vm: switch CentOS 8 to CentOS 8 Stream

The old CentOS image didn't work anymore because it was already EOL at
the beginning of 2022.

Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220708153503.18864-4-jsnow@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 5d8e7da891f60b0e46ff66a6fad3703d4ce2ba63
      
https://github.com/qemu/qemu/commit/5d8e7da891f60b0e46ff66a6fad3703d4ce2ba63
  Author: John Snow <jsnow@redhat.com>
  Date:   2022-07-18 (Mon, 18 Jul 2022)

  Changed paths:
    M tests/vm/centos.aarch64

  Log Message:
  -----------
  tests/vm: switch centos.aarch64 to CentOS 8 Stream

Switch this test over to using a cloud image like the base CentOS8 VM
test, which helps make this script a bit simpler too.

Note: At time of writing, this test seems pretty flaky when run without
KVM support for aarch64. Certain unit tests like migration-test,
virtio-net-failover, test-hmp and qom-test seem quite prone to fail
under TCG. Still, this is an improvement in that at least pure build
tests are functional.

Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220708153503.18864-5-jsnow@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 47f71f8912dadb6b1bc0d3015eb18253092bcc70
      
https://github.com/qemu/qemu/commit/47f71f8912dadb6b1bc0d3015eb18253092bcc70
  Author: John Snow <jsnow@redhat.com>
  Date:   2022-07-18 (Mon, 18 Jul 2022)

  Changed paths:
    M tests/vm/ubuntu.aarch64

  Log Message:
  -----------
  tests/vm: upgrade Ubuntu 18.04 VM to 20.04

18.04 has fallen out of our support window, so move ubuntu.aarch64
forward to ubuntu 20.04, which is now our oldest supported Ubuntu
release.

Notes:

This checksum changes periodically; use a fixed point image with a known
checksum so that the image isn't re-downloaded on every single
invocation. (The checksum for the 18.04 image was already incorrect at
the time of writing.)

Just like the centos.aarch64 test, this test currently seems very
flaky when run as a TCG test.

Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220708153503.18864-6-jsnow@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 5e658729b6e6f79cf3afac046f067459f4fcecb2
      
https://github.com/qemu/qemu/commit/5e658729b6e6f79cf3afac046f067459f4fcecb2
  Author: John Snow <jsnow@redhat.com>
  Date:   2022-07-18 (Mon, 18 Jul 2022)

  Changed paths:
    M tests/vm/Makefile.include
    R tests/vm/ubuntu.i386

  Log Message:
  -----------
  tests/vm: remove ubuntu.i386 VM test

Ubuntu 18.04 is out of our support window, and Ubuntu 20.04 does not
support i386 anymore. The debian project does, but they do not provide
any cloud images for it, a new expect-style script would have to be
written.

Since we have i386 cross-compiler tests hosted on GitLab CI, we don't
need to support this VM test anymore.

Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220708153503.18864-7-jsnow@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: b967bf134581214280540b2aec1161cee6543f83
      
https://github.com/qemu/qemu/commit/b967bf134581214280540b2aec1161cee6543f83
  Author: John Snow <jsnow@redhat.com>
  Date:   2022-07-18 (Mon, 18 Jul 2022)

  Changed paths:
    M tests/vm/Makefile.include

  Log Message:
  -----------
  tests/vm: remove duplicate 'centos' VM test

This is listed twice by accident; we require genisoimage to run the
test, so remove the unconditional entry.

Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220708153503.18864-8-jsnow@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: eaf46a65ab41b120a07204bedccadf1844c73009
      
https://github.com/qemu/qemu/commit/eaf46a65ab41b120a07204bedccadf1844c73009
  Author: John Snow <jsnow@redhat.com>
  Date:   2022-07-18 (Mon, 18 Jul 2022)

  Changed paths:
    M tests/vm/basevm.py

  Log Message:
  -----------
  tests/vm: add 1GB extra memory per core

If you try to run a 16 or 32 threaded test, you're going to run out of
memory very quickly with qom-test and a few others. Bump the memory
limit to try to scale with larger-core machines.

Granted, this means that a 16 core processor is going to ask for 16GB,
but you *probably* meet that requirement if you have such a machine.

512MB per core didn't seem to be enough to avoid ENOMEM and SIGABRTs in
the test cases in practice on a six core machine; so I bumped it up to
1GB which seemed to help.

Add this magic in early to the configuration process so that the
config file, if provided, can still override it.

Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Acked-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220708153503.18864-9-jsnow@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 28a48ed5f7bdbddb6955f732402ca9f51e56b23a
      
https://github.com/qemu/qemu/commit/28a48ed5f7bdbddb6955f732402ca9f51e56b23a
  Author: John Snow <jsnow@redhat.com>
  Date:   2022-07-18 (Mon, 18 Jul 2022)

  Changed paths:
    M tests/vm/centos

  Log Message:
  -----------
  tests/vm: Remove docker cross-compile test from CentOS VM

The fedora container has since been split apart, so there's no suitable
nearby target that would support "test-mingw" as it requires both x32
and x64 support -- so either fedora-cross-win32 nor fedora-cross-win64
would be truly suitable.

Just remove this test as superfluous with our current CI infrastructure.

Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220708153503.18864-10-jsnow@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: e18f27d9ed6132b774910e6ce6999cfc59822e67
      
https://github.com/qemu/qemu/commit/e18f27d9ed6132b774910e6ce6999cfc59822e67
  Author: Song Gao <gaosong@loongson.cn>
  Date:   2022-07-18 (Mon, 18 Jul 2022)

  Changed paths:
    M tests/qtest/machine-none-test.c

  Log Message:
  -----------
  qtest/machine-none: Add LoongArch support

Update the cpu_maps[] to support the LoongArch target.

Signed-off-by: Song Gao <gaosong@loongson.cn>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220713020258.601424-1-gaosong@loongson.cn>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: c4f8ce24de81162d925ca24db8adb194b47fffb8
      
https://github.com/qemu/qemu/commit/c4f8ce24de81162d925ca24db8adb194b47fffb8
  Author: Philippe Mathieu-Daudé <philmd@redhat.com>
  Date:   2022-07-18 (Mon, 18 Jul 2022)

  Changed paths:
    M tests/unit/ptimer-test.c
    M tests/unit/test-iov.c

  Log Message:
  -----------
  tests/unit: Replace g_memdup() by g_memdup2()

Per 
https://discourse.gnome.org/t/port-your-module-from-g-memdup-to-g-memdup2-now/5538

  The old API took the size of the memory to duplicate as a guint,
  whereas most memory functions take memory sizes as a gsize. This
  made it easy to accidentally pass a gsize to g_memdup(). For large
  values, that would lead to a silent truncation of the size from 64
  to 32 bits, and result in a heap area being returned which is
  significantly smaller than what the caller expects. This can likely
  be exploited in various modules to cause a heap buffer overflow.

Replace g_memdup() by the safer g_memdup2() wrapper.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20210903174510.751630-24-philmd@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 2d2e4843b641f53c8016978f73675da7b66136fb
      
https://github.com/qemu/qemu/commit/2d2e4843b641f53c8016978f73675da7b66136fb
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2022-07-18 (Mon, 18 Jul 2022)

  Changed paths:
    M docs/devel/submitting-a-patch.rst
    M docs/tools/qemu-nbd.rst
    M scripts/vmstate-static-checker.py

  Log Message:
  -----------
  Replace 'whitelist' with 'allow'

Let's use more inclusive language here and avoid terms
that are frowned upon nowadays.

Message-Id: <20220711095300.60462-1-thuth@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 0a979a1320a4ea10c6a26c0d133a147fee5b5ecf
      
https://github.com/qemu/qemu/commit/0a979a1320a4ea10c6a26c0d133a147fee5b5ecf
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2022-07-18 (Mon, 18 Jul 2022)

  Changed paths:
    M util/cutils.c
    M util/oslib-posix.c

  Log Message:
  -----------
  util: Fix broken build on Haiku

A recent commit moved some Haiku-specific code parts from oslib-posix.c
to cutils.c, but failed to move the corresponding header #include
statement, too, so "make vm-build-haiku.x86_64" is currently broken.
Fix it by moving the header #include, too.

Fixes: 06680b15b4 ("include: move qemu_*_exec_dir() to cutils")
Message-Id: <20220718172026.139004-1-thuth@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 9b0ecfaba5920ddf8601d7b31746a428aa3779c6
      
https://github.com/qemu/qemu/commit/9b0ecfaba5920ddf8601d7b31746a428aa3779c6
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2022-07-18 (Mon, 18 Jul 2022)

  Changed paths:
    M python/qemu/qmp/legacy.py

  Log Message:
  -----------
  python/qemu/qmp/legacy: Replace 'returns-whitelist' with the correct type

'returns-whitelist' has been renamed to 'command-returns-exceptions' in
commit b86df3747848 ("qapi: Rename pragma *-whitelist to *-exceptions").

Message-Id: <20220711095721.61280-1-thuth@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: da7da9d5e608200ecc0749ff37be246e9cd3314f
      
https://github.com/qemu/qemu/commit/da7da9d5e608200ecc0749ff37be246e9cd3314f
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2022-07-19 (Tue, 19 Jul 2022)

  Changed paths:
    M docs/devel/submitting-a-patch.rst
    M docs/tools/qemu-nbd.rst
    M python/qemu/qmp/legacy.py
    M qga/commands-posix.c
    M scripts/vmstate-static-checker.py
    M tests/qtest/machine-none-test.c
    M tests/unit/ptimer-test.c
    M tests/unit/test-iov.c
    M tests/vm/Makefile.include
    M tests/vm/basevm.py
    M tests/vm/centos
    M tests/vm/centos.aarch64
    M tests/vm/ubuntu.aarch64
    R tests/vm/ubuntu.i386
    M util/cutils.c
    M util/oslib-posix.c

  Log Message:
  -----------
  Merge tag 'pull-request-2022-07-19' of https://gitlab.com/thuth/qemu into 
staging

* Clean up tests/vm (remove obsolte VMs, upgrade Ubuntu 18.04 to 20.04 etc.)
* Fix broken build on Haiku
* Replace the term 'whitelist' in some files with a better one
* Some other minor test related fixes

# gpg: Signature made Tue 19 Jul 2022 07:55:26 BST
# gpg:                using RSA key 27B88847EEE0250118F3EAB92ED9D774FE702DB5
# gpg:                issuer "thuth@redhat.com"
# gpg: Good signature from "Thomas Huth <th.huth@gmx.de>" [full]
# gpg:                 aka "Thomas Huth <thuth@redhat.com>" [full]
# gpg:                 aka "Thomas Huth <huth@tuxfamily.org>" [full]
# gpg:                 aka "Thomas Huth <th.huth@posteo.de>" [unknown]
# Primary key fingerprint: 27B8 8847 EEE0 2501 18F3  EAB9 2ED9 D774 FE70 2DB5

* tag 'pull-request-2022-07-19' of https://gitlab.com/thuth/qemu:
  python/qemu/qmp/legacy: Replace 'returns-whitelist' with the correct type
  util: Fix broken build on Haiku
  Replace 'whitelist' with 'allow'
  tests/unit: Replace g_memdup() by g_memdup2()
  qtest/machine-none: Add LoongArch support
  tests/vm: Remove docker cross-compile test from CentOS VM
  tests/vm: add 1GB extra memory per core
  tests/vm: remove duplicate 'centos' VM test
  tests/vm: remove ubuntu.i386 VM test
  tests/vm: upgrade Ubuntu 18.04 VM to 20.04
  tests/vm: switch centos.aarch64 to CentOS 8 Stream
  tests/vm: switch CentOS 8 to CentOS 8 Stream
  tests/vm: use 'cp' instead of 'ln' for temporary vm images
  qga: treat get-guest-fsinfo as "best effort"

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/f9d9fff72eed...da7da9d5e608



reply via email to

[Prev in Thread] Current Thread [Next in Thread]