[Qemu-commits] [qemu/qemu] d8cf2c: hvf: Enable RDTSCP support

[Peter Maydell]

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: d8cf2c29cc1077cd8f8ab0580b285bff92f09d1c
      
https://github.com/qemu/qemu/commit/d8cf2c29cc1077cd8f8ab0580b285bff92f09d1c
  Author: Cameron Esfahani <dirty@apple.com>
  Date:   2022-07-13 (Wed, 13 Jul 2022)

  Changed paths:
    M target/i386/hvf/hvf.c
    M target/i386/hvf/vmcs.h
    M target/i386/hvf/x86_cpuid.c

  Log Message:
  -----------
  hvf: Enable RDTSCP support

Pass through RDPID and RDTSCP support in CPUID if host supports it.
Correctly detect if CPU_BASED_TSC_OFFSET and CPU_BASED2_RDTSCP would
be supported in primary and secondary processor-based VM-execution
controls.  Enable RDTSCP in secondary processor controls if RDTSCP
support is indicated in CPUID.

Signed-off-by: Cameron Esfahani <dirty@apple.com>
Message-Id: <20220214185605.28087-7-f4bug@amsat.org>
Tested-by: Silvio Moioli <moio@suse.com>
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1011
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


  Commit: 7630156d347646cc310a911bce02ca7b6a018f2a
      
https://github.com/qemu/qemu/commit/7630156d347646cc310a911bce02ca7b6a018f2a
  Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
  Date:   2022-07-13 (Wed, 13 Jul 2022)

  Changed paths:
    M .gitlab-ci.d/buildtest.yml
    M configure

  Log Message:
  -----------
  configure: Restrict TCG to emulation

If we don't need to emulate any target, we certainly don't need TCG.

This should also help to compile again with
 ".../configure --enable-tools --disable-system --disable-user"
on systems that do not have a TCG backend.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
[thuth: Re-arranged the code, remove check-softfloat from buildtest.yml]
Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220706153816.768143-1-thuth@redhat.com>


  Commit: 713911a10752642564ff9b7c9c0bd1a5498105a5
      
https://github.com/qemu/qemu/commit/713911a10752642564ff9b7c9c0bd1a5498105a5
  Author: Peter Delevoryas <peter@pjd.dev>
  Date:   2022-07-13 (Wed, 13 Jul 2022)

  Changed paths:
    M ui/cocoa.m

  Log Message:
  -----------
  ui/cocoa: Fix switched_to_fullscreen warning

I noticed this error while building QEMU on Mac OS X:

    [1040/1660] Compiling Objective-C object libcommon.fa.p/ui_cocoa.m.o
    ../ui/cocoa.m:803:17: warning: variable 'switched_to_fullscreen' set but 
not used [-Wunused-but-set-variable]
        static bool switched_to_fullscreen = false;
                    ^
    1 warning generated.

I think the behavior is fine if you remove "switched_to_fullscreen", I can
still switch in and out of mouse grabbed mode and fullscreen mode with this
change, and Command keycodes will only be passed to the guest if the mouse
is grabbed, which I think is the right behavior. I'm not sure why a static
piece of state was needed to handle that in the first place. Perhaps the
refactoring of the flags-state-change fixed that by toggling the Command
keycode on.

I tested this with an Ubuntu core image on macOS 12.4

    wget 
https://cdimage.ubuntu.com/ubuntu-core/18/stable/current/ubuntu-core-18-i386.img.xz
    xz -d ubuntu-core-18-i386.img.xz
    qemu-system-x86_64 -drive file=ubuntu-core-18.i386.img,format=raw

Fixes: 6d73bb643aa7 ("ui/cocoa: Clear modifiers whenever possible")
Signed-off-by: Peter Delevoryas <peter@pjd.dev>
Reviewed-by: Akihiko Odaki <akihiko.odaki@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20220702044304.90553-1-peter@pjd.dev>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


  Commit: 52eaefd36c33d17c5c52de0d02f1edf7400c0abb
      
https://github.com/qemu/qemu/commit/52eaefd36c33d17c5c52de0d02f1edf7400c0abb
  Author: Akihiko Odaki <akihiko.odaki@gmail.com>
  Date:   2022-07-13 (Wed, 13 Jul 2022)

  Changed paths:
    M meson.build
    M ui/cocoa.m

  Log Message:
  -----------
  ui/cocoa: Take refresh rate into account

Retrieve the refresh rate of the display and reflect it with
dpy_set_ui_info() and update_displaychangelistener(), allowing the
guest and DisplayChangeListener to consume the information.

The information will be used as a hint how often the display should
be updated. For example, when we run 30 Hz physical display updates
it is pointless for the guest to update the screen at 60Hz
frequency, the guest can spare some work instead.

Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20220702142519.12188-1-akihiko.odaki@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


  Commit: 50b13d31f4cc6c70330cc3a92561a581fc176ec9
      
https://github.com/qemu/qemu/commit/50b13d31f4cc6c70330cc3a92561a581fc176ec9
  Author: Peter Delevoryas <peter@pjd.dev>
  Date:   2022-07-13 (Wed, 13 Jul 2022)

  Changed paths:
    M tests/avocado/avocado_qemu/__init__.py

  Log Message:
  -----------
  avocado: Fix BUILD_DIR if it's equal to SOURCE_DIR

I like to build QEMU from the root source directory [*], rather
than cd'ing into the build directory. This code may as well include
a search path for that, so that you can run avocado tests individually
without specifying "-p qemu_bin=build/qemu-system-arm" manually.

[*] See commit dedad02720 ("configure: add support for pseudo-"in source tree" 
builds")

Signed-off-by: Peter Delevoryas <peter@pjd.dev>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20220702185604.46643-1-peter@pjd.dev>
[PMD: Mention commit dedad02720]
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


  Commit: 08c9f7eec7002dac2da52c8265eb319aba381c86
      
https://github.com/qemu/qemu/commit/08c9f7eec7002dac2da52c8265eb319aba381c86
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2022-07-14 (Thu, 14 Jul 2022)

  Changed paths:
    M .gitlab-ci.d/buildtest.yml
    M configure
    M meson.build
    M target/i386/hvf/hvf.c
    M target/i386/hvf/vmcs.h
    M target/i386/hvf/x86_cpuid.c
    M tests/avocado/avocado_qemu/__init__.py
    M ui/cocoa.m

  Log Message:
  -----------
  Merge tag 'darwin-20220712' of https://github.com/philmd/qemu into staging

Darwin patches:

- Enable RDTSCP support on HVF
- ui/cocoa: Take refresh rate into account

Few buildsys fixes:

- Restrict TCG to emulation
- Remove a unused-but-set-variable warning
- Allow running Avocado from pseudo-"in source tree" builds

# gpg: Signature made Tue 12 Jul 2022 23:14:37 BST
# gpg:                using RSA key FAABE75E12917221DCFD6BB2E3E32C2CDEADC0DE
# gpg: Good signature from "Philippe Mathieu-Daudé (F4BUG) <f4bug@amsat.org>" 
[full]
# Primary key fingerprint: FAAB E75E 1291 7221 DCFD  6BB2 E3E3 2C2C DEAD C0DE

* tag 'darwin-20220712' of https://github.com/philmd/qemu:
  avocado: Fix BUILD_DIR if it's equal to SOURCE_DIR
  ui/cocoa: Take refresh rate into account
  ui/cocoa: Fix switched_to_fullscreen warning
  configure: Restrict TCG to emulation
  hvf: Enable RDTSCP support

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/455c62d85f72...08c9f7eec700