qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] e4e68c: gitlab-ci: Switch the container of th


From: Richard Henderson
Subject: [Qemu-commits] [qemu/qemu] e4e68c: gitlab-ci: Switch the container of the 'check-patc...
Date: Wed, 18 May 2022 07:17:00 -0700

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: e4e68c31db5472111fbff528d7348a7e6b2ae07d
      
https://github.com/qemu/qemu/commit/e4e68c31db5472111fbff528d7348a7e6b2ae07d
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2022-05-18 (Wed, 18 May 2022)

  Changed paths:
    M .gitlab-ci.d/static_checks.yml

  Log Message:
  -----------
  gitlab-ci: Switch the container of the 'check-patch' & 'check-dco' jobs

The 'check-patch' and 'check-dco' jobs only need Python and git for
checking the patches, so it's not really necessary to use a container
here that has all the other build dependencies installed. By using a
lightweight Alpine container, we can improve the runtime here quite a
bit, cutting it down from ca. 1:30 minutes to ca. 45 seconds.

Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220516082310.33876-1-thuth@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: f3f0cbaf97c78b1fc1f3855f576e46ea6ad4f34c
      
https://github.com/qemu/qemu/commit/f3f0cbaf97c78b1fc1f3855f576e46ea6ad4f34c
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2022-05-18 (Wed, 18 May 2022)

  Changed paths:
    M .gitlab-ci.d/containers.yml
    M .gitlab-ci.d/custom-runners/ubuntu-20.04-aarch32.yml
    M .gitlab-ci.d/custom-runners/ubuntu-20.04-aarch64.yml
    M scripts/ci/setup/build-environment.yml
    R tests/docker/dockerfiles/ubuntu1804.docker
    M tests/lcitool/refresh

  Log Message:
  -----------
  Remove Ubuntu 18.04 container support from the repository

According to our "Supported build platforms" policy, we now do not support
Ubuntu 18.04 anymore. Remove the related container files and entries from
our CI.

Message-Id: <20220516115912.120951-1-thuth@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 83f79d4efc8dac7e511bc4375d0f9d90ff9db731
      
https://github.com/qemu/qemu/commit/83f79d4efc8dac7e511bc4375d0f9d90ff9db731
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2022-05-18 (Wed, 18 May 2022)

  Changed paths:
    M tests/qtest/libqtest.c

  Log Message:
  -----------
  tests/qtest: fix registration of ABRT handler for QEMU cleanup

qtest_init registers a hook to cleanup the running QEMU process
should g_assert() fire before qtest_quit is called. When the first
hook is registered, it is supposed to triggere registration of the
SIGABRT handler. Unfortunately the logic in hook_list_is_empty is
inverted, so the SIGABRT handler never gets registered, unless
2 or more QEMU processes are run concurrently. This caused qtest
to leak QEMU processes anytime g_assert triggers.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220513154906.206715-2-berrange@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 6cbde91a27587ca27a3c1979fe7f5f0d28eb6db9
      
https://github.com/qemu/qemu/commit/6cbde91a27587ca27a3c1979fe7f5f0d28eb6db9
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2022-05-18 (Wed, 18 May 2022)

  Changed paths:
    M tests/qtest/libqtest.c

  Log Message:
  -----------
  tests/qtest: use prctl(PR_SET_PDEATHSIG) as fallback to kill QEMU

Although we register a ABRT handler to kill off QEMU when g_assert()
triggers, we want an extra safety net. The QEMU process might be
non-functional and thus not have responded to SIGTERM. The test script
might also have crashed with SEGV, in which case the cleanup handlers
won't ever run.

Using the Linux specific prctl(PR_SET_PDEATHSIG) syscall, we
can ensure that QEMU gets sent SIGKILL as soon as the controlling
qtest exits, if nothing else has correctly told it to quit.

Note, technically the death signal is sent when the *thread* that
called fork() exits. IOW, if you are calling qtest_init() in one
thread, letting that thread exit, and then expecting to run
qtest_quit() in a different thread, things are not going to work
out. Fortunately that is not a scenario that exists in qtests,
as pairs of qtest_init and qtest_quit are always called from the
same thread.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220513154906.206715-3-berrange@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 0ce9b08c10d043307d125709032a897d05c80bdd
      
https://github.com/qemu/qemu/commit/0ce9b08c10d043307d125709032a897d05c80bdd
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2022-05-18 (Wed, 18 May 2022)

  Changed paths:
    M configure
    M docs/about/build-platforms.rst
    M include/qemu/osdep.h

  Log Message:
  -----------
  docs/about: Update the support statement for Windows

Our support statement for Windows currently talks about "Vista / Server
2008" - which is related to the API of Windows, and this is not easy
to understand for the non-technical users. Additionally, glib sets the
_WIN32_WINNT macro to 0x0601 already, which indicates the Windows 7 API,
so QEMU effectively depends on the Windows 7 API, too.

Thus let's bump the _WIN32_WINNT setting in QEMU to the same level as
glib uses and adjust our support statement in the documentation to
something similar that we're using for Linux and the *BSD systems
(i.e. only the two most recent versions), which should hopefully be
easier to understand for the users now.

And since we're nowadays also compile-testing QEMU with MSYS2 on Windows
itself, I think we could mention this build environment here, too.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/880
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Stefan Weil <sw@weilnetz.de>
Message-Id: <20220513063958.1181443-1-thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 28e7e95e6bc374262a3f03cf7b6fb7a1b3c3ebbe
      
https://github.com/qemu/qemu/commit/28e7e95e6bc374262a3f03cf7b6fb7a1b3c3ebbe
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2022-05-18 (Wed, 18 May 2022)

  Changed paths:
    M tests/vm/netbsd
    M tests/vm/openbsd

  Log Message:
  -----------
  tests/vm: Add capstone to the NetBSD and OpenBSD VMs

The Capstone library that is shipped with NetBSD and OpenBSD works
fine when compiling QEMU, so let's enable this in our build-test
VMs to get a little bit more build-test coverage.

Message-Id: <20220516145823.148450-2-thuth@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 43ecd16678b74b281c3cc7de0dd62a36279b6025
      
https://github.com/qemu/qemu/commit/43ecd16678b74b281c3cc7de0dd62a36279b6025
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2022-05-18 (Wed, 18 May 2022)

  Changed paths:
    M .gitlab-ci.d/buildtest.yml
    M meson.build

  Log Message:
  -----------
  capstone: Allow version 3.0.5 again

According to

 
https://lore.kernel.org/qemu-devel/20200921174118.39352-1-richard.henderson@linaro.org/

there was an issue with Capstone 3.0.4 from Ubuntu 18, which was the reason
for bumping our minimum Capstone requirement to version 4.0. And indeed,
compiling with that version 3.0.4 from Ubuntu 18.04 still fails (after
allowing it with a hack in meson.build). But now that we've dropped support
for Ubuntu 18.04, that issue is not relevant anymore. Compiling with Capstone
version 3.0.5 (e.g. used in Ubuntu 20.04) seems to work fine, so let's allow
that version again.

Message-Id: <20220516145823.148450-3-thuth@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 83602083b4ada6ceb86bfb327e83556ebab120fc
      
https://github.com/qemu/qemu/commit/83602083b4ada6ceb86bfb327e83556ebab120fc
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2022-05-18 (Wed, 18 May 2022)

  Changed paths:
    M .gitlab-ci.d/buildtest.yml
    M .gitlab-ci.d/windows.yml
    M .gitmodules
    R capstone
    M configure
    M meson.build
    M meson_options.txt
    M scripts/meson-buildoptions.sh

  Log Message:
  -----------
  capstone: Remove the capstone submodule

Now that we allow compiling with Capstone v3.0.5 again, all our supported
build hosts should provide at least this version of the disassembler
library, so we do not need to ship this as a submodule anymore.

Message-Id: <20220516145823.148450-4-thuth@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 3e30dd87c9ad134d0b8abb8af00f596fb161707f
      
https://github.com/qemu/qemu/commit/3e30dd87c9ad134d0b8abb8af00f596fb161707f
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2022-05-18 (Wed, 18 May 2022)

  Changed paths:
    M .gitlab-ci.d/buildtest.yml
    M .gitlab-ci.d/containers.yml
    M .gitlab-ci.d/custom-runners/ubuntu-20.04-aarch32.yml
    M .gitlab-ci.d/custom-runners/ubuntu-20.04-aarch64.yml
    M .gitlab-ci.d/static_checks.yml
    M .gitlab-ci.d/windows.yml
    M .gitmodules
    R capstone
    M configure
    M docs/about/build-platforms.rst
    M include/qemu/osdep.h
    M meson.build
    M meson_options.txt
    M scripts/ci/setup/build-environment.yml
    M scripts/meson-buildoptions.sh
    R tests/docker/dockerfiles/ubuntu1804.docker
    M tests/lcitool/refresh
    M tests/qtest/libqtest.c
    M tests/vm/netbsd
    M tests/vm/openbsd

  Log Message:
  -----------
  Merge tag 'pull-request-2022-05-18' of https://gitlab.com/thuth/qemu into 
staging

* Remove Ubuntu 18.04 containers (not supported anymore)
* Improve the cleanup of the QEMU binary in case of failing qtests
* Update the Windows support statement
* Remove the capstone submodule (and rely on Capstone of the distros instead)

# -----BEGIN PGP SIGNATURE-----
#
# iQJFBAABCAAvFiEEJ7iIR+7gJQEY8+q5LtnXdP5wLbUFAmKEovQRHHRodXRoQHJl
# ZGhhdC5jb20ACgkQLtnXdP5wLbXXtxAAsjL2M/kUcr1KBSfkaMhTa0D3OKPQ+p/e
# Bac/9+l7UhZZLLffzg53lSsCmlj9cSr5cVUkooT7IFS03wauH7ZJ/wuefIS8IYED
# jREmeMWXmVTTfQo4QQZ+6T+XknG2DWjzXQ3sNat71LH4RbHXO5um3zYIdDUaujP+
# v4sAKKH+F/FUsEXMP1rFmZpkaWOcvsuSwP/H4kEfhlovebAZINPow26eYYRrTM2t
# Ifs7HelO12TlmqlBFn0UzHj8bV8MZkqcjj0efocVzuYMQ8DVcxE7IPc3tft2PuUu
# Ia+Czh1hLsLA1zYiO/nN9bVIIewFGOErASzjlYWUlQwNRc1nLik+m+p4Cl9WOEhL
# JpkN/yY3pTI5uC6a4KgxDQGTeFUR4D5la6Hg7yQjQbTBMEeGFCV50iOdkItdnRBx
# ByReVctXS3oIhsDqHMb8qydlBkPp5pUrAXdj43IBCUb3UsrHmCxH+z8U5BhHvv4D
# OleykLKyMcuff6HcEpC1fBQNIFJX5uS69EtAXYtyo2kb5zAJWezCv65UPldAZJCT
# kRT4beueQ+d5t+4LZn1qNePdoyeFArdCLlOqg/3Fx08kM5eEv22pSQhOtWclE7U3
# tgorikFybClvKJ+YnXBAxD7oFKe+h9L+RYCFOgoTebrbMX54IjjJfeo2DydhHTt7
# IaJnsI+vvAA=
# =z6e9
# -----END PGP SIGNATURE-----
# gpg: Signature made Wed 18 May 2022 12:40:36 AM PDT
# gpg:                using RSA key 27B88847EEE0250118F3EAB92ED9D774FE702DB5
# gpg:                issuer "thuth@redhat.com"
# gpg: Good signature from "Thomas Huth <th.huth@gmx.de>" [undefined]
# gpg:                 aka "Thomas Huth <thuth@redhat.com>" [undefined]
# gpg:                 aka "Thomas Huth <th.huth@posteo.de>" [unknown]
# gpg:                 aka "Thomas Huth <huth@tuxfamily.org>" [undefined]
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg:          There is no indication that the signature belongs to the owner.
# Primary key fingerprint: 27B8 8847 EEE0 2501 18F3  EAB9 2ED9 D774 FE70 2DB5

* tag 'pull-request-2022-05-18' of https://gitlab.com/thuth/qemu:
  capstone: Remove the capstone submodule
  capstone: Allow version 3.0.5 again
  tests/vm: Add capstone to the NetBSD and OpenBSD VMs
  docs/about: Update the support statement for Windows
  tests/qtest: use prctl(PR_SET_PDEATHSIG) as fallback to kill QEMU
  tests/qtest: fix registration of ABRT handler for QEMU cleanup
  Remove Ubuntu 18.04 container support from the repository
  gitlab-ci: Switch the container of the 'check-patch' & 'check-dco' jobs

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


Compare: https://github.com/qemu/qemu/compare/bcf0a3a422cd...3e30dd87c9ad



reply via email to

[Prev in Thread] Current Thread [Next in Thread]