qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] db67a6: target/s390x: Fix writeback to v1 in


From: Richard Henderson
Subject: [Qemu-commits] [qemu/qemu] db67a6: target/s390x: Fix writeback to v1 in helper_vstl
Date: Wed, 04 May 2022 13:43:22 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: db67a6ff480b346b1415b983f9582028cf8e18f0
      
https://github.com/qemu/qemu/commit/db67a6ff480b346b1415b983f9582028cf8e18f0
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2022-05-04 (Wed, 04 May 2022)

  Changed paths:
    M target/s390x/tcg/vec_helper.c

  Log Message:
  -----------
  target/s390x: Fix writeback to v1 in helper_vstl

Fixes: 0e0a5b49ad58 ("s390x/tcg: Implement VECTOR STORE WITH LENGTH")
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: David Hildenbrand <david@redhat.com>
Tested-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: David Miller <dmiller423@gmail.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Message-Id: <20220428094708.84835-2-david@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 4756b106b372e525365c62b41df38052571c0a71
      
https://github.com/qemu/qemu/commit/4756b106b372e525365c62b41df38052571c0a71
  Author: David Hildenbrand <david@redhat.com>
  Date:   2022-05-04 (Wed, 04 May 2022)

  Changed paths:
    M target/s390x/gen-features.c

  Log Message:
  -----------
  s390x/cpu_models: drop "msa5" from the TCG "max" model

We don't include the "msa5" feature in the "qemu" model because it
generates a warning. The PoP states:

"The message-security-assist extension 5 requires
the secure-hash-algorithm (SHA-512) capabilities of
the message-security-assist extension 2 as a prereq-
uisite. (March, 2015)"

As SHA-512 won't be supported in the near future, let's just drop the
feature from the "max" model. This avoids the warning and allows us for
making the "max" model match the "qemu" model (except for compat
machines). We don't lose much, as we only implement the function stubs
for MSA, excluding any real subfunctions.

Signed-off-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/897
Message-Id: <20220428094708.84835-3-david@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: d98ed7d96e2951b5e5c92b0f1de9aa2e58889019
      
https://github.com/qemu/qemu/commit/d98ed7d96e2951b5e5c92b0f1de9aa2e58889019
  Author: David Hildenbrand <david@redhat.com>
  Date:   2022-05-04 (Wed, 04 May 2022)

  Changed paths:
    M target/s390x/cpu_models.c
    M target/s390x/gen-features.c

  Log Message:
  -----------
  s390x/cpu_models: make "max" match the unmodified "qemu" CPU model under TCG

Before we were able to bump up the qemu CPU model to a z13, we included
some experimental features during development in the "max" model only.
Nowadays, the "max" model corresponds exactly to the "qemu" CPU model
of the latest QEMU machine under TCG.

Let's remove all the special casing, effectively making both models
match completely from now on, and clean up.

Signed-off-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220428094708.84835-4-david@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 46be8425fff0cc7f86ee7e1102aa3451fdae9ec8
      
https://github.com/qemu/qemu/commit/46be8425fff0cc7f86ee7e1102aa3451fdae9ec8
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2022-05-04 (Wed, 04 May 2022)

  Changed paths:
    M include/tcg/tcg-op.h
    M tcg/tcg-op.c

  Log Message:
  -----------
  tcg: Implement tcg_gen_{h,w}swap_{i32,i64}

Swap half-words (16-bit) and words (32-bit) within a larger value.
Mirrors functions of the same names within include/qemu/bitops.h.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: David Hildenbrand <david@redhat.com>
Reviewed-by: David Miller <dmiller423@gmail.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Message-Id: <20220428094708.84835-5-david@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: acc2d3a4064d54339f8e2b2e0c5741ba5c4b6924
      
https://github.com/qemu/qemu/commit/acc2d3a4064d54339f8e2b2e0c5741ba5c4b6924
  Author: David Miller <dmiller423@gmail.com>
  Date:   2022-05-04 (Wed, 04 May 2022)

  Changed paths:
    M target/s390x/helper.h
    M target/s390x/tcg/translate_vx.c.inc
    M target/s390x/tcg/vec_fpu_helper.c

  Log Message:
  -----------
  target/s390x: vxeh2: vector convert short/32b

Signed-off-by: David Miller <dmiller423@gmail.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: David Hildenbrand <david@redhat.com>
Tested-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Message-Id: <20220428094708.84835-6-david@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 1d706f31419192b3103f0c65bf53fe1e08f780ea
      
https://github.com/qemu/qemu/commit/1d706f31419192b3103f0c65bf53fe1e08f780ea
  Author: David Miller <dmiller423@gmail.com>
  Date:   2022-05-04 (Wed, 04 May 2022)

  Changed paths:
    M target/s390x/helper.h
    M target/s390x/tcg/insn-data.def
    M target/s390x/tcg/translate.c
    M target/s390x/tcg/translate_vx.c.inc
    M target/s390x/tcg/vec_string_helper.c

  Log Message:
  -----------
  target/s390x: vxeh2: vector string search

Signed-off-by: David Miller <dmiller423@gmail.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: David Hildenbrand <david@redhat.com>
Tested-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Message-Id: <20220428094708.84835-7-david@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: b7a50eb7d665f2bb77cbae54461be2f16938dece
      
https://github.com/qemu/qemu/commit/b7a50eb7d665f2bb77cbae54461be2f16938dece
  Author: David Miller <dmiller423@gmail.com>
  Date:   2022-05-04 (Wed, 04 May 2022)

  Changed paths:
    M target/s390x/helper.h
    M target/s390x/tcg/insn-data.def
    M target/s390x/tcg/translate_vx.c.inc
    M target/s390x/tcg/vec_int_helper.c

  Log Message:
  -----------
  target/s390x: vxeh2: Update for changes to vector shifts

Signed-off-by: David Miller <dmiller423@gmail.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: David Hildenbrand <david@redhat.com>
Tested-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Message-Id: <20220428094708.84835-8-david@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: ed9ce869521f90ad1104389873f5382bc6ccb461
      
https://github.com/qemu/qemu/commit/ed9ce869521f90ad1104389873f5382bc6ccb461
  Author: David Miller <dmiller423@gmail.com>
  Date:   2022-05-04 (Wed, 04 May 2022)

  Changed paths:
    M target/s390x/tcg/insn-data.def
    M target/s390x/tcg/translate_vx.c.inc

  Log Message:
  -----------
  target/s390x: vxeh2: vector shift double by bit

Signed-off-by: David Miller <dmiller423@gmail.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: David Hildenbrand <david@redhat.com>
Tested-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20220428094708.84835-9-david@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 1d26a02af0464c50150a4717efd2482ad9958286
      
https://github.com/qemu/qemu/commit/1d26a02af0464c50150a4717efd2482ad9958286
  Author: David Miller <dmiller423@gmail.com>
  Date:   2022-05-04 (Wed, 04 May 2022)

  Changed paths:
    M target/s390x/tcg/insn-data.def
    M target/s390x/tcg/translate_vx.c.inc

  Log Message:
  -----------
  target/s390x: vxeh2: vector {load, store} elements reversed

Signed-off-by: David Miller <dmiller423@gmail.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: David Hildenbrand <david@redhat.com>
Tested-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Message-Id: <20220428094708.84835-10-david@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: f4dd00f1a6f42d3bc1404048513f888f3d6d97cb
      
https://github.com/qemu/qemu/commit/f4dd00f1a6f42d3bc1404048513f888f3d6d97cb
  Author: David Miller <dmiller423@gmail.com>
  Date:   2022-05-04 (Wed, 04 May 2022)

  Changed paths:
    M target/s390x/tcg/insn-data.def
    M target/s390x/tcg/translate_vx.c.inc

  Log Message:
  -----------
  target/s390x: vxeh2: vector {load, store} byte reversed elements

Signed-off-by: David Miller <dmiller423@gmail.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: David Hildenbrand <david@redhat.com>
Tested-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Message-Id: <20220428094708.84835-11-david@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: d621f7bd0a180dee785f2aabdc857829c1acf9e8
      
https://github.com/qemu/qemu/commit/d621f7bd0a180dee785f2aabdc857829c1acf9e8
  Author: David Miller <dmiller423@gmail.com>
  Date:   2022-05-04 (Wed, 04 May 2022)

  Changed paths:
    M target/s390x/tcg/insn-data.def
    M target/s390x/tcg/translate_vx.c.inc

  Log Message:
  -----------
  target/s390x: vxeh2: vector {load, store} byte reversed element

Signed-off-by: David Miller <dmiller423@gmail.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: David Hildenbrand <david@redhat.com>
Tested-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Message-Id: <20220428094708.84835-12-david@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 4f9b6c7ddb2937157a6f87de6bb79a5b93dcea5a
      
https://github.com/qemu/qemu/commit/4f9b6c7ddb2937157a6f87de6bb79a5b93dcea5a
  Author: David Miller <dmiller423@gmail.com>
  Date:   2022-05-04 (Wed, 04 May 2022)

  Changed paths:
    M hw/s390x/s390-virtio-ccw.c
    M target/s390x/gen-features.c

  Log Message:
  -----------
  target/s390x: add S390_FEAT_VECTOR_ENH2 to qemu CPU model

[ dh: take care of compat machines ]

Signed-off-by: David Miller <dmiller423@gmail.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20220428094708.84835-13-david@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: bc556c6686269c905043760631d7f57a30588bf3
      
https://github.com/qemu/qemu/commit/bc556c6686269c905043760631d7f57a30588bf3
  Author: David Miller <dmiller423@gmail.com>
  Date:   2022-05-04 (Wed, 04 May 2022)

  Changed paths:
    M tests/tcg/s390x/Makefile.target
    A tests/tcg/s390x/vx.h
    A tests/tcg/s390x/vxeh2_vcvt.c
    A tests/tcg/s390x/vxeh2_vlstr.c
    A tests/tcg/s390x/vxeh2_vs.c

  Log Message:
  -----------
  tests/tcg/s390x: Tests for Vector Enhancements Facility 2

Signed-off-by: David Miller <dmiller423@gmail.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: David Hildenbrand <david@redhat.com>
Tested-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20220428094708.84835-14-david@redhat.com>
[thuth: Only add test if -march=z15 is supported. Fix constraints for Clang]
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 9992f57978b8badb9d95f0eb601c7379f786f76c
      
https://github.com/qemu/qemu/commit/9992f57978b8badb9d95f0eb601c7379f786f76c
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2022-05-04 (Wed, 04 May 2022)

  Changed paths:
    M MAINTAINERS
    M disas.c
    M disas/meson.build
    R disas/s390.c
    M include/disas/dis-asm.h
    M target/s390x/cpu.c

  Log Message:
  -----------
  disas: Remove old libopcode s390 disassembler

Capstone should be superior to the old libopcode disassembler,
so we can drop the old file nowadays.

Message-Id: <20220412165836.355850-2-thuth@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 0c5c4d5b3c1cb594e808dd4120cc56ee28fa31dd
      
https://github.com/qemu/qemu/commit/0c5c4d5b3c1cb594e808dd4120cc56ee28fa31dd
  Author: Ilya Leoshkevich <iii@linux.ibm.com>
  Date:   2022-05-04 (Wed, 04 May 2022)

  Changed paths:
    M tests/tcg/s390x/branch-relative-long.c

  Log Message:
  -----------
  tests/tcg/s390x: Use a different PCRel32 notation in branch-relative-long.c

Binutils >=2.37 and Clang do not accept (. - 0x100000000) PCRel32
constants. While this looks like a bug that needs fixing, use a
different notation (-0x100000000) as a workaround.

Reported-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Message-Id: <20220502164830.1622191-1-iii@linux.ibm.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 1fba9dc71a170b3a05b9d3272dd8ecfe7f26e215
      
https://github.com/qemu/qemu/commit/1fba9dc71a170b3a05b9d3272dd8ecfe7f26e215
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2022-05-04 (Wed, 04 May 2022)

  Changed paths:
    M MAINTAINERS
    M disas.c
    M disas/meson.build
    R disas/s390.c
    M hw/s390x/s390-virtio-ccw.c
    M include/disas/dis-asm.h
    M include/tcg/tcg-op.h
    M target/s390x/cpu.c
    M target/s390x/cpu_models.c
    M target/s390x/gen-features.c
    M target/s390x/helper.h
    M target/s390x/tcg/insn-data.def
    M target/s390x/tcg/translate.c
    M target/s390x/tcg/translate_vx.c.inc
    M target/s390x/tcg/vec_fpu_helper.c
    M target/s390x/tcg/vec_helper.c
    M target/s390x/tcg/vec_int_helper.c
    M target/s390x/tcg/vec_string_helper.c
    M tcg/tcg-op.c
    M tests/tcg/s390x/Makefile.target
    M tests/tcg/s390x/branch-relative-long.c
    A tests/tcg/s390x/vx.h
    A tests/tcg/s390x/vxeh2_vcvt.c
    A tests/tcg/s390x/vxeh2_vlstr.c
    A tests/tcg/s390x/vxeh2_vs.c

  Log Message:
  -----------
  Merge tag 'pull-request-2022-05-04' of https://gitlab.com/thuth/qemu into 
staging

* Silence the warning about the msa5 feature when using the "max" CPU on s390x
* Implement the s390x Vector-Enhancements Facility 2
* Remove the old libopcode-based s390 disassembler
* Fix branch-relative-long test compilation with Clang

# -----BEGIN PGP SIGNATURE-----
#
# iQJFBAABCAAvFiEEJ7iIR+7gJQEY8+q5LtnXdP5wLbUFAmJyXKURHHRodXRoQHJl
# ZGhhdC5jb20ACgkQLtnXdP5wLbX1bg//bSZhEFekeak8nsM2piEwA/d3hEz5aTqN
# 9UW296E3MpE6cyfai+rQw1HzACA/sbOHLGBpOfo+dPkCq7JPhif62xOWd/6pfjvl
# d6+GRB7YusSnyePwQ7AJwWK7xOFi9LqYiqfM7wqUQf/TbetB4/ufssVc47LBsrqR
# 5OWJMRf0G/GItpCCy4IDp1oEJnKI9lGN+VG9hWJePeGYPLelmx0uHH02kgDCOb93
# atCOEeoDEsrVsbtwt9/NDw5H3DvgL2/bYGtVMkkXivysT3QhrxzoJMYRndK03CSx
# 2rWnmGGqorlzIJ8RdKvu27c9XfTtf8ssaidZMuCk4WD54H7Ln32L9EvRCpjtT8o2
# RHgxnkWSa2NWHhVrX9r0syRc7tFfFK3U7G5kYlZov+o1IyrgA7prwIjKzTk5ZIAl
# ZPmXWTUuewWSnGsJsRK9R8+UQ+nB6x8gxqK1s0dHf2rTgtIgWsx5s9WEdxGqeQ5h
# 5IvIBOML4aXnp2i0QGoGdq4zaDl1ac8AGpLd2jqc9svlHl44Q7NfY2MiWMVGCOP+
# O7DdO/tfmuJyPZS4QolGHghJFycC3Qr3Z42/dJrNK8bwaVGG/ysWkrutxcUzS3z9
# /xkkBWz8Vlktcy4Ft8lqkvofQGUYuJIfbU++EBu6yAp+mSzbO7elE8TZbgpGOVQv
# BFgwW3J4iqI=
# =7QOT
# -----END PGP SIGNATURE-----
# gpg: Signature made Wed 04 May 2022 03:59:49 AM PDT
# gpg:                using RSA key 27B88847EEE0250118F3EAB92ED9D774FE702DB5
# gpg:                issuer "thuth@redhat.com"
# gpg: Good signature from "Thomas Huth <th.huth@gmx.de>" [undefined]
# gpg:                 aka "Thomas Huth <thuth@redhat.com>" [undefined]
# gpg:                 aka "Thomas Huth <th.huth@posteo.de>" [unknown]
# gpg:                 aka "Thomas Huth <huth@tuxfamily.org>" [undefined]
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg:          There is no indication that the signature belongs to the owner.
# Primary key fingerprint: 27B8 8847 EEE0 2501 18F3  EAB9 2ED9 D774 FE70 2DB5

* tag 'pull-request-2022-05-04' of https://gitlab.com/thuth/qemu:
  tests/tcg/s390x: Use a different PCRel32 notation in branch-relative-long.c
  disas: Remove old libopcode s390 disassembler
  tests/tcg/s390x: Tests for Vector Enhancements Facility 2
  target/s390x: add S390_FEAT_VECTOR_ENH2 to qemu CPU model
  target/s390x: vxeh2: vector {load, store} byte reversed element
  target/s390x: vxeh2: vector {load, store} byte reversed elements
  target/s390x: vxeh2: vector {load, store} elements reversed
  target/s390x: vxeh2: vector shift double by bit
  target/s390x: vxeh2: Update for changes to vector shifts
  target/s390x: vxeh2: vector string search
  target/s390x: vxeh2: vector convert short/32b
  tcg: Implement tcg_gen_{h,w}swap_{i32,i64}
  s390x/cpu_models: make "max" match the unmodified "qemu" CPU model under TCG
  s390x/cpu_models: drop "msa5" from the TCG "max" model
  target/s390x: Fix writeback to v1 in helper_vstl

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


Compare: https://github.com/qemu/qemu/compare/9cf289af47bc...1fba9dc71a17



reply via email to

[Prev in Thread] Current Thread [Next in Thread]