qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 5c08ed: error-report: fix g_date_time_format


From: Richard Henderson
Subject: [Qemu-commits] [qemu/qemu] 5c08ed: error-report: fix g_date_time_format assertion
Date: Thu, 28 Apr 2022 08:34:02 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 5c08edd1fab9b6e5b02bedecb1130199ab75a29c
      
https://github.com/qemu/qemu/commit/5c08edd1fab9b6e5b02bedecb1130199ab75a29c
  Author: Haiyue Wang <haiyue.wang@intel.com>
  Date:   2022-04-28 (Thu, 28 Apr 2022)

  Changed paths:
    M util/error-report.c

  Log Message:
  -----------
  error-report: fix g_date_time_format assertion

The 'g_get_real_time' returns the number of microseconds since January
1, 1970 UTC, but 'g_date_time_new_from_unix_utc' needs the number of
seconds, so it will cause the invalid time input:

(process:279642): GLib-CRITICAL (recursed) **: g_date_time_format: assertion 
'datetime != NULL' failed

Call function 'g_date_time_new_now_utc' instead, it has the same result
as 'g_date_time_new_from_unix_utc(g_get_real_time() / G_USEC_PER_SEC)';

Fixes: 73dab893b569 ("error-report: replace deprecated g_get_current_time() 
with glib >= 2.62")
Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20220424105036.291370-1-haiyue.wang@intel.com>


  Commit: 1f3f2bfe0ef8f3c0232a1de66c1f9cc46512afea
      
https://github.com/qemu/qemu/commit/1f3f2bfe0ef8f3c0232a1de66c1f9cc46512afea
  Author: Michael Tokarev <mjt@tls.msk.ru>
  Date:   2022-04-28 (Thu, 28 Apr 2022)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: make fortify_source=yes by default

Commit c87ea1163111917 "configure: add --without-default-feature"
changed fortify_source from "yes" to "$default_feature". But there's
no option to turn it on, we only turn it off for debug build.  I think
this should always be initialized to "yes" in the first place.

Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Message-Id: <20220422100825.3692002-1-mjt@msgid.tls.msk.ru>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: e960a7ee46e29556b80996bed396b79d7077f82f
      
https://github.com/qemu/qemu/commit/e960a7ee46e29556b80996bed396b79d7077f82f
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2022-04-28 (Thu, 28 Apr 2022)

  Changed paths:
    M docs/about/deprecated.rst
    M docs/about/removed-features.rst
    M include/qemu/config-file.h
    M qemu-options.hx
    M softmmu/vl.c
    M util/qemu-config.c

  Log Message:
  -----------
  remove -writeconfig

Like -set and -readconfig, it would not really be too hard to
extend -writeconfig to parsing mechanisms other than QemuOpts.
However, the uses of -writeconfig are substantially more
limited, as it is generally easier to write the configuration
by hand in the first place.  In addition, -writeconfig does
not even try to detect cases where it prints incorrect
syntax (for example if values have a quote in them, since
qemu_config_parse does not support any kind of escaping.
Just remove it.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20220414145721.326866-1-pbonzini@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: d1da229ff1333d4619e55bb5d99ba2e7a280d984
      
https://github.com/qemu/qemu/commit/d1da229ff1333d4619e55bb5d99ba2e7a280d984
  Author: Paul Brook <paul@nowt.org>
  Date:   2022-04-28 (Thu, 28 Apr 2022)

  Changed paths:
    M target/i386/ops_sse.h

  Log Message:
  -----------
  i386: pcmpestr 64-bit sign extension bug

The abs1 function in ops_sse.h only works sorrectly when the result fits
in a signed int. This is fine most of the time because we're only dealing
with byte sized values.

However pcmp_elen helper function uses abs1 to calculate the absolute value
of a cpu register. This incorrectly truncates to 32 bits, and will give
the wrong anser for the most negative value.

Fix by open coding the saturation check before taking the absolute value.

Signed-off-by: Paul Brook <paul@nowt.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: d065177e01d06800cdfd2919c9812ee53bd156bd
      
https://github.com/qemu/qemu/commit/d065177e01d06800cdfd2919c9812ee53bd156bd
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2022-04-28 (Thu, 28 Apr 2022)

  Changed paths:
    M meson.build

  Log Message:
  -----------
  meson: show final set of compiler flags

The actual set of compiler flags can grow beyond what is found by the configure
script, for example if gprof is used.  Show the full set in the summary.

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: ff8ca58d208c2aa780dc8eacb5d88b4be070dce6
      
https://github.com/qemu/qemu/commit/ff8ca58d208c2aa780dc8eacb5d88b4be070dce6
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2022-04-28 (Thu, 28 Apr 2022)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: remove dead code

tcg_interpreter is never written, it is purely a meson option;
trace_backends is never read.

And SeaBIOS is only build from the source tree with roms/Makefile,
so the config.mak file is unused.

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 6e4442090bd3c9f81643db9ffd8d1a9b44d3e527
      
https://github.com/qemu/qemu/commit/6e4442090bd3c9f81643db9ffd8d1a9b44d3e527
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2022-04-28 (Thu, 28 Apr 2022)

  Changed paths:
    M configure
    M qga/meson.build

  Log Message:
  -----------
  qga: wixl: get path to sysroot from pkg-config as intended

The .wxs file uses $(var.Mingw_bin) while configure/meson have always
used Mingw_dlls.  Fix them to match what was probably intended.

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 2ed197d66e3fc66d7bbe272f80536e0a7a2dcca2
      
https://github.com/qemu/qemu/commit/2ed197d66e3fc66d7bbe272f80536e0a7a2dcca2
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2022-04-28 (Thu, 28 Apr 2022)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: pc-bios/qemu-icon.bmp does not exist

The file has been removed in commit a8260d3876 ("ui: install logo icons to
$prefix/share/icons", 2019-01-21), do not try to symlink it in the build tree.

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: df42fa7d47473a2f3912453db1e652b148e182da
      
https://github.com/qemu/qemu/commit/df42fa7d47473a2f3912453db1e652b148e182da
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2022-04-28 (Thu, 28 Apr 2022)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: gcov should not exclude fortify-source

There is no reason other than history (dating back to commit 1d728c3946, 
"tests: add gcov
support", 2013-01-06) for this, remove this unnecessary conditional.

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 28609749feab39502919475acb72eeab53f99257
      
https://github.com/qemu/qemu/commit/28609749feab39502919475acb72eeab53f99257
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2022-04-28 (Thu, 28 Apr 2022)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: move --enable/--disable-debug-info to second option parsing pass

$debug_info is not needed anywhere except in the final meson invocation,
no need to special case it.

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 88b6e618fda51cd2cfe7931e480e86ff8005a7d7
      
https://github.com/qemu/qemu/commit/88b6e618fda51cd2cfe7931e480e86ff8005a7d7
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2022-04-28 (Thu, 28 Apr 2022)

  Changed paths:
    M configure
    M meson.build
    M meson_options.txt
    M scripts/meson-buildoptions.sh
    M ui/meson.build

  Log Message:
  -----------
  configure, meson: move OpenGL check to meson

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 3730a7341f19cbadde4d12e214b7a82b9de01f75
      
https://github.com/qemu/qemu/commit/3730a7341f19cbadde4d12e214b7a82b9de01f75
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2022-04-28 (Thu, 28 Apr 2022)

  Changed paths:
    M configure
    M contrib/rdmacm-mux/meson.build
    M meson.build
    M meson_options.txt
    M migration/meson.build
    M scripts/meson-buildoptions.sh

  Log Message:
  -----------
  meson, configure: move RDMA options to meson

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 2edd2c04c27b469ab2b46c6fe6e4bffe6b0c2895
      
https://github.com/qemu/qemu/commit/2edd2c04c27b469ab2b46c6fe6e4bffe6b0c2895
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2022-04-28 (Thu, 28 Apr 2022)

  Changed paths:
    M configure
    M crypto/meson.build
    M meson.build
    M meson_options.txt
    M scripts/meson-buildoptions.sh

  Log Message:
  -----------
  meson, configure: move keyctl test to meson

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 0dae95d4ad00b42814d3da451783d0b1f372ada4
      
https://github.com/qemu/qemu/commit/0dae95d4ad00b42814d3da451783d0b1f372ada4
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2022-04-28 (Thu, 28 Apr 2022)

  Changed paths:
    M configure
    M meson.build

  Log Message:
  -----------
  meson, configure: move usbfs test to meson

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 7544060ef30590e3e43e145288c990aeb07c5cc5
      
https://github.com/qemu/qemu/commit/7544060ef30590e3e43e145288c990aeb07c5cc5
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2022-04-28 (Thu, 28 Apr 2022)

  Changed paths:
    M backends/meson.build
    M configure
    M meson.build
    M meson_options.txt
    M scripts/meson-buildoptions.sh
    M tests/qtest/meson.build
    M ui/meson.build
    M util/meson.build

  Log Message:
  -----------
  meson, configure: move libgio test to meson

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 215b00a542ee46504c32f53be92f6ed168f15926
      
https://github.com/qemu/qemu/commit/215b00a542ee46504c32f53be92f6ed168f15926
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2022-04-28 (Thu, 28 Apr 2022)

  Changed paths:
    M hw/xen/meson.build
    M meson.build

  Log Message:
  -----------
  meson: remove CONFIG_XEN_PCI_PASSTHROUGH from config-target.h

CONFIG_XEN_PCI_PASSTHROUGH is just a global configuration option;
it is never used in the source files, so there is no need to put
CONFIG_XEN_PCI_PASSTHROUGH in config-target.h or even in config-host.h.

This inaccuracy was copied over from the configure script in commit
8a19980e3f ("configure: move accelerator logic to meson", 2020-10-03).

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 2cb2f5804c26a767f29eb032aebf9d063d9f0ced
      
https://github.com/qemu/qemu/commit/2cb2f5804c26a767f29eb032aebf9d063d9f0ced
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2022-04-28 (Thu, 28 Apr 2022)

  Changed paths:
    M configure
    M meson.build
    M meson_options.txt
    M scripts/meson-buildoptions.sh

  Log Message:
  -----------
  meson, configure: move --enable-module-upgrades to meson

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 21abf010bb28f0c98db4ee66a990065062c62126
      
https://github.com/qemu/qemu/commit/21abf010bb28f0c98db4ee66a990065062c62126
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2022-04-28 (Thu, 28 Apr 2022)

  Changed paths:
    M qemu-options.hx

  Log Message:
  -----------
  qemu-options: Limit the -enable-kvm option to the targets that support it

There is no need to present the user with -enable-kvm if there
is no support for KVM on the corresponding target.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20220427134906.348118-1-thuth@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 6071ff6087208bf1d8e488dca43037b41d5ad764
      
https://github.com/qemu/qemu/commit/6071ff6087208bf1d8e488dca43037b41d5ad764
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2022-04-28 (Thu, 28 Apr 2022)

  Changed paths:
    M backends/meson.build
    M configure
    M contrib/rdmacm-mux/meson.build
    M crypto/meson.build
    M docs/about/deprecated.rst
    M docs/about/removed-features.rst
    M hw/xen/meson.build
    M include/qemu/config-file.h
    M meson.build
    M meson_options.txt
    M migration/meson.build
    M qemu-options.hx
    M qga/meson.build
    M scripts/meson-buildoptions.sh
    M softmmu/vl.c
    M target/i386/ops_sse.h
    M tests/qtest/meson.build
    M ui/meson.build
    M util/error-report.c
    M util/meson.build
    M util/qemu-config.c

  Log Message:
  -----------
  Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging

* Bugfixes
* Meson conversions

# -----BEGIN PGP SIGNATURE-----
#
# iQFIBAABCAAyFiEE8TM4V0tmI4mGbHaCv/vSX3jHroMFAmJqObcUHHBib256aW5p
# QHJlZGhhdC5jb20ACgkQv/vSX3jHroPwFgf9GgktU8JPTr/PENuYJkJkcoDriPSk
# KC5w5XWMzHHtSQLDLYhA9boLVo4flsAmE+CBJ3dQlKNhR2uezEvFM3ndtQ7koQ3z
# 9svjBZ/z5HKooSxPgOrRE43JpRxUHEhcRFGIfu8AIfRz8xQZ5fD9I5sGCUcNlRRi
# gWBjh849pSGW0ukL+ADz86UzTCSQGVY5ia6vnyYhvE7vT/uvcDTSLTBXmj2EpDEg
# vJzQYvcApgCd8U+Aj5iNvryt4fnjdj0xaDdyIIkrKK0WA8wJw5u7YFl7RWrkmVQG
# 1K/rrkULJUlCpx/bHkgI88Wrd3t7G8EGFL0OkzKYfFHWv+XUfndtmxkkfg==
# =JLRA
# -----END PGP SIGNATURE-----
# gpg: Signature made Wed 27 Apr 2022 11:52:39 PM PDT
# gpg:                using RSA key F13338574B662389866C7682BFFBD25F78C7AE83
# gpg:                issuer "pbonzini@redhat.com"
# gpg: Good signature from "Paolo Bonzini <bonzini@gnu.org>" [undefined]
# gpg:                 aka "Paolo Bonzini <pbonzini@redhat.com>" [undefined]
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg:          There is no indication that the signature belongs to the owner.
# Primary key fingerprint: 46F5 9FBD 57D6 12E7 BFD4  E2F7 7E15 100C CD36 69B1
#      Subkey fingerprint: F133 3857 4B66 2389 866C  7682 BFFB D25F 78C7 AE83

* tag 'for-upstream' of https://gitlab.com/bonzini/qemu:
  qemu-options: Limit the -enable-kvm option to the targets that support it
  meson, configure: move --enable-module-upgrades to meson
  meson: remove CONFIG_XEN_PCI_PASSTHROUGH from config-target.h
  meson, configure: move libgio test to meson
  meson, configure: move usbfs test to meson
  meson, configure: move keyctl test to meson
  meson, configure: move RDMA options to meson
  configure, meson: move OpenGL check to meson
  configure: move --enable/--disable-debug-info to second option parsing pass
  configure: gcov should not exclude fortify-source
  configure: pc-bios/qemu-icon.bmp does not exist
  qga: wixl: get path to sysroot from pkg-config as intended
  configure: remove dead code
  meson: show final set of compiler flags
  i386: pcmpestr 64-bit sign extension bug
  remove -writeconfig
  configure: make fortify_source=yes by default
  error-report: fix g_date_time_format assertion

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


Compare: https://github.com/qemu/qemu/compare/cf6f26d6f9b2...6071ff608720



reply via email to

[Prev in Thread] Current Thread [Next in Thread]