qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 67ae04: hw/display/vmware_vga: do not discard


From: Richard Henderson
Subject: [Qemu-commits] [qemu/qemu] 67ae04: hw/display/vmware_vga: do not discard screen updates
Date: Tue, 26 Apr 2022 09:39:49 -0700

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: 67ae04273736f103b31fb5d1f9e5170dfee3d64c
      
https://github.com/qemu/qemu/commit/67ae04273736f103b31fb5d1f9e5170dfee3d64c
  Author: Carwyn Ellis <carwynellis@gmail.com>
  Date:   2022-04-22 (Fri, 22 Apr 2022)

  Changed paths:
    M hw/display/trace-events
    M hw/display/vmware_vga.c

  Log Message:
  -----------
  hw/display/vmware_vga: do not discard screen updates

In certain circumstances, typically when there is lots changing on the
screen, updates will be discarded resulting in garbled output.

This change simplifies the traversal of the display update FIFO queue
when applying updates. We just track the queue length and iterate up to
the end of the queue.

Additionally when adding updates to the queue, if the buffer reaches
capacity we force a flush before accepting further events.

Signed-off-by: Carwyn Ellis <carwynellis@gmail.com>
Message-Id: <20220206183956.10694-3-carwynellis@gmail.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 35a17a1f0a1879bcf86b03935d88ba6d80d8a9e5
      
https://github.com/qemu/qemu/commit/35a17a1f0a1879bcf86b03935d88ba6d80d8a9e5
  Author: Kshitij Suri <kshitij.suri@nutanix.com>
  Date:   2022-04-26 (Tue, 26 Apr 2022)

  Changed paths:
    M meson.build
    M meson_options.txt
    M scripts/ci/org.centos/stream/8/x86_64/configure
    M scripts/meson-buildoptions.sh
    M ui/vnc-enc-tight.c
    M ui/vnc.c
    M ui/vnc.h

  Log Message:
  -----------
  Replacing CONFIG_VNC_PNG with CONFIG_PNG

Libpng is only detected if VNC is enabled currently. This patch adds a
generalised png option in the meson build which is aimed to replace use of
CONFIG_VNC_PNG with CONFIG_PNG.

Signed-off-by: Kshitij Suri <kshitij.suri@nutanix.com>

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220408071336.99839-2-kshitij.suri@nutanix.com>

[ kraxel: add meson-buildoptions.sh updates ]
[ kraxel: fix centos8 testcase ]

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 6e48cc3a045a1547e77e1d78b568ee66a5531981
      
https://github.com/qemu/qemu/commit/6e48cc3a045a1547e77e1d78b568ee66a5531981
  Author: Kshitij Suri <kshitij.suri@nutanix.com>
  Date:   2022-04-26 (Tue, 26 Apr 2022)

  Changed paths:
    M hmp-commands.hx
    M monitor/hmp-cmds.c
    M qapi/ui.json
    M ui/console.c

  Log Message:
  -----------
  Added parameter to take screenshot with screendump as PNG

Currently screendump only supports PPM format, which is un-compressed. Added
a "format" parameter to QMP and HMP screendump command to support PNG image
capture using libpng.

QMP example usage:
{ "execute": "screendump", "arguments": { "filename": "/tmp/image",
"format":"png" } }

HMP example usage:
screendump /tmp/image -f png

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/718

Signed-off-by: Kshitij Suri <kshitij.suri@nutanix.com>

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Acked-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Message-Id: <20220408071336.99839-3-kshitij.suri@nutanix.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 867e58505896449b517f955177cd807744a0476e
      
https://github.com/qemu/qemu/commit/867e58505896449b517f955177cd807744a0476e
  Author: Vladimir Sementsov-Ogievskiy <vladimir.sementsov-ogievskiy@openvz.org>
  Date:   2022-04-26 (Tue, 26 Apr 2022)

  Changed paths:
    M ui/vnc.c

  Log Message:
  -----------
  ui/vnc: refactor arrays of addresses to SocketAddressList

Let's use SocketAddressList instead of dynamic arrays.
Benefits:
 - Automatic cleanup: don't need specific freeing function and drop
   some gotos.
 - Less indirection: no triple asterix anymore!
 - Prepare for the following commit, which will reuse new interface of
   vnc_display_listen().

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@openvz.org>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220401143936.356460-2-vsementsov@openvz.org>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: a7222d3acf3a21b6d9cc21456e17b11836e5eb1c
      
https://github.com/qemu/qemu/commit/a7222d3acf3a21b6d9cc21456e17b11836e5eb1c
  Author: Vladimir Sementsov-Ogievskiy <vladimir.sementsov-ogievskiy@openvz.org>
  Date:   2022-04-26 (Tue, 26 Apr 2022)

  Changed paths:
    M docs/about/removed-features.rst
    M include/ui/console.h
    M monitor/qmp-cmds.c
    M qapi/ui.json
    M ui/vnc.c

  Log Message:
  -----------
  qapi/ui: add 'display-update' command for changing listen address

Add possibility to change addresses where VNC server listens for new
connections. Prior to 6.0 this functionality was available through
'change' qmp command which was deleted.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@openvz.org>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220401143936.356460-3-vsementsov@openvz.org>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 33afc0c104bf3e825854dd172c0e7e58cd3428b6
      
https://github.com/qemu/qemu/commit/33afc0c104bf3e825854dd172c0e7e58cd3428b6
  Author: Vladimir Sementsov-Ogievskiy <vladimir.sementsov-ogievskiy@openvz.org>
  Date:   2022-04-26 (Tue, 26 Apr 2022)

  Changed paths:
    M tests/avocado/vnc.py

  Log Message:
  -----------
  avocado/vnc: add test_change_listen

Add simple test-case for new display-update qmp command.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@openvz.org>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220401143936.356460-4-vsementsov@openvz.org>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: a5ab3304c5f211fc2d5a326b2783e3412d14ae1a
      
https://github.com/qemu/qemu/commit/a5ab3304c5f211fc2d5a326b2783e3412d14ae1a
  Author: Gerd Hoffmann <kraxel@redhat.com>
  Date:   2022-04-26 (Tue, 26 Apr 2022)

  Changed paths:
    M hw/i386/x86.c

  Log Message:
  -----------
  i386: move bios load error message

Switch to usual goto-end-of-function error handling style.
No functional change.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Tested-by: Xiaoyao Li <xiaoyao.li@intel.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Message-Id: <20220425135051.551037-2-kraxel@redhat.com>


  Commit: e3a73b101ae01e32f22465d67619cccc1911a847
      
https://github.com/qemu/qemu/commit/e3a73b101ae01e32f22465d67619cccc1911a847
  Author: Gerd Hoffmann <kraxel@redhat.com>
  Date:   2022-04-26 (Tue, 26 Apr 2022)

  Changed paths:
    M hw/i386/pc_sysfw.c
    M include/hw/i386/x86.h

  Log Message:
  -----------
  i386: factor out x86_firmware_configure()

move sev firmware setup to separate function so it can be used from
other code paths.  No functional change.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Tested-by: Xiaoyao Li <xiaoyao.li@intel.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Message-Id: <20220425135051.551037-3-kraxel@redhat.com>


  Commit: f7683b652742402f0bcd3b2714d2795ce524bd26
      
https://github.com/qemu/qemu/commit/f7683b652742402f0bcd3b2714d2795ce524bd26
  Author: Gerd Hoffmann <kraxel@redhat.com>
  Date:   2022-04-26 (Tue, 26 Apr 2022)

  Changed paths:
    M hw/i386/x86.c

  Log Message:
  -----------
  i386: firmware parsing and sev setup for -bios loaded firmware

Don't register firmware as rom, not needed (see comment).
Add x86_firmware_configure() call for proper sev initialization.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Tested-by: Xiaoyao Li <xiaoyao.li@intel.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Tested-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Message-Id: <20220425135051.551037-4-kraxel@redhat.com>


  Commit: 9aac40c166a583a8a9cbb03531eedca662f02813
      
https://github.com/qemu/qemu/commit/9aac40c166a583a8a9cbb03531eedca662f02813
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2022-04-26 (Tue, 26 Apr 2022)

  Changed paths:
    M docs/about/removed-features.rst
    M hmp-commands.hx
    M hw/display/trace-events
    M hw/display/vmware_vga.c
    M hw/i386/pc_sysfw.c
    M hw/i386/x86.c
    M include/hw/i386/x86.h
    M include/ui/console.h
    M meson.build
    M meson_options.txt
    M monitor/hmp-cmds.c
    M monitor/qmp-cmds.c
    M qapi/ui.json
    M scripts/ci/org.centos/stream/8/x86_64/configure
    M scripts/meson-buildoptions.sh
    M tests/avocado/vnc.py
    M ui/console.c
    M ui/vnc-enc-tight.c
    M ui/vnc.c
    M ui/vnc.h

  Log Message:
  -----------
  Merge tag 'kraxel-20220426-pull-request' of git://git.kraxel.org/qemu into 
staging

vnc: add display-update monitor command.
screendump: add png support.
vmsvga: screen update fix.
i386: sev setup for -bios loaded firmware

# -----BEGIN PGP SIGNATURE-----
#
# iQIzBAABCgAdFiEEoDKM/7k6F6eZAf59TLbY7tPocTgFAmJn0Y8ACgkQTLbY7tPo
# cThxchAAtaz1nUhp4zYPkRaYMYiSI25SIotjzTVozCrtDwgV0SKgGmqBgnY3FFeo
# 1N1xduiDIgfZxam4ptQzZOyQlGq2o7jZGaD07J8wYonqZgQnWjNjZsZGRvAQbuSZ
# e6QCKP29s0ICnp+Y1ync0rFXXKhBCsd6ezl/9irkvtKJ6wkM+Q4hDZft/L9s1eH+
# J+U2TPwAwha91eOKd1UCRnS5mjauIQSY84GOq2ldhHCEqAdkMtwgvsrTYdp8Pp4d
# Ebogwf6xp5fWbhff7Wv9vMUOwa6gYCtSXeLQsgLLcWVmyDBpXxp0FMhT5A35+Mtc
# lrtON+y7/XpZ6lDsG1/WsuJKKjL7l4T2nYcec9z653lWdXMaiZNS9md9eK7+azlc
# JRPk2Mo522OB4xd8uMztBMltIKPWI9mmd48JBq3UbZfv1UG4ZoEw5vwrxrb4iuzk
# GScuW+J3jDdhgKyE8WZIBcIg1C2lRAlp9GmR8J9ZwvecJeFA2dlBrpBSNt26AC21
# ioWFtRrF72C0chJPuijm3P302QaxgFj/vCQ/HX+0BrJbcJQccjCrBzC4OX8tHVcd
# adz1RlOnJoecHXGmMfadeU5triiPWKgEu6E8M4mNzR7BPmwhbnD0SeXh3Dx1nUmf
# le4Mem+94xbzlIwcsgE30wEf91dGiidvkDMTNjhJ3TtVzF3CgqU=
# =TCjo
# -----END PGP SIGNATURE-----
# gpg: Signature made Tue 26 Apr 2022 04:03:43 AM PDT
# gpg:                using RSA key A0328CFFB93A17A79901FE7D4CB6D8EED3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <kraxel@redhat.com>" 
[undefined]
# gpg:                 aka "Gerd Hoffmann <gerd@kraxel.org>" [undefined]
# gpg:                 aka "Gerd Hoffmann (private) <kraxel@gmail.com>" 
[undefined]
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg:          There is no indication that the signature belongs to the owner.
# Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138

* tag 'kraxel-20220426-pull-request' of git://git.kraxel.org/qemu:
  i386: firmware parsing and sev setup for -bios loaded firmware
  i386: factor out x86_firmware_configure()
  i386: move bios load error message
  avocado/vnc: add test_change_listen
  qapi/ui: add 'display-update' command for changing listen address
  ui/vnc: refactor arrays of addresses to SocketAddressList
  Added parameter to take screenshot with screendump as PNG
  Replacing CONFIG_VNC_PNG with CONFIG_PNG
  hw/display/vmware_vga: do not discard screen updates

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


Compare: https://github.com/qemu/qemu/compare/80a172de5592...9aac40c166a5



reply via email to

[Prev in Thread] Current Thread [Next in Thread]