[Qemu-commits] [qemu/qemu] 67ae04: hw/display/vmware_vga: do not discard screen updates

[Richard Henderson]

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: 67ae04273736f103b31fb5d1f9e5170dfee3d64c
      
https://github.com/qemu/qemu/commit/67ae04273736f103b31fb5d1f9e5170dfee3d64c
  Author: Carwyn Ellis <carwynellis@gmail.com>
  Date:   2022-04-22 (Fri, 22 Apr 2022)

  Changed paths:
    M hw/display/trace-events
    M hw/display/vmware_vga.c

  Log Message:
  -----------
  hw/display/vmware_vga: do not discard screen updates

In certain circumstances, typically when there is lots changing on the
screen, updates will be discarded resulting in garbled output.

This change simplifies the traversal of the display update FIFO queue
when applying updates. We just track the queue length and iterate up to
the end of the queue.

Additionally when adding updates to the queue, if the buffer reaches
capacity we force a flush before accepting further events.

Signed-off-by: Carwyn Ellis <carwynellis@gmail.com>
Message-Id: <20220206183956.10694-3-carwynellis@gmail.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 8d46ae43bb919011960c8f4e6a216e23d19eb676
      
https://github.com/qemu/qemu/commit/8d46ae43bb919011960c8f4e6a216e23d19eb676
  Author: Kshitij Suri <kshitij.suri@nutanix.com>
  Date:   2022-04-22 (Fri, 22 Apr 2022)

  Changed paths:
    M meson.build
    M meson_options.txt
    M scripts/meson-buildoptions.sh
    M ui/vnc-enc-tight.c
    M ui/vnc.c
    M ui/vnc.h

  Log Message:
  -----------
  Replacing CONFIG_VNC_PNG with CONFIG_PNG

Libpng is only detected if VNC is enabled currently. This patch adds a
generalised png option in the meson build which is aimed to replace use of
CONFIG_VNC_PNG with CONFIG_PNG.

Signed-off-by: Kshitij Suri <kshitij.suri@nutanix.com>

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220408071336.99839-2-kshitij.suri@nutanix.com>

[ kraxel: add meson-buildoptions.sh updates ]

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 82391f0e5deb1fbd16805b4f2f5507f84dfa748a
      
https://github.com/qemu/qemu/commit/82391f0e5deb1fbd16805b4f2f5507f84dfa748a
  Author: Kshitij Suri <kshitij.suri@nutanix.com>
  Date:   2022-04-22 (Fri, 22 Apr 2022)

  Changed paths:
    M hmp-commands.hx
    M monitor/hmp-cmds.c
    M qapi/ui.json
    M ui/console.c

  Log Message:
  -----------
  Added parameter to take screenshot with screendump as PNG

Currently screendump only supports PPM format, which is un-compressed. Added
a "format" parameter to QMP and HMP screendump command to support PNG image
capture using libpng.

QMP example usage:
{ "execute": "screendump", "arguments": { "filename": "/tmp/image",
"format":"png" } }

HMP example usage:
screendump /tmp/image -f png

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/718

Signed-off-by: Kshitij Suri <kshitij.suri@nutanix.com>

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Acked-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Message-Id: <20220408071336.99839-3-kshitij.suri@nutanix.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 1b14556c4b56105be21de5985198cdc6a839e37a
      
https://github.com/qemu/qemu/commit/1b14556c4b56105be21de5985198cdc6a839e37a
  Author: Vladimir Sementsov-Ogievskiy <vladimir.sementsov-ogievskiy@openvz.org>
  Date:   2022-04-22 (Fri, 22 Apr 2022)

  Changed paths:
    M ui/vnc.c

  Log Message:
  -----------
  ui/vnc: refactor arrays of addresses to SocketAddressList

Let's use SocketAddressList instead of dynamic arrays.
Benefits:
 - Automatic cleanup: don't need specific freeing function and drop
   some gotos.
 - Less indirection: no triple asterix anymore!
 - Prepare for the following commit, which will reuse new interface of
   vnc_display_listen().

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@openvz.org>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220401143936.356460-2-vsementsov@openvz.org>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: bee5cbfb46a057cc2ebbac24def23628ddc1c464
      
https://github.com/qemu/qemu/commit/bee5cbfb46a057cc2ebbac24def23628ddc1c464
  Author: Vladimir Sementsov-Ogievskiy <vladimir.sementsov-ogievskiy@openvz.org>
  Date:   2022-04-22 (Fri, 22 Apr 2022)

  Changed paths:
    M docs/about/removed-features.rst
    M include/ui/console.h
    M monitor/qmp-cmds.c
    M qapi/ui.json
    M ui/vnc.c

  Log Message:
  -----------
  qapi/ui: add 'display-update' command for changing listen address

Add possibility to change addresses where VNC server listens for new
connections. Prior to 6.0 this functionality was available through
'change' qmp command which was deleted.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@openvz.org>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220401143936.356460-3-vsementsov@openvz.org>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: ef798418a3037434951002d0afc5f3d919e294db
      
https://github.com/qemu/qemu/commit/ef798418a3037434951002d0afc5f3d919e294db
  Author: Vladimir Sementsov-Ogievskiy <vladimir.sementsov-ogievskiy@openvz.org>
  Date:   2022-04-22 (Fri, 22 Apr 2022)

  Changed paths:
    M tests/avocado/vnc.py

  Log Message:
  -----------
  avocado/vnc: add test_change_listen

Add simple test-case for new display-update qmp command.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@openvz.org>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220401143936.356460-4-vsementsov@openvz.org>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 649c45158ff86807cd92fff811971600d8cbffb6
      
https://github.com/qemu/qemu/commit/649c45158ff86807cd92fff811971600d8cbffb6
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2022-04-25 (Mon, 25 Apr 2022)

  Changed paths:
    M docs/about/removed-features.rst
    M hmp-commands.hx
    M hw/display/trace-events
    M hw/display/vmware_vga.c
    M include/ui/console.h
    M meson.build
    M meson_options.txt
    M monitor/hmp-cmds.c
    M monitor/qmp-cmds.c
    M qapi/ui.json
    M scripts/meson-buildoptions.sh
    M tests/avocado/vnc.py
    M ui/console.c
    M ui/vnc-enc-tight.c
    M ui/vnc.c
    M ui/vnc.h

  Log Message:
  -----------
  Merge tag 'kraxel-20220425-pull-request' of git://git.kraxel.org/qemu into 
staging

vnc: add display-update monitor command.
screendump: add png support.
vmsvga: screen update fix.

# -----BEGIN PGP SIGNATURE-----
#
# iQIzBAABCgAdFiEEoDKM/7k6F6eZAf59TLbY7tPocTgFAmJmO0kACgkQTLbY7tPo
# cTjKpQ//andeQGomuWXU6XW6/7PHrGrSSHFOJ2cUdCJvj9v8/BxZWcsJd2kWTmj2
# LKNfVMmnvb33gdN3fRf2iExyCgkWgJckAG1S8XNQBlv1mM+nkhiMg/RbFfr1KMiy
# ldleFac6Ca65/8Yi7vnUBB9ex2Q+tYoSARTCIyKn/JMR/h5TnAXVlWE3ndbuPCwN
# HP5dz2jtpC7jPJqxsv8Eg8C32AMg+QwXsqvD9oEB/g7T1l28CYosdRmZpr6tPvxE
# qXTBdMzamBa5ZfKzw8Ogl77WODmZ8iArOpYLizj7dYuiCqfvL7VljxY+gSZly2Xk
# xsvt/NfBxuvP0A9/s4QThK1oucdeomcV8qZCXvblrPaQY/UFjyV9InWgSnNJq8r0
# qBaTFHXptFlHV0U7tRj/11xKoLfjyL3WxvWVbB9sk95bpolGV7yZI0Ix29maig8K
# 9VegbED+qc3C+y2dd9VTmhD9qahF6kj9H35wbzF69qnXiEyeQyabDGxIm4FCdBFD
# Wwz8/hewyHx/BepnA4Q1EM15faovO3vFtUaMY6qWVRQsj7P1Lmo68vn5RqvH4u1Y
# 0IHKJczJPRessLIrS2BdY3UopOIClvK1/XLGobSUEhpoFd34yDG1G3LBLygC/cFc
# 8V8m+3EVacMQzK0BwcLX+quEwFwpEWSENz/jqFMTO+u7qp915vY=
# =kMYX
# -----END PGP SIGNATURE-----
# gpg: Signature made Sun 24 Apr 2022 11:10:17 PM PDT
# gpg:                using RSA key A0328CFFB93A17A79901FE7D4CB6D8EED3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <kraxel@redhat.com>" 
[undefined]
# gpg:                 aka "Gerd Hoffmann <gerd@kraxel.org>" [undefined]
# gpg:                 aka "Gerd Hoffmann (private) <kraxel@gmail.com>" 
[undefined]
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg:          There is no indication that the signature belongs to the owner.
# Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138

* tag 'kraxel-20220425-pull-request' of git://git.kraxel.org/qemu:
  avocado/vnc: add test_change_listen
  qapi/ui: add 'display-update' command for changing listen address
  ui/vnc: refactor arrays of addresses to SocketAddressList
  Added parameter to take screenshot with screendump as PNG
  Replacing CONFIG_VNC_PNG with CONFIG_PNG
  hw/display/vmware_vga: do not discard screen updates

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


Compare: https://github.com/qemu/qemu/compare/754f756cc4c6...649c45158ff8