qemu-commits
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 951cc9: glib-compat: isolate g_date_time_form

From: Richard Henderson
Subject: [Qemu-commits] [qemu/qemu] 951cc9: glib-compat: isolate g_date_time_format_iso8601 ve...
Date: Thu, 21 Apr 2022 09:30:54 -0700 
  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: 951cc9df88291b275f4db10e6853afd3e2a600c8
      
https://github.com/qemu/qemu/commit/951cc9df88291b275f4db10e6853afd3e2a600c8
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2022-04-21 (Thu, 21 Apr 2022)

  Changed paths:
    M include/glib-compat.h
    M util/error-report.c

  Log Message:
  -----------
  glib-compat: isolate g_date_time_format_iso8601 version-bypass

The solution was discussed with Markus Armbruster during the review:
https://patchew.org/QEMU/20220323155743.1585078-1-marcandre.lureau@redhat.com/20220323155743.1585078-14-marcandre.lureau@redhat.com/

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220420132624.2439741-3-marcandre.lureau@redhat.com>


  Commit: 6712f04ec8f417d5082e206e0bc0b80d6572afbb
      
https://github.com/qemu/qemu/commit/6712f04ec8f417d5082e206e0bc0b80d6572afbb
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2022-04-21 (Thu, 21 Apr 2022)

  Changed paths:
    M scripts/analyze-inclusions

  Log Message:
  -----------
  scripts/analyze-inclusions: drop qemu-common.h from analysis

The header is no longer commonly included.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220420132624.2439741-4-marcandre.lureau@redhat.com>


  Commit: 88c39c8693f2b7f0a9fbac1cdd9496493066563a
      
https://github.com/qemu/qemu/commit/88c39c8693f2b7f0a9fbac1cdd9496493066563a
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2022-04-21 (Thu, 21 Apr 2022)

  Changed paths:
    M include/qemu-common.h
    A include/qemu-main.h
    M softmmu/main.c
    M ui/cocoa.m

  Log Message:
  -----------
  Simplify softmmu/main.c

Move qemu_main() declaration to a new header.

Simplify main.c since both cocoa & sdl cannot be enabled together.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Akihiko Odaki <akihiko.odaki@gmail.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220420132624.2439741-5-marcandre.lureau@redhat.com>


  Commit: aa77a877fd033ad62b7072998975f08b340b3952
      
https://github.com/qemu/qemu/commit/aa77a877fd033ad62b7072998975f08b340b3952
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2022-04-21 (Thu, 21 Apr 2022)

  Changed paths:
    M hw/hyperv/syndbg.c

  Log Message:
  -----------
  hw/hyperv: remove needless qemu-common.h include

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220420132624.2439741-6-marcandre.lureau@redhat.com>


  Commit: 49f95221935db33a3636888860f5006070e09dc8
      
https://github.com/qemu/qemu/commit/49f95221935db33a3636888860f5006070e09dc8
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2022-04-21 (Thu, 21 Apr 2022)

  Changed paths:
    M bsd-user/main.c
    R include/qemu-common.h
    A include/qemu/help-texts.h
    M linux-user/main.c
    M qemu-img.c
    M qemu-io.c
    M qemu-nbd.c
    M qga/main.c
    M scsi/qemu-pr-helper.c
    M softmmu/vl.c
    M storage-daemon/qemu-storage-daemon.c
    M tools/virtiofsd/passthrough_ll.c
    M ui/cocoa.m

  Log Message:
  -----------
  include: rename qemu-common.h qemu/help-texts.h

Suggested-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Warner Losh <imp@bsdimp.com>
Message-Id: <20220420132624.2439741-7-marcandre.lureau@redhat.com>


  Commit: 4e8c41947b0eb5a96e940aa1be8ff71abb46d33f
      
https://github.com/qemu/qemu/commit/4e8c41947b0eb5a96e940aa1be8ff71abb46d33f
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2022-04-21 (Thu, 21 Apr 2022)

  Changed paths:
    M qga/main.c

  Log Message:
  -----------
  qga: replace usleep() with g_usleep()

The latter simply requires glib.h, while the former is not in the
Windows API (but provided by mingw header & CRT)

Also simplify the expression for 1/10s.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220420132624.2439741-12-marcandre.lureau@redhat.com>


  Commit: 7a42e6885aab340c1fad8efea95929b673714ecc
      
https://github.com/qemu/qemu/commit/7a42e6885aab340c1fad8efea95929b673714ecc
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2022-04-21 (Thu, 21 Apr 2022)

  Changed paths:
    M docs/devel/tracing.rst

  Log Message:
  -----------
  docs: trace-events-all is installed without renaming

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220420132624.2439741-13-marcandre.lureau@redhat.com>


  Commit: e5c41835250ebb3f0297606bc7cc48cfa5474e8f
      
https://github.com/qemu/qemu/commit/e5c41835250ebb3f0297606bc7cc48cfa5474e8f
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2022-04-21 (Thu, 21 Apr 2022)

  Changed paths:
    M hw/arm/digic.c

  Log Message:
  -----------
  arm/digic: replace snprintf() with g_strdup_printf()

Also fixes a GCC 12.0.1 false-positive:
../hw/arm/digic.c: In function ‘digic_init’:
../hw/arm/digic.c:45:54: error: ‘%d’ directive output may be truncated writing 
between 1 and 11 bytes into a region of size 5 [-Werror=format-truncation=]
   45 |         snprintf(name, DIGIC_TIMER_NAME_MLEN, "timer[%d]", i);
      |                                                      ^~

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220420132624.2439741-14-marcandre.lureau@redhat.com>


  Commit: aaea18d5d697d94ba63122a644690b9a9e7db007
      
https://github.com/qemu/qemu/commit/aaea18d5d697d94ba63122a644690b9a9e7db007
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2022-04-21 (Thu, 21 Apr 2022)

  Changed paths:
    M hw/arm/allwinner-a10.c

  Log Message:
  -----------
  arm/allwinner-a10: replace snprintf() with g_strdup_printf()

Also fixes a GCC 12.0.1 false-positive:
../hw/arm/allwinner-a10.c: In function ‘aw_a10_realize’:
../hw/arm/allwinner-a10.c:135:35: error: ‘%d’ directive writing between 1 and 
11 bytes into a region of size 8 [-Werror=format-overflow=]
  135 |             sprintf(bus, "usb-bus.%d", i);
      |                                   ^~

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220420132624.2439741-15-marcandre.lureau@redhat.com>


  Commit: a0e04317f3ef86d7b18ec6e6459d8aa66f787d12
      
https://github.com/qemu/qemu/commit/a0e04317f3ef86d7b18ec6e6459d8aa66f787d12
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2022-04-21 (Thu, 21 Apr 2022)

  Changed paths:
    M hw/intc/exynos4210_gic.c

  Log Message:
  -----------
  intc/exynos4210_gic: replace snprintf() with g_strdup_printf()

While at it, replace '%x' with '%u' as suggested by Philippe Mathieu-Daudé.

Also fixes a GCC 12.0.1 -Wformat-overflow false-positive.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220420132624.2439741-16-marcandre.lureau@redhat.com>


  Commit: 1812a2d366016becbe127879cc1d9504ccd437a0
      
https://github.com/qemu/qemu/commit/1812a2d366016becbe127879cc1d9504ccd437a0
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2022-04-21 (Thu, 21 Apr 2022)

  Changed paths:
    M docs/devel/style.rst

  Log Message:
  -----------
  doc/style: CLang -> Clang

It's not the way it is usually written (see https://clang.llvm.org/).

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Damien Hedde <damien.hedde@greensocs.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220420132624.2439741-17-marcandre.lureau@redhat.com>


  Commit: 94ae6b579d5fa0e4e4ac16b0769350ee853ede8a
      
https://github.com/qemu/qemu/commit/94ae6b579d5fa0e4e4ac16b0769350ee853ede8a
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2022-04-21 (Thu, 21 Apr 2022)

  Changed paths:
    M include/qemu/compiler.h
    M include/qemu/osdep.h

  Log Message:
  -----------
  osdep.h: move qemu_build_not_reached()

Move the macro and declaration so it can use glib in the following
patch (it already depends on glib anyway for !optimize)

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220420132624.2439741-19-marcandre.lureau@redhat.com>


  Commit: 8905770b27be326d12a704629f3cb715642db6cc
      
https://github.com/qemu/qemu/commit/8905770b27be326d12a704629f3cb715642db6cc
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2022-04-21 (Thu, 21 Apr 2022)

  Changed paths:
    M accel/stubs/tcg-stub.c
    M accel/tcg/internal.h
    M bsd-user/signal.c
    M hw/misc/mips_itu.c
    M include/exec/exec-all.h
    M include/exec/helper-head.h
    M include/glib-compat.h
    M include/hw/core/cpu.h
    M include/hw/core/tcg-cpu-ops.h
    M include/hw/hw.h
    M include/qemu/compiler.h
    M include/qemu/osdep.h
    M include/qemu/thread.h
    M include/tcg/tcg-ldst.h
    M include/tcg/tcg.h
    M linux-user/signal.c
    M linux-user/user-internals.h
    M monitor/hmp.c
    M qemu-img.c
    M scripts/checkpatch.pl
    M scripts/cocci-macro-file.h
    M target/alpha/cpu.h
    M target/alpha/helper.c
    M target/arm/internals.h
    M target/arm/pauth_helper.c
    M target/arm/tlb_helper.c
    M target/hexagon/op_helper.c
    M target/hppa/cpu.c
    M target/hppa/cpu.h
    M target/hppa/op_helper.c
    M target/i386/tcg/bpt_helper.c
    M target/i386/tcg/excp_helper.c
    M target/i386/tcg/helper-tcg.h
    M target/i386/tcg/misc_helper.c
    M target/i386/tcg/sysemu/misc_helper.c
    M target/microblaze/cpu.h
    M target/mips/tcg/tcg-internal.h
    M target/nios2/cpu.h
    M target/openrisc/exception.c
    M target/openrisc/exception.h
    M target/openrisc/exception_helper.c
    M target/ppc/cpu.h
    M target/ppc/internal.h
    M target/riscv/cpu.h
    M target/riscv/op_helper.c
    M target/rx/op_helper.c
    M target/s390x/s390x-internal.h
    M target/s390x/tcg/excp_helper.c
    M target/s390x/tcg/tcg_s390x.h
    M target/sh4/cpu.h
    M target/sh4/op_helper.c
    M target/sparc/cpu.h
    M target/sparc/mmu_helper.c
    M target/tricore/op_helper.c
    M target/xtensa/cpu.h
    M tcg/tcg.c
    M tests/fp/fp-bench.c
    M tests/fp/fp-test.c

  Log Message:
  -----------
  compiler.h: replace QEMU_NORETURN with G_NORETURN

G_NORETURN was introduced in glib 2.68, fallback to G_GNUC_NORETURN in
glib-compat.

Note that this attribute must be placed before the function declaration
(bringing a bit of consistency in qemu codebase usage).

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Warner Losh <imp@bsdimp.com>
Message-Id: <20220420132624.2439741-20-marcandre.lureau@redhat.com>


  Commit: 73991a922217a499ffb19fa254b1fda8bfac42c4
      
https://github.com/qemu/qemu/commit/73991a922217a499ffb19fa254b1fda8bfac42c4
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2022-04-21 (Thu, 21 Apr 2022)

  Changed paths:
    M include/qemu/cutils.h
    M include/qemu/osdep.h
    M util/cutils.c
    M util/oslib-posix.c
    M util/oslib-win32.c

  Log Message:
  -----------
  include: move qemu_msync() to osdep

The implementation depends on the OS. (and longer-term goal is to move
cutils to a common subproject)

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220420132624.2439741-21-marcandre.lureau@redhat.com>


  Commit: 282468c7c4c84ce497e51d046f545badc320c154
      
https://github.com/qemu/qemu/commit/282468c7c4c84ce497e51d046f545badc320c154
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2022-04-21 (Thu, 21 Apr 2022)

  Changed paths:
    M include/qemu/cutils.h
    M include/qemu/osdep.h
    M util/cutils.c
    M util/osdep.c

  Log Message:
  -----------
  include: move qemu_fdatasync() to osdep

Move QEMU-specific code to util/osdep.c, so cutils can become a common
subproject.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220420132624.2439741-22-marcandre.lureau@redhat.com>


  Commit: 9ca9c893b617c0c182f16331021c5ff8c64c5c00
      
https://github.com/qemu/qemu/commit/9ca9c893b617c0c182f16331021c5ff8c64c5c00
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2022-04-21 (Thu, 21 Apr 2022)

  Changed paths:
    A include/qemu/keyval.h
    M include/qemu/option.h
    M qapi/qobject-input-visitor.c
    M qom/object_interfaces.c
    M softmmu/vl.c
    M tests/unit/check-qom-proplist.c
    M tests/unit/test-forward-visitor.c
    M tests/unit/test-keyval.c
    M util/keyval.c

  Log Message:
  -----------
  include: add qemu/keyval.h

Do not require the whole option machinery to handle keyval, as it is
used by QAPI alone, without the option API. And match the associated
unit name.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220420132624.2439741-24-marcandre.lureau@redhat.com>


  Commit: 215aea0cb2c1ede4bac8877a8c85b66568bed694
      
https://github.com/qemu/qemu/commit/215aea0cb2c1ede4bac8877a8c85b66568bed694
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2022-04-21 (Thu, 21 Apr 2022)

  Changed paths:
    M include/block/qdict.h
    M include/qapi/qmp/qdict.h
    M softmmu/vl.c
    M tests/unit/check-qobject.c

  Log Message:
  -----------
  include: move qdict_{crumple,flatten} declarations

Move them where they belong, since the functions are implemented in 
block-qdict.c.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220420132624.2439741-25-marcandre.lureau@redhat.com>


  Commit: 5472b5b6a42482e924014bca0c42a79044d6e7d9
      
https://github.com/qemu/qemu/commit/5472b5b6a42482e924014bca0c42a79044d6e7d9
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2022-04-21 (Thu, 21 Apr 2022)

  Changed paths:
    M tests/unit/check-qobject.c

  Log Message:
  -----------
  tests: remove block/qdict checks from check-qobject.c

The functions are already covered in check-block-qdict.c.
This will help moving QAPI-related tests in a common subproject.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220420132624.2439741-26-marcandre.lureau@redhat.com>


  Commit: c213ef9a66b0774771cb0cc04c9b3b019bb508db
      
https://github.com/qemu/qemu/commit/c213ef9a66b0774771cb0cc04c9b3b019bb508db
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2022-04-21 (Thu, 21 Apr 2022)

  Changed paths:
    M include/qemu/compiler.h

  Log Message:
  -----------
  compiler.h: add QEMU_SANITIZE_{ADDRESS,THREAD}

Simplify a bit pre-compiler conditions.

For TSAN, QEMU already has CONFIG_TSAN, but it is only set when the
fiber API is present. (I wonder whether supporting TSAN without the
fiber API is really relevant)

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220420132624.2439741-27-marcandre.lureau@redhat.com>


  Commit: a7bd942c900ff83b25ccef68629b34831db03a59
      
https://github.com/qemu/qemu/commit/a7bd942c900ff83b25ccef68629b34831db03a59
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2022-04-21 (Thu, 21 Apr 2022)

  Changed paths:
    M tests/unit/meson.build
    M tests/unit/test-qga.c

  Log Message:
  -----------
  tests: run-time skip test-qga if TSAN is enabled

This allows to make sure the test is still built, and gives more
accurate report details.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220420132624.2439741-30-marcandre.lureau@redhat.com>


  Commit: 756a98dd701ec3a9127c700ba9e7e93254b05f28
      
https://github.com/qemu/qemu/commit/756a98dd701ec3a9127c700ba9e7e93254b05f28
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2022-04-21 (Thu, 21 Apr 2022)

  Changed paths:
    M include/monitor/monitor.h
    M include/qemu/error-report.h
    M monitor/monitor.c
    M stubs/error-printf.c
    M ui/vnc.c
    M util/error-report.c

  Log Message:
  -----------
  Move error_printf_unless_qmp() with monitor unit

Since it depends on monitor code, and error_vprintf_unless_qmp() is
already there.

This will help to move error-report in a common subproject.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220420132624.2439741-31-marcandre.lureau@redhat.com>


  Commit: 548fb0da730072d8c96b40ce29b024dd16cbab92
      
https://github.com/qemu/qemu/commit/548fb0da730072d8c96b40ce29b024dd16cbab92
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2022-04-21 (Thu, 21 Apr 2022)

  Changed paths:
    M include/qemu/osdep.h
    M qga/commands-common.h
    M qga/commands-posix.c
    M qga/commands-win32.c
    M qga/commands.c
    M util/oslib-posix.c
    M util/oslib-win32.c

  Log Message:
  -----------
  qga: move qga_get_host_name()

The function is specific to qemu-ga, no need to share it in QEMU.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Message-Id: <20220420132624.2439741-32-marcandre.lureau@redhat.com>


  Commit: c3e5704af19ac6e28098a73849a65cad83b80d00
      
https://github.com/qemu/qemu/commit/c3e5704af19ac6e28098a73849a65cad83b80d00
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2022-04-21 (Thu, 21 Apr 2022)

  Changed paths:
    M tests/qtest/libqtest.c

  Log Message:
  -----------
  qtest: simplify socket_send()

Reuse qemu_write_full().

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20220420132624.2439741-33-marcandre.lureau@redhat.com>


  Commit: d0dedf2f4c116293d82d0bda510e4bb4d7dfac26
      
https://github.com/qemu/qemu/commit/d0dedf2f4c116293d82d0bda510e4bb4d7dfac26
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2022-04-21 (Thu, 21 Apr 2022)

  Changed paths:
    M util/compatfd.c

  Log Message:
  -----------
  util: simplify write in signal handler

Use qemu_write_full() instead of open-coding a write loop.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220420132624.2439741-36-marcandre.lureau@redhat.com>


  Commit: 96eb9b2b47ecd923ff67848c0b1a92a900f95d91
      
https://github.com/qemu/qemu/commit/96eb9b2b47ecd923ff67848c0b1a92a900f95d91
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2022-04-21 (Thu, 21 Apr 2022)

  Changed paths:
    M util/oslib-posix.c

  Log Message:
  -----------
  util: use qemu_write_full() in qemu_write_pidfile()

Mostly for correctness.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220420132624.2439741-37-marcandre.lureau@redhat.com>


  Commit: 1b34d08f0b529ccf80e9da9d0928afa97d5d7807
      
https://github.com/qemu/qemu/commit/1b34d08f0b529ccf80e9da9d0928afa97d5d7807
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2022-04-21 (Thu, 21 Apr 2022)

  Changed paths:
    M util/oslib-posix.c

  Log Message:
  -----------
  util: use qemu_create() in qemu_write_pidfile()

qemu_open_old(O_CREATE) should be replaced with qemu_create() which
handles Error reporting.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220420132624.2439741-38-marcandre.lureau@redhat.com>


  Commit: 1fbf2665e6773d87657c2a1654d9bf272a4f1ec0
      
https://github.com/qemu/qemu/commit/1fbf2665e6773d87657c2a1654d9bf272a4f1ec0
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2022-04-21 (Thu, 21 Apr 2022)

  Changed paths:
    M include/qemu/osdep.h
    M qga/main.c
    M scsi/qemu-pr-helper.c
    M tools/virtiofsd/fuse_virtio.c
    M util/oslib-posix.c
    M util/oslib-win32.c

  Log Message:
  -----------
  util: replace qemu_get_local_state_pathname()

Simplify the function to only return the directory path. Callers are
adjusted to use the GLib function to build paths, g_build_filename().

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220420132624.2439741-39-marcandre.lureau@redhat.com>


  Commit: c267d750d87529de9371789109047b8d68d5477f
      
https://github.com/qemu/qemu/commit/c267d750d87529de9371789109047b8d68d5477f
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2022-04-21 (Thu, 21 Apr 2022)

  Changed paths:
    M qga/commands.c

  Log Message:
  -----------
  qga: remove need for QEMU atomic.h

Since the introduction of guest-exec in/out/err redirections in commit
a1853dca74 ("qga: guest-exec simple stdin/stdout/stderr redirection"),
some execution state variables are handled with atomic ops. However,
there are no threads involved in this code (and glib sources are
dispatched in the same thread), and no other obvious reason to use them.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220420132624.2439741-40-marcandre.lureau@redhat.com>


  Commit: d30c08dfe42ba3e3521e17cc41ea320366264a11
      
https://github.com/qemu/qemu/commit/d30c08dfe42ba3e3521e17cc41ea320366264a11
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2022-04-21 (Thu, 21 Apr 2022)

  Changed paths:
    M tests/qtest/fuzz/generic_fuzz.c

  Log Message:
  -----------
  tests/fuzz: fix warning

../tests/qtest/fuzz/generic_fuzz.c:746:17: warning: variable 'name' set but not 
used [-Wunused-but-set-variable]

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20220420132624.2439741-42-marcandre.lureau@redhat.com>


  Commit: 55fa0170721e827c1701db3a66a54d44b5660d53
      
https://github.com/qemu/qemu/commit/55fa0170721e827c1701db3a66a54d44b5660d53
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2022-04-21 (Thu, 21 Apr 2022)

  Changed paths:
    M qga/main.c

  Log Message:
  -----------
  qga: use fixed-length and GDateTime for log timestamp

The old code is kind of wrong. Say it's 1649309843.000001 seconds past
the epoch. Prints "1649309843.1". 9us later, it prints "1649309843.10".
Should really use %06lu for the microseconds part.

Use GDateTime instead, as suggested by Daniel.

Suggested-by: Markus Armbruster <armbru@redhat.com>
Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


  Commit: 28298069afff3eb696e4995e63b2579b27adf378
      
https://github.com/qemu/qemu/commit/28298069afff3eb696e4995e63b2579b27adf378
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2022-04-21 (Thu, 21 Apr 2022)

  Changed paths:
    M accel/stubs/tcg-stub.c
    M accel/tcg/internal.h
    M bsd-user/main.c
    M bsd-user/signal.c
    M docs/devel/style.rst
    M docs/devel/tracing.rst
    M hw/arm/allwinner-a10.c
    M hw/arm/digic.c
    M hw/hyperv/syndbg.c
    M hw/intc/exynos4210_gic.c
    M hw/misc/mips_itu.c
    M include/block/qdict.h
    M include/exec/exec-all.h
    M include/exec/helper-head.h
    M include/glib-compat.h
    M include/hw/core/cpu.h
    M include/hw/core/tcg-cpu-ops.h
    M include/hw/hw.h
    M include/monitor/monitor.h
    M include/qapi/qmp/qdict.h
    R include/qemu-common.h
    A include/qemu-main.h
    M include/qemu/compiler.h
    M include/qemu/cutils.h
    M include/qemu/error-report.h
    A include/qemu/help-texts.h
    A include/qemu/keyval.h
    M include/qemu/option.h
    M include/qemu/osdep.h
    M include/qemu/thread.h
    M include/tcg/tcg-ldst.h
    M include/tcg/tcg.h
    M linux-user/main.c
    M linux-user/signal.c
    M linux-user/user-internals.h
    M monitor/hmp.c
    M monitor/monitor.c
    M qapi/qobject-input-visitor.c
    M qemu-img.c
    M qemu-io.c
    M qemu-nbd.c
    M qga/commands-common.h
    M qga/commands-posix.c
    M qga/commands-win32.c
    M qga/commands.c
    M qga/main.c
    M qom/object_interfaces.c
    M scripts/analyze-inclusions
    M scripts/checkpatch.pl
    M scripts/cocci-macro-file.h
    M scsi/qemu-pr-helper.c
    M softmmu/main.c
    M softmmu/vl.c
    M storage-daemon/qemu-storage-daemon.c
    M stubs/error-printf.c
    M target/alpha/cpu.h
    M target/alpha/helper.c
    M target/arm/internals.h
    M target/arm/pauth_helper.c
    M target/arm/tlb_helper.c
    M target/hexagon/op_helper.c
    M target/hppa/cpu.c
    M target/hppa/cpu.h
    M target/hppa/op_helper.c
    M target/i386/tcg/bpt_helper.c
    M target/i386/tcg/excp_helper.c
    M target/i386/tcg/helper-tcg.h
    M target/i386/tcg/misc_helper.c
    M target/i386/tcg/sysemu/misc_helper.c
    M target/microblaze/cpu.h
    M target/mips/tcg/tcg-internal.h
    M target/nios2/cpu.h
    M target/openrisc/exception.c
    M target/openrisc/exception.h
    M target/openrisc/exception_helper.c
    M target/ppc/cpu.h
    M target/ppc/internal.h
    M target/riscv/cpu.h
    M target/riscv/op_helper.c
    M target/rx/op_helper.c
    M target/s390x/s390x-internal.h
    M target/s390x/tcg/excp_helper.c
    M target/s390x/tcg/tcg_s390x.h
    M target/sh4/cpu.h
    M target/sh4/op_helper.c
    M target/sparc/cpu.h
    M target/sparc/mmu_helper.c
    M target/tricore/op_helper.c
    M target/xtensa/cpu.h
    M tcg/tcg.c
    M tests/fp/fp-bench.c
    M tests/fp/fp-test.c
    M tests/qtest/fuzz/generic_fuzz.c
    M tests/qtest/libqtest.c
    M tests/unit/check-qobject.c
    M tests/unit/check-qom-proplist.c
    M tests/unit/meson.build
    M tests/unit/test-forward-visitor.c
    M tests/unit/test-keyval.c
    M tests/unit/test-qga.c
    M tools/virtiofsd/fuse_virtio.c
    M tools/virtiofsd/passthrough_ll.c
    M ui/cocoa.m
    M ui/vnc.c
    M util/compatfd.c
    M util/cutils.c
    M util/error-report.c
    M util/keyval.c
    M util/osdep.c
    M util/oslib-posix.c
    M util/oslib-win32.c

  Log Message:
  -----------
  Merge tag 'misc-pull-request' of gitlab.com:marcandre.lureau/qemu into staging

Misc cleanups

# -----BEGIN PGP SIGNATURE-----
#
# iQJQBAABCAA6FiEEh6m9kz+HxgbSdvYt2ujhCXWWnOUFAmJhYIscHG1hcmNhbmRy
# ZS5sdXJlYXVAcmVkaGF0LmNvbQAKCRDa6OEJdZac5W0jD/43n8PL2cv42lq6OaIS
# OYN9vfW9xgA9THZiUH4xEHYreZh+KofmY1PbJn1n7q+v6DecBiqM4fZr1LY8X3PM
# xRUH0l4gjXwYwX2cSSo5UTZ/PF248Uoo3tUE3vgMFkYghHMjKcTtaSkYEPGHf2nR
# t3m1qLG9w9YPhVg7PNCntjUKi+w2TtcrRVzP7V7XyFc1HrAoT0ys6KaBBrXMbcjz
# SxTRbcwSq+6aPjQIn0RWp8Hp1HkdNjegB98dkyqRLlVaugHZWPYDXDQTgVziQlX8
# dU8YrlvTOtDWwsNP6awWnW6/IjKuJjGR0wT3QKwi8JAZ0YV3egwEKoQRUAyHtnn2
# FkSMYgmJcF0ai1aIJFAx+3PIzCfS49lKXA0t303DtY3hRR9JKGMwaV2do9Wm2irt
# o7T1lKKN7R7R8Q3U4OsatYMYm7KYL07NEDiQCPloGvCo27ezkAWCKXAw1mRUkxKF
# jKwJPcnOUq21Jp6tpjsR8ifSw70jBSEWQSGqhXnDhZhx2C2/Qqkg2I8DagLiPger
# kYxbQ13LTG0R25YHa1r3UmzuD+HpZOM8XoLJc5yun/1UrwyR9ghHrOoxkSnRT2Ks
# QFn//xQ2SzUnGBNzNSMfTk8vzludxSWfFnOjkviF6E2Elnw3p8f/kOQRAft5dMBY
# ftgoy2yLone3HpKfjuOriicIzg==
# =0GLo
# -----END PGP SIGNATURE-----
# gpg: Signature made Thu 21 Apr 2022 06:47:55 AM PDT
# gpg:                using RSA key 87A9BD933F87C606D276F62DDAE8E10975969CE5
# gpg:                issuer "marcandre.lureau@redhat.com"
# gpg: Good signature from "Marc-André Lureau <marcandre.lureau@redhat.com>" 
[full]
# gpg:                 aka "Marc-André Lureau <marcandre.lureau@gmail.com>" 
[full]

* tag 'misc-pull-request' of gitlab.com:marcandre.lureau/qemu: (30 commits)
  qga: use fixed-length and GDateTime for log timestamp
  tests/fuzz: fix warning
  qga: remove need for QEMU atomic.h
  util: replace qemu_get_local_state_pathname()
  util: use qemu_create() in qemu_write_pidfile()
  util: use qemu_write_full() in qemu_write_pidfile()
  util: simplify write in signal handler
  qtest: simplify socket_send()
  qga: move qga_get_host_name()
  Move error_printf_unless_qmp() with monitor unit
  tests: run-time skip test-qga if TSAN is enabled
  compiler.h: add QEMU_SANITIZE_{ADDRESS,THREAD}
  tests: remove block/qdict checks from check-qobject.c
  include: move qdict_{crumple,flatten} declarations
  include: add qemu/keyval.h
  include: move qemu_fdatasync() to osdep
  include: move qemu_msync() to osdep
  compiler.h: replace QEMU_NORETURN with G_NORETURN
  osdep.h: move qemu_build_not_reached()
  doc/style: CLang -> Clang
  ...

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


Compare: https://github.com/qemu/qemu/compare/401d46789410...28298069afff
reply via email to
[Prev in Thread] Current Thread [Next in Thread]