qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 3f1db9: block: Fix misleading hexadecimal for


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] 3f1db9: block: Fix misleading hexadecimal format
Date: Thu, 24 Mar 2022 13:14:06 -0700

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: 3f1db95917bf0b4accaf8f56d43f795fed1fb733
      
https://github.com/qemu/qemu/commit/3f1db95917bf0b4accaf8f56d43f795fed1fb733
  Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
  Date:   2022-03-24 (Thu, 24 Mar 2022)

  Changed paths:
    M block/parallels-ext.c

  Log Message:
  -----------
  block: Fix misleading hexadecimal format

"0x%u" format is very misleading, replace by "0x%x".

Found running:

  $ git grep -E '0x%[0-9]*([lL]*|" ?PRI)[dDuU]' block/

Inspired-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Denis V. Lunev <den@openvz.org>
Message-id: 20220323114718.58714-2-philippe.mathieu.daude@gmail.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>


  Commit: 2539eade4f689eda7e9fe45486f18334bfbafaf0
      
https://github.com/qemu/qemu/commit/2539eade4f689eda7e9fe45486f18334bfbafaf0
  Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
  Date:   2022-03-24 (Thu, 24 Mar 2022)

  Changed paths:
    M hw/i386/sgx.c
    M hw/i386/trace-events
    M hw/misc/trace-events
    M hw/scsi/trace-events

  Log Message:
  -----------
  hw: Fix misleading hexadecimal format

"0x%u" format is very misleading, replace by "0x%x".

Found running:

  $ git grep -E '0x%[0-9]*([lL]*|" ?PRI)[dDuU]' hw/

Inspired-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-id: 20220323114718.58714-3-philippe.mathieu.daude@gmail.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>


  Commit: 10c473246b17be5aa72eac1ba64c1f5a690bc7ef
      
https://github.com/qemu/qemu/commit/10c473246b17be5aa72eac1ba64c1f5a690bc7ef
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2022-03-24 (Thu, 24 Mar 2022)

  Changed paths:
    M block/parallels-ext.c
    M hw/i386/sgx.c
    M hw/i386/trace-events
    M hw/misc/trace-events
    M hw/scsi/trace-events

  Log Message:
  -----------
  Merge tag 'block-pull-request' of https://gitlab.com/stefanha/qemu into 
staging

Pull request

Philippe found cases where the 0x%d format string was used, leading to
misleading output. The patches look harmless and could save people time, so I
think it's worth including them in 7.0.

# gpg: Signature made Thu 24 Mar 2022 17:15:20 GMT
# gpg:                using RSA key 8695A8BFD3F97CDAAC35775A9CA4ABB381AB73C8
# gpg: Good signature from "Stefan Hajnoczi <stefanha@redhat.com>" [full]
# gpg:                 aka "Stefan Hajnoczi <stefanha@gmail.com>" [full]
# Primary key fingerprint: 8695 A8BF D3F9 7CDA AC35  775A 9CA4 ABB3 81AB 73C8

* tag 'block-pull-request' of https://gitlab.com/stefanha/qemu:
  hw: Fix misleading hexadecimal format
  block: Fix misleading hexadecimal format

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/9c721291506c...10c473246b17



reply via email to

[Prev in Thread] Current Thread [Next in Thread]