qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 2297db: ui/gtk: Ignore 2- and 3-button press


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] 2297db: ui/gtk: Ignore 2- and 3-button press events
Date: Sat, 19 Mar 2022 07:16:22 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 2297db8228cc0ee601a21b3e3f443ab6879f2a06
      
https://github.com/qemu/qemu/commit/2297db8228cc0ee601a21b3e3f443ab6879f2a06
  Author: K. Lange <klange@toaruos.org>
  Date:   2022-03-18 (Fri, 18 Mar 2022)

  Changed paths:
    M ui/gtk.c

  Log Message:
  -----------
  ui/gtk: Ignore 2- and 3-button press events

GTK already produces corresponding GDK_BUTTON_PRESS events
alongside 2BUTTON and 3BUTTON_PRESS events. The 2BUTTON and
3BUTTON_PRESS events were incorrectly being interpreted and
passed to guests as button release events.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/558
Signed-off-by: K. Lange <klange@toaruos.org>
Message-Id: <20220305104521.3583703-1-klange@toaruos.org>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 6c08964b415a7bfd3b3ed65e7309cc3ffdb096b8
      
https://github.com/qemu/qemu/commit/6c08964b415a7bfd3b3ed65e7309cc3ffdb096b8
  Author: Wen, Jianxian <Jianxian.Wen@verisilicon.com>
  Date:   2022-03-18 (Fri, 18 Mar 2022)

  Changed paths:
    M ui/vnc.c

  Log Message:
  -----------
  ui: avoid unnecessary memory operations in vnc_refresh_server_surface()

Check the dirty bits in advance to avoid unnecessary memory operations.
In the case that guest surface has different format than the server,
but it does not have dirty bits which means no refresh is actually needed,
the memory operations is not necessary.

Signed-off-by: Jianxian Wen <jianxian.wen@verisilicon.com>
Signed-off-by: Lu Gao <lu.gao@verisilicon.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <4C23C17B8E87E74E906A25A3254A03F4FA22100C@SHASXM06.verisilicon.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 832061a2fa33b933bf3e080cbc3625ec99bacd30
      
https://github.com/qemu/qemu/commit/832061a2fa33b933bf3e080cbc3625ec99bacd30
  Author: Akihiko Odaki <akihiko.odaki@gmail.com>
  Date:   2022-03-18 (Fri, 18 Mar 2022)

  Changed paths:
    M audio/mixeng.c

  Log Message:
  -----------
  audio/mixeng: Do not declare unused variables

The unused variables when FLOAT_MIXENG is defined caused warnings on
Apple clang version 13.1.6 (clang-1316.0.21.2).

Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20220316061053.60587-1-akihiko.odaki@gmail.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 5f2011be44b8d17f93680d01d617cd9a96678886
      
https://github.com/qemu/qemu/commit/5f2011be44b8d17f93680d01d617cd9a96678886
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2022-03-18 (Fri, 18 Mar 2022)

  Changed paths:
    M hw/display/cirrus_vga.c

  Log Message:
  -----------
  hw/display/cirrus_vga: Clean up indentation in pci_cirrus_vga_realize()

Most of the code in this function had been indented with 5 spaces instead
of 4. Since 4 is our preferred style, remove one space in the bad lines here.

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20220317083027.16688-2-thuth@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 6832deb8ff0807e0b46a8a67f5d2abfa36ca3b47
      
https://github.com/qemu/qemu/commit/6832deb8ff0807e0b46a8a67f5d2abfa36ca3b47
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2022-03-18 (Fri, 18 Mar 2022)

  Changed paths:
    M hw/display/ati.c
    M hw/display/cirrus_vga.c
    M hw/display/cirrus_vga_isa.c
    M hw/display/qxl.c
    M hw/display/vga-isa.c
    M hw/display/vga-mmio.c
    M hw/display/vga-pci.c
    M hw/display/vga.c
    M hw/display/vga_int.h
    M hw/display/virtio-vga.c
    M hw/display/vmware_vga.c

  Log Message:
  -----------
  hw/display: Allow vga_common_init() to return errors

The vga_common_init() function currently cannot report errors to its
caller. But in the following patch, we'd need this possibility, so
let's change it to take an "Error **" as parameter for this.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20220317083027.16688-3-thuth@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 9eb840a20998a97c0ad0f5ced6ebc7e6a88a4dc4
      
https://github.com/qemu/qemu/commit/9eb840a20998a97c0ad0f5ced6ebc7e6a88a4dc4
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2022-03-18 (Fri, 18 Mar 2022)

  Changed paths:
    M hw/display/vga.c

  Log Message:
  -----------
  hw/display/vga: Report a proper error when adding a 2nd ISA VGA

QEMU currently abort()s if the user tries to add a second ISA VGA
device, for example:

$ ./qemu-system-x86_64 -device isa-vga -device isa-vga
RAMBlock "vga.vram" already registered, abort!
Aborted (core dumped)
$ ./qemu-system-x86_64 -device isa-cirrus-vga -device isa-cirrus-vga
RAMBlock "vga.vram" already registered, abort!
Aborted (core dumped)
$ ./qemu-system-mips64el -M pica61 -device isa-vga
RAMBlock "vga.vram" already registered, abort!
Aborted (core dumped)

Such a crash should never happen just because of giving bad parameters
at the command line. Let's return a proper error message instead.
(The idea is based on an original patch by Jose R. Ziviani for the
isa-vga device, but this now fixes it for the isa-cirrus-vga device, too)

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/44
Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20220317083027.16688-4-thuth@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 2058fdbe81e2985c226a026851dd26b146d3395c
      
https://github.com/qemu/qemu/commit/2058fdbe81e2985c226a026851dd26b146d3395c
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2022-03-19 (Sat, 19 Mar 2022)

  Changed paths:
    M audio/mixeng.c
    M hw/display/ati.c
    M hw/display/cirrus_vga.c
    M hw/display/cirrus_vga_isa.c
    M hw/display/qxl.c
    M hw/display/vga-isa.c
    M hw/display/vga-mmio.c
    M hw/display/vga-pci.c
    M hw/display/vga.c
    M hw/display/vga_int.h
    M hw/display/virtio-vga.c
    M hw/display/vmware_vga.c
    M ui/gtk.c
    M ui/vnc.c

  Log Message:
  -----------
  Merge tag 'fixes-20220318-pull-request' of git://git.kraxel.org/qemu into 
staging

bugfixes for vga, audio, vnc

# gpg: Signature made Fri 18 Mar 2022 13:56:22 GMT
# gpg:                using RSA key A0328CFFB93A17A79901FE7D4CB6D8EED3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <kraxel@redhat.com>" [full]
# gpg:                 aka "Gerd Hoffmann <gerd@kraxel.org>" [full]
# gpg:                 aka "Gerd Hoffmann (private) <kraxel@gmail.com>" [full]
# Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138

* tag 'fixes-20220318-pull-request' of git://git.kraxel.org/qemu:
  hw/display/vga: Report a proper error when adding a 2nd ISA VGA
  hw/display: Allow vga_common_init() to return errors
  hw/display/cirrus_vga: Clean up indentation in pci_cirrus_vga_realize()
  audio/mixeng: Do not declare unused variables
  ui: avoid unnecessary memory operations in vnc_refresh_server_surface()
  ui/gtk: Ignore 2- and 3-button press events

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/c9020c8e6c0d...2058fdbe81e2



reply via email to

[Prev in Thread] Current Thread [Next in Thread]