[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] f530ba: tests/tcg/s390x: Fix mvc, mvo and pac
|
From: |
Peter Maydell |
|
Subject: |
[Qemu-commits] [qemu/qemu] f530ba: tests/tcg/s390x: Fix mvc, mvo and pack tests with ... |
|
Date: |
Tue, 08 Mar 2022 11:31:04 -0800 |
Branch: refs/heads/master
Home: https://github.com/qemu/qemu
Commit: f530ba8f8d69738b7516432ab2eacd727b79c3ed
https://github.com/qemu/qemu/commit/f530ba8f8d69738b7516432ab2eacd727b79c3ed
Author: Thomas Huth <thuth@redhat.com>
Date: 2022-03-07 (Mon, 07 Mar 2022)
Changed paths:
M tests/tcg/s390x/mvc.c
M tests/tcg/s390x/mvo.c
M tests/tcg/s390x/pack.c
Log Message:
-----------
tests/tcg/s390x: Fix mvc, mvo and pack tests with Clang
These instructions use addressing with a "base address", meaning
that if register r0 is used, it is always treated as zero, no matter
what value is stored in the register. So we have to make sure not
to use register r0 for these instructions in our tests. There was
no problem with GCC so far since it seems to always pick other
registers by default, but Clang likes to chose register r0, too,
so we have to use the "a" constraint to make sure that it does
not pick r0 here.
Message-Id: <20220301093911.1450719-1-thuth@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Commit: 2b4e8cf05035a31fd20639e3a88daa39e921bd07
https://github.com/qemu/qemu/commit/2b4e8cf05035a31fd20639e3a88daa39e921bd07
Author: Thomas Huth <thuth@redhat.com>
Date: 2022-03-07 (Mon, 07 Mar 2022)
Changed paths:
M tests/tcg/s390x/exrl-trt.c
M tests/tcg/s390x/exrl-trtr.c
Log Message:
-----------
tests/tcg/s390x: Fix the exrl-trt* tests with Clang
The exrl-trt* tests use two pre-initialized variables for the
results of the assembly code:
uint64_t r1 = 0xffffffffffffffffull;
uint64_t r2 = 0xffffffffffffffffull;
But then the assembly code copies over the full contents
of the register into the output variable, without taking
care of this pre-initialized values:
" lgr %[r1],%%r1\n"
" lgr %[r2],%%r2\n"
The code then finally compares the register contents to
a value that apparently depends on the pre-initialized values:
if (r2 != 0xffffffffffffffaaull) {
write(1, "bad r2\n", 7);
return 1;
}
This all works with GCC, since the 0xffffffffffffffff got into
the r2 register there by accident, but it fails completely with
Clang.
Let's fix this by declaring the r1 and r2 variables as proper
register variables instead, so the pre-initialized values get
correctly passed into the inline assembly code.
Message-Id: <20220301092431.1448419-1-thuth@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Commit: 8b398296d4f149f34fc5630d79f1888bf22fa86a
https://github.com/qemu/qemu/commit/8b398296d4f149f34fc5630d79f1888bf22fa86a
Author: David Miller <dmiller423@gmail.com>
Date: 2022-03-07 (Mon, 07 Mar 2022)
Changed paths:
M tests/tcg/s390x/mie3-mvcrl.c
M tests/tcg/s390x/mie3-sel.c
Log Message:
-----------
tests/tcg/s390x: Cleanup of mie3 tests.
Adds clobbers and merges remaining separate asm statements.
Signed-off-by: David Miller <dmiller423@gmail.com>
Message-Id: <20220301214305.2778-1-dmiller423@gmail.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
[thuth: dropped changes to mie3-compl.c, whitespace fixes]
Signed-off-by: Thomas Huth <thuth@redhat.com>
Commit: 5be6fd0cb95e9c684c0b8685b979c9b5f63f6057
https://github.com/qemu/qemu/commit/5be6fd0cb95e9c684c0b8685b979c9b5f63f6057
Author: Thomas Huth <thuth@redhat.com>
Date: 2022-03-07 (Mon, 07 Mar 2022)
Changed paths:
M MAINTAINERS
Log Message:
-----------
MAINTAINERS: Update the files in the FreeBSD section
The FreeBSD CI definitions now reside in other files than .cirrs.yml.
Update the entry in MAINTAINERS accordingly.
Message-Id: <20220217141138.917292-1-thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Commit: 8c88e1782ffd0504c7fce1f5d2f687aa329fd593
https://github.com/qemu/qemu/commit/8c88e1782ffd0504c7fce1f5d2f687aa329fd593
Author: Thomas Huth <thuth@redhat.com>
Date: 2022-03-07 (Mon, 07 Mar 2022)
Changed paths:
M tests/avocado/avocado_qemu/__init__.py
Log Message:
-----------
tests/avocado: Cancel BootLinux tests in case there is no free port
The BootLinux tests are currently failing with an ugly python
stack trace on my RHEL8 system since they cannot get a free port
(likely due to the firewall settings on my system). Let's properly
check the return value of find_free_port() instead and cancel the
test gracefully if it cannot get a free port.
Message-Id: <20220228114325.818294-1-thuth@redhat.com>
Reviewed-by: Beraldo Leal <bleal@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Commit: 63021223ff2d3db51cb784ab645275543e9d136a
https://github.com/qemu/qemu/commit/63021223ff2d3db51cb784ab645275543e9d136a
Author: Thomas Huth <thuth@redhat.com>
Date: 2022-03-07 (Mon, 07 Mar 2022)
Changed paths:
M tests/vm/haiku.x86_64
Log Message:
-----------
tests/vm: Update haiku test vm to R1/Beta3
The old image did not have python3 yet, and thus was not usable
for compiling QEMU anymore.
Suggested-by: Alexander von Gluck IV <kallisti5@unixzen.com>
Message-Id: <20220216154208.2985103-1-kallisti5@unixzen.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Commit: 818e1636080768749dc826acd4825e71828ec7e6
https://github.com/qemu/qemu/commit/818e1636080768749dc826acd4825e71828ec7e6
Author: Rohit Kumar <rohit.kumar3@nutanix.com>
Date: 2022-03-07 (Mon, 07 Mar 2022)
Changed paths:
M softmmu/qdev-monitor.c
Log Message:
-----------
Check and report for incomplete 'global' option format
Qemu might crash when provided incomplete '-global' option.
For example:
qemu-system-x86_64 -global driver=isa-fdc
qemu-system-x86_64: ../../devel/qemu/qapi/string-input-visitor.c:394:
string_input_visitor_new: Assertion `str' failed.
Aborted (core dumped)
Fixes: 3751d7c43f795b ("vl: allow full-blown QemuOpts syntax for -global")
Signed-off-by: Rohit Kumar <rohit.kumar3@nutanix.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/604
Message-Id: <20220216071508.412974-1-rohit.kumar3@nutanix.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Commit: 9a61e6c7e1216a9a9d50e4f3973c1dcd5886b9d9
https://github.com/qemu/qemu/commit/9a61e6c7e1216a9a9d50e4f3973c1dcd5886b9d9
Author: Peter Maydell <peter.maydell@linaro.org>
Date: 2022-03-08 (Tue, 08 Mar 2022)
Changed paths:
M MAINTAINERS
M softmmu/qdev-monitor.c
M tests/avocado/avocado_qemu/__init__.py
M tests/tcg/s390x/exrl-trt.c
M tests/tcg/s390x/exrl-trtr.c
M tests/tcg/s390x/mie3-mvcrl.c
M tests/tcg/s390x/mie3-sel.c
M tests/tcg/s390x/mvc.c
M tests/tcg/s390x/mvo.c
M tests/tcg/s390x/pack.c
M tests/vm/haiku.x86_64
Log Message:
-----------
Merge remote-tracking branch
'remotes/thuth-gitlab/tags/pull-request-2022-03-07' into staging
* Fixes for s390x TCG tests
* Update Haiku VM to a usable level
* Some other miscellaneous small fixes
# gpg: Signature made Mon 07 Mar 2022 18:07:00 GMT
# gpg: using RSA key 27B88847EEE0250118F3EAB92ED9D774FE702DB5
# gpg: issuer "thuth@redhat.com"
# gpg: Good signature from "Thomas Huth <th.huth@gmx.de>" [full]
# gpg: aka "Thomas Huth <thuth@redhat.com>" [full]
# gpg: aka "Thomas Huth <huth@tuxfamily.org>" [full]
# gpg: aka "Thomas Huth <th.huth@posteo.de>" [unknown]
# Primary key fingerprint: 27B8 8847 EEE0 2501 18F3 EAB9 2ED9 D774 FE70 2DB5
* remotes/thuth-gitlab/tags/pull-request-2022-03-07:
Check and report for incomplete 'global' option format
tests/vm: Update haiku test vm to R1/Beta3
tests/avocado: Cancel BootLinux tests in case there is no free port
MAINTAINERS: Update the files in the FreeBSD section
tests/tcg/s390x: Cleanup of mie3 tests.
tests/tcg/s390x: Fix the exrl-trt* tests with Clang
tests/tcg/s390x: Fix mvc, mvo and pack tests with Clang
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Compare: https://github.com/qemu/qemu/compare/9740b907a536...9a61e6c7e121