[Qemu-commits] [qemu/qemu] e0bd74: 9p: linux: Fix a couple Linux assumpt

qemu-commits
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] e0bd74: 9p: linux: Fix a couple Linux assumpt

From:	Peter Maydell
Subject:	[Qemu-commits] [qemu/qemu] e0bd74: 9p: linux: Fix a couple Linux assumptions
Date:	Tue, 08 Mar 2022 01:12:47 -0800
  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: e0bd743bb2dd4985791d4de880446bdbb4e04fed
      
https://github.com/qemu/qemu/commit/e0bd743bb2dd4985791d4de880446bdbb4e04fed
  Author: Keno Fischer <keno@juliacomputing.com>
  Date:   2022-03-07 (Mon, 07 Mar 2022)

  Changed paths:
    M fsdev/file-op-9p.h
    M hw/9pfs/9p-local.c
    M hw/9pfs/9p.c
    M include/qemu/xattr.h

  Log Message:
  -----------
  9p: linux: Fix a couple Linux assumptions

 - Guard Linux only headers.
 - Add qemu/statfs.h header to abstract over the which
   headers are needed for struct statfs
 - Define `ENOATTR` only if not only defined
   (it's defined in system headers on Darwin).

Signed-off-by: Keno Fischer <keno@juliacomputing.com>
[Michael Roitzsch: - Rebase for NixOS]
Signed-off-by: Michael Roitzsch <reactorcontrol@icloud.com>

While it might at first appear that fsdev/virtfs-proxy-header.c would
need similar adjustment for darwin as file-op-9p here, a later patch in
this series disables virtfs-proxy-helper for non-Linux. Allowing
virtfs-proxy-helper on darwin could potentially be an additional
optimization later.

[Will Cohen: - Fix headers for Alpine
             - Integrate statfs.h back into file-op-9p.h
             - Remove superfluous header guards from file-opt-9p
             - Add note about virtfs-proxy-helper being disabled
               on non-Linux for this patch series]
Signed-off-by: Will Cohen <wwcohen@gmail.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Greg Kurz <groug@kaod.org>
Message-Id: <20220227223522.91937-2-wwcohen@gmail.com>
Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>


  Commit: 6450084a66b6cf72b9126a8c8ecead7ddca896e9
      
https://github.com/qemu/qemu/commit/6450084a66b6cf72b9126a8c8ecead7ddca896e9
  Author: Keno Fischer <keno@juliacomputing.com>
  Date:   2022-03-07 (Mon, 07 Mar 2022)

  Changed paths:
    A hw/9pfs/9p-util-linux.c
    R hw/9pfs/9p-util.c
    M hw/9pfs/meson.build

  Log Message:
  -----------
  9p: Rename 9p-util -> 9p-util-linux

The current file only has the Linux versions of these functions.
Rename the file accordingly and update the Makefile to only build
it on Linux. A Darwin version of these will follow later in the
series.

Signed-off-by: Keno Fischer <keno@juliacomputing.com>
[Michael Roitzsch: - Rebase for NixOS]
Signed-off-by: Michael Roitzsch <reactorcontrol@icloud.com>
Signed-off-by: Will Cohen <wwcohen@gmail.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20220227223522.91937-3-wwcohen@gmail.com>
Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>


  Commit: f41db099c71151291c269bf48ad006de9cbd9ca6
      
https://github.com/qemu/qemu/commit/f41db099c71151291c269bf48ad006de9cbd9ca6
  Author: Keno Fischer <keno@juliacomputing.com>
  Date:   2022-03-07 (Mon, 07 Mar 2022)

  Changed paths:
    M hw/9pfs/9p-proxy.c
    M hw/9pfs/9p-synth.c
    M hw/9pfs/9p.c

  Log Message:
  -----------
  9p: darwin: Handle struct stat(fs) differences

Signed-off-by: Keno Fischer <keno@juliacomputing.com>
Signed-off-by: Michael Roitzsch <reactorcontrol@icloud.com>
[Will Cohen: - Note lack of f_namelen and f_frsize on Darwin
             - Ensure that tv_sec and tv_nsec are both
               initialized for Darwin and non-Darwin]
Signed-off-by: Will Cohen <wwcohen@gmail.com>
Message-Id: <20220227223522.91937-4-wwcohen@gmail.com>
Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Reviewed-by: Christian Schoenebeck <qemu_oss@crudebyte.com>


  Commit: 6b3b279bd670c6a2fa23c9049820c814f0e2c846
      
https://github.com/qemu/qemu/commit/6b3b279bd670c6a2fa23c9049820c814f0e2c846
  Author: Keno Fischer <keno@juliacomputing.com>
  Date:   2022-03-07 (Mon, 07 Mar 2022)

  Changed paths:
    M hw/9pfs/9p-local.c
    M hw/9pfs/9p-proxy.c
    M hw/9pfs/9p-synth.c
    M hw/9pfs/9p-util.h
    M hw/9pfs/9p.c
    M hw/9pfs/codir.c

  Log Message:
  -----------
  9p: darwin: Handle struct dirent differences

On darwin d_seekoff exists, but is optional and does not seem to
be commonly used by file systems. Use `telldir` instead to obtain
the seek offset and inject it into d_seekoff, and create a
qemu_dirent_off helper to call it appropriately when appropriate.

Signed-off-by: Keno Fischer <keno@juliacomputing.com>
[Michael Roitzsch: - Rebase for NixOS]
Signed-off-by: Michael Roitzsch <reactorcontrol@icloud.com>
[Will Cohen: - Adjust to pass testing
             - Ensure that d_seekoff is filled using telldir
               on darwin, and create qemu_dirent_off helper
               to decide which to access]
[Fabian Franz: - Add telldir error handling for darwin]
Signed-off-by: Fabian Franz <fabianfranz.oss@gmail.com>
[Will Cohen: - Ensure that telldir error handling uses
               signed int
             - Cleanup of telldir error handling
             - Remove superfluous error handling for
               qemu_dirent_off
             - Adjust formatting
             - Use qemu_dirent_off in codir.c
             - Declare qemu_dirent_off as static to prevent
               linker error
             - Move qemu_dirent_off above the end-of-file
               endif to fix compilation]
Signed-off-by: Will Cohen <wwcohen@gmail.com>
Message-Id: <20220227223522.91937-5-wwcohen@gmail.com>
Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Reviewed-by: Christian Schoenebeck <qemu_oss@crudebyte.com>


  Commit: 67a71e3b71a2834d028031a92e76eb9444e423c6
      
https://github.com/qemu/qemu/commit/67a71e3b71a2834d028031a92e76eb9444e423c6
  Author: Keno Fischer <keno@juliacomputing.com>
  Date:   2022-03-07 (Mon, 07 Mar 2022)

  Changed paths:
    M hw/9pfs/9p-util.h
    M hw/9pfs/9p.c

  Log Message:
  -----------
  9p: darwin: Ignore O_{NOATIME, DIRECT}

Darwin doesn't have either of these flags. Darwin does have
F_NOCACHE, which is similar to O_DIRECT, but has different
enough semantics that other projects don't generally map
them automatically. In any case, we don't support O_DIRECT
on Linux at the moment either.

Signed-off-by: Keno Fischer <keno@juliacomputing.com>
[Michael Roitzsch: - Rebase for NixOS]
Signed-off-by: Michael Roitzsch <reactorcontrol@icloud.com>
[Will Cohen: - Adjust coding style]
Signed-off-by: Will Cohen <wwcohen@gmail.com>
Message-Id: <20220227223522.91937-6-wwcohen@gmail.com>
[C.S.: - Fix compiler warning "unused label 'again'". ]
Link: https://lore.kernel.org/qemu-devel/11201492.CjeqJxXfGd@silver/
Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Reviewed-by: Christian Schoenebeck <qemu_oss@crudebyte.com>


  Commit: 38d7fd68b0c8775b5253ab84367419621aa032e6
      
https://github.com/qemu/qemu/commit/38d7fd68b0c8775b5253ab84367419621aa032e6
  Author: Keno Fischer <keno@juliacomputing.com>
  Date:   2022-03-07 (Mon, 07 Mar 2022)

  Changed paths:
    M hw/9pfs/9p.c
    M hw/9pfs/9p.h

  Log Message:
  -----------
  9p: darwin: Move XATTR_SIZE_MAX->P9_XATTR_SIZE_MAX

Signed-off-by: Keno Fischer <keno@juliacomputing.com>
Signed-off-by: Michael Roitzsch <reactorcontrol@icloud.com>

Because XATTR_SIZE_MAX is not defined on Darwin,
create a cross-platform P9_XATTR_SIZE_MAX instead.

[Will Cohen: - Adjust coding style
             - Lower XATTR_SIZE_MAX to 64k
             - Add explanatory context related to XATTR_SIZE_MAX]
[Fabian Franz: - Move XATTR_SIZE_MAX reference from 9p.c to
                 P9_XATTR_SIZE_MAX in 9p.h]
Signed-off-by: Will Cohen <wwcohen@gmail.com>
Signed-off-by: Fabian Franz <fabianfranz.oss@gmail.com>
[Will Cohen: - For P9_XATTR_MAX, ensure that Linux uses
               XATTR_SIZE_MAX, Darwin uses 64k, and error
               out for undefined hosts]
Signed-off-by: Will Cohen <wwcohen@gmail.com>
Message-Id: <20220227223522.91937-7-wwcohen@gmail.com>
Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Reviewed-by: Christian Schoenebeck <qemu_oss@crudebyte.com>


  Commit: 57b3910bc3513ab515296692daafd1c546f3c115
      
https://github.com/qemu/qemu/commit/57b3910bc3513ab515296692daafd1c546f3c115
  Author: Keno Fischer <keno@juliacomputing.com>
  Date:   2022-03-07 (Mon, 07 Mar 2022)

  Changed paths:
    A hw/9pfs/9p-util-darwin.c
    M hw/9pfs/meson.build

  Log Message:
  -----------
  9p: darwin: *xattr_nofollow implementations

This implements the darwin equivalent of the functions that were
moved to 9p-util(-linux) earlier in this series in the new
9p-util-darwin file.

Signed-off-by: Keno Fischer <keno@juliacomputing.com>
[Michael Roitzsch: - Rebase for NixOS]
Signed-off-by: Michael Roitzsch <reactorcontrol@icloud.com>
Signed-off-by: Will Cohen <wwcohen@gmail.com>
Message-Id: <20220227223522.91937-8-wwcohen@gmail.com>
Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Acked-by: Christian Schoenebeck <qemu_oss@crudebyte.com>


  Commit: b5989326f558faedd2511f29459112cced2ca8f5
      
https://github.com/qemu/qemu/commit/b5989326f558faedd2511f29459112cced2ca8f5
  Author: Keno Fischer <keno@juliacomputing.com>
  Date:   2022-03-07 (Mon, 07 Mar 2022)

  Changed paths:
    M hw/9pfs/9p-local.c
    M hw/9pfs/9p-util.h

  Log Message:
  -----------
  9p: darwin: Compatibility for f/l*xattr

On darwin `fgetxattr` takes two extra optional arguments,
and the l* variants are not defined (in favor of an extra
flag to the regular variants.

Signed-off-by: Keno Fischer <keno@juliacomputing.com>
[Michael Roitzsch: - Rebase for NixOS]
Signed-off-by: Michael Roitzsch <reactorcontrol@icloud.com>
Signed-off-by: Will Cohen <wwcohen@gmail.com>
Message-Id: <20220227223522.91937-9-wwcohen@gmail.com>
Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Acked-by: Christian Schoenebeck <qemu_oss@crudebyte.com>


  Commit: 029ed1bd9defa33a80bb40cdcd003699299af8db
      
https://github.com/qemu/qemu/commit/029ed1bd9defa33a80bb40cdcd003699299af8db
  Author: Keno Fischer <keno@juliacomputing.com>
  Date:   2022-03-07 (Mon, 07 Mar 2022)

  Changed paths:
    M hw/9pfs/9p-local.c
    M hw/9pfs/9p-util-darwin.c
    M hw/9pfs/9p-util-linux.c
    M hw/9pfs/9p-util.h
    M meson.build

  Log Message:
  -----------
  9p: darwin: Implement compatibility for mknodat

Darwin does not support mknodat. However, to avoid race conditions
with later setting the permissions, we must avoid using mknod on
the full path instead. We could try to fchdir, but that would cause
problems if multiple threads try to call mknodat at the same time.
However, luckily there is a solution: Darwin includes a function
that sets the cwd for the current thread only.
This should suffice to use mknod safely.

This function (pthread_fchdir_np) is protected by a check in
meson in a patch later in this series.

Signed-off-by: Keno Fischer <keno@juliacomputing.com>
Signed-off-by: Michael Roitzsch <reactorcontrol@icloud.com>
[Will Cohen: - Adjust coding style
             - Replace clang references with gcc
             - Note radar filed with Apple for missing syscall
             - Replace direct syscall with pthread_fchdir_np and
               adjust patch notes accordingly
             - Declare pthread_fchdir_np with
             - __attribute__((weak_import)) to allow checking for
               its presence before usage
             - Move declarations above cplusplus guard
             - Add CONFIG_PTHREAD_FCHDIR_NP to meson and check for
               presence in 9p-util
             - Rebase to apply cleanly on top of the 2022-02-10
               changes to 9pfs
             - Fix line over 90 characters formatting error]
Signed-off-by: Will Cohen <wwcohen@gmail.com>
Message-Id: <20220227223522.91937-10-wwcohen@gmail.com>
Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Reviewed-by: Christian Schoenebeck <qemu_oss@crudebyte.com>


  Commit: d3671fd972cd185a6923433aa4802f54d8b62112
      
https://github.com/qemu/qemu/commit/d3671fd972cd185a6923433aa4802f54d8b62112
  Author: Will Cohen <wwcohen@gmail.com>
  Date:   2022-03-07 (Mon, 07 Mar 2022)

  Changed paths:
    M tests/qtest/virtio-9p-test.c

  Log Message:
  -----------
  9p: darwin: Adjust assumption on virtio-9p-test

The previous test depended on the assumption that P9_DOTL_AT_REMOVEDIR
and AT_REMOVEDIR have the same value.

While this is true on Linux, it is not true everywhere, and leads to an
incorrect test failure on unlink_at, noticed when adding 9p to darwin:

Received response 7 (RLERROR) instead of 77 (RUNLINKAT)
Rlerror has errno 22 (Invalid argument)
**

ERROR:../tests/qtest/virtio-9p-test.c:305:v9fs_req_recv: assertion
failed (hdr.id == id): (7 == 77) Bail out!

ERROR:../tests/qtest/virtio-9p-test.c:305:v9fs_req_recv: assertion
failed (hdr.id == id): (7 == 77)

Signed-off-by: Fabian Franz <fabianfranz.oss@gmail.com>
[Will Cohen: - Add explanation of patch and description
               of pre-patch test failure]
Signed-off-by: Will Cohen <wwcohen@gmail.com>
Acked-by: Thomas Huth <thuth@redhat.com>
[Will Cohen: - Move this patch before 9p: darwin: meson
               patch to avoid qtest breakage during
               bisecting]
Signed-off-by: Will Cohen <wwcohen@gmail.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Message-Id: <20220227223522.91937-11-wwcohen@gmail.com>
Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>


  Commit: 0fb1e19d78536e23b650ca72decdc29c98f2dcc1
      
https://github.com/qemu/qemu/commit/0fb1e19d78536e23b650ca72decdc29c98f2dcc1
  Author: Keno Fischer <keno@juliacomputing.com>
  Date:   2022-03-07 (Mon, 07 Mar 2022)

  Changed paths:
    M fsdev/meson.build
    M meson.build

  Log Message:
  -----------
  9p: darwin: meson: Allow VirtFS on Darwin

To allow VirtFS on darwin, we need to check that pthread_fchdir_np is
available, which has only been available since macOS 10.12.

Additionally, virtfs_proxy_helper is disabled on Darwin. This patch
series does not currently provide an implementation of the proxy-helper,
but this functionality could be implemented later on.

Signed-off-by: Keno Fischer <keno@juliacomputing.com>
[Michael Roitzsch: - Rebase for NixOS]
Signed-off-by: Michael Roitzsch <reactorcontrol@icloud.com>
[Will Cohen: - Rebase to master]
Signed-off-by: Will Cohen <wwcohen@gmail.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
[Will Cohen: - Add check for pthread_fchdir_np to virtfs
             - Add comments to patch commit
             - Note that virtfs_proxy_helper does not work
               on macOS
             - Fully adjust meson virtfs error note to specify
               macOS
             - Rebase to master]
Signed-off-by: Will Cohen <wwcohen@gmail.com>
Message-Id: <20220227223522.91937-12-wwcohen@gmail.com>
Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Acked-by: Christian Schoenebeck <qemu_oss@crudebyte.com>


  Commit: 1983d8b0d6b013f025905c7d37e3f0261edc328b
      
https://github.com/qemu/qemu/commit/1983d8b0d6b013f025905c7d37e3f0261edc328b
  Author: Christian Schoenebeck <qemu_oss@crudebyte.com>
  Date:   2022-03-07 (Mon, 07 Mar 2022)

  Changed paths:
    M hw/9pfs/9p-util.h
    M include/qemu/osdep.h
    M util/osdep.c

  Log Message:
  -----------
  9pfs: move qemu_dirent_dup() from osdep -> 9p-util

Function qemu_dirent_dup() is currently only used by 9pfs server, so move
it from project global header osdep.h to 9pfs specific header 9p-util.h.

Link: 
https://lore.kernel.org/qemu-devel/CAFEAcA_=HAUNomKD2wurSVaAHa5mrk22A1oHKLWUDjk7v6Khmg@mail.gmail.com/
Based-on: <20220227223522.91937-12-wwcohen@gmail.com>
Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <E1nP9Oz-00043L-KJ@lizzy.crudebyte.com>


  Commit: 63ce31c35da18f9dbd9b7dbea5b6e1d2b85deb24
      
https://github.com/qemu/qemu/commit/63ce31c35da18f9dbd9b7dbea5b6e1d2b85deb24
  Author: Christian Schoenebeck <qemu_oss@crudebyte.com>
  Date:   2022-03-07 (Mon, 07 Mar 2022)

  Changed paths:
    M hw/9pfs/9p-util.h

  Log Message:
  -----------
  9pfs: drop Doxygen format from qemu_dirent_dup() API comment

API doc comments in QEMU are supposed to be in kerneldoc format, so drop
occurrences of "@c" which is Doxygen format for fixed-width text.

Link: 
https://lore.kernel.org/qemu-devel/CAFEAcA89+ENOM6x19OEF53Kd2DWkhN5SN21Va0D7yepJSa3Jyg@mail.gmail.com/
Based-on: <E1nP9Oz-00043L-KJ@lizzy.crudebyte.com>
Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Greg Kurz <groug@kaod.org>
Message-Id: <E1nPTwO-0006pl-Np@lizzy.crudebyte.com>


  Commit: 39db33471909f8ab083e1a079eeae6975b55df13
      
https://github.com/qemu/qemu/commit/39db33471909f8ab083e1a079eeae6975b55df13
  Author: Christian Schoenebeck <qemu_oss@crudebyte.com>
  Date:   2022-03-07 (Mon, 07 Mar 2022)

  Changed paths:
    M hw/9pfs/9p.h

  Log Message:
  -----------
  9pfs/9p.h: convert Doxygen -> kerneldoc format

API doc comments in QEMU are supposed to be in kerneldoc format, so
convert API doc comments from Doxygen format to kerneldoc format.

Based-on: <E1nPTwO-0006pl-Np@lizzy.crudebyte.com>
Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Message-Id: 
<2b8f91de7bac3d3bc85d60eb08830a35a394be75.1646314856.git.qemu_oss@crudebyte.com>


  Commit: 1a7f2400148fd273536daa0adba5ecdea35c4bfb
      
https://github.com/qemu/qemu/commit/1a7f2400148fd273536daa0adba5ecdea35c4bfb
  Author: Christian Schoenebeck <qemu_oss@crudebyte.com>
  Date:   2022-03-07 (Mon, 07 Mar 2022)

  Changed paths:
    M hw/9pfs/codir.c

  Log Message:
  -----------
  9pfs/codir.c: convert Doxygen -> kerneldoc format

API doc comments in QEMU are supposed to be in kerneldoc format, so
convert API doc comments from Doxygen format to kerneldoc format.

Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Message-Id: 
<c76be7d38ea448c6417b2ffb5ccd6b711519a878.1646314856.git.qemu_oss@crudebyte.com>


  Commit: e16fea4156b6f0877df45104320164501ca689f6
      
https://github.com/qemu/qemu/commit/e16fea4156b6f0877df45104320164501ca689f6
  Author: Christian Schoenebeck <qemu_oss@crudebyte.com>
  Date:   2022-03-07 (Mon, 07 Mar 2022)

  Changed paths:
    M hw/9pfs/9p.c

  Log Message:
  -----------
  9pfs/9p.c: convert Doxygen -> kerneldoc format

API doc comments in QEMU are supposed to be in kerneldoc format, so
convert API doc comments from Doxygen format to kerneldoc format.

Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Message-Id: 
<4ece6ffa4465c271c6a7c42a3040f42780fcce87.1646314856.git.qemu_oss@crudebyte.com>


  Commit: 041b0945f98821fe4b1a3caf5c081ca35032279c
      
https://github.com/qemu/qemu/commit/041b0945f98821fe4b1a3caf5c081ca35032279c
  Author: Christian Schoenebeck <qemu_oss@crudebyte.com>
  Date:   2022-03-07 (Mon, 07 Mar 2022)

  Changed paths:
    M hw/9pfs/9p-util.h

  Log Message:
  -----------
  9pfs/9p-util.h: convert Doxygen -> kerneldoc format

API doc comments in QEMU are supposed to be in kerneldoc format, so
convert API doc comments from Doxygen format to kerneldoc format.

Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Message-Id: 
<dc1c4a85e233f5884ee5f6ec96b87db286083df7.1646314856.git.qemu_oss@crudebyte.com>


  Commit: 09d19d58078767f14f9a602eb939743d0a7c7a85
      
https://github.com/qemu/qemu/commit/09d19d58078767f14f9a602eb939743d0a7c7a85
  Author: Christian Schoenebeck <qemu_oss@crudebyte.com>
  Date:   2022-03-07 (Mon, 07 Mar 2022)

  Changed paths:
    M hw/9pfs/coth.h

  Log Message:
  -----------
  9pfs/coth.h: drop Doxygen format on v9fs_co_run_in_worker()

API doc comments in QEMU are supposed to be in kerneldoc format, so
drop Doxygen format used on v9fs_co_run_in_worker() macro.

Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Message-Id: 
<a8fdf0290d1e40a68f5577f29aeae12298b70733.1646314856.git.qemu_oss@crudebyte.com>


  Commit: 35b6466459f9234b9cb30296f243a70b6f1b44b7
      
https://github.com/qemu/qemu/commit/35b6466459f9234b9cb30296f243a70b6f1b44b7
  Author: Christian Schoenebeck <qemu_oss@crudebyte.com>
  Date:   2022-03-07 (Mon, 07 Mar 2022)

  Changed paths:
    M fsdev/p9array.h

  Log Message:
  -----------
  fsdev/p9array.h: convert Doxygen -> kerneldoc format

API doc comments in QEMU are supposed to be in kerneldoc format, so
convert API doc comments from Doxygen format to kerneldoc format.

Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Message-Id: 
<2e2d46a402560f155de322d95789ba107d728885.1646314856.git.qemu_oss@crudebyte.com>


  Commit: f45cc81911adc7726e8a2801986b6998b91b816e
      
https://github.com/qemu/qemu/commit/f45cc81911adc7726e8a2801986b6998b91b816e
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2022-03-08 (Tue, 08 Mar 2022)

  Changed paths:
    M fsdev/file-op-9p.h
    M fsdev/meson.build
    M fsdev/p9array.h
    M hw/9pfs/9p-local.c
    M hw/9pfs/9p-proxy.c
    M hw/9pfs/9p-synth.c
    A hw/9pfs/9p-util-darwin.c
    A hw/9pfs/9p-util-linux.c
    R hw/9pfs/9p-util.c
    M hw/9pfs/9p-util.h
    M hw/9pfs/9p.c
    M hw/9pfs/9p.h
    M hw/9pfs/codir.c
    M hw/9pfs/coth.h
    M hw/9pfs/meson.build
    M include/qemu/osdep.h
    M include/qemu/xattr.h
    M meson.build
    M tests/qtest/virtio-9p-test.c
    M util/osdep.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/cschoenebeck/tags/pull-9p-20220307' 
into staging

9pfs: introduce macOS host support and cleanup

* Add support for Darwin (a.k.a. macOS) hosts.

* Code cleanup (move qemu_dirent_dup() from osdep -> 9p-util).

* API doc cleanup (convert Doxygen -> kerneldoc format).

# gpg: Signature made Mon 07 Mar 2022 11:14:45 GMT
# gpg:                using RSA key 96D8D110CF7AF8084F88590134C2B58765A47395
# gpg:                issuer "qemu_oss@crudebyte.com"
# gpg: Good signature from "Christian Schoenebeck <qemu_oss@crudebyte.com>" 
[unknown]
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg:          There is no indication that the signature belongs to the owner.
# Primary key fingerprint: ECAB 1A45 4014 1413 BA38  4926 30DB 47C3 A012 D5F4
#      Subkey fingerprint: 96D8 D110 CF7A F808 4F88  5901 34C2 B587 65A4 7395

* remotes/cschoenebeck/tags/pull-9p-20220307:
  fsdev/p9array.h: convert Doxygen -> kerneldoc format
  9pfs/coth.h: drop Doxygen format on v9fs_co_run_in_worker()
  9pfs/9p-util.h: convert Doxygen -> kerneldoc format
  9pfs/9p.c: convert Doxygen -> kerneldoc format
  9pfs/codir.c: convert Doxygen -> kerneldoc format
  9pfs/9p.h: convert Doxygen -> kerneldoc format
  9pfs: drop Doxygen format from qemu_dirent_dup() API comment
  9pfs: move qemu_dirent_dup() from osdep -> 9p-util
  9p: darwin: meson: Allow VirtFS on Darwin
  9p: darwin: Adjust assumption on virtio-9p-test
  9p: darwin: Implement compatibility for mknodat
  9p: darwin: Compatibility for f/l*xattr
  9p: darwin: *xattr_nofollow implementations
  9p: darwin: Move XATTR_SIZE_MAX->P9_XATTR_SIZE_MAX
  9p: darwin: Ignore O_{NOATIME, DIRECT}
  9p: darwin: Handle struct dirent differences
  9p: darwin: Handle struct stat(fs) differences
  9p: Rename 9p-util -> 9p-util-linux
  9p: linux: Fix a couple Linux assumptions

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/99c4a9e68eaf...f45cc81911ad
[Prev in Thread]
Current Thread
[Next in Thread]
[Qemu-commits] [qemu/qemu] e0bd74: 9p: linux: Fix a couple Linux assumptions, Peter Maydell <=
- [Qemu-commits] [qemu/qemu] e0bd74: 9p: linux: Fix a couple Linux assumptions, Peter Maydell, 2022/03/08
Prev by Date: [Qemu-commits] [qemu/qemu] f9a6bc: accel: Restrict sysemu stubs to system emulation
Next by Date: [Qemu-commits] [qemu/qemu] e0bd74: 9p: linux: Fix a couple Linux assumptions
Previous by thread: [Qemu-commits] [qemu/qemu] 7e5cdb: ide: Increment BB in-flight counter for TRIM BH
Next by thread: [Qemu-commits] [qemu/qemu] e0bd74: 9p: linux: Fix a couple Linux assumptions
Index(es):
- Date
- Thread