[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] 42c939: hw/usb: pacify xhciwmi.exe warning
|
From: |
Peter Maydell |
|
Subject: |
[Qemu-commits] [qemu/qemu] 42c939: hw/usb: pacify xhciwmi.exe warning |
|
Date: |
Sat, 05 Mar 2022 02:46:49 -0800 |
Branch: refs/heads/master
Home: https://github.com/qemu/qemu
Commit: 42c93917f7829190fcae05c5c0827d0c187d7713
https://github.com/qemu/qemu/commit/42c93917f7829190fcae05c5c0827d0c187d7713
Author: Denis V. Lunev <den@openvz.org>
Date: 2022-03-04 (Fri, 04 Mar 2022)
Changed paths:
M hw/usb/hcd-xhci.c
Log Message:
-----------
hw/usb: pacify xhciwmi.exe warning
xhciwmi.exe is used inside Windows 2022 SVVP tests. This tool called as
'xhciwmi.exe --verify' reports that 'The firmware loaded on this
controller has known bugs and/or compatibility issues'. This is just
a warning but there is no particular sense to ignore it.
This patch just pacifies the tool.
There is a big question whether this change should be put using
machine type mechanics, but at my opinion this would be an overkill.
Signed-off-by: Denis V. Lunev <den@openvz.org>
Tested-by: Pavel Polozov <pavel.polozov@virtuozzo.com>
CC: Yan Vugenfirer <yvugenfi@redhat.com>
CC: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Yan Vugenfirer <yvugenfi@redhat.com>
Message-Id: <20211223095443.130276-1-den@openvz.org>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: 7c204e96384b8e03b917fd30abf3bc96da237990
https://github.com/qemu/qemu/commit/7c204e96384b8e03b917fd30abf3bc96da237990
Author: Volker Rümelin <vr_qemu@t-online.de>
Date: 2022-03-04 (Fri, 04 Mar 2022)
Changed paths:
M hw/usb/dev-mtp.c
Log Message:
-----------
hw/usb/dev-mtp: create directories with a+x mode mask
Current code creates directories with mode 0644. Even the creator
can't create files in the new directory. Set all x mode flags in
variable mask and clear all x mode flags in function open() to
preserve the current open mode.
Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Message-Id: <20220122140619.7514-1-vr_qemu@t-online.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: 6e821e5084fb1169d653c835b3819acf94e8b52c
https://github.com/qemu/qemu/commit/6e821e5084fb1169d653c835b3819acf94e8b52c
Author: BALATON Zoltan <balaton@eik.bme.hu>
Date: 2022-03-04 (Fri, 04 Mar 2022)
Changed paths:
M hw/usb/hcd-ohci.c
M hw/usb/trace-events
Log Message:
-----------
usb/ohci: Move trace point and log ep number to help debugging
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Message-Id:
<4e3a05a64b5029a88654eab9a873fb45ac80b1a7.1643117600.git.balaton@eik.bme.hu>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: ae310557f4ec635dadb5a0857fb9bd592016919c
https://github.com/qemu/qemu/commit/ae310557f4ec635dadb5a0857fb9bd592016919c
Author: BALATON Zoltan <balaton@eik.bme.hu>
Date: 2022-03-04 (Fri, 04 Mar 2022)
Changed paths:
M hw/usb/hcd-ohci.c
Log Message:
-----------
usb/ohci: Move cancelling async packet to ohci_stop_endpoints()
This is always done before calling this function so remove duplicated
code and do it within the function at one place.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Message-Id:
<ce766722506bfd7145cccbec750692ff57072280.1643117600.git.balaton@eik.bme.hu>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: 37bf0654b8e6195e2255e7d5f737a66b0ef4d83f
https://github.com/qemu/qemu/commit/37bf0654b8e6195e2255e7d5f737a66b0ef4d83f
Author: BALATON Zoltan <balaton@eik.bme.hu>
Date: 2022-03-04 (Fri, 04 Mar 2022)
Changed paths:
M hw/usb/hcd-ohci.c
Log Message:
-----------
usb/ohci: Move USBPortOps related functions together
This also allows removing two forward declarations
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id:
<9fd730375c4cad0b11163631660d68711d3fc13f.1643117600.git.balaton@eik.bme.hu>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: b6b0c066f5750c3c977b647509f225ba06038b60
https://github.com/qemu/qemu/commit/b6b0c066f5750c3c977b647509f225ba06038b60
Author: BALATON Zoltan <balaton@eik.bme.hu>
Date: 2022-03-04 (Fri, 04 Mar 2022)
Changed paths:
M hw/usb/hcd-ohci.c
Log Message:
-----------
usb/ohci: Merge ohci_async_cancel_device() into ohci_child_detach()
These two do the same and only used once so no need to have two
functions, simplify by merging them.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id:
<5fc8ba0bbf55703014d22dd06ab2f9eabaf370bf.1643117600.git.balaton@eik.bme.hu>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: 3a4d06f26f2606dd5029b05b4aff97f198455249
https://github.com/qemu/qemu/commit/3a4d06f26f2606dd5029b05b4aff97f198455249
Author: BALATON Zoltan <balaton@eik.bme.hu>
Date: 2022-03-04 (Fri, 04 Mar 2022)
Changed paths:
M hw/usb/hcd-ohci.c
Log Message:
-----------
usb/ohci: Don't use packet from OHCIState for isochronous transfers
Since isochronous transfers cannot be handled async (the function
returns error in that case) we don't need to remember the packet.
Avoid using the usb_packet field in OHCIState (as that can be a
waiting async packet on another endpoint) and allocate and use a local
USBPacket for the iso transfer instead. After this we don't have to
care if we're called from a completion callback or not so we can drop
that parameter as well.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Message-Id:
<bf523d40f8088a84383cb00ffd2e6e82fa47790d.1643117600.git.balaton@eik.bme.hu>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: 18404ff111e43d218b36b69ae002cae58acef352
https://github.com/qemu/qemu/commit/18404ff111e43d218b36b69ae002cae58acef352
Author: Volker Rümelin <vr_qemu@t-online.de>
Date: 2022-03-04 (Fri, 04 Mar 2022)
Changed paths:
M audio/audio.c
M audio/audio_int.h
M audio/coreaudio.c
M audio/sdlaudio.c
Log Message:
-----------
audio: replace open-coded buffer arithmetic
Replace open-coded buffer arithmetic with the new function
audio_ring_posb(). That's the position in backward direction
of a given point at a given distance.
Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Reviewed-by: Akihiko Odaki <akihiko.odaki@gmail.com>
Message-Id: <20220301191311.26695-1-vr_qemu@t-online.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: 8e56a172a15708c6b7382fbf3441bed26bc0ffef
https://github.com/qemu/qemu/commit/8e56a172a15708c6b7382fbf3441bed26bc0ffef
Author: Volker Rümelin <vr_qemu@t-online.de>
Date: 2022-03-04 (Fri, 04 Mar 2022)
Changed paths:
M audio/audio.c
Log Message:
-----------
audio: move function audio_pcm_hw_clip_out()
Move the function audio_pcm_hw_clip_out() into the correct
section 'Hard voice (playback)'.
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Message-Id: <20220301191311.26695-2-vr_qemu@t-online.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: 251f15496ec5f274f100cd155eb60b9add96196e
https://github.com/qemu/qemu/commit/251f15496ec5f274f100cd155eb60b9add96196e
Author: Volker Rümelin <vr_qemu@t-online.de>
Date: 2022-03-04 (Fri, 04 Mar 2022)
Changed paths:
M audio/audio.c
Log Message:
-----------
audio: add function audio_pcm_hw_conv_in()
Add a function audio_pcm_hw_conv_in() similar to the existing
counterpart function audio_pcm_hw_clip_out(). This function reduces
the number of calls to the pcm_ops functions get_buffer_in() and
put_buffer_in(). That's one less call to get_buffer_in() and
put_buffer_in() every time the conv_buffer wraps around.
Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Message-Id: <20220301191311.26695-3-vr_qemu@t-online.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: 0ceb26af0c2f4f07ed5d2c2493552501926df45b
https://github.com/qemu/qemu/commit/0ceb26af0c2f4f07ed5d2c2493552501926df45b
Author: Volker Rümelin <vr_qemu@t-online.de>
Date: 2022-03-04 (Fri, 04 Mar 2022)
Changed paths:
M audio/audio.c
Log Message:
-----------
audio: inline function audio_pcm_sw_get_rpos_in()
Simplify code by inlining function audio_pcm_sw_get_rpos_in()
at the only call site and remove the duplicated audio_bug()
test.
Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Message-Id: <20220301191311.26695-4-vr_qemu@t-online.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: 30ff5e24a31e818f2ae41861727866a35bfdbe23
https://github.com/qemu/qemu/commit/30ff5e24a31e818f2ae41861727866a35bfdbe23
Author: Volker Rümelin <vr_qemu@t-online.de>
Date: 2022-03-04 (Fri, 04 Mar 2022)
Changed paths:
M audio/paaudio.c
Log Message:
-----------
paaudio: increase default latency to 46ms
This is a patch to improve the pulseaudio playback experience.
Asking pulseaudio for a playback latency of 15ms is quite
demanding. Increase this to 46ms. The total playback latency
now is 31ms larger. One of the next patches will reduce the
total playback latency again by more than 46ms.
Here is a quote from the PulseAudio Latency Control
documentation: 'For the sake of (...) drop-out safety always
make sure to pick the highest latency possible that fulfills
your needs.'
Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Message-Id: <20220301191311.26695-5-vr_qemu@t-online.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: 369829a435ad87d2ac8ae79e6dc61e8c76d6890b
https://github.com/qemu/qemu/commit/369829a435ad87d2ac8ae79e6dc61e8c76d6890b
Author: Volker Rümelin <vr_qemu@t-online.de>
Date: 2022-03-04 (Fri, 04 Mar 2022)
Changed paths:
M audio/jackaudio.c
Log Message:
-----------
jackaudio: use more jack audio buffers
The next patch reduces the effective qemu playback buffer size
by timer-period. Increase the number of jack audio buffers by
one to preserve the total effective buffer size. The size of one
jack audio buffer is 512 samples. With audio defaults that's
512 samples / 44100 samples/s = 11.6 ms and only slightly larger
than the timer-period of 10 ms.
The larger jack audio buffer increases audio dropout safety,
because the high priority jack-audio worker threads can provide
audio data for a longer period of time as with a smaller buffer
and more audio data in the mixing engine buffer that they can't
access.
Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Reviewed-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Message-Id: <20220301191311.26695-6-vr_qemu@t-online.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: a806f95904cdb825c7b9d0cda95c8944907fb226
https://github.com/qemu/qemu/commit/a806f95904cdb825c7b9d0cda95c8944907fb226
Author: Volker Rümelin <vr_qemu@t-online.de>
Date: 2022-03-04 (Fri, 04 Mar 2022)
Changed paths:
M audio/audio.c
Log Message:
-----------
audio: copy playback stream in sequential order
Change the code to copy the playback stream in sequential order.
The advantage can be seen in the next patches where the stream
copy operation effectively becomes a write through operation.
The following diagram shows the average buffer fill level and
the stream copy sequence. ### represents a timer_period sized
chunk. The rest of the buffer sizes are not to scale.
With current code:
|--------| |#####111| |---#####|
sw->buf mix_buf backend buffer
1. clip
|--------| |---#####| |111##222|
sw->buf mix_buf backend buffer
2. write to audio device
333 -> |--------| |---#####| |---111##| -> 222
sw->buf mix_buf backend buffer
3a. sw device write
|-----333| |---#####| |---111##|
sw->buf mix_buf backend buffer
3b. resample and mix
|--------| |333#####| |---111##|
sw->buf mix_buf backend buffer
With this patch:
111 -> |--------| |---#####| |---#####|
sw->buf mix_buf backend buffer
1a: sw device write
|-----111| |---#####| |---#####|
sw->buf mix_buf backend buffer
1b. resample and mix
|--------| |111##222| |---#####|
sw->buf mix_buf backend buffer
2. clip
|--------| |---111##| |222##333|
sw->buf mix_buf backend buffer
3. write to audio device
|--------| |---111##| |---222##| -> 333
sw->buf mix_buf backend buffer
The effective total playback buffer size is reduced by
timer_period.
Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Message-Id: <20220301191311.26695-7-vr_qemu@t-online.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: 33940dd3368f1c8b490f9aa3a762727f6b6df106
https://github.com/qemu/qemu/commit/33940dd3368f1c8b490f9aa3a762727f6b6df106
Author: Volker Rümelin <vr_qemu@t-online.de>
Date: 2022-03-04 (Fri, 04 Mar 2022)
Changed paths:
M audio/audio.c
Log Message:
-----------
audio: add pcm_ops function table for capture backend
Add a pcm_ops function table for the capture backend. This avoids
additional code in the next patches to test if the pcm_ops table
is available.
Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Message-Id: <20220301191311.26695-8-vr_qemu@t-online.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: 669b95229d13e3c521c2f50bcc9ca0503efb3c5f
https://github.com/qemu/qemu/commit/669b95229d13e3c521c2f50bcc9ca0503efb3c5f
Author: Volker Rümelin <vr_qemu@t-online.de>
Date: 2022-03-04 (Fri, 04 Mar 2022)
Changed paths:
M audio/audio.c
Log Message:
-----------
Revert "audio: fix wavcapture segfault"
This reverts commit cbaf25d1f59ee13fc7542a06ea70784f2e000c04.
Since previous commit every audio backend has a pcm_ops function
table. It's no longer necessary to test if the table is available.
Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Message-Id: <20220301191311.26695-9-vr_qemu@t-online.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: 9833438ef624155de879d4ed57ecfcd3464a0bbe
https://github.com/qemu/qemu/commit/9833438ef624155de879d4ed57ecfcd3464a0bbe
Author: Volker Rümelin <vr_qemu@t-online.de>
Date: 2022-03-04 (Fri, 04 Mar 2022)
Changed paths:
M audio/alsaaudio.c
M audio/audio.c
M audio/audio_int.h
M audio/coreaudio.c
M audio/jackaudio.c
M audio/noaudio.c
M audio/ossaudio.c
M audio/sdlaudio.c
M audio/wavaudio.c
Log Message:
-----------
audio: restore mixing-engine playback buffer size
Commit ff095e5231 "audio: api for mixeng code free backends"
introduced another FIFO for the audio subsystem with exactly the
same size as the mixing-engine FIFO. Most audio backends use
this generic FIFO. The generic FIFO used together with the
mixing-engine FIFO doubles the audio FIFO size, because that's
just two independent FIFOs connected together in series.
For audio playback this nearly doubles the playback latency.
This patch restores the effective mixing-engine playback buffer
size to a pre v4.2.0 size by only accepting the amount of
samples for the mixing-engine queue which the downstream queue
accepts.
Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Reviewed-by: Akihiko Odaki <akihiko.odaki@gmail.com>
Message-Id: <20220301191311.26695-10-vr_qemu@t-online.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: ddf2050ce67617b3063a48215694a932d0af71ed
https://github.com/qemu/qemu/commit/ddf2050ce67617b3063a48215694a932d0af71ed
Author: Volker Rümelin <vr_qemu@t-online.de>
Date: 2022-03-04 (Fri, 04 Mar 2022)
Changed paths:
M audio/paaudio.c
Log Message:
-----------
paaudio: reduce effective playback buffer size
Add the buffer_get_free pcm_ops function to reduce the effective
playback buffer size. All intermediate audio playback buffers
become temporary buffers.
Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Message-Id: <20220301191311.26695-11-vr_qemu@t-online.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: c93a593372967b98438ab832b1b6eded12fdee8f
https://github.com/qemu/qemu/commit/c93a593372967b98438ab832b1b6eded12fdee8f
Author: Volker Rümelin <vr_qemu@t-online.de>
Date: 2022-03-04 (Fri, 04 Mar 2022)
Changed paths:
M audio/dsoundaudio.c
Log Message:
-----------
dsoundaudio: reduce effective playback buffer size
Add the buffer_get_free pcm_ops function to reduce the effective
playback buffer size. All intermediate audio playback buffers
become temporary buffers.
Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Message-Id: <20220301191311.26695-12-vr_qemu@t-online.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: 385211e8f903c75d7d1322ba0e21c370b2edaddd
https://github.com/qemu/qemu/commit/385211e8f903c75d7d1322ba0e21c370b2edaddd
Author: Volker Rümelin <vr_qemu@t-online.de>
Date: 2022-03-04 (Fri, 04 Mar 2022)
Changed paths:
M audio/ossaudio.c
Log Message:
-----------
ossaudio: reduce effective playback buffer size
Return the free buffer size for the mmapped case in function
oss_buffer_get_free() to reduce the effective playback buffer
size. All intermediate audio playback buffers become temporary
buffers.
Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Message-Id: <20220301191311.26695-13-vr_qemu@t-online.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: acf7a705980d157735242cf3bedabd2ef22c5384
https://github.com/qemu/qemu/commit/acf7a705980d157735242cf3bedabd2ef22c5384
Author: Volker Rümelin <vr_qemu@t-online.de>
Date: 2022-03-04 (Fri, 04 Mar 2022)
Changed paths:
M audio/paaudio.c
Log Message:
-----------
paaudio: fix samples vs. frames mix-up
Now that the mixing buffer size no longer adds to playback
latency, fix the samples vs. frames mix-up in the mixing buffer
size calculation. This change will go largely unnoticed as long
as the user doesn't use a buffer-size smaller than timer-period.
Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Message-Id: <20220301191311.26695-14-vr_qemu@t-online.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: 7b672528070ffe9c401d760c0edb75849d8e484e
https://github.com/qemu/qemu/commit/7b672528070ffe9c401d760c0edb75849d8e484e
Author: Volker Rümelin <vr_qemu@t-online.de>
Date: 2022-03-04 (Fri, 04 Mar 2022)
Changed paths:
M audio/sdlaudio.c
Log Message:
-----------
sdlaudio: fix samples vs. frames mix-up
Fix the same samples vs. frames mix-up that the previous commit
fixed for the PulseAudio backend.
Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Message-Id: <20220301191311.26695-15-vr_qemu@t-online.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: fedc1c19155f78f4f5be58092cd54cef0ea874ff
https://github.com/qemu/qemu/commit/fedc1c19155f78f4f5be58092cd54cef0ea874ff
Author: Peter Maydell <peter.maydell@linaro.org>
Date: 2022-03-04 (Fri, 04 Mar 2022)
Changed paths:
M hw/usb/redirect.c
Log Message:
-----------
hw/usb/redirect.c: Stop using qemu_oom_check()
qemu_oom_check() is a function which essentially says "if you pass me
a NULL pointer then print a message then abort()". On POSIX systems
the message includes strerror(errno); on Windows it includes the
GetLastError() error value printed as an integer.
Other than in the implementation of qemu_memalign(), we use this
function only in hw/usb/redirect.c, for three checks:
* on a call to usbredirparser_create()
* on a call to usberedirparser_serialize()
* on a call to malloc()
The usbredir library API functions make no guarantees that they will
set errno on errors, let alone that they might set the
Windows-specific GetLastError string. malloc() is documented as
setting errno, not GetLastError -- and in any case the only thing it
might set errno to is ENOMEM. So qemu_oom_check() isn't the right
thing for any of these. Replace them with straightforward
error-checking code. This will allow us to get rid of
qemu_oom_check().
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220226180723.1706285-2-peter.maydell@linaro.org>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: bd7819de227f47df72e21558c019147673726a74
https://github.com/qemu/qemu/commit/bd7819de227f47df72e21558c019147673726a74
Author: Akihiko Odaki <akihiko.odaki@gmail.com>
Date: 2022-03-04 (Fri, 04 Mar 2022)
Changed paths:
M audio/coreaudio.c
Log Message:
-----------
coreaudio: Notify error in coreaudio_init_out
Otherwise, the audio subsystem tries to use the voice and
eventually aborts due to the maximum number of samples in the
buffer is not set.
Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
Reviewed-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20220226115953.60335-1-akihiko.odaki@gmail.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: 64915058e18c2fbff8c80f9ad2e5be854dee2965
https://github.com/qemu/qemu/commit/64915058e18c2fbff8c80f9ad2e5be854dee2965
Author: Dov Murik <dovmurik@linux.ibm.com>
Date: 2022-03-04 (Fri, 04 Mar 2022)
Changed paths:
M hw/i386/pc_sysfw_ovmf.c
Log Message:
-----------
hw/i386: Improve bounds checking in OVMF table parsing
When pc_system_parse_ovmf_flash() parses the optional GUIDed table in
the end of the OVMF flash memory area, the table length field is checked
for sizes that are too small, but doesn't error on sizes that are too
big (bigger than the flash content itself).
Add a check for maximal size of the OVMF table, and add an error report
in case the size is invalid. In such a case, an error like this will be
displayed during launch:
qemu-system-x86_64: OVMF table has invalid size 4047
and the table parsing is skipped.
Signed-off-by: Dov Murik <dovmurik@linux.ibm.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220222071906.2632426-2-dovmurik@linux.ibm.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: bfc8c14459dae16b525cd024600d20f022b6ee55
https://github.com/qemu/qemu/commit/bfc8c14459dae16b525cd024600d20f022b6ee55
Author: Dov Murik <dovmurik@linux.ibm.com>
Date: 2022-03-04 (Fri, 04 Mar 2022)
Changed paths:
M hw/i386/pc_sysfw_ovmf.c
Log Message:
-----------
hw/i386: Replace magic number with field length calculation
Replce the literal magic number 48 with length calculation (32 bytes at
the end of the firmware after the table footer + 16 bytes of the OVMF
table footer GUID).
No functional change intended.
Signed-off-by: Dov Murik <dovmurik@linux.ibm.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220222071906.2632426-3-dovmurik@linux.ibm.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: 0a2a40da4fba8256bffd9abd94626106f80c3c8c
https://github.com/qemu/qemu/commit/0a2a40da4fba8256bffd9abd94626106f80c3c8c
Author: Dov Murik <dovmurik@linux.ibm.com>
Date: 2022-03-04 (Fri, 04 Mar 2022)
Changed paths:
M docs/specs/index.rst
A docs/specs/sev-guest-firmware.rst
Log Message:
-----------
docs: Add spec of OVMF GUIDed table for SEV guests
Add docs/specs/sev-guest-firmware.rst which describes the GUIDed table
in the end of OVMF's image which is parsed by QEMU, and currently used
to describe some values for SEV and SEV-ES guests.
Signed-off-by: Dov Murik <dovmurik@linux.ibm.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220103091413.2869-1-dovmurik@linux.ibm.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: a9fbce5e94d6b68ec8404f8a466fde873ba2bc73
https://github.com/qemu/qemu/commit/a9fbce5e94d6b68ec8404f8a466fde873ba2bc73
Author: Marc-André Lureau <marcandre.lureau@redhat.com>
Date: 2022-03-04 (Fri, 04 Mar 2022)
Changed paths:
M ui/console.c
Log Message:
-----------
ui/console: fix crash when using gl context with non-gl listeners
The commit 7cc712e98 ("ui: dispatch GL events to all listener")
mechanically replaced the dpy_gl calls with a dispatch loop, using the
same pre-conditions. However, it didn't take into account that all
listeners do not have to implement the GL callbacks.
Add the missing pre-conditions before calling the callbacks.
Fix crash when running a GL-enabled VM with "-device virtio-gpu-gl-pci
-display egl-headless -vnc :0".
Fixes: 7cc712e98 ("ui: dispatch GL events to all listener")
Reported-by: Akihiko Odaki <akihiko.odaki@gmail.com>
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20220214201337.1814787-2-marcandre.lureau@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: 6cdcf8810744cbc67074468b7f3c2f50f8e3539c
https://github.com/qemu/qemu/commit/6cdcf8810744cbc67074468b7f3c2f50f8e3539c
Author: Marc-André Lureau <marcandre.lureau@redhat.com>
Date: 2022-03-04 (Fri, 04 Mar 2022)
Changed paths:
M ui/console-gl.c
Log Message:
-----------
ui/console: fix texture leak when calling surface_gl_create_texture()
Make surface_gl_create_texture() idempotent: if the surface is already
bound to a texture, do not create a new one.
This fixes texture leaks when there are multiple DBus listeners, for
example.
Reported-by: Akihiko Odaki <akihiko.odaki@gmail.com>
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20220214201337.1814787-3-marcandre.lureau@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: cb8962c146b2633a4b04562281de9b2703bba849
https://github.com/qemu/qemu/commit/cb8962c146b2633a4b04562281de9b2703bba849
Author: Marc-André Lureau <marcandre.lureau@redhat.com>
Date: 2022-03-04 (Fri, 04 Mar 2022)
Changed paths:
M ui/console.c
Log Message:
-----------
ui: do not create a surface when resizing a GL scanout
qemu_console_resize() will create a blank surface and replace the
current scanout with it if called while the current scanout is
GL (texture or dmabuf).
This is not only very costly, but also can produce glitches on the
display/listener side.
Instead, compare the current console size with the fitting console
functions, which also works when the scanout is GL.
Note: there might be still an unnecessary surface creation on calling
qemu_console_resize() when the size is actually changing, but display
backends currently rely on DisplaySurface details during
dpy_gfx_switch() to handle various resize aspects. We would need more
refactoring to handle resize without DisplaySurface, this is left for a
future improvement.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20220214201337.1814787-4-marcandre.lureau@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: 02a8ee2e1840d13db065f418969bcfcb404a94cb
https://github.com/qemu/qemu/commit/02a8ee2e1840d13db065f418969bcfcb404a94cb
Author: Marc-André Lureau <marcandre.lureau@redhat.com>
Date: 2022-03-04 (Fri, 04 Mar 2022)
Changed paths:
M ui/clipboard.c
Log Message:
-----------
ui/clipboard: fix use-after-free regression
The same info may be used to update the clipboard, and may be freed
before being ref'ed again.
Fixes: 70a54b01693ed ("ui: avoid compiler warnings from unused clipboard info
variable")
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220214115917.1679568-1-marcandre.lureau@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: 5b6988c18a57fa72ddd44a232388518fcf8124bc
https://github.com/qemu/qemu/commit/5b6988c18a57fa72ddd44a232388518fcf8124bc
Author: Akihiko Odaki <akihiko.odaki@gmail.com>
Date: 2022-03-04 (Fri, 04 Mar 2022)
Changed paths:
M ui/cocoa.m
Log Message:
-----------
ui/cocoa: Add Services menu
Services menu functionality of Cocoa is described at:
https://developer.apple.com/design/human-interface-guidelines/macos/extensions/services/
Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20220214091320.51750-1-akihiko.odaki@gmail.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: f4ba24b3857251e7531803d6a157b3495dcb5703
https://github.com/qemu/qemu/commit/f4ba24b3857251e7531803d6a157b3495dcb5703
Author: Akihiko Odaki <akihiko.odaki@gmail.com>
Date: 2022-03-04 (Fri, 04 Mar 2022)
Changed paths:
M softmmu/qdev-monitor.c
Log Message:
-----------
softmmu/qdev-monitor: Add virtio-gpu-gl aliases
Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
Message-Id: <20220213021800.2525-1-akihiko.odaki@gmail.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: 4377683df969e715e3cb2dbd258e44f9ff51f788
https://github.com/qemu/qemu/commit/4377683df969e715e3cb2dbd258e44f9ff51f788
Author: Akihiko Odaki <akihiko.odaki@gmail.com>
Date: 2022-03-04 (Fri, 04 Mar 2022)
Changed paths:
M hw/display/edid-generate.c
Log Message:
-----------
edid: Fix clock of Detailed Timing Descriptor
The clock field is 16-bits in EDID Detailed Timing Descriptor, but
edid_desc_timing assumed it is 32-bit. Write the 16-bit value if it fits
in 16-bit. Write DisplayID otherwise.
Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
Message-Id: <20220213021529.2248-1-akihiko.odaki@gmail.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: 02218aedb1c851340207db89b8eeb96843fed241
https://github.com/qemu/qemu/commit/02218aedb1c851340207db89b8eeb96843fed241
Author: Carwyn Ellis <carwynellis@gmail.com>
Date: 2022-03-04 (Fri, 04 Mar 2022)
Changed paths:
M hw/display/trace-events
M hw/display/vmware_vga.c
Log Message:
-----------
hw/display/vmware_vga: replace fprintf calls with trace events
Debug output was always being sent to STDERR.
This has been replaced with trace events.
Signed-off-by: Carwyn Ellis <carwynellis@gmail.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20220206183956.10694-2-carwynellis@gmail.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: 5c8463886d50eeb0337bd121ab877cf692731e36
https://github.com/qemu/qemu/commit/5c8463886d50eeb0337bd121ab877cf692731e36
Author: Peter Maydell <peter.maydell@linaro.org>
Date: 2022-03-04 (Fri, 04 Mar 2022)
Changed paths:
M audio/alsaaudio.c
M audio/audio.c
M audio/audio_int.h
M audio/coreaudio.c
M audio/dsoundaudio.c
M audio/jackaudio.c
M audio/noaudio.c
M audio/ossaudio.c
M audio/paaudio.c
M audio/sdlaudio.c
M audio/wavaudio.c
M docs/specs/index.rst
A docs/specs/sev-guest-firmware.rst
M hw/display/edid-generate.c
M hw/display/trace-events
M hw/display/vmware_vga.c
M hw/i386/pc_sysfw_ovmf.c
M hw/usb/dev-mtp.c
M hw/usb/hcd-ohci.c
M hw/usb/hcd-xhci.c
M hw/usb/redirect.c
M hw/usb/trace-events
M softmmu/qdev-monitor.c
M ui/clipboard.c
M ui/cocoa.m
M ui/console-gl.c
M ui/console.c
Log Message:
-----------
Merge remote-tracking branch
'remotes/kraxel/tags/kraxel-20220304-pull-request' into staging
usb: fixes for ohci, xhci, mtp and redirect
audio: latency fixes
ui: opengl and cocoa fixes
firmware: ovmf tabel aprser fixes
# gpg: Signature made Fri 04 Mar 2022 14:18:47 GMT
# gpg: using RSA key A0328CFFB93A17A79901FE7D4CB6D8EED3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <kraxel@redhat.com>" [full]
# gpg: aka "Gerd Hoffmann <gerd@kraxel.org>" [full]
# gpg: aka "Gerd Hoffmann (private) <kraxel@gmail.com>" [full]
# Primary key fingerprint: A032 8CFF B93A 17A7 9901 FE7D 4CB6 D8EE D3E8 7138
* remotes/kraxel/tags/kraxel-20220304-pull-request: (35 commits)
hw/display/vmware_vga: replace fprintf calls with trace events
edid: Fix clock of Detailed Timing Descriptor
softmmu/qdev-monitor: Add virtio-gpu-gl aliases
ui/cocoa: Add Services menu
ui/clipboard: fix use-after-free regression
ui: do not create a surface when resizing a GL scanout
ui/console: fix texture leak when calling surface_gl_create_texture()
ui/console: fix crash when using gl context with non-gl listeners
docs: Add spec of OVMF GUIDed table for SEV guests
hw/i386: Replace magic number with field length calculation
hw/i386: Improve bounds checking in OVMF table parsing
coreaudio: Notify error in coreaudio_init_out
hw/usb/redirect.c: Stop using qemu_oom_check()
sdlaudio: fix samples vs. frames mix-up
paaudio: fix samples vs. frames mix-up
ossaudio: reduce effective playback buffer size
dsoundaudio: reduce effective playback buffer size
paaudio: reduce effective playback buffer size
audio: restore mixing-engine playback buffer size
Revert "audio: fix wavcapture segfault"
...
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Compare: https://github.com/qemu/qemu/compare/3d1fbc59665f...5c8463886d50