[Qemu-commits] [qemu/qemu] b1b213: linux-user: Remove unnecessary 'aligned' attribute...

[Peter Maydell]

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: b1b2138753be4a0c9dc50975b080f8e7743b78a9
      
https://github.com/qemu/qemu/commit/b1b2138753be4a0c9dc50975b080f8e7743b78a9
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2022-01-27 (Thu, 27 Jan 2022)

  Changed paths:
    M linux-user/qemu.h

  Log Message:
  -----------
  linux-user: Remove unnecessary 'aligned' attribute from TaskState

The linux-user struct TaskState has an 'aligned(16)' attribute.  When
the struct was first added in commit 851e67a1b46f in 2003, there was
a justification in a comment (still present in the source today):

/* NOTE: we force a big alignment so that the stack stored after is
   aligned too */

because the final field in the struct was "uint8_t stack[0];"
But that field was removed in commit 48e15fc2d in 2010 which
switched us to allocating the stack and the TaskState separately.
Because we allocate the structure with g_new0() rather than as
a local variable, the attribute made no difference to the alignment
of the structure anyway.

Remove the unnecessary attribute, and the corresponding comment.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20220114153732.3767229-2-peter.maydell@linaro.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: ca9946d734147155d6c27b348920125f623a588f
      
https://github.com/qemu/qemu/commit/ca9946d734147155d6c27b348920125f623a588f
  Author: Serge Belyshev <belyshev@depni.sinp.msu.ru>
  Date:   2022-01-27 (Thu, 27 Jan 2022)

  Changed paths:
    M linux-user/syscall_defs.h

  Log Message:
  -----------
  linux-user/alpha: Fix target rlimits for alpha and rearrange for clarity

Alpha uses different values of some TARGET_RLIMIT_* constants, which were
missing and caused bugs like #577, fixed thus.  Also rearranged all three
(alpha, mips and sparc) that differ from everyone else for clarity.

Signed-off-by: Serge Belyshev <belyshev@depni.sinp.msu.ru>
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/577
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <87y236lpwb.fsf@depni.sinp.msu.ru>
[lv: replace tabs by spaces]
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 33f53ac52ab664f3d6ec34047c0ae21e32fa26b4
      
https://github.com/qemu/qemu/commit/33f53ac52ab664f3d6ec34047c0ae21e32fa26b4
  Author: Paul Brook <paul@nowt.org>
  Date:   2022-01-27 (Thu, 27 Jan 2022)

  Changed paths:
    M linux-user/fd-trans.c
    M linux-user/syscall.c

  Log Message:
  -----------
  linux-user: Fix inotify on aarch64

The inotify implementation originally called the raw host syscalls.
Commit 3b3f24add0 changed this to use the glibc wrappers. However ifdefs
in syscall.c still test for presence of the raw syscalls.

This causes a problem on e.g. aarch64 hosts which never had the
inotify_init syscall - it had been obsoleted by inotify_init1 before
aarch64 was invented! However it does have a perfectly good glibc
implementation of inotify_wait.

Fix this by removing all the raw __NR_inotify_* tests, and instead check
CONFIG_INOTIFY, which already tests for the glibc functionality we use.

Also remove the now-pointless sys_inotify* wrappers.

Tested using x86-64 inotifywatch on aarch64 host, and vice-versa

Signed-off-by: Paul Brook <paul@nowt.org>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20220126202636.655289-1-paul@nowt.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: d3ced2a59a543b3c3fc7dee2e64ee360e9a698cd
      
https://github.com/qemu/qemu/commit/d3ced2a59a543b3c3fc7dee2e64ee360e9a698cd
  Author: Shu-Chun Weng <scw@google.com>
  Date:   2022-01-27 (Thu, 27 Jan 2022)

  Changed paths:
    M linux-user/syscall.c

  Log Message:
  -----------
  linux-user: rt_sigprocmask, check read perms first

Linux kernel does it this way (checks read permission before validating `how`)
and the latest version of ABSL's `AddressIsReadable()` depends on this
behavior.

c.f.  
https://github.com/torvalds/linux/blob/9539ba4308ad5bdca6cb41c7b73cbb9f796dcdd7/kernel/signal.c#L3147
Reviewed-by: Patrick Venture <venture@google.com>
Signed-off-by: Shu-Chun Weng <scw@google.com>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Signed-off-by: Patrick Venture <venture@google.com>
Message-Id: <20220126212559.1936290-2-venture@google.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: ebce1719ac0a2a71b64742ecf1c9ec2497a65a55
      
https://github.com/qemu/qemu/commit/ebce1719ac0a2a71b64742ecf1c9ec2497a65a55
  Author: Patrick Venture <venture@google.com>
  Date:   2022-01-27 (Thu, 27 Jan 2022)

  Changed paths:
    M linux-user/syscall.c

  Log Message:
  -----------
  linux-user: sigprocmask check read perms first

Linux kernel now checks the read permissions before validating `how`

Suggested-by: Laurent Vivier <laurent@vivier.eu>
Signed-off-by: Patrick Venture <venture@google.com>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20220126212559.1936290-3-venture@google.com>
[lv: remove unneeded ")"]
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: eb33cdaeda55d951f915152ad23816d47aca9955
      
https://github.com/qemu/qemu/commit/eb33cdaeda55d951f915152ad23816d47aca9955
  Author: Cameron Esfahani <dirty@apple.com>
  Date:   2022-01-28 (Fri, 28 Jan 2022)

  Changed paths:
    M linux-user/main.c
    M linux-user/qemu.h
    M linux-user/syscall.c

  Log Message:
  -----------
  linux-user: Implement starttime field in self stat emulation

Instead of always returning 0, return actual starttime.

Signed-off-by: Cameron Esfahani <dirty@apple.com>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20220128001251.45165-1-dirty@apple.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: b13e49bc86961c6725b2ebddd53898fe1366f6dc
      
https://github.com/qemu/qemu/commit/b13e49bc86961c6725b2ebddd53898fe1366f6dc
  Author: Serge Belyshev <belyshev@depni.sinp.msu.ru>
  Date:   2022-02-01 (Tue, 01 Feb 2022)

  Changed paths:
    A linux-user/aarch64/target_resource.h
    A linux-user/alpha/target_resource.h
    A linux-user/arm/target_resource.h
    A linux-user/cris/target_resource.h
    A linux-user/generic/target_resource.h
    A linux-user/hexagon/target_resource.h
    A linux-user/hppa/target_resource.h
    A linux-user/i386/target_resource.h
    A linux-user/m68k/target_resource.h
    A linux-user/microblaze/target_resource.h
    A linux-user/mips/target_resource.h
    A linux-user/mips64/target_resource.h
    A linux-user/nios2/target_resource.h
    A linux-user/openrisc/target_resource.h
    A linux-user/ppc/target_resource.h
    A linux-user/riscv/target_resource.h
    A linux-user/s390x/target_resource.h
    A linux-user/sh4/target_resource.h
    A linux-user/sparc/target_resource.h
    M linux-user/syscall_defs.h
    A linux-user/x86_64/target_resource.h
    A linux-user/xtensa/target_resource.h

  Log Message:
  -----------
  linux-user: Move generic TARGET_RLIMIT* definitions to 
generic/target_resource.h

Signed-off-by: Serge Belyshev <belyshev@depni.sinp.msu.ru>
Message-Id: <87ee4ql3yk.fsf_-_@depni.sinp.msu.ru>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 244fd08323088db73590ff2317dfe86f810b51d7
      
https://github.com/qemu/qemu/commit/244fd08323088db73590ff2317dfe86f810b51d7
  Author: Serge Belyshev <belyshev@depni.sinp.msu.ru>
  Date:   2022-02-01 (Tue, 01 Feb 2022)

  Changed paths:
    M linux-user/generic/target_resource.h
    M linux-user/syscall.c

  Log Message:
  -----------
  linux-user/syscall: Translate TARGET_RLIMIT_RTTIME

Signed-off-by: Serge Belyshev <belyshev@depni.sinp.msu.ru>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <87a6fel3w8.fsf_-_@depni.sinp.msu.ru>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 55ef0b702bc2c90c3c4ed97f97676d8f139e5ca1
      
https://github.com/qemu/qemu/commit/55ef0b702bc2c90c3c4ed97f97676d8f139e5ca1
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2022-02-07 (Mon, 07 Feb 2022)

  Changed paths:
    A linux-user/aarch64/target_resource.h
    A linux-user/alpha/target_resource.h
    A linux-user/arm/target_resource.h
    A linux-user/cris/target_resource.h
    M linux-user/fd-trans.c
    A linux-user/generic/target_resource.h
    A linux-user/hexagon/target_resource.h
    A linux-user/hppa/target_resource.h
    A linux-user/i386/target_resource.h
    A linux-user/m68k/target_resource.h
    M linux-user/main.c
    A linux-user/microblaze/target_resource.h
    A linux-user/mips/target_resource.h
    A linux-user/mips64/target_resource.h
    A linux-user/nios2/target_resource.h
    A linux-user/openrisc/target_resource.h
    A linux-user/ppc/target_resource.h
    M linux-user/qemu.h
    A linux-user/riscv/target_resource.h
    A linux-user/s390x/target_resource.h
    A linux-user/sh4/target_resource.h
    A linux-user/sparc/target_resource.h
    M linux-user/syscall.c
    M linux-user/syscall_defs.h
    A linux-user/x86_64/target_resource.h
    A linux-user/xtensa/target_resource.h

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/lvivier-gitlab/tags/linux-user-for-7.0-pull-request' into staging

Linux-user pull request 20220207

Fix target rlimits for alpha
Add startime in /proc/self/stat

# gpg: Signature made Mon 07 Feb 2022 08:27:27 GMT
# gpg:                using RSA key CD2F75DDC8E3A4DC2E4F5173F30C38BD3F2FBE3C
# gpg:                issuer "laurent@vivier.eu"
# gpg: Good signature from "Laurent Vivier <lvivier@redhat.com>" [full]
# gpg:                 aka "Laurent Vivier <laurent@vivier.eu>" [full]
# gpg:                 aka "Laurent Vivier (Red Hat) <lvivier@redhat.com>" 
[full]
# Primary key fingerprint: CD2F 75DD C8E3 A4DC 2E4F  5173 F30C 38BD 3F2F BE3C

* remotes/lvivier-gitlab/tags/linux-user-for-7.0-pull-request:
  linux-user/syscall: Translate TARGET_RLIMIT_RTTIME
  linux-user: Move generic TARGET_RLIMIT* definitions to 
generic/target_resource.h
  linux-user: Implement starttime field in self stat emulation
  linux-user: sigprocmask check read perms first
  linux-user: rt_sigprocmask, check read perms first
  linux-user: Fix inotify on aarch64
  linux-user/alpha: Fix target rlimits for alpha and rearrange for clarity
  linux-user: Remove unnecessary 'aligned' attribute from TaskState

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/0d564a3e32ba...55ef0b702bc2