[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] 06aa63: tpm: CRB: Use ram_device for "tpm-crb
From: |
Peter Maydell |
Subject: |
[Qemu-commits] [qemu/qemu] 06aa63: tpm: CRB: Use ram_device for "tpm-crb-cmd" region |
Date: |
Fri, 04 Feb 2022 14:23:11 -0800 |
Branch: refs/heads/staging
Home: https://github.com/qemu/qemu
Commit: 06aa63a34bcdb4960e0c26440a2b004cda1c7ca1
https://github.com/qemu/qemu/commit/06aa63a34bcdb4960e0c26440a2b004cda1c7ca1
Author: Eric Auger <eric.auger@redhat.com>
Date: 2022-02-03 (Thu, 03 Feb 2022)
Changed paths:
M hw/tpm/tpm_crb.c
Log Message:
-----------
tpm: CRB: Use ram_device for "tpm-crb-cmd" region
Representing the CRB cmd/response buffer as a standard
RAM region causes some trouble when the device is used
with VFIO. Indeed VFIO attempts to DMA_MAP this region
as usual RAM but this latter does not have a valid page
size alignment causing such an error report:
"vfio_listener_region_add received unaligned region".
To allow VFIO to detect that failing dma mapping
this region is not an issue, let's use a ram_device
memory region type instead.
Signed-off-by: Eric Auger <eric.auger@redhat.com>
Tested-by: Stefan Berger <stefanb@linux.ibm.com>
Acked-by: Stefan Berger <stefanb@linux.ibm.com>
[PMD: Keep tpm_crb.c in meson's softmmu_ss]
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Link: https://lore.kernel.org/r/20220120001242.230082-2-f4bug@amsat.org
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Commit: 36fe5d5836c8d5d928ef6d34e999d6991a2f732e
https://github.com/qemu/qemu/commit/36fe5d5836c8d5d928ef6d34e999d6991a2f732e
Author: Eric Auger <eric.auger@redhat.com>
Date: 2022-02-03 (Thu, 03 Feb 2022)
Changed paths:
M hw/vfio/common.c
M hw/vfio/trace-events
Log Message:
-----------
hw/vfio/common: Silence ram device offset alignment error traces
Failing to DMA MAP a ram_device should not cause an error message.
This is currently happening with the TPM CRB command region and
this is causing confusion.
We may want to keep the trace for debug purpose though.
Signed-off-by: Eric Auger <eric.auger@redhat.com>
Tested-by: Stefan Berger <stefanb@linux.ibm.com>
Acked-by: Alex Williamson <alex.williamson@redhat.com>
Acked-by: Stefan Berger <stefanb@linux.ibm.com>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Link: https://lore.kernel.org/r/20220120001242.230082-3-f4bug@amsat.org
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Commit: f6775a0d362368ba6532f50e7ac3b749308f0413
https://github.com/qemu/qemu/commit/f6775a0d362368ba6532f50e7ac3b749308f0413
Author: Peter Maydell <peter.maydell@linaro.org>
Date: 2022-02-04 (Fri, 04 Feb 2022)
Changed paths:
M hw/tpm/tpm_crb.c
M hw/vfio/common.c
M hw/vfio/trace-events
Log Message:
-----------
Merge remote-tracking branch 'remotes/awilliam/tags/vfio-fixes-20220203.0'
into staging
VFIO fixes 2022-02-03
* Fix alignment warnings when using TPM CRB with vfio-pci devices
(Eric Auger & Philippe Mathieu-Daudé)
# gpg: Signature made Thu 03 Feb 2022 22:30:11 GMT
# gpg: using RSA key 42F6C04E540BD1A99E7B8A90239B9B6E3BB08B22
# gpg: issuer "alex.williamson@redhat.com"
# gpg: Good signature from "Alex Williamson <alex.williamson@redhat.com>" [full]
# gpg: aka "Alex Williamson <alex@shazbot.org>" [full]
# gpg: aka "Alex Williamson <alwillia@redhat.com>" [full]
# gpg: aka "Alex Williamson <alex.l.williamson@gmail.com>"
[full]
# Primary key fingerprint: 42F6 C04E 540B D1A9 9E7B 8A90 239B 9B6E 3BB0 8B22
* remotes/awilliam/tags/vfio-fixes-20220203.0:
hw/vfio/common: Silence ram device offset alignment error traces
tpm: CRB: Use ram_device for "tpm-crb-cmd" region
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Compare: https://github.com/qemu/qemu/compare/31f59af39592...f6775a0d3623
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-commits] [qemu/qemu] 06aa63: tpm: CRB: Use ram_device for "tpm-crb-cmd" region,
Peter Maydell <=