[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] 7e7237: schemas: add missing vim modeline
From: |
Peter Maydell |
Subject: |
[Qemu-commits] [qemu/qemu] 7e7237: schemas: add missing vim modeline |
Date: |
Thu, 27 Jan 2022 09:12:22 -0800 |
Branch: refs/heads/master
Home: https://github.com/qemu/qemu
Commit: 7e7237cd2bebede25f43a550ccb1219070da427e
https://github.com/qemu/qemu/commit/7e7237cd2bebede25f43a550ccb1219070da427e
Author: Victor Toso <victortoso@redhat.com>
Date: 2022-01-27 (Thu, 27 Jan 2022)
Changed paths:
M qapi/audio.json
M qapi/compat.json
M qapi/replay.json
M qapi/trace.json
Log Message:
-----------
schemas: add missing vim modeline
Similar to f7160f3218 "schemas: Add vim modeline"
Signed-off-by: Victor Toso <victortoso@redhat.com>
Message-Id: <20211220145624.52801-1-victortoso@redhat.com>
Acked-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Commit: 4e86df17326d2afaf74622c082d906ed3f96d1d7
https://github.com/qemu/qemu/commit/4e86df17326d2afaf74622c082d906ed3f96d1d7
Author: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Date: 2022-01-27 (Thu, 27 Jan 2022)
Changed paths:
M scripts/qapi/gen.py
Log Message:
-----------
qapi/gen: Add FOO.trace-events output module
We are going to generate trace events for QMP commands. We should
generate both trace_*() function calls and trace-events files listing
events for trace generator.
So, add an output module FOO.trace-events for each FOO schema module.
Since we're going to add trace events only to command marshallers,
make the trace-events output optional, so we don't generate so many
useless empty files.
Currently nobody set add_trace_events to True, so new functionality is
disabled. It will be enabled for QAPISchemaGenCommandVisitor
in a further commit.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20220126161130.3240892-2-vsementsov@virtuozzo.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Commit: 167d913f34aa469fa30b0c51a04d8d2b9a5f1fa5
https://github.com/qemu/qemu/commit/167d913f34aa469fa30b0c51a04d8d2b9a5f1fa5
Author: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Date: 2022-01-27 (Thu, 27 Jan 2022)
Changed paths:
M docs/devel/qapi-code-gen.rst
M scripts/qapi/commands.py
Log Message:
-----------
qapi/commands: refactor error handling code
Move error_propagate() to if (err) and make "if (err)" block mandatory.
This is to simplify further commit, which will bring trace events
generation for QMP commands.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20220126161130.3240892-3-vsementsov@virtuozzo.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Commit: bd2017bc41566a94fbdfd8728b6e805ce2a2c124
https://github.com/qemu/qemu/commit/bd2017bc41566a94fbdfd8728b6e805ce2a2c124
Author: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Date: 2022-01-27 (Thu, 27 Jan 2022)
Changed paths:
M scripts/qapi/commands.py
M scripts/qapi/main.py
Log Message:
-----------
qapi/commands: Optionally generate trace for QMP commands
Add trace generation disabled by default and new option --gen-trace to
enable it. The next commit will enable it for qapi/, but not for qga/
and tests/. Making it work for the latter two would involve some Meson
hackery to ensure we generate the trace-events files before trace-tool
uses them. Since we don't actually support tracing there, we'll bypass
that problem.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20220126161130.3240892-4-vsementsov@virtuozzo.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
[Superfluous #include dropped]
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Commit: b83a80e831137d57eadd3b91b74d06bf9d4a3f36
https://github.com/qemu/qemu/commit/b83a80e831137d57eadd3b91b74d06bf9d4a3f36
Author: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Date: 2022-01-27 (Thu, 27 Jan 2022)
Changed paths:
M meson.build
M qapi/meson.build
M trace/meson.build
Log Message:
-----------
meson: generate trace events for qmp commands
1. Use --gen-trace when generate qmp commands
2. Add corresponding .trace-events files as outputs in qapi_files
custom target
3. Define global qapi_trace_events list of .trace-events file targets,
to fill in trace/qapi.build and to use in trace/meson.build
4. In trace/meson.build use the new array as an additional source of
.trace_events files to be processed
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20220126161130.3240892-5-vsementsov@virtuozzo.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Commit: ff8e4827adb08b3db5ee5faacf4822a7b84b91be
https://github.com/qemu/qemu/commit/ff8e4827adb08b3db5ee5faacf4822a7b84b91be
Author: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Date: 2022-01-27 (Thu, 27 Jan 2022)
Changed paths:
M docs/devel/qapi-code-gen.rst
M docs/devel/tracing.rst
Log Message:
-----------
docs/qapi-code-gen: update to cover trace events code generation
Previous commits enabled trace events generation for most of QAPI
generated code (except for tests/ and qga/). Let's update documentation
to illustrate it.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20220126161130.3240892-6-vsementsov@virtuozzo.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Commit: 378dfa482d6569b0034d21931570a4f31d940301
https://github.com/qemu/qemu/commit/378dfa482d6569b0034d21931570a4f31d940301
Author: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Date: 2022-01-27 (Thu, 27 Jan 2022)
Changed paths:
M qga/meson.build
M tests/meson.build
Log Message:
-----------
meson: document why we don't generate trace events for tests/ and qga/
Making trace generation work for tests/ and qga/ would involve some
Meson hackery to ensure we generate the trace-events files before
trace-tool uses them. Since we don't actually support tracing there
anyway, we bypass that problem.
Let's add corresponding comments.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20220126161130.3240892-7-vsementsov@virtuozzo.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
[Pasto fixed, commit message punctuation tidied up]
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Commit: 761a1a488e67a77858f3645a43fbdfe6208b51ce
https://github.com/qemu/qemu/commit/761a1a488e67a77858f3645a43fbdfe6208b51ce
Author: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Date: 2022-01-27 (Thu, 27 Jan 2022)
Changed paths:
M qapi/meson.build
M qga/meson.build
M scripts/qapi/main.py
M tests/meson.build
Log Message:
-----------
qapi: generate trace events by default
We don't generate trace events for tests/ and qga/ because that it is
not simple and not necessary. We have corresponding comments in both
tests/meson.build and qga/meson.build.
Still to not miss possible future qapi code generation call, and not to
forget to enable trace events generation, let's enable it by default.
So, turn option --gen-trace into opposite --no-trace-events and use new
option only in tests/ and qga/ where we already have good comments why
we don't generate trace events code.
Note that this commit enables trace-events generation for qapi-gen.py
call from tests/qapi-schema/meson.build and storage-daemon/meson.build.
Still, both are kind of noop: tests/qapi-schema/ doesn't seem to
generate any QMP command code and no .trace-events files anyway,
storage-daemon/ uses common QMP command implementations and just
generate empty .trace-events
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20220126161130.3240892-8-vsementsov@virtuozzo.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Commit: cfe63e46be0a1f8a7fd2fd5547222f8344a43279
https://github.com/qemu/qemu/commit/cfe63e46be0a1f8a7fd2fd5547222f8344a43279
Author: Peter Maydell <peter.maydell@linaro.org>
Date: 2022-01-27 (Thu, 27 Jan 2022)
Changed paths:
M docs/devel/qapi-code-gen.rst
M docs/devel/tracing.rst
M meson.build
M qapi/audio.json
M qapi/compat.json
M qapi/meson.build
M qapi/replay.json
M qapi/trace.json
M qga/meson.build
M scripts/qapi/commands.py
M scripts/qapi/gen.py
M scripts/qapi/main.py
M tests/meson.build
M trace/meson.build
Log Message:
-----------
Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2022-01-27-v2'
into staging
QAPI patches patches for 2022-01-27
# gpg: Signature made Thu 27 Jan 2022 14:19:51 GMT
# gpg: using RSA key 354BC8B3D7EB2A6B68674E5F3870B400EB918653
# gpg: issuer "armbru@redhat.com"
# gpg: Good signature from "Markus Armbruster <armbru@redhat.com>" [full]
# gpg: aka "Markus Armbruster <armbru@pond.sub.org>" [full]
# Primary key fingerprint: 354B C8B3 D7EB 2A6B 6867 4E5F 3870 B400 EB91 8653
* remotes/armbru/tags/pull-qapi-2022-01-27-v2:
qapi: generate trace events by default
meson: document why we don't generate trace events for tests/ and qga/
docs/qapi-code-gen: update to cover trace events code generation
meson: generate trace events for qmp commands
qapi/commands: Optionally generate trace for QMP commands
qapi/commands: refactor error handling code
qapi/gen: Add FOO.trace-events output module
schemas: add missing vim modeline
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Compare: https://github.com/qemu/qemu/compare/48302d4eb628...cfe63e46be0a