qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 70a54b: ui: avoid compiler warnings from unus


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] 70a54b: ui: avoid compiler warnings from unused clipboard ...
Date: Wed, 19 Jan 2022 08:37:51 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 70a54b01693eda3c61814b05d699aba41015ac48
      
https://github.com/qemu/qemu/commit/70a54b01693eda3c61814b05d699aba41015ac48
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2022-01-18 (Tue, 18 Jan 2022)

  Changed paths:
    M ui/clipboard.c

  Log Message:
  -----------
  ui: avoid compiler warnings from unused clipboard info variable

With latest clang 13.0.0 we get

../ui/clipboard.c:47:34: error: variable 'old' set but not used 
[-Werror,-Wunused-but-set-variable]
    g_autoptr(QemuClipboardInfo) old = NULL;
                                 ^

The compiler can't tell that we only declared this variable in
order to get the side effect of free'ing it when out of scope.

This pattern is a little dubious for a use of g_autoptr, so
rewrite the code to avoid it.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
[AJB: fix merge conflict]
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20211215141949.3512719-2-berrange@redhat.com>
Message-Id: <20220105135009.1584676-2-alex.bennee@linaro.org>


  Commit: 9dcafa400e57d75f77c67151ff57508065651dd8
      
https://github.com/qemu/qemu/commit/9dcafa400e57d75f77c67151ff57508065651dd8
  Author: John Snow <jsnow@redhat.com>
  Date:   2022-01-18 (Tue, 18 Jan 2022)

  Changed paths:
    M hw/display/qxl.c
    M include/ui/qemu-spice.h
    M ui/spice-display.c

  Log Message:
  -----------
  spice: Update QXLInterface for spice >= 0.15.0

spice updated the spelling (and arguments) of "attache_worker" in
0.15.0. Update QEMU to match, preventing -Wdeprecated-declarations
compilations from reporting build errors.

See also:
https://gitlab.freedesktop.org/spice/spice/-/commit/974692bda1e77af92b71ed43b022439448492cb9

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: John Snow <jsnow@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20211215141949.3512719-3-berrange@redhat.com>
Message-Id: <20220105135009.1584676-3-alex.bennee@linaro.org>


  Commit: a41b4fdc445f1aad5f8bdbb36b351415647f91fc
      
https://github.com/qemu/qemu/commit/a41b4fdc445f1aad5f8bdbb36b351415647f91fc
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2022-01-18 (Tue, 18 Jan 2022)

  Changed paths:
    M meson.build

  Log Message:
  -----------
  meson: require liburing >= 0.3

openSUSE Leap 15.2 ships with liburing == 0.2 against which QEMU fails
to build.

../util/fdmon-io_uring.c: In function ‘fdmon_io_uring_need_wait’:
../util/fdmon-io_uring.c:305:9: error: implicit declaration of function 
‘io_uring_sq_ready’; did you mean ‘io_uring_cq_ready’? 
[-Werror=implicit-function-declaration]
     if (io_uring_sq_ready(&ctx->fdmon_io_uring)) {
         ^~~~~~~~~~~~~~~~~
         io_uring_cq_ready

This method was introduced in liburing 0.3, so set that as a minimum
requirement.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20211215141949.3512719-4-berrange@redhat.com>
Message-Id: <20220105135009.1584676-4-alex.bennee@linaro.org>


  Commit: 021e3fa33b57612fd0e1a6b7ced23d3480cfbdca
      
https://github.com/qemu/qemu/commit/021e3fa33b57612fd0e1a6b7ced23d3480cfbdca
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2022-01-18 (Tue, 18 Jan 2022)

  Changed paths:
    M include/ui/sdl2.h

  Log Message:
  -----------
  ui: avoid warnings about directdb on Alpine / musl libc

On Alpine, SDL is built with directfb support and this triggers warnings
during QEMU build

In file included from /usr/include/directfb/direct/thread.h:38,
                 from /usr/include/directfb/direct/debug.h:43,
                 from /usr/include/directfb/direct/interface.h:36,
                 from /usr/include/directfb/directfb.h:49,
                 from /usr/include/SDL2/SDL_syswm.h:80,
                 from /builds/berrange/qemu/include/ui/sdl2.h:8,
                 from ../ui/sdl2-gl.c:31:
/usr/include/directfb/direct/os/waitqueue.h:41:25: error: redundant 
redeclaration of 'direct_waitqueue_init' [-Werror=redundant-decls]
   41 | DirectResult DIRECT_API direct_waitqueue_init        ( DirectWaitQueue 
*queue );
      |                         ^~~~~~~~~~~~~~~~~~~~~

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20211215141949.3512719-5-berrange@redhat.com>
Message-Id: <20220105135009.1584676-5-alex.bennee@linaro.org>


  Commit: f178c62afc9cb1c6ef25601c584006e21149036e
      
https://github.com/qemu/qemu/commit/f178c62afc9cb1c6ef25601c584006e21149036e
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2022-01-18 (Tue, 18 Jan 2022)

  Changed paths:
    M .gitlab-ci.d/buildtest.yml

  Log Message:
  -----------
  ci: explicitly skip I/O tests on alpine

The block I/O tests don't work on Alpine because their alternative libc
impl emits different strings for errnos, which breaks the expected
output matching. e.g.

=== IO: pattern 102
 wrote 512/512 bytes at offset 512
 512 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
-qemu-img: Error while reading offset 0 of 
blkdebug:TEST_DIR/blkdebug.conf:TEST_DIR/t.IMGFMT: Input/output error
+qemu-img: Error while reading offset 0 of 
blkdebug:TEST_DIR/blkdebug.conf:TEST_DIR/t.IMGFMT: I/O error
 4
 Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=1073741824
 Formatting 'TEST_DIR/t.IMGFMT.2', fmt=IMGFMT size=0

Currently the I/O tests are skipped as a side effect of the Alpine image
containing a minimal busybox 'sed' binary, rather than GNU sed. This is
a fragile assumption that will be invalidated when the dockerfile is
changed to be autogenerated from a standardized package list that
includes GNU sed.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20211215141949.3512719-6-berrange@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20220105135009.1584676-6-alex.bennee@linaro.org>


  Commit: 3f4a7a7cfb8216d0435de3e7d6d2a5a18b46f7bf
      
https://github.com/qemu/qemu/commit/3f4a7a7cfb8216d0435de3e7d6d2a5a18b46f7bf
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2022-01-18 (Tue, 18 Jan 2022)

  Changed paths:
    M tests/docker/dockerfiles/fedora.docker

  Log Message:
  -----------
  tests/docker: switch fedora image to release 35

The Fedora 33 release is shortly end of life. Switch to the newest
Fedora 35 to maximise lifespan until we need to update again.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20211215141949.3512719-7-berrange@redhat.com>
Message-Id: <20220105135009.1584676-7-alex.bennee@linaro.org>


  Commit: 4ebb040f1fd6985df191b63321493d1b6fb504f5
      
https://github.com/qemu/qemu/commit/4ebb040f1fd6985df191b63321493d1b6fb504f5
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2022-01-18 (Tue, 18 Jan 2022)

  Changed paths:
    M .gitmodules
    M Makefile
    M docs/devel/testing.rst
    A tests/lcitool/Makefile.include
    A tests/lcitool/libvirt-ci
    A tests/lcitool/projects/qemu.yml
    A tests/lcitool/refresh

  Log Message:
  -----------
  tests: integrate lcitool for generating build env manifests

This introduces

  https://gitlab.com/libvirt/libvirt-ci

as a git submodule at tests/lcitool/libvirt-ci

The 'lcitool' program within this submodule will be used to
automatically generate build environment manifests from a definition
of requirements in tests/lcitool/projects/qemu.yml

It will ultimately be capable of generating

 - Dockerfiles
 - Package lists for installation in VMs
 - Variables for configuring Cirrus CI environments

When a new build pre-requisite is needed for QEMU, if this package
is not currently known to libvirt-ci, it must first be added to the
'mappings.yml' file in the above git repo.

Then the submodule can be updated and the build pre-requisite added
to the tests/lcitool/projects/qemu.yml file. Now all the build env
manifests can be re-generated using  'make lcitool-refresh'

This ensures that when a new build pre-requisite is introduced, it
is added to all the different OS containers, VMs and Cirrus CI
environments consistently.

It also facilitates the addition of containers targetting new distros
or updating existing containers to new versions of the same distro,
where packages might have been renamed.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20211215141949.3512719-8-berrange@redhat.com>
Message-Id: <20220105135009.1584676-8-alex.bennee@linaro.org>


  Commit: 21ea888fc2bb3bdbd79fd122a201348f1738982c
      
https://github.com/qemu/qemu/commit/21ea888fc2bb3bdbd79fd122a201348f1738982c
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2022-01-18 (Tue, 18 Jan 2022)

  Changed paths:
    M tests/docker/dockerfiles/centos8.docker
    M tests/lcitool/refresh

  Log Message:
  -----------
  tests/docker: auto-generate centos8.docker with lcitool

This commit is best examined using the "-b" option to diff.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20211215141949.3512719-9-berrange@redhat.com>
Message-Id: <20220105135009.1584676-9-alex.bennee@linaro.org>


  Commit: 05e47b75cb0310210321028eee98116a0006f93e
      
https://github.com/qemu/qemu/commit/05e47b75cb0310210321028eee98116a0006f93e
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2022-01-18 (Tue, 18 Jan 2022)

  Changed paths:
    M tests/docker/dockerfiles/fedora.docker
    M tests/lcitool/refresh

  Log Message:
  -----------
  tests/docker: auto-generate fedora.docker with lcitool

This commit is best examined using the "-b" option to diff.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20211215141949.3512719-10-berrange@redhat.com>
Message-Id: <20220105135009.1584676-10-alex.bennee@linaro.org>


  Commit: e482191643256aca6d6e84568f510da1abda219d
      
https://github.com/qemu/qemu/commit/e482191643256aca6d6e84568f510da1abda219d
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2022-01-18 (Tue, 18 Jan 2022)

  Changed paths:
    M tests/docker/dockerfiles/ubuntu1804.docker
    M tests/lcitool/refresh

  Log Message:
  -----------
  tests/docker: auto-generate ubuntu1804.docker with lcitool

This commit is best examined using the "-b" option to diff.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20211215141949.3512719-11-berrange@redhat.com>
Message-Id: <20220105135009.1584676-11-alex.bennee@linaro.org>


  Commit: bb317c325830ac7c9e1f4b6fef23146ad85bc1be
      
https://github.com/qemu/qemu/commit/bb317c325830ac7c9e1f4b6fef23146ad85bc1be
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2022-01-18 (Tue, 18 Jan 2022)

  Changed paths:
    M tests/docker/dockerfiles/ubuntu2004.docker
    M tests/lcitool/refresh

  Log Message:
  -----------
  tests/docker: auto-generate ubuntu2004.docker with lcitool

This commit is best examined using the "-b" option to diff.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20211215141949.3512719-12-berrange@redhat.com>
Message-Id: <20220105135009.1584676-12-alex.bennee@linaro.org>


  Commit: 122198393df0386bbae234f376187359f3210d62
      
https://github.com/qemu/qemu/commit/122198393df0386bbae234f376187359f3210d62
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2022-01-18 (Tue, 18 Jan 2022)

  Changed paths:
    M tests/docker/dockerfiles/opensuse-leap.docker
    M tests/lcitool/refresh

  Log Message:
  -----------
  tests/docker: auto-generate opensuse-leap.docker with lcitool

This commit is best examined using the "-b" option to diff.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20211215141949.3512719-13-berrange@redhat.com>
Message-Id: <20220105135009.1584676-13-alex.bennee@linaro.org>


  Commit: 6815e63f31fc83b8f5062e3167765a9fa74660e4
      
https://github.com/qemu/qemu/commit/6815e63f31fc83b8f5062e3167765a9fa74660e4
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2022-01-18 (Tue, 18 Jan 2022)

  Changed paths:
    M .gitlab-ci.d/containers.yml
    R tests/docker/dockerfiles/ubuntu.docker

  Log Message:
  -----------
  tests/docker: remove ubuntu.docker container

This duplicates the ubuntu2004 container but with an inconsistent set of
packages.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20211215141949.3512719-14-berrange@redhat.com>
Message-Id: <20220105135009.1584676-14-alex.bennee@linaro.org>


  Commit: c45a540f4bd47b2947edf585c89bbfdc338eaef7
      
https://github.com/qemu/qemu/commit/c45a540f4bd47b2947edf585c89bbfdc338eaef7
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2022-01-18 (Tue, 18 Jan 2022)

  Changed paths:
    M .gitlab-ci.d/cirrus/freebsd-12.vars
    M .gitlab-ci.d/cirrus/freebsd-13.vars
    M .gitlab-ci.d/cirrus/macos-11.vars
    M tests/lcitool/refresh

  Log Message:
  -----------
  .gitlab-ci.d/cirrus: auto-generate variables with lcitool

The current Cirrus CI variables files were previously generated by using
lcitool. This change wires them up to the refresh script to make that
link explicit.

This changes the package list because libvirt-ci now knows about the
mapping for dtc on FreeBSD and macOS platforms.

The variables are also now emit in sorted order for stability across
runs.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20211215141949.3512719-15-berrange@redhat.com>
Message-Id: <20220105135009.1584676-15-alex.bennee@linaro.org>


  Commit: 8d5528016028c0df124c2af428094ca1a61be61c
      
https://github.com/qemu/qemu/commit/8d5528016028c0df124c2af428094ca1a61be61c
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2022-01-18 (Tue, 18 Jan 2022)

  Changed paths:
    M tests/docker/dockerfiles/alpine.docker

  Log Message:
  -----------
  tests/docker: updates to alpine package list

Cleanup the package lists by removing some entries that we don't need to
directly reference

  binutils: implied by the compiler toolchain
  coreutils: not required by QEMU build
  mesa-egl mesa-gbm: implied by mesa-dev
  ninja: alias for samurai package
  shadow: not required by QEMU build
  util-linux-dev: not directly required by QEMU build

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20211215141949.3512719-16-berrange@redhat.com>
Message-Id: <20220105135009.1584676-16-alex.bennee@linaro.org>


  Commit: 46b1c19beceaea6295cddd56d87c0a21e984cb64
      
https://github.com/qemu/qemu/commit/46b1c19beceaea6295cddd56d87c0a21e984cb64
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2022-01-18 (Tue, 18 Jan 2022)

  Changed paths:
    M tests/docker/dockerfiles/alpine.docker

  Log Message:
  -----------
  tests/docker: fix sorting of alpine image package lists

"python" sorts alphabetically after "py3-xxxx"

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20211215141949.3512719-17-berrange@redhat.com>
Message-Id: <20220105135009.1584676-17-alex.bennee@linaro.org>


  Commit: e6302780086d8453524e63d1fe8053ca80cc09a3
      
https://github.com/qemu/qemu/commit/e6302780086d8453524e63d1fe8053ca80cc09a3
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2022-01-18 (Tue, 18 Jan 2022)

  Changed paths:
    M tests/docker/dockerfiles/alpine.docker

  Log Message:
  -----------
  tests/docker: fully expand the alpine package list

Add many extra alpine packages to cover the various optional QEMU build
dependencies pulled in by other dockerfiles.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20211215141949.3512719-18-berrange@redhat.com>
Message-Id: <20220105135009.1584676-18-alex.bennee@linaro.org>


  Commit: e1cb5c7550804ea61971366598431aa7c0cadfd8
      
https://github.com/qemu/qemu/commit/e1cb5c7550804ea61971366598431aa7c0cadfd8
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2022-01-18 (Tue, 18 Jan 2022)

  Changed paths:
    M tests/docker/dockerfiles/alpine.docker
    M tests/lcitool/refresh

  Log Message:
  -----------
  tests/docker: auto-generate alpine.docker with lcitool

This commit is best examined using the "-b" option to diff.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20211215141949.3512719-19-berrange@redhat.com>
Message-Id: <20220105135009.1584676-19-alex.bennee@linaro.org>


  Commit: 91ad2244b73ce2b98129bc4ac7ea45fa280ccf62
      
https://github.com/qemu/qemu/commit/91ad2244b73ce2b98129bc4ac7ea45fa280ccf62
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2022-01-18 (Tue, 18 Jan 2022)

  Changed paths:
    M tests/tcg/configure.sh
    M tests/tcg/multiarch/Makefile.target
    M tests/tcg/x86_64/Makefile.target

  Log Message:
  -----------
  tests/tcg: use CONFIG_LINUX_USER, not CONFIG_LINUX

The two more or less overlap, because CONFIG_LINUX is a requirement for Linux
user-mode emulation.  However, CONFIG_LINUX is technically a host symbol
that applies even to system emulation.  Defining CONFIG_LINUX_USER, and
CONFIG_BSD_USER for eventual future use, is cleaner.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20211210084836.25202-1-pbonzini@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20220105135009.1584676-20-alex.bennee@linaro.org>


  Commit: 7bef20d72985c5da4082d198ad175715272cd50c
      
https://github.com/qemu/qemu/commit/7bef20d72985c5da4082d198ad175715272cd50c
  Author: Stefan Hajnoczi <stefanha@redhat.com>
  Date:   2022-01-18 (Tue, 18 Jan 2022)

  Changed paths:
    M tests/docker/dockerfiles/alpine.docker
    M tests/docker/dockerfiles/centos8.docker
    M tests/docker/dockerfiles/fedora.docker
    M tests/docker/dockerfiles/opensuse-leap.docker
    M tests/docker/dockerfiles/ubuntu2004.docker
    M tests/lcitool/projects/qemu.yml

  Log Message:
  -----------
  tests/docker: add libfuse3 development headers

The FUSE exports feature is not built because most container images do
not have libfuse3 development headers installed. Add the necessary
packages to the Dockerfiles.

Cc: Hanna Reitz <hreitz@redhat.com>
Cc: Richard W.M. Jones <rjones@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Acked-by: Richard W.M. Jones <rjones@redhat.com>
Reviewed-by: Beraldo Leal <bleal@redhat.com>
Tested-by: Beraldo Leal <bleal@redhat.com>
Message-Id: <20211207160025.52466-1-stefanha@redhat.com>
[AJB: migrate to lcitool qemu.yml and regenerate]
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard W.M. Jones <rjones@redhat.com>
Message-Id: <20220105135009.1584676-21-alex.bennee@linaro.org>


  Commit: 33973e1e1f88b7588fe9629645e279ff2c6ca1c4
      
https://github.com/qemu/qemu/commit/33973e1e1f88b7588fe9629645e279ff2c6ca1c4
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2022-01-18 (Tue, 18 Jan 2022)

  Changed paths:
    M docs/system/arm/virt.rst
    M hw/arm/virt.c
    M include/hw/arm/virt.h

  Log Message:
  -----------
  hw/arm: add control knob to disable kaslr_seed via DTB

Generally a guest needs an external source of randomness to properly
enable things like address space randomisation. However in a trusted
boot environment where the firmware will cryptographically verify
components having random data in the DTB will cause verification to
fail. Add a control knob so we can prevent this being added to the
system DTB.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Tested-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Acked-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Acked-by: Jerome Forissier <jerome@forissier.org>
Reviewed-by: Andrew Jones <drjones@redhat.com>
Message-Id: <20220105135009.1584676-22-alex.bennee@linaro.org>


  Commit: 92e28c03d6162d55b40f7052962067c021c90e7d
      
https://github.com/qemu/qemu/commit/92e28c03d6162d55b40f7052962067c021c90e7d
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2022-01-18 (Tue, 18 Jan 2022)

  Changed paths:
    M accel/tcg/cpu-exec.c
    M hmp-commands-info.hx
    M monitor/qmp-cmds.c
    M qapi/machine.json

  Log Message:
  -----------
  monitor: move x-query-profile into accel/tcg to fix build

As --enable-profiler isn't defended in CI we missed this breakage.
Move the qmp handler into accel/tcg so we have access to the helpers
we need. While we are at it ensure we gate the feature on CONFIG_TCG.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
Reported-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Fixes: 37087fde0e ("qapi: introduce x-query-profile QMP command")
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/773
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Tested-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20220105135009.1584676-23-alex.bennee@linaro.org>


  Commit: a68e025bf5103280be6cfeab19452491b793e679
      
https://github.com/qemu/qemu/commit/a68e025bf5103280be6cfeab19452491b793e679
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2022-01-18 (Tue, 18 Jan 2022)

  Changed paths:
    M docs/devel/style.rst

  Log Message:
  -----------
  docs/devel: update C standard to C11

Since 8a9d3d5640 (configure: Use -std=gnu11) we have allowed C11 code
so lets reflect that in the style guide.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20220105135009.1584676-24-alex.bennee@linaro.org>


  Commit: 3918fe16b0f8c6657928a14f41b7ff50061e33e1
      
https://github.com/qemu/qemu/commit/3918fe16b0f8c6657928a14f41b7ff50061e33e1
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2022-01-18 (Tue, 18 Jan 2022)

  Changed paths:
    M docs/devel/style.rst
    M include/glib-compat.h

  Log Message:
  -----------
  docs/devel: more documentation on the use of suffixes

Using _qemu is a little confusing. Let's use _compat for these sorts
of things. We should also mention _impl which is another common suffix
in the code base.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20220105135009.1584676-25-alex.bennee@linaro.org>


  Commit: 11d3672788b48548811810bdc0f3f7969662572d
      
https://github.com/qemu/qemu/commit/11d3672788b48548811810bdc0f3f7969662572d
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2022-01-18 (Tue, 18 Jan 2022)

  Changed paths:
    M linux-user/elfload.c

  Log Message:
  -----------
  linux-user: expand reserved brk space for 64bit guests

A recent change to fix commpage allocation issues on 32bit hosts
revealed another intermittent issue on s390x. The root cause was the
headroom we give for the brk space wasn't enough causing the guest to
attempt to map something on top of QEMUs own pages. We do not
currently do anything to protect from this (see #555).

By inspection the brk mmap moves around and top of the address range
has been measured as far as 19Mb away from the top of the binary. As
we chose a smallish number to keep 32bit on 32 bit feasible we only
increase the gap for 64 bit guests. This does mean that 64-on-32
static binaries are more likely to fail to find a hole in the address
space but that is hopefully a fairly rare situation.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20220113165550.4184455-1-alex.bennee@linaro.org>


  Commit: e7588237ce8f8115b5ad9a3ecdd46f60d95a461a
      
https://github.com/qemu/qemu/commit/e7588237ce8f8115b5ad9a3ecdd46f60d95a461a
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2022-01-18 (Tue, 18 Jan 2022)

  Changed paths:
    M linux-user/elfload.c

  Log Message:
  -----------
  linux-user/elfload: add extra logging for hole finding

The various approaches to finding memory holes are quite complicated
to follow especially at a distance. Improve the logging so we can see
exactly what method found the space for the guest memory.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Warner Losh <imp@bsdimp.com>
Message-Id: <20220105135009.1584676-26-alex.bennee@linaro.org>


  Commit: 190674f3719d7a26387715952312f6397cddfaaf
      
https://github.com/qemu/qemu/commit/190674f3719d7a26387715952312f6397cddfaaf
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2022-01-18 (Tue, 18 Jan 2022)

  Changed paths:
    M linux-user/elfload.c

  Log Message:
  -----------
  linux-user: don't adjust base of found hole

The pgb_find_hole function goes to the trouble of taking account of
both mmap_min_addr and any offset we've applied to decide the starting
address of a potential hole. This is especially important for
emulating 32bit ARM in a 32bit build as we have applied the offset to
ensure there will be space to map the ARM_COMMPAGE bellow the main
guest map (using wrapped arithmetic).

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/690
Message-Id: <20220105135009.1584676-27-alex.bennee@linaro.org>


  Commit: 603bd9c25eba3c994a1ba681a641372d23eca5f0
      
https://github.com/qemu/qemu/commit/603bd9c25eba3c994a1ba681a641372d23eca5f0
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2022-01-18 (Tue, 18 Jan 2022)

  Changed paths:
    M tests/tcg/hexagon/float_convs.ref
    M tests/tcg/hexagon/float_madds.ref
    M tests/tcg/multiarch/float_convs.c
    M tests/tcg/multiarch/float_madds.c

  Log Message:
  -----------
  tests/tcg/multiarch: Read fp flags before printf

We need to read the floating-point flags before printf may do
other floating-point operations which may affect the flags.

Hexagon reference files regenerated by Taylor Simpson.

Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Taylor Simpson <tsimpson@quicinc.com>
Message-Id: <1639510781-3790-1-git-send-email-tsimpson@quicinc.com>
Message-Id: <20211224035541.2159966-2-richard.henderson@linaro.org>
Message-Id: <20220105135009.1584676-29-alex.bennee@linaro.org>


  Commit: 3118bfbf07068c6488ce30e3ac6d2a639d2e1312
      
https://github.com/qemu/qemu/commit/3118bfbf07068c6488ce30e3ac6d2a639d2e1312
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2022-01-18 (Tue, 18 Jan 2022)

  Changed paths:
    A tests/tcg/ppc64le/float_convs.ref
    A tests/tcg/ppc64le/float_madds.ref

  Log Message:
  -----------
  test/tcg/ppc64le: Add float reference files

Generated on Power9, PowerNV 9006-22P.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20211224035541.2159966-3-richard.henderson@linaro.org>
Message-Id: <20220105135009.1584676-30-alex.bennee@linaro.org>


  Commit: e850897e67026fa235bd34c56adf1c26e6aa1110
      
https://github.com/qemu/qemu/commit/e850897e67026fa235bd34c56adf1c26e6aa1110
  Author: Brad Smith <brad@comstyle.com>
  Date:   2022-01-18 (Tue, 18 Jan 2022)

  Changed paths:
    M .gitlab-ci.d/cirrus.yml
    M tests/vm/freebsd

  Log Message:
  -----------
  FreeBSD: Upgrade to 12.3 release

Note, since libtasn1 was fixed in 12.3 [*], this commit re-enables GnuTLS.

[*] https://gitlab.com/gnutls/libtasn1/-/merge_requests/71

Signed-off-by: Brad Smith <brad@comstyle.com>
Tested-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Warner Losh <imp@bsdimp.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <YdUCQLVe5JSWZByQ@humpty.home.comstyle.com>
Message-Id: <20220105135009.1584676-31-alex.bennee@linaro.org>


  Commit: 3265d1fc77eb5da522accb37e50053dfdfda7e8f
      
https://github.com/qemu/qemu/commit/3265d1fc77eb5da522accb37e50053dfdfda7e8f
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2022-01-18 (Tue, 18 Jan 2022)

  Changed paths:
    M tests/docker/dockerfiles/debian-tricore-cross.docker

  Log Message:
  -----------
  docker: include bison in debian-tricore-cross

Binutils sometimes fail to build if bison is not installed:

  /bin/sh ./ylwrap `test -f arparse.y || echo ./`arparse.y y.tab.c arparse.c 
y.tab.h arparse.h y.output arparse.output --  -d
  ./ylwrap: 109: ./ylwrap: -d: not found

(the correct invocation of ylwrap would have "bison -d" after the double
dash).  Work around by installing it in the container.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/596
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20211221111624.352804-1-pbonzini@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20220105135009.1584676-34-alex.bennee@linaro.org>


  Commit: 3d228a741acc2267c290102543237c4e0f2547ca
      
https://github.com/qemu/qemu/commit/3d228a741acc2267c290102543237c4e0f2547ca
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2022-01-19 (Wed, 19 Jan 2022)

  Changed paths:
    M .gitlab-ci.d/buildtest.yml
    M .gitlab-ci.d/cirrus.yml
    M .gitlab-ci.d/cirrus/freebsd-12.vars
    M .gitlab-ci.d/cirrus/freebsd-13.vars
    M .gitlab-ci.d/cirrus/macos-11.vars
    M .gitlab-ci.d/containers.yml
    M .gitmodules
    M Makefile
    M accel/tcg/cpu-exec.c
    M docs/devel/style.rst
    M docs/devel/testing.rst
    M docs/system/arm/virt.rst
    M hmp-commands-info.hx
    M hw/arm/virt.c
    M hw/display/qxl.c
    M include/glib-compat.h
    M include/hw/arm/virt.h
    M include/ui/qemu-spice.h
    M include/ui/sdl2.h
    M linux-user/elfload.c
    M meson.build
    M monitor/qmp-cmds.c
    M qapi/machine.json
    M tests/docker/dockerfiles/alpine.docker
    M tests/docker/dockerfiles/centos8.docker
    M tests/docker/dockerfiles/debian-tricore-cross.docker
    M tests/docker/dockerfiles/fedora.docker
    M tests/docker/dockerfiles/opensuse-leap.docker
    R tests/docker/dockerfiles/ubuntu.docker
    M tests/docker/dockerfiles/ubuntu1804.docker
    M tests/docker/dockerfiles/ubuntu2004.docker
    A tests/lcitool/Makefile.include
    A tests/lcitool/libvirt-ci
    A tests/lcitool/projects/qemu.yml
    A tests/lcitool/refresh
    M tests/tcg/configure.sh
    M tests/tcg/hexagon/float_convs.ref
    M tests/tcg/hexagon/float_madds.ref
    M tests/tcg/multiarch/Makefile.target
    M tests/tcg/multiarch/float_convs.c
    M tests/tcg/multiarch/float_madds.c
    A tests/tcg/ppc64le/float_convs.ref
    A tests/tcg/ppc64le/float_madds.ref
    M tests/tcg/x86_64/Makefile.target
    M tests/vm/freebsd
    M ui/clipboard.c
    M ui/spice-display.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/stsquad/tags/pull-for-7.0-180122-2' 
into staging

Various testing and other misc updates:

  - fix compiler warnings with ui and sdl
  - update QXL/spice dependancy
  - skip I/O tests on Alpine
  - update fedora image to latest version
  - integrate lcitool and regenerate docker images
  - favour CONFIG_LINUX_USER over CONFIG_LINUX
  - add libfuse3 dependencies to docker images
  - add dtb-kaslr-seed control knob to virt machine
  - fix build breakage from HMP update
  - update docs for C standard and suffix usage
  - add more logging for debugging user hole finding
  - expand reserve for brk() for static 64 bit programs
  - fix bug with linux-user hole calculation
  - avoid affecting flags when printing results in float tests
  - add float reference files for ppc64
  - update FreeBSD to 12.3
  - add bison dependancy to tricore images

# gpg: Signature made Tue 18 Jan 2022 16:47:42 GMT
# gpg:                using RSA key 6685AE99E75167BCAFC8DF35FBD0DB095A9E2A44
# gpg: Good signature from "Alex Bennée (Master Work Key) 
<alex.bennee@linaro.org>" [full]
# Primary key fingerprint: 6685 AE99 E751 67BC AFC8  DF35 FBD0 DB09 5A9E 2A44

* remotes/stsquad/tags/pull-for-7.0-180122-2: (31 commits)
  docker: include bison in debian-tricore-cross
  FreeBSD: Upgrade to 12.3 release
  test/tcg/ppc64le: Add float reference files
  tests/tcg/multiarch: Read fp flags before printf
  linux-user: don't adjust base of found hole
  linux-user/elfload: add extra logging for hole finding
  linux-user: expand reserved brk space for 64bit guests
  docs/devel: more documentation on the use of suffixes
  docs/devel: update C standard to C11
  monitor: move x-query-profile into accel/tcg to fix build
  hw/arm: add control knob to disable kaslr_seed via DTB
  tests/docker: add libfuse3 development headers
  tests/tcg: use CONFIG_LINUX_USER, not CONFIG_LINUX
  tests/docker: auto-generate alpine.docker with lcitool
  tests/docker: fully expand the alpine package list
  tests/docker: fix sorting of alpine image package lists
  tests/docker: updates to alpine package list
  .gitlab-ci.d/cirrus: auto-generate variables with lcitool
  tests/docker: remove ubuntu.docker container
  tests/docker: auto-generate opensuse-leap.docker with lcitool
  ...

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/dea52c223bdb...3d228a741acc



reply via email to

[Prev in Thread] Current Thread [Next in Thread]