[Qemu-commits] [qemu/qemu] 1627ae: ui: avoid compiler warnings from unus

qemu-commits
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] 1627ae: ui: avoid compiler warnings from unus

From:	Peter Maydell
Subject:	[Qemu-commits] [qemu/qemu] 1627ae: ui: avoid compiler warnings from unused clipboard ...
Date:	Wed, 12 Jan 2022 08:12:42 -0800
  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: 1627aebbda29d1938c15dff67070d574978d62b1
      
https://github.com/qemu/qemu/commit/1627aebbda29d1938c15dff67070d574978d62b1
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2022-01-11 (Tue, 11 Jan 2022)

  Changed paths:
    M ui/clipboard.c

  Log Message:
  -----------
  ui: avoid compiler warnings from unused clipboard info variable

With latest clang 13.0.0 we get

../ui/clipboard.c:47:34: error: variable 'old' set but not used 
[-Werror,-Wunused-but-set-variable]
    g_autoptr(QemuClipboardInfo) old = NULL;
                                 ^

The compiler can't tell that we only declared this variable in
order to get the side effect of free'ing it when out of scope.

This pattern is a little dubious for a use of g_autoptr, so
rewrite the code to avoid it.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
[AJB: fix merge conflict]
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20211215141949.3512719-2-berrange@redhat.com>
Message-Id: <20220105135009.1584676-2-alex.bennee@linaro.org>


  Commit: cbdfcec5014db101efd67fa1c75915b25c6baa47
      
https://github.com/qemu/qemu/commit/cbdfcec5014db101efd67fa1c75915b25c6baa47
  Author: John Snow <jsnow@redhat.com>
  Date:   2022-01-11 (Tue, 11 Jan 2022)

  Changed paths:
    M hw/display/qxl.c
    M include/ui/qemu-spice.h
    M ui/spice-display.c

  Log Message:
  -----------
  spice: Update QXLInterface for spice >= 0.15.0

spice updated the spelling (and arguments) of "attache_worker" in
0.15.0. Update QEMU to match, preventing -Wdeprecated-declarations
compilations from reporting build errors.

See also:
https://gitlab.freedesktop.org/spice/spice/-/commit/974692bda1e77af92b71ed43b022439448492cb9

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: John Snow <jsnow@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20211215141949.3512719-3-berrange@redhat.com>
Message-Id: <20220105135009.1584676-3-alex.bennee@linaro.org>


  Commit: 014272033b46628604f18be9cb750b9b119105e8
      
https://github.com/qemu/qemu/commit/014272033b46628604f18be9cb750b9b119105e8
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2022-01-11 (Tue, 11 Jan 2022)

  Changed paths:
    M meson.build

  Log Message:
  -----------
  meson: require liburing >= 0.3

openSUSE Leap 15.2 ships with liburing == 0.2 against which QEMU fails
to build.

../util/fdmon-io_uring.c: In function ‘fdmon_io_uring_need_wait’:
../util/fdmon-io_uring.c:305:9: error: implicit declaration of function 
‘io_uring_sq_ready’; did you mean ‘io_uring_cq_ready’? 
[-Werror=implicit-function-declaration]
     if (io_uring_sq_ready(&ctx->fdmon_io_uring)) {
         ^~~~~~~~~~~~~~~~~
         io_uring_cq_ready

This method was introduced in liburing 0.3, so set that as a minimum
requirement.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20211215141949.3512719-4-berrange@redhat.com>
Message-Id: <20220105135009.1584676-4-alex.bennee@linaro.org>


  Commit: 49c93f3f37b3e753df801c8d9656efd34597eb25
      
https://github.com/qemu/qemu/commit/49c93f3f37b3e753df801c8d9656efd34597eb25
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2022-01-11 (Tue, 11 Jan 2022)

  Changed paths:
    M include/ui/sdl2.h

  Log Message:
  -----------
  ui: avoid warnings about directdb on Alpine / musl libc

On Alpine, SDL is built with directfb support and this triggers warnings
during QEMU build

In file included from /usr/include/directfb/direct/thread.h:38,
                 from /usr/include/directfb/direct/debug.h:43,
                 from /usr/include/directfb/direct/interface.h:36,
                 from /usr/include/directfb/directfb.h:49,
                 from /usr/include/SDL2/SDL_syswm.h:80,
                 from /builds/berrange/qemu/include/ui/sdl2.h:8,
                 from ../ui/sdl2-gl.c:31:
/usr/include/directfb/direct/os/waitqueue.h:41:25: error: redundant 
redeclaration of 'direct_waitqueue_init' [-Werror=redundant-decls]
   41 | DirectResult DIRECT_API direct_waitqueue_init        ( DirectWaitQueue 
*queue );
      |                         ^~~~~~~~~~~~~~~~~~~~~

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20211215141949.3512719-5-berrange@redhat.com>
Message-Id: <20220105135009.1584676-5-alex.bennee@linaro.org>


  Commit: 9a69e53d9d291752648b3b0804a1e2163de81a5c
      
https://github.com/qemu/qemu/commit/9a69e53d9d291752648b3b0804a1e2163de81a5c
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2022-01-11 (Tue, 11 Jan 2022)

  Changed paths:
    M .gitlab-ci.d/buildtest.yml

  Log Message:
  -----------
  ci: explicitly skip I/O tests on alpine

The block I/O tests don't work on Alpine because their alternative libc
impl emits different strings for errnos, which breaks the expected
output matching. e.g.

=== IO: pattern 102
 wrote 512/512 bytes at offset 512
 512 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
-qemu-img: Error while reading offset 0 of 
blkdebug:TEST_DIR/blkdebug.conf:TEST_DIR/t.IMGFMT: Input/output error
+qemu-img: Error while reading offset 0 of 
blkdebug:TEST_DIR/blkdebug.conf:TEST_DIR/t.IMGFMT: I/O error
 4
 Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=1073741824
 Formatting 'TEST_DIR/t.IMGFMT.2', fmt=IMGFMT size=0

Currently the I/O tests are skipped as a side effect of the Alpine image
containing a minimal busybox 'sed' binary, rather than GNU sed. This is
a fragile assumption that will be invalidated when the dockerfile is
changed to be autogenerated from a standardized package list that
includes GNU sed.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20211215141949.3512719-6-berrange@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20220105135009.1584676-6-alex.bennee@linaro.org>


  Commit: a0d3209e98fab6c68d4860990f858df23222c0b2
      
https://github.com/qemu/qemu/commit/a0d3209e98fab6c68d4860990f858df23222c0b2
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2022-01-11 (Tue, 11 Jan 2022)

  Changed paths:
    M tests/docker/dockerfiles/fedora.docker

  Log Message:
  -----------
  tests/docker: switch fedora image to release 35

The Fedora 33 release is shortly end of life. Switch to the newest
Fedora 35 to maximise lifespan until we need to update again.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20211215141949.3512719-7-berrange@redhat.com>
Message-Id: <20220105135009.1584676-7-alex.bennee@linaro.org>


  Commit: 074450c34fc5c03d74c1971970b187bbd1de04a8
      
https://github.com/qemu/qemu/commit/074450c34fc5c03d74c1971970b187bbd1de04a8
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2022-01-11 (Tue, 11 Jan 2022)

  Changed paths:
    M .gitmodules
    M Makefile
    M docs/devel/testing.rst
    A tests/lcitool/Makefile.include
    A tests/lcitool/libvirt-ci
    A tests/lcitool/projects/qemu.yml
    A tests/lcitool/refresh

  Log Message:
  -----------
  tests: integrate lcitool for generating build env manifests

This introduces

  https://gitlab.com/libvirt/libvirt-ci

as a git submodule at tests/lcitool/libvirt-ci

The 'lcitool' program within this submodule will be used to
automatically generate build environment manifests from a definition
of requirements in tests/lcitool/projects/qemu.yml

It will ultimately be capable of generating

 - Dockerfiles
 - Package lists for installation in VMs
 - Variables for configuring Cirrus CI environments

When a new build pre-requisite is needed for QEMU, if this package
is not currently known to libvirt-ci, it must first be added to the
'mappings.yml' file in the above git repo.

Then the submodule can be updated and the build pre-requisite added
to the tests/lcitool/projects/qemu.yml file. Now all the build env
manifests can be re-generated using  'make lcitool-refresh'

This ensures that when a new build pre-requisite is introduced, it
is added to all the different OS containers, VMs and Cirrus CI
environments consistently.

It also facilitates the addition of containers targetting new distros
or updating existing containers to new versions of the same distro,
where packages might have been renamed.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20211215141949.3512719-8-berrange@redhat.com>
Message-Id: <20220105135009.1584676-8-alex.bennee@linaro.org>


  Commit: 6a5c12f4647262ec9d5bd3c6d2e6fe68133d4e2f
      
https://github.com/qemu/qemu/commit/6a5c12f4647262ec9d5bd3c6d2e6fe68133d4e2f
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2022-01-11 (Tue, 11 Jan 2022)

  Changed paths:
    M tests/docker/dockerfiles/centos8.docker
    M tests/lcitool/refresh

  Log Message:
  -----------
  tests/docker: auto-generate centos8.docker with lcitool

This commit is best examined using the "-b" option to diff.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20211215141949.3512719-9-berrange@redhat.com>
Message-Id: <20220105135009.1584676-9-alex.bennee@linaro.org>


  Commit: 654479f97cfb4258b6e9c4b42658551ea481e6e4
      
https://github.com/qemu/qemu/commit/654479f97cfb4258b6e9c4b42658551ea481e6e4
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2022-01-11 (Tue, 11 Jan 2022)

  Changed paths:
    M tests/docker/dockerfiles/fedora.docker
    M tests/lcitool/refresh

  Log Message:
  -----------
  tests/docker: auto-generate fedora.docker with lcitool

This commit is best examined using the "-b" option to diff.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20211215141949.3512719-10-berrange@redhat.com>
Message-Id: <20220105135009.1584676-10-alex.bennee@linaro.org>


  Commit: 000e90def976d412009ff545c63be0da05ef1e68
      
https://github.com/qemu/qemu/commit/000e90def976d412009ff545c63be0da05ef1e68
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2022-01-11 (Tue, 11 Jan 2022)

  Changed paths:
    M tests/docker/dockerfiles/ubuntu1804.docker
    M tests/lcitool/refresh

  Log Message:
  -----------
  tests/docker: auto-generate ubuntu1804.docker with lcitool

This commit is best examined using the "-b" option to diff.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20211215141949.3512719-11-berrange@redhat.com>
Message-Id: <20220105135009.1584676-11-alex.bennee@linaro.org>


  Commit: a801bc4bd980d4e52eebd6ebe1ac9314a2efd228
      
https://github.com/qemu/qemu/commit/a801bc4bd980d4e52eebd6ebe1ac9314a2efd228
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2022-01-11 (Tue, 11 Jan 2022)

  Changed paths:
    M tests/docker/dockerfiles/ubuntu2004.docker
    M tests/lcitool/refresh

  Log Message:
  -----------
  tests/docker: auto-generate ubuntu2004.docker with lcitool

This commit is best examined using the "-b" option to diff.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20211215141949.3512719-12-berrange@redhat.com>
Message-Id: <20220105135009.1584676-12-alex.bennee@linaro.org>


  Commit: 804f261323afcb12fcd0496bb0c35ac7e3347935
      
https://github.com/qemu/qemu/commit/804f261323afcb12fcd0496bb0c35ac7e3347935
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2022-01-11 (Tue, 11 Jan 2022)

  Changed paths:
    M tests/docker/dockerfiles/opensuse-leap.docker
    M tests/lcitool/refresh

  Log Message:
  -----------
  tests/docker: auto-generate opensuse-leap.docker with lcitool

This commit is best examined using the "-b" option to diff.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20211215141949.3512719-13-berrange@redhat.com>
Message-Id: <20220105135009.1584676-13-alex.bennee@linaro.org>


  Commit: 0df078d020dfa29b8c795d09e8db07145949cc64
      
https://github.com/qemu/qemu/commit/0df078d020dfa29b8c795d09e8db07145949cc64
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2022-01-11 (Tue, 11 Jan 2022)

  Changed paths:
    M .gitlab-ci.d/containers.yml
    R tests/docker/dockerfiles/ubuntu.docker

  Log Message:
  -----------
  tests/docker: remove ubuntu.docker container

This duplicates the ubuntu2004 container but with an inconsistent set of
packages.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20211215141949.3512719-14-berrange@redhat.com>
Message-Id: <20220105135009.1584676-14-alex.bennee@linaro.org>


  Commit: aeceaf8e0aa03add5f5ccadb6f6ae1780eb13da4
      
https://github.com/qemu/qemu/commit/aeceaf8e0aa03add5f5ccadb6f6ae1780eb13da4
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2022-01-11 (Tue, 11 Jan 2022)

  Changed paths:
    M .gitlab-ci.d/cirrus/freebsd-12.vars
    M .gitlab-ci.d/cirrus/freebsd-13.vars
    M .gitlab-ci.d/cirrus/macos-11.vars
    M tests/lcitool/refresh

  Log Message:
  -----------
  .gitlab-ci.d/cirrus: auto-generate variables with lcitool

The current Cirrus CI variables files were previously generated by using
lcitool. This change wires them up to the refresh script to make that
link explicit.

This changes the package list because libvirt-ci now knows about the
mapping for dtc on FreeBSD and macOS platforms.

The variables are also now emit in sorted order for stability across
runs.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20211215141949.3512719-15-berrange@redhat.com>
Message-Id: <20220105135009.1584676-15-alex.bennee@linaro.org>


  Commit: 102bcf6b3a3b611596e1e57a172f019e3101004e
      
https://github.com/qemu/qemu/commit/102bcf6b3a3b611596e1e57a172f019e3101004e
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2022-01-11 (Tue, 11 Jan 2022)

  Changed paths:
    M tests/docker/dockerfiles/alpine.docker

  Log Message:
  -----------
  tests/docker: updates to alpine package list

Cleanup the package lists by removing some entries that we don't need to
directly reference

  binutils: implied by the compiler toolchain
  coreutils: not required by QEMU build
  mesa-egl mesa-gbm: implied by mesa-dev
  ninja: alias for samurai package
  shadow: not required by QEMU build
  util-linux-dev: not directly required by QEMU build

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20211215141949.3512719-16-berrange@redhat.com>
Message-Id: <20220105135009.1584676-16-alex.bennee@linaro.org>


  Commit: 5c2db14e09f62f48d054e36a4ec99b16b922a20c
      
https://github.com/qemu/qemu/commit/5c2db14e09f62f48d054e36a4ec99b16b922a20c
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2022-01-11 (Tue, 11 Jan 2022)

  Changed paths:
    M tests/docker/dockerfiles/alpine.docker

  Log Message:
  -----------
  tests/docker: fix sorting of alpine image package lists

"python" sorts alphabetically after "py3-xxxx"

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20211215141949.3512719-17-berrange@redhat.com>
Message-Id: <20220105135009.1584676-17-alex.bennee@linaro.org>


  Commit: 3d3cbabc46ad643d5f2378440072b19c1665ceca
      
https://github.com/qemu/qemu/commit/3d3cbabc46ad643d5f2378440072b19c1665ceca
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2022-01-11 (Tue, 11 Jan 2022)

  Changed paths:
    M tests/docker/dockerfiles/alpine.docker

  Log Message:
  -----------
  tests/docker: fully expand the alpine package list

Add many extra alpine packages to cover the various optional QEMU build
dependencies pulled in by other dockerfiles.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20211215141949.3512719-18-berrange@redhat.com>
Message-Id: <20220105135009.1584676-18-alex.bennee@linaro.org>


  Commit: 5953e47bc3e387d45294c458b4b7ef1241e27c98
      
https://github.com/qemu/qemu/commit/5953e47bc3e387d45294c458b4b7ef1241e27c98
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2022-01-11 (Tue, 11 Jan 2022)

  Changed paths:
    M tests/docker/dockerfiles/alpine.docker
    M tests/lcitool/refresh

  Log Message:
  -----------
  tests/docker: auto-generate alpine.docker with lcitool

This commit is best examined using the "-b" option to diff.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20211215141949.3512719-19-berrange@redhat.com>
Message-Id: <20220105135009.1584676-19-alex.bennee@linaro.org>


  Commit: c0f463c58c4e18fec5dbce16fcd59a4e944a89be
      
https://github.com/qemu/qemu/commit/c0f463c58c4e18fec5dbce16fcd59a4e944a89be
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2022-01-11 (Tue, 11 Jan 2022)

  Changed paths:
    M tests/tcg/configure.sh
    M tests/tcg/multiarch/Makefile.target
    M tests/tcg/x86_64/Makefile.target

  Log Message:
  -----------
  tests/tcg: use CONFIG_LINUX_USER, not CONFIG_LINUX

The two more or less overlap, because CONFIG_LINUX is a requirement for Linux
user-mode emulation.  However, CONFIG_LINUX is technically a host symbol
that applies even to system emulation.  Defining CONFIG_LINUX_USER, and
CONFIG_BSD_USER for eventual future use, is cleaner.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20211210084836.25202-1-pbonzini@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20220105135009.1584676-20-alex.bennee@linaro.org>


  Commit: 3cf4d26d306a2db1ff99d1b155e9307ecfc522ee
      
https://github.com/qemu/qemu/commit/3cf4d26d306a2db1ff99d1b155e9307ecfc522ee
  Author: Stefan Hajnoczi <stefanha@redhat.com>
  Date:   2022-01-11 (Tue, 11 Jan 2022)

  Changed paths:
    M tests/docker/dockerfiles/alpine.docker
    M tests/docker/dockerfiles/centos8.docker
    M tests/docker/dockerfiles/fedora.docker
    M tests/docker/dockerfiles/opensuse-leap.docker
    M tests/docker/dockerfiles/ubuntu2004.docker
    M tests/lcitool/projects/qemu.yml

  Log Message:
  -----------
  tests/docker: add libfuse3 development headers

The FUSE exports feature is not built because most container images do
not have libfuse3 development headers installed. Add the necessary
packages to the Dockerfiles.

Cc: Hanna Reitz <hreitz@redhat.com>
Cc: Richard W.M. Jones <rjones@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Acked-by: Richard W.M. Jones <rjones@redhat.com>
Reviewed-by: Beraldo Leal <bleal@redhat.com>
Tested-by: Beraldo Leal <bleal@redhat.com>
Message-Id: <20211207160025.52466-1-stefanha@redhat.com>
[AJB: migrate to lcitool qemu.yml and regenerate]
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard W.M. Jones <rjones@redhat.com>
Message-Id: <20220105135009.1584676-21-alex.bennee@linaro.org>


  Commit: 04390bd0fdec4571f1621adc92820c04bfcb51b2
      
https://github.com/qemu/qemu/commit/04390bd0fdec4571f1621adc92820c04bfcb51b2
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2022-01-11 (Tue, 11 Jan 2022)

  Changed paths:
    M docs/system/arm/virt.rst
    M hw/arm/virt.c
    M include/hw/arm/virt.h

  Log Message:
  -----------
  hw/arm: add control knob to disable kaslr_seed via DTB

Generally a guest needs an external source of randomness to properly
enable things like address space randomisation. However in a trusted
boot environment where the firmware will cryptographically verify
components having random data in the DTB will cause verification to
fail. Add a control knob so we can prevent this being added to the
system DTB.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Tested-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Acked-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Acked-by: Jerome Forissier <jerome@forissier.org>
Reviewed-by: Andrew Jones <drjones@redhat.com>
Message-Id: <20220105135009.1584676-22-alex.bennee@linaro.org>


  Commit: 65f7b4c1304eaf0eb52b85984bd4b75fd1e9743e
      
https://github.com/qemu/qemu/commit/65f7b4c1304eaf0eb52b85984bd4b75fd1e9743e
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2022-01-11 (Tue, 11 Jan 2022)

  Changed paths:
    M accel/tcg/cpu-exec.c
    M hmp-commands-info.hx
    M monitor/qmp-cmds.c
    M qapi/machine.json

  Log Message:
  -----------
  monitor: move x-query-profile into accel/tcg to fix build

As --enable-profiler isn't defended in CI we missed this breakage.
Move the qmp handler into accel/tcg so we have access to the helpers
we need. While we are at it ensure we gate the feature on CONFIG_TCG.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
Reported-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Fixes: 37087fde0e ("qapi: introduce x-query-profile QMP command")
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/773
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Tested-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20220105135009.1584676-23-alex.bennee@linaro.org>


  Commit: 63be585a9b1478dd533cb0d748becf46c531c52b
      
https://github.com/qemu/qemu/commit/63be585a9b1478dd533cb0d748becf46c531c52b
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2022-01-11 (Tue, 11 Jan 2022)

  Changed paths:
    M docs/devel/style.rst

  Log Message:
  -----------
  docs/devel: update C standard to C11

Since 8a9d3d5640 (configure: Use -std=gnu11) we have allowed C11 code
so lets reflect that in the style guide.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20220105135009.1584676-24-alex.bennee@linaro.org>


  Commit: c69eb6bd39e9ccd9b4d3b64a5abaa94b190cfe6a
      
https://github.com/qemu/qemu/commit/c69eb6bd39e9ccd9b4d3b64a5abaa94b190cfe6a
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2022-01-11 (Tue, 11 Jan 2022)

  Changed paths:
    M docs/devel/style.rst
    M include/glib-compat.h

  Log Message:
  -----------
  docs/devel: more documentation on the use of suffixes

Using _qemu is a little confusing. Let's use _compat for these sorts
of things. We should also mention _impl which is another common suffix
in the code base.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20220105135009.1584676-25-alex.bennee@linaro.org>


  Commit: 0eebf1250f10511f9413c9adb23bac9f9d8c0137
      
https://github.com/qemu/qemu/commit/0eebf1250f10511f9413c9adb23bac9f9d8c0137
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2022-01-11 (Tue, 11 Jan 2022)

  Changed paths:
    M linux-user/elfload.c

  Log Message:
  -----------
  linux-user/elfload: add extra logging for hole finding

The various approaches to finding memory holes are quite complicated
to follow especially at a distance. Improve the logging so we can see
exactly what method found the space for the guest memory.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Warner Losh <imp@bsdimp.com>
Message-Id: <20220105135009.1584676-26-alex.bennee@linaro.org>


  Commit: 39d73ec91f67dd4b1da08a3746d755532b433f49
      
https://github.com/qemu/qemu/commit/39d73ec91f67dd4b1da08a3746d755532b433f49
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2022-01-11 (Tue, 11 Jan 2022)

  Changed paths:
    M linux-user/elfload.c

  Log Message:
  -----------
  linux-user: don't adjust base of found hole

The pgb_find_hole function goes to the trouble of taking account of
both mmap_min_addr and any offset we've applied to decide the starting
address of a potential hole. This is especially important for
emulating 32bit ARM in a 32bit build as we have applied the offset to
ensure there will be space to map the ARM_COMMPAGE bellow the main
guest map (using wrapped arithmetic).

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/690
Message-Id: <20220105135009.1584676-27-alex.bennee@linaro.org>


  Commit: a9026eaebf86473e995b26796bae86c7da602cf2
      
https://github.com/qemu/qemu/commit/a9026eaebf86473e995b26796bae86c7da602cf2
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2022-01-11 (Tue, 11 Jan 2022)

  Changed paths:
    M tests/tcg/hexagon/float_convs.ref
    M tests/tcg/hexagon/float_madds.ref
    M tests/tcg/multiarch/float_convs.c
    M tests/tcg/multiarch/float_madds.c

  Log Message:
  -----------
  tests/tcg/multiarch: Read fp flags before printf

We need to read the floating-point flags before printf may do
other floating-point operations which may affect the flags.

Hexagon reference files regenerated by Taylor Simpson.

Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Taylor Simpson <tsimpson@quicinc.com>
Message-Id: <1639510781-3790-1-git-send-email-tsimpson@quicinc.com>
Message-Id: <20211224035541.2159966-2-richard.henderson@linaro.org>
Message-Id: <20220105135009.1584676-29-alex.bennee@linaro.org>


  Commit: 9d4d82eaf7f41c36d72526c08ccb1482989218c8
      
https://github.com/qemu/qemu/commit/9d4d82eaf7f41c36d72526c08ccb1482989218c8
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2022-01-11 (Tue, 11 Jan 2022)

  Changed paths:
    A tests/tcg/ppc64le/float_convs.ref
    A tests/tcg/ppc64le/float_madds.ref

  Log Message:
  -----------
  test/tcg/ppc64le: Add float reference files

Generated on Power9, PowerNV 9006-22P.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20211224035541.2159966-3-richard.henderson@linaro.org>
Message-Id: <20220105135009.1584676-30-alex.bennee@linaro.org>


  Commit: dda3e287f105f38912ddf8ab5a98c1cb9e1ca564
      
https://github.com/qemu/qemu/commit/dda3e287f105f38912ddf8ab5a98c1cb9e1ca564
  Author: Brad Smith <brad@comstyle.com>
  Date:   2022-01-11 (Tue, 11 Jan 2022)

  Changed paths:
    M .gitlab-ci.d/cirrus.yml
    M tests/vm/freebsd

  Log Message:
  -----------
  FreeBSD: Upgrade to 12.3 release

Note, since libtasn1 was fixed in 12.3 [*], this commit re-enables GnuTLS.

[*] https://gitlab.com/gnutls/libtasn1/-/merge_requests/71

Signed-off-by: Brad Smith <brad@comstyle.com>
Tested-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Warner Losh <imp@bsdimp.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <YdUCQLVe5JSWZByQ@humpty.home.comstyle.com>
Message-Id: <20220105135009.1584676-31-alex.bennee@linaro.org>


  Commit: 8d1e719a5dd1c77fcb942fffe3fd2f24465da2b3
      
https://github.com/qemu/qemu/commit/8d1e719a5dd1c77fcb942fffe3fd2f24465da2b3
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2022-01-11 (Tue, 11 Jan 2022)

  Changed paths:
    M tests/docker/dockerfiles/debian-tricore-cross.docker

  Log Message:
  -----------
  docker: include bison in debian-tricore-cross

Binutils sometimes fail to build if bison is not installed:

  /bin/sh ./ylwrap `test -f arparse.y || echo ./`arparse.y y.tab.c arparse.c 
y.tab.h arparse.h y.output arparse.output --  -d
  ./ylwrap: 109: ./ylwrap: -d: not found

(the correct invocation of ylwrap would have "bison -d" after the double
dash).  Work around by installing it in the container.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/596
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20211221111624.352804-1-pbonzini@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20220105135009.1584676-34-alex.bennee@linaro.org>


  Commit: dbd30b7abee963f4fb08892a7d7f920bb76ece58
      
https://github.com/qemu/qemu/commit/dbd30b7abee963f4fb08892a7d7f920bb76ece58
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2022-01-11 (Tue, 11 Jan 2022)

  Changed paths:
    M .gitlab-ci.d/buildtest.yml
    R configs/targets/ppc64abi32-linux-user.mak
    M configure
    M docs/about/deprecated.rst
    M docs/about/removed-features.rst
    M docs/user/main.rst
    M linux-user/elfload.c
    M linux-user/ppc/signal.c
    M linux-user/ppc/target_syscall.h
    M linux-user/syscall_defs.h
    M tests/docker/dockerfiles/debian-ppc64el-cross.docker
    M tests/tcg/configure.sh

  Log Message:
  -----------
  linux-user: Remove the deprecated ppc64abi32 target

It's likely broken, and nobody cared for picking it up again
during the deprecation phase, so let's remove this now.

Since this is the last entry in deprecated_targets_list, remove
the related code in the configure script, too.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Acked-by: Cédric Le Goater <clg@kaod.org>
Acked-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20211215084958.185214-1-thuth@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20220105135009.1584676-35-alex.bennee@linaro.org>


  Commit: 70389027d507ca7a41db92354ff26ee8528e1c90
      
https://github.com/qemu/qemu/commit/70389027d507ca7a41db92354ff26ee8528e1c90
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2022-01-12 (Wed, 12 Jan 2022)

  Changed paths:
    M .gitlab-ci.d/buildtest.yml
    M .gitlab-ci.d/cirrus.yml
    M .gitlab-ci.d/cirrus/freebsd-12.vars
    M .gitlab-ci.d/cirrus/freebsd-13.vars
    M .gitlab-ci.d/cirrus/macos-11.vars
    M .gitlab-ci.d/containers.yml
    M .gitmodules
    M Makefile
    M accel/tcg/cpu-exec.c
    R configs/targets/ppc64abi32-linux-user.mak
    M configure
    M docs/about/deprecated.rst
    M docs/about/removed-features.rst
    M docs/devel/style.rst
    M docs/devel/testing.rst
    M docs/system/arm/virt.rst
    M docs/user/main.rst
    M hmp-commands-info.hx
    M hw/arm/virt.c
    M hw/display/qxl.c
    M include/glib-compat.h
    M include/hw/arm/virt.h
    M include/ui/qemu-spice.h
    M include/ui/sdl2.h
    M linux-user/elfload.c
    M linux-user/ppc/signal.c
    M linux-user/ppc/target_syscall.h
    M linux-user/syscall_defs.h
    M meson.build
    M monitor/qmp-cmds.c
    M qapi/machine.json
    M tests/docker/dockerfiles/alpine.docker
    M tests/docker/dockerfiles/centos8.docker
    M tests/docker/dockerfiles/debian-ppc64el-cross.docker
    M tests/docker/dockerfiles/debian-tricore-cross.docker
    M tests/docker/dockerfiles/fedora.docker
    M tests/docker/dockerfiles/opensuse-leap.docker
    R tests/docker/dockerfiles/ubuntu.docker
    M tests/docker/dockerfiles/ubuntu1804.docker
    M tests/docker/dockerfiles/ubuntu2004.docker
    A tests/lcitool/Makefile.include
    A tests/lcitool/libvirt-ci
    A tests/lcitool/projects/qemu.yml
    A tests/lcitool/refresh
    M tests/tcg/configure.sh
    M tests/tcg/hexagon/float_convs.ref
    M tests/tcg/hexagon/float_madds.ref
    M tests/tcg/multiarch/Makefile.target
    M tests/tcg/multiarch/float_convs.c
    M tests/tcg/multiarch/float_madds.c
    A tests/tcg/ppc64le/float_convs.ref
    A tests/tcg/ppc64le/float_madds.ref
    M tests/tcg/x86_64/Makefile.target
    M tests/vm/freebsd
    M ui/clipboard.c
    M ui/spice-display.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/stsquad/tags/pull-for-7.0-110122-1' 
into staging

Various testing and other misc updates:

  - fix compiler warnings with ui and sdl
  - update QXL/spice dependancy
  - skip I/O tests on Alpine
  - update fedora image to latest version
  - integrate lcitool and regenerate docker images
  - favour CONFIG_LINUX_USER over CONFIG_LINUX
  - add libfuse3 dependencies to docker images
  - add dtb-kaslr-seed control knob to virt machine
  - fix build breakage from HMP update
  - update docs for C standard and suffix usage
  - add more logging for debugging user hole finding
  - fix bug with linux-user hold calculation
  - avoid affecting flags when printing results in float tests
  - add float reference files for ppc64
  - update FreeBSD to 12.3
  - add bison dependancy to tricore images
  - remove deprecated ppc64abi32 target

# gpg: Signature made Tue 11 Jan 2022 13:04:01 GMT
# gpg:                using RSA key 6685AE99E75167BCAFC8DF35FBD0DB095A9E2A44
# gpg: Good signature from "Alex Bennée (Master Work Key) 
<alex.bennee@linaro.org>" [full]
# Primary key fingerprint: 6685 AE99 E751 67BC AFC8  DF35 FBD0 DB09 5A9E 2A44

* remotes/stsquad/tags/pull-for-7.0-110122-1: (31 commits)
  linux-user: Remove the deprecated ppc64abi32 target
  docker: include bison in debian-tricore-cross
  FreeBSD: Upgrade to 12.3 release
  test/tcg/ppc64le: Add float reference files
  tests/tcg/multiarch: Read fp flags before printf
  linux-user: don't adjust base of found hole
  linux-user/elfload: add extra logging for hole finding
  docs/devel: more documentation on the use of suffixes
  docs/devel: update C standard to C11
  monitor: move x-query-profile into accel/tcg to fix build
  hw/arm: add control knob to disable kaslr_seed via DTB
  tests/docker: add libfuse3 development headers
  tests/tcg: use CONFIG_LINUX_USER, not CONFIG_LINUX
  tests/docker: auto-generate alpine.docker with lcitool
  tests/docker: fully expand the alpine package list
  tests/docker: fix sorting of alpine image package lists
  tests/docker: updates to alpine package list
  .gitlab-ci.d/cirrus: auto-generate variables with lcitool
  tests/docker: remove ubuntu.docker container
  tests/docker: auto-generate opensuse-leap.docker with lcitool
  ...

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/91f5f7a5df1f...70389027d507
[Prev in Thread]
Current Thread
[Next in Thread]
[Qemu-commits] [qemu/qemu] 1627ae: ui: avoid compiler warnings from unused clipboard ..., Peter Maydell <=
Prev by Date: [Qemu-commits] [qemu/qemu] d010b8: linux-user/alpha: Set TRAP_UNK for bugchk and unkn...
Next by Date: [Qemu-commits] [qemu/qemu] 1c127f: pseries: Update SLOF firmware image
Previous by thread: [Qemu-commits] [qemu/qemu] d010b8: linux-user/alpha: Set TRAP_UNK for bugchk and unkn...
Next by thread: [Qemu-commits] [qemu/qemu] 1c127f: pseries: Update SLOF firmware image
Index(es):
- Date
- Thread